[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

2016-05-03 Thread noreply 
The proposal to merge lp:~mzanetti/reminders-app/section-separator into 
lp:reminders-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622
-- 
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

2016-05-03 Thread Alan Pope  
The proposal to merge lp:~mzanetti/reminders-app/section-separator into 
lp:reminders-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622
-- 
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

2016-05-03 Thread Alan Pope  
Review: Approve

Looks great, thanks!
-- 
https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

2016-05-03 Thread Jenkins Bot 
Review: Approve continuous-integration

PASSED: Continuous integration, rev:557
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/56/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/891/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/56/rebuild

-- 
https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622
Your team Ubuntu Notes app developers is requested to review the proposed merge 
of lp:~mzanetti/reminders-app/section-separator into lp:reminders-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

2016-05-03 Thread Michael Zanetti 
Michael Zanetti has proposed merging 
lp:~mzanetti/reminders-app/section-separator into lp:reminders-app.

Commit message:
Add a separator to section headers

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge 
of lp:~mzanetti/reminders-app/section-separator into lp:reminders-app.
=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2016-04-30 21:32:48 +
+++ src/app/qml/ui/NotesPage.qml	2016-05-03 13:27:25 +
@@ -215,9 +215,15 @@
 }
 section.property: root.sortOrderToString(notes.sortOrder);
 
-section.delegate: Empty {
+section.delegate: ListItem {
 height: units.gu(5)
-showDivider: false
+Rectangle {
+anchors { left: parent.left; top: parent.top; right: parent.right }
+height: units.dp(1)
+color: theme.palette.normal.base
+visible: index > 0
+}
+
 RowLayout {
 anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(1) }
 Label {

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp