[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/import-contact into lp:ubuntu-filemanager-app

2016-07-19 Thread noreply 
The proposal to merge lp:~renatofilho/ubuntu-filemanager-app/import-contact 
into lp:ubuntu-filemanager-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/import-contact/+merge/300087
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/import-contact into lp:ubuntu-filemanager-app

2016-07-19 Thread Jenkins Bot 
Review: Approve continuous-integration


-- 
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/import-contact/+merge/300087
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/import-contact into lp:ubuntu-filemanager-app

2016-07-19 Thread Bill Filler 
The proposal to merge lp:~renatofilho/ubuntu-filemanager-app/import-contact 
into lp:ubuntu-filemanager-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/import-contact/+merge/300087
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/import-contact into lp:ubuntu-filemanager-app

2016-07-19 Thread Bill Filler 
Review: Approve

works as expected
-- 
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/import-contact/+merge/300087
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app

2016-07-19 Thread Jenkins Bot 
Review: Approve continuous-integration

PASSED: Continuous integration, rev:250
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/69/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/958/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/69/rebuild

-- 
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/uc1.3-migrations/+merge/300508
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app

2016-07-19 Thread Jenkins Bot 
Review: Approve continuous-integration

PASSED: Continuous integration, rev:249
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/68/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/957/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/68/rebuild

-- 
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/uc1.3-migrations/+merge/300508
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app

2016-07-19 Thread Jenkins Bot 
Review: Approve continuous-integration

PASSED: Continuous integration, rev:248
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/67/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/956/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/67/rebuild

-- 
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/uc1.3-migrations/+merge/300508
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app

2016-07-19 Thread Andrew Hayzen 
Andrew Hayzen has proposed merging 
lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app.

Commit message:
* Migrate to use new uc1.3 page headers - also fixes topMargin on bottom edge 
page
* Migrate to use sdk bottom edge

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/uc1.3-migrations/+merge/300508

* Migrate to use new uc1.3 page headers - also fixes topMargin on bottom edge 
page
* Migrate to use sdk bottom edge


Note this is likely failing autopilot, but is more of a functional review.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/uc1.3-migrations into lp:ubuntu-weather-app.
=== modified file 'app/components/CMakeLists.txt'
--- app/components/CMakeLists.txt	2015-03-03 18:37:59 +
+++ app/components/CMakeLists.txt	2016-07-19 18:03:11 +
@@ -1,3 +1,4 @@
+add_subdirectory(HeadState)
 add_subdirectory(ListItemActions)
 
 file(GLOB COMPONENTS_QML_JS_FILES *.qml *.js)

=== added directory 'app/components/HeadState'
=== added file 'app/components/HeadState/CMakeLists.txt'
--- app/components/HeadState/CMakeLists.txt	1970-01-01 00:00:00 +
+++ app/components/HeadState/CMakeLists.txt	2016-07-19 18:03:11 +
@@ -0,0 +1,4 @@
+# make the qml files visible on qtcreator
+file(GLOB HEAD_STATE_QML_FILES RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.qml)
+
+add_custom_target(com_ubuntu_music_HEAD_STATE_QMLFiles ALL SOURCES ${HEAD_STATE_QML_FILES})

=== added file 'app/components/HeadState/LocationsHeadState.qml'
--- app/components/HeadState/LocationsHeadState.qml	1970-01-01 00:00:00 +
+++ app/components/HeadState/LocationsHeadState.qml	2016-07-19 18:03:11 +
@@ -0,0 +1,54 @@
+/*
+ * Copyright (C) 2016
+ *  Andrew Hayzen 
+ *  Victor Thompson 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see .
+ */
+
+import QtQuick 2.4
+import Ubuntu.Components 1.3
+
+
+State {
+name: "default"
+
+property PageHeader thisHeader: PageHeader {
+flickable: thisPage.flickable
+leadingActionBar {
+actions: [
+Action {
+iconName: "down"
+onTriggered: thisPage.pop()
+}
+]
+}
+title: i18n.tr("Locations")
+trailingActionBar {
+actions: [
+Action {
+iconName: "add"
+objectName: "addLocation"
+onTriggered: mainPageStack.push(Qt.resolvedUrl("../../ui/AddLocationPage.qml"))
+}
+]
+}
+visible: thisPage.state === "default"
+}
+property Item thisPage
+
+PropertyChanges {
+target: thisPage
+header: thisHeader
+}
+}

=== renamed file 'app/components/MultiSelectHeadState.qml' => 'app/components/HeadState/MultiSelectHeadState.qml'
--- app/components/MultiSelectHeadState.qml	2015-11-02 21:28:34 +
+++ app/components/HeadState/MultiSelectHeadState.qml	2016-07-19 18:03:11 +
@@ -19,49 +19,55 @@
 import QtQuick 2.4
 import Ubuntu.Components 1.3
 
-PageHeadState {
+
+State {
 id: selectionState
-actions: [
-Action {
-iconName: "select"
-text: i18n.tr("Select All")
-onTriggered: {
-if (listview.selectedItems.length === listview.model.count) {
-listview.clearSelection()
-} else {
-listview.selectAll()
-}
-}
-},
-Action {
-enabled: listview.selectedItems.length > 0
-iconName: "delete"
-text: i18n.tr("Delete")
-visible: removable
-
-onTriggered: {
-removed(listview.selectedItems)
-
-listview.closeSelection()
-}
-}
-
-]
-backAction: Action {
-text: i18n.tr("Cancel selection")
-iconName: "back"
-onTriggered: {
-listview.clearSelection()
-listview.state = "normal"
-}
-}
-head: thisPage.head
 name: "selection"
 
-PropertyChanges {
-target: thisPage.head
-backAction: selectionState.backAction
-actions: selectionState.actions
+property PageHeader thisHeader: PageHeader {
+flickable: thisPage.flickable
+leadingActionBar {

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpredotka/ubuntu-clock-app/app-window-size into lp:ubuntu-clock-app

2016-07-19 Thread Bartosz Kosiorek 
The proposal to merge lp:~mpredotka/ubuntu-clock-app/app-window-size into 
lp:ubuntu-clock-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~mpredotka/ubuntu-clock-app/app-window-size/+merge/299980
-- 
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpredotka/ubuntu-clock-app/app-window-size into lp:ubuntu-clock-app

2016-07-19 Thread noreply 
The proposal to merge lp:~mpredotka/ubuntu-clock-app/app-window-size into 
lp:ubuntu-clock-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~mpredotka/ubuntu-clock-app/app-window-size/+merge/299980
-- 
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpredotka/ubuntu-clock-app/app-window-size into lp:ubuntu-clock-app

2016-07-19 Thread Bartosz Kosiorek 
Review: Approve

It's works correctly for me. 
Thanks.
-- 
https://code.launchpad.net/~mpredotka/ubuntu-clock-app/app-window-size/+merge/299980
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into lp:ubuntu-weather-app

2016-07-19 Thread Jenkins Bot 
Review: Approve continuous-integration

PASSED: Continuous integration, rev:248
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/66/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/955/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/66/rebuild

-- 
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent/+merge/300452
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into 
lp:ubuntu-weather-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into lp:ubuntu-weather-app

2016-07-19 Thread Andrew Hayzen 
Andrew Hayzen has proposed merging 
lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into 
lp:ubuntu-weather-app.

Commit message:
* Set useragent in geocode so that osm can uniquely identify our requests

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1602691 in Ubuntu Weather App: "No location in weather app on latest 
images"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1602691

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent/+merge/300452

* Set useragent in geocode so that osm can uniquely identify our requests

This fixes the issue of location not being detected within the weather-app.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into 
lp:ubuntu-weather-app.
=== modified file 'app/components/CurrentLocation.qml'
--- app/components/CurrentLocation.qml	2015-11-02 21:28:34 +
+++ app/components/CurrentLocation.qml	2016-07-19 11:33:24 +
@@ -65,6 +65,12 @@
 Plugin {
 id: osmPlugin
 name: "osm"
+
+// Set a useragent so that osm can uniquely identify out requests
+PluginParameter {
+name: "osm.useragent"
+value: "ubuntu-weather-app"
+}
 }
 
 GeocodeModel {

=== modified file 'debian/changelog'
--- debian/changelog	2016-06-05 20:16:22 +
+++ debian/changelog	2016-07-19 11:33:24 +
@@ -1,4 +1,12 @@
-ubuntu-weather-app (3.3ubuntu1) UNRELEASED; urgency=medium
+ubuntu-weather-app (3.4ubuntu1) UNRELEASED; urgency=medium
+
+  [ Andrew Hayzen ]
+  * Set useragent in geocode so that osm can uniquely identify our requests
+  * Release 3.3 and bump version to 3.4
+
+ -- Andrew Hayzen   Tue, 19 Jul 2016 12:22:57 +0100
+
+ubuntu-weather-app (3.3ubuntu1) xenial; urgency=medium
 
   [ Andrew Hayzen ]
   * Release 3.2 and bump version to 3.3
@@ -8,7 +16,7 @@
   * Update to use new weather API
   * Change the trimAPIKey function so it only trims the API Key
 
- -- Andrew Hayzen   Sat, 04 Jun 2016 18:31:29 +0100
+ -- Andrew Hayzen   Tue, 19 Jul 2016 12:22:35 +0100
 
 ubuntu-weather-app (3.2ubuntu1) vivid; urgency=medium
 

=== modified file 'manifest.json.in'
--- manifest.json.in	2016-06-05 20:16:22 +
+++ manifest.json.in	2016-07-19 11:33:24 +
@@ -12,7 +12,7 @@
 "maintainer": "Ubuntu App Cats ",
 "name": "@PROJECT_NAME@",
 "title": "Weather",
-"version": "3.3.@BZR_REVNO@",
+"version": "3.4.@BZR_REVNO@",
 "x-source": {
 "vcs-bzr": "@BZR_SOURCE@",
 "vcs-bzr-revno": "@BZR_REVNO@"

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp