Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app
Review: Approve Tested on up to date M10, that fixed the crasher. Many thanks. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051/+merge/315772 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051/+merge/315772 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snappy-unity8 into lp:reminders-app
Review: Approve LGTM -- https://code.launchpad.net/~renatofilho/reminders-app/snappy-unity8/+merge/312393 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snappy-unity8 into lp:reminders-app
The proposal to merge lp:~renatofilho/reminders-app/snappy-unity8 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/reminders-app/snappy-unity8/+merge/312393 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app
The proposal to merge lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/fix-icon-snap/+merge/311401 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app
Review: Approve LGTM -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/fix-icon-snap/+merge/311401 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app
Review: Needs Fixing
The Icon path should really be:-
Icon=${SNAP}/meta/gui/icon.png
Rather than hard wiring the /snap path, as there is no guarantee that /snap is
valid on all platforms.
--
https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/fix-icon-snap/+merge/311401
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/all-arch into lp:ubuntu-calculator-app
The proposal to merge lp:~renatofilho/ubuntu-calculator-app/all-arch into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/all-arch/+merge/311011 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/all-arch into lp:ubuntu-calculator-app
Review: Approve -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/all-arch/+merge/311011 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-clock-app/new-snappy into lp:ubuntu-clock-app
The proposal to merge lp:~renatofilho/ubuntu-clock-app/new-snappy into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-clock-app/new-snappy/+merge/310585 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/new-snappy into lp:ubuntu-calculator-app
Review: Approve LGTM! Tested on Ubuntu desktop. -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/new-snappy/+merge/310663 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app
The proposal to merge lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snappy/+merge/308050 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app
Review: Approve LGTM! -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snappy/+merge/308050 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app
Running snapcraft on this branch in xenial results in:- Error downloading stage packages for part 'ubuntu-filemanager-app': no such package 'qtdeclarative5-nemo-qml-plugin-folderlistmodel' Is this only intended to work on yakkety? -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snappy/+merge/308050 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~laney/ubuntu-terminal-app/notshowin-unity into lp:ubuntu-terminal-app
Interestingly this fails click-review, if built as a click (which we do for the phone, although armhf, not amd64 as in the example below)... Now executing: click-review ./com.ubuntu.terminal_0.7.217_amd64.click Errors -- - desktop:validates:terminal did not validate: (ValidationError in file '/tmp/review-pp96fg9l/com.ubuntu.terminal.desktop': - 'Unity7' is not a registered OnlyShowIn value ) http://askubuntu.com/questions/417377/what-does-desktop-validates-mean/417378 -- https://code.launchpad.net/~laney/ubuntu-terminal-app/notshowin-unity/+merge/306855 Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~laney/ubuntu-terminal-app/notshowin-unity into lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp:ubuntu-docviewer-app
Review: Approve Terribly sorry this languished for so long. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async/+merge/294122 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/missing-settings-dep into lp:ubuntu-terminal-app
Review: Approve Good spot, thanks Larry. -- https://code.launchpad.net/~larryprice/ubuntu-terminal-app/missing-settings-dep/+merge/306111 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/missing-settings-dep into lp:ubuntu-terminal-app
The proposal to merge lp:~larryprice/ubuntu-terminal-app/missing-settings-dep into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~larryprice/ubuntu-terminal-app/missing-settings-dep/+merge/306111 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/update-qmltermwidget into lp:ubuntu-terminal-app
The proposal to merge lp:~larryprice/ubuntu-terminal-app/update-qmltermwidget into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~larryprice/ubuntu-terminal-app/update-qmltermwidget/+merge/306107 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp:ubuntu-terminal-app
The proposal to merge lp:~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp:ubuntu-terminal-app has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~larryprice/ubuntu-terminal-app/fix-cmake-xenial/+merge/297394 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp:ubuntu-terminal-app
Review: Disapprove Thanks Larry. Apologies for the lengthy delay in responding. As discussed on irc, this merge has been superseded. -- https://code.launchpad.net/~larryprice/ubuntu-terminal-app/fix-cmake-xenial/+merge/297394 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~themuso/ubuntu-terminal-app/yakkety-packaging-updates into lp:ubuntu-terminal-app
Review: Approve Many thanks Luke! -- https://code.launchpad.net/~themuso/ubuntu-terminal-app/yakkety-packaging-updates/+merge/306050 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~themuso/ubuntu-terminal-app/yakkety-packaging-updates into lp:ubuntu-terminal-app
The proposal to merge lp:~themuso/ubuntu-terminal-app/yakkety-packaging-updates into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~themuso/ubuntu-terminal-app/yakkety-packaging-updates/+merge/306050 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~tpeeters/ubuntu-docviewer-app/bug1577277-workaround into lp:ubuntu-docviewer-app
Review: Approve WFM. -- https://code.launchpad.net/~tpeeters/ubuntu-docviewer-app/bug1577277-workaround/+merge/304561 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app
The proposal to merge lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/ubuntu-filemanager-app/share-files/+merge/299821 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app
The proposal to merge lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/ubuntu-filemanager-app/share-files/+merge/299821 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~sil/dropping-letters/add-vcs into lp:dropping-letters
The proposal to merge lp:~sil/dropping-letters/add-vcs into lp:dropping-letters has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~sil/dropping-letters/add-vcs/+merge/296814 -- Your team Dropping Letters developers is requested to review the proposed merge of lp:~sil/dropping-letters/add-vcs into lp:dropping-letters. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpniel/ubuntu-filemanager-app/new-listitems into lp:ubuntu-filemanager-app
Doh, can you fix and we'll land it? -- https://code.launchpad.net/~dpniel/ubuntu-filemanager-app/new-listitems/+merge/296500 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpniel/ubuntu-filemanager-app/new-listitems into lp:ubuntu-filemanager-app
The proposal to merge lp:~dpniel/ubuntu-filemanager-app/new-listitems into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dpniel/ubuntu-filemanager-app/new-listitems/+merge/296500 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpniel/ubuntu-filemanager-app/new-page-header into lp:ubuntu-filemanager-app
Review: Approve That's better! Thanks Dan! -- https://code.launchpad.net/~dpniel/ubuntu-filemanager-app/new-page-header/+merge/296499 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpniel/ubuntu-filemanager-app/new-page-header into lp:ubuntu-filemanager-app
The proposal to merge lp:~dpniel/ubuntu-filemanager-app/new-page-header into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dpniel/ubuntu-filemanager-app/new-page-header/+merge/296499 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpniel/ubuntu-filemanager-app/new-page-header into lp:ubuntu-filemanager-app
Review: Needs Fixing Settings page seems blank after this change? -- https://code.launchpad.net/~dpniel/ubuntu-filemanager-app/new-page-header/+merge/296499 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpniel/ubuntu-filemanager-app/fix-1588252 into lp:ubuntu-filemanager-app
Review: Approve LGTM! Thanks Dan! -- https://code.launchpad.net/~dpniel/ubuntu-filemanager-app/fix-1588252/+merge/296498 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/reminders-app/no-ubuntucolors into lp:reminders-app
Review: Approve LGTM! -- https://code.launchpad.net/~mterry/reminders-app/no-ubuntucolors/+merge/295460 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/translations-fixes into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/translations-fixes into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/translations-fixes/+merge/295994 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/translations-fixes into lp:reminders-app
Review: Approve LGTM! -- https://code.launchpad.net/~mzanetti/reminders-app/translations-fixes/+merge/295994 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/fix-1581216 into lp:ubuntu-terminal-app
Alan Pope has proposed merging lp:~popey/ubuntu-terminal-app/fix-1581216 into
lp:ubuntu-terminal-app.
Commit message:
Move close button to fix lp:1581216
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
Bug #1581216 in Ubuntu Terminal App: "Move tab close button to the left"
https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1581216
For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/fix-1581216/+merge/294844
Move close button to fix lp:1581216
--
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~popey/ubuntu-terminal-app/fix-1581216 into lp:ubuntu-terminal-app.
=== modified file 'src/app/qml/TabsPage.qml'
--- src/app/qml/TabsPage.qml 2016-03-15 14:39:25 +
+++ src/app/qml/TabsPage.qml 2016-05-16 21:18:44 +
@@ -65,7 +65,7 @@
NumberAnimation { duration: 200 }
}
-anchors {top: parent.top; right: parent.right; margins: units.gu(1)}
+anchors {top: parent.top; left: parent.left; margins: units.gu(1)}
innerOpacity: 0.6
border {color: UbuntuColors.orange; width: units.dp(1)}
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/fix-1581216 into lp:ubuntu-terminal-app
The proposal to merge lp:~popey/ubuntu-terminal-app/fix-1581216 into lp:ubuntu-terminal-app has been updated. Commit Message changed to: Move close button to fix lp:1581216 For more details, see: https://code.launchpad.net/~popey/ubuntu-terminal-app/fix-1581216/+merge/294844 -- Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~popey/ubuntu-terminal-app/fix-1581216 into lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-imported-folder into lp:ubuntu-docviewer-app
Review: Needs Fixing This doesn't work as expected. Downloaded PDF from browser. Tap Open when done, get an error on Docviewer, and the file isn't saved. (no new files in ~/Documents on device) Here's a video showing it. https://youtu.be/R30dq-NeGe0 -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-imported-folder/+merge/291923 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142/+merge/291293 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app
Review: Approve Works perfectly. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142/+merge/291293 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/section-separator into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app
Review: Approve Looks great, thanks! -- https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/improve-tags-dialog/+merge/293466 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app
Review: Approve Much better, thanks! -- https://code.launchpad.net/~mzanetti/reminders-app/improve-tags-dialog/+merge/293466 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app
Review: Approve Works a treat, thanks for the fix! -- https://code.launchpad.net/~mzanetti/reminders-app/fix-sorting-dialog/+merge/293472 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-sorting-dialog/+merge/293472 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-edit-button into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/fix-edit-button into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-edit-button/+merge/293363 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-edit-button into lp:reminders-app
Review: Approve Tested on my bq e4.5 and it works! Thanks! -- https://code.launchpad.net/~mzanetti/reminders-app/fix-edit-button/+merge/293363 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/remove-stale-lock-files into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/remove-stale-lock-files into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/remove-stale-lock-files/+merge/293355 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/remove-stale-lock-files into lp:reminders-app
Review: Approve Tested and this recovers from the stale lock file issue. Thanks for the fix! -- https://code.launchpad.net/~mzanetti/reminders-app/remove-stale-lock-files/+merge/293355 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app
The proposal to merge lp:~popey/reminders-app/fix-1576139 into lp:reminders-app has been updated. Commit Message changed to: Remove shadow on notes For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~popey/reminders-app/fix-1576139 into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app
Alan Pope has proposed merging lp:~popey/reminders-app/fix-1576139 into
lp:reminders-app.
Commit message:
Remove shadow on notes
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Notes app developers (notes-app-dev)
Related bugs:
Bug #1576139 in Ubuntu Notes app: "Remove shadow at bottom of notes in notes
list"
https://bugs.launchpad.net/reminders-app/+bug/1576139
For more details, see:
https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298
--
Your team Ubuntu Notes app developers is requested to review the proposed merge
of lp:~popey/reminders-app/fix-1576139 into lp:reminders-app.
=== modified file 'src/app/qml/components/NotesDelegate.qml'
--- src/app/qml/components/NotesDelegate.qml 2015-09-15 14:50:55 +
+++ src/app/qml/components/NotesDelegate.qml 2016-04-28 16:24:22 +
@@ -189,13 +189,6 @@
fillMode: Image.PreserveAspectCrop
}
}
-Rectangle {
-anchors.fill: parent
-gradient: Gradient {
-GradientStop{ position: 0.8; color: "transparent" }
-GradientStop{ position: 1; color: "#d9d9d9" }
-}
-}
}
}
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576140 into lp:reminders-app
Alan Pope has proposed merging lp:~popey/reminders-app/fix-1576140 into
lp:reminders-app.
Commit message:
Simple removal of background colour.
Requested reviews:
Ubuntu Notes app developers (notes-app-dev)
Related bugs:
Bug #1576140 in Ubuntu Notes app: "Revert background to default colour"
https://bugs.launchpad.net/reminders-app/+bug/1576140
For more details, see:
https://code.launchpad.net/~popey/reminders-app/fix-1576140/+merge/293288
--
Your team Ubuntu Notes app developers is requested to review the proposed merge
of lp:~popey/reminders-app/fix-1576140 into lp:reminders-app.
=== modified file 'src/app/qml/Reminders.qml'
--- src/app/qml/Reminders.qml 2016-03-01 14:57:01 +
+++ src/app/qml/Reminders.qml 2016-04-28 15:30:03 +
@@ -124,8 +124,6 @@
}
}
-backgroundColor: "#dd"
-
function openAccountPage() {
var unauthorizedAccounts = allAccounts.count - accounts.count > 0 ? true : false
var accountPage = pagestack.push(Qt.createComponent(Qt.resolvedUrl("ui/AccountSelectorPage.qml")), { accounts: accounts, unauthorizedAccounts: unauthorizedAccounts, oaSetup: setup });
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576140 into lp:reminders-app
The proposal to merge lp:~popey/reminders-app/fix-1576140 into lp:reminders-app has been updated. Commit Message changed to: Simple removal of background colour. For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576140/+merge/293288 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~popey/reminders-app/fix-1576140 into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app
The proposal to merge lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app
Alan Pope has proposed merging lp:~popey/ubuntu-filemanager-app/fix-1554621
into lp:ubuntu-filemanager-app.
Commit message:
Remove the blue occurrences.
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into
lp:ubuntu-filemanager-app.
=== modified file 'src/app/qml/components/FolderIconDelegate.qml'
--- src/app/qml/components/FolderIconDelegate.qml 2016-01-18 10:32:34 +
+++ src/app/qml/components/FolderIconDelegate.qml 2016-04-06 14:58:24 +
@@ -49,7 +49,7 @@
property string fileName: model.fileName
property string filePath: fileView.folder + '/' + fileName
-property string text: fileName
+property string text: fileName
property string subText: itemDateAndSize(model)
property var icon: fileIcon(filePath, model)
@@ -99,7 +99,7 @@
}
color: "white"
radius: height/2
-border.color: UbuntuColors.warmGrey
+border.color: UbuntuColors.slate
antialiasing: true
opacity: expand ? 1 : 0
@@ -126,10 +126,7 @@
elide: Text.ElideMiddle
text: delegate.text
-color: expand ? UbuntuColors.coolGrey : Theme.palette.selected.backgroundText
-Behavior on color {
-ColorAnimation { duration: 200 }
-}
+color: UbuntuColors.graphite
}
MouseArea {
=== modified file 'src/app/qml/components/PathHistoryRow.qml'
--- src/app/qml/components/PathHistoryRow.qml 2016-02-08 11:15:18 +
+++ src/app/qml/components/PathHistoryRow.qml 2016-04-06 14:58:24 +
@@ -84,7 +84,7 @@
text: i18n.tr("Device")
fontSize: flickable.textSize
anchors.verticalCenter: parent.verticalCenter
-color: UbuntuColors.darkGrey
+color: UbuntuColors.inkstone
clip: true
/* Maximum Width = Flickable Width */
width: if (contentWidth > flickable.width) { flickable.width }
@@ -139,7 +139,7 @@
text: pathText(folder,index)
fontSize: flickable.textSize
anchors.verticalCenter: parent.verticalCenter
-color: repeater.model === index + 1 ? UbuntuColors.darkGrey : UbuntuColors.darkGrey
+color: repeater.model === index + 1 ? UbuntuColors.inkstone : UbuntuColors.inkstone
clip: true
/* Maximum Width = Flickable Width */
@@ -153,7 +153,7 @@
width: flickable.iconWidth
anchors.verticalCenter: parent.verticalCenter
anchors.right: label.left
-color: UbuntuColors.darkGrey
+color: UbuntuColors.inkstone
// clip: true
}
@@ -196,7 +196,7 @@
: pathText(repeater.memoryPath,index)
fontSize: flickable.textSize
anchors.verticalCenter: parent.verticalCenter
-color: UbuntuColors.darkGrey
+color: UbuntuColors.inkstone
clip: true
/* Maximum Width = Flickable Width */
@@ -210,7 +210,7 @@
width: flickable.iconWidth
anchors.verticalCenter: parent.verticalCenter
anchors.right: memoryLabel.left
-color: UbuntuColors.darkGrey
+color: UbuntuColors.inkstone
// clip: true
}
=== modified file 'src/app/qml/components/PlacesSidebar.qml'
--- src/app/qml/components/PlacesSidebar.qml 2016-02-02 00:35:27 +
+++ src/app/qml/components/PlacesSidebar.qml 2016-04-06 14:58:24 +
@@ -25,7 +25,7 @@
id: root
//color: Qt.rgba(0.5,0.5,0.5,0.3)
-color: "#F5F5F5"
+color: UbuntuColors.Porcelain
width: expanded ? (collapsed ? units.gu(8) : units.gu(22)) : 0
property bool collapsed: collapsedSidebar
=== modified file 'src/app/qml/ui/FileDetailsPopover.qml'
--- src/app/qml/ui/FileDetailsPopover.qml 2016-01-18 10:32:34 +
+++ src/app/qml/ui/FileDetailsPopover.qml 2016-04-06 14:58:24 +
@@ -78,7 +78,7 @@
anchors.verticalCenter: parent.verticalCenter
text: folderDisplayName(root.path)
-color: Theme.palette.normal.overlayText
+color: UbuntuColors.ash
font.bold: true
}
}
@@ -89,50 +89,50 @@
Label {
text: i18n.tr("Path:")
-color: Theme.palette.normal.overlayText
+color: UbuntuColors.ash
}
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app
The proposal to merge lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
The proposal to merge lp:~mpt/reminders-app/1551780-setup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
Review: Approve -- https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1552100] Re: Move to .snap
Marking the others low until the store supports snappy to click conversion. ** Changed in: ubuntu-calendar-app Importance: Undecided => Low ** Changed in: ubuntu-calendar-app Status: New => Triaged ** Changed in: ubuntu-docviewer-app Importance: Undecided => Low ** Changed in: ubuntu-docviewer-app Status: New => Triaged ** Changed in: ubuntu-filemanager-app Importance: Undecided => Low ** Changed in: ubuntu-filemanager-app Status: New => Triaged ** Changed in: music-app Importance: Undecided => Low ** Changed in: music-app Status: New => Triaged ** Changed in: reminders-app Importance: Undecided => Low ** Changed in: reminders-app Status: New => Triaged ** Changed in: ubuntu-terminal-app Importance: Undecided => Low ** Changed in: ubuntu-terminal-app Status: New => Triaged ** Changed in: ubuntu-weather-app Importance: Undecided => Low ** Changed in: ubuntu-weather-app Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1552100 Title: Move to .snap Status in Canonical System Image: New Status in Ubuntu Music App: Triaged Status in Ubuntu Notes app: Triaged Status in Telegram app: New Status in Ubuntu Calendar App: Triaged Status in Ubuntu Document Viewer App: Triaged Status in Ubuntu File Manager App: Triaged Status in Ubuntu Terminal App: Triaged Status in Ubuntu Weather App: Triaged Status in webbrowser-app package in Ubuntu: Invalid Bug description: Move all packages to .snap (snappy) To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1552100/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/minor-last-design-fixes into lp:ubuntu-clock-app
Review: Approve LGTM! -- https://code.launchpad.net/~nik90/ubuntu-clock-app/minor-last-design-fixes/+merge/287771 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848 into lp:ubuntu-calculator-app
Review: Approve Built deb and click successfully here. -- https://code.launchpad.net/~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848/+merge/287675 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848 into lp:ubuntu-calculator-app
The proposal to merge lp:~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848 into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848/+merge/287675 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app
Review: Approve Works great! Thanks! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option/+merge/287187 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option/+merge/287187 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into lp:ubuntu-docviewer-app
Review: Approve Works perfectly. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility/+merge/286193 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502 -- Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 into lp:ubuntu-docviewer-app
Review: Approve Yup! Fixed! Thank you! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149/+merge/285641 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149/+merge/285641 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1 into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1 into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1/+merge/285791 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/splash-screen into lp:ubuntu-terminal-app
I agree we should not have a header where the app has none. -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver into lp:ubuntu-docviewer-app
Review: Approve Ok, re-tested! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver/+merge/283717 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver/+merge/283717 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/splash-screen into lp:ubuntu-terminal-app
Review: Approve http://people.canonical.com/~alan/screenshots/device-2016-02-11-215750.png Looks good to me! -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/splash-screen into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/splash-screen into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1543995] Re: Shorts converts & into when reading RDF feeds
** Also affects: ubuntu-rssreader-app Importance: Undecided Status: New ** Changed in: ubuntu-rssreader-app Status: New => Confirmed ** Changed in: ubuntu-rssreader-app Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1543995 Title: Shorts converts & into when reading RDF feeds Status in Canonical System Image: New Status in Ubuntu Shorts App: Confirmed Bug description: When opening a RDF Feed, shorts converts the & char into which is interpreted as a parameter in the url. Check the GET Line. The is changed into bin_id ... Example is taken from my blog URL: http://stargate.solsys.org/mod.php?mod=blog=rdf=102 Example from RDF File read from Kjots -> KDE: GET /bin.php?bin=get_id=774 HTTP/1.1 Host: stargate.solsys.org Connection: keep-alive User-Agent: Mozilla/5.0 (X11) KHTML/5.18.0 (like Gecko) Konqueror/5.18 Referer: http://stargate.solsys.org/mod.php?mod=blog=view=294=yes=true Pragma: no-cache Cache-control: no-cache Accept: image/png, image/jpeg, video/x-mng, image/jp2, image/gif;q=0.5,*/*;q=0.1 Accept-Encoding: gzip, deflate, x-gzip, x-deflate Accept-Charset: utf-8,*;q=0.5 Accept-Language: en-US,fr;q=0.9,de;q=0.8,en;q=0.7 Cookie: PHPSESSID=xxx HTTP/1.1 200 OK Date: Wed, 10 Feb 2016 11:02:44 GMT Server: Apache/2.4.7 (Ubuntu) OpenSSL/1.0.1f Expires: Thu, 19 Nov 1981 08:52:00 GMT Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0 Pragma: no-cache Content-disposition: filename="navod.jpg" Content-Length: 4517 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: image/jpeg Shorts request: GET /bin.php?bin=getbin_id=774 HTTP/1.1 Cookie: PHPSESSID=x Connection: Keep-Alive Accept-Encoding: gzip, deflate Accept-Language: en-US,* User-Agent: Mozilla/5.0 Host: stargate.solsys.org HTTP/1.1 401 Bad Request Date: Wed, 10 Feb 2016 10:23:29 GMT Server: Apache/2.4.7 (Ubuntu) OpenSSL/1.0.1f Expires: Thu, 19 Nov 1981 08:52:00 GMT Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0 Pragma: no-cache Content-Length: 2563 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: text/html; charset=UTF-8 To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1543995/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app
The proposal to merge lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app has been updated. Commit Message changed to: The additional sudoku-app.pot file, dating from 2014, is getting Launchpad confused. Removing it to allow the only 1 valid .pot file to be imported For more details, see: https://code.launchpad.net/~dpm/sudoku-app/rm-pot/+merge/285397 -- Your team Sudoku Touch developers is requested to review the proposed merge of lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
To be clear, this patch was originally created by @bartbes who asked me to manage the bzr mangling for him. Neither of us is currently skilled enough in qml to implement the ctrl lock right now. Hints / tips / forks welcome :) -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1543058] Re: Header font too large in UITK1.3
** Branch linked: lp:~popey/ubuntu-filemanager-app/fix-1543058 ** Changed in: ubuntu-filemanager-app Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1543058 Title: Header font too large in UITK1.3 Status in Ubuntu File Manager App: In Progress Bug description: http://people.canonical.com/~alan/screenshots/device-2016-02-08-110126.png The font used in the header is a little too large. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1543058/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1543058] [NEW] Header font too large in UITK1.3
Public bug reported: http://people.canonical.com/~alan/screenshots/device-2016-02-08-110126.png The font used in the header is a little too large. ** Affects: ubuntu-filemanager-app Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1543058 Title: Header font too large in UITK1.3 Status in Ubuntu File Manager App: New Bug description: http://people.canonical.com/~alan/screenshots/device-2016-02-08-110126.png The font used in the header is a little too large. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1543058/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app
The proposal to merge lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app has been updated. Description changed to: Reduce the font size of the header from x-large to large. Before:- http://people.canonical.com/~alan/screenshots/device-2016-02-08-110126.png After:- http://people.canonical.com/~alan/screenshots/device-2016-02-08-111454.png For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1543058/+merge/285327 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app
Review: Approve Tested on device and it looks great exactly as it is http://people.canonical.com/~alan/screenshots/device-2016-02-05-135844.png I think the background in https://imgur.com/Q0fGgY6 looks too washed-out personally. Thanks for fixing this! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
The proposal to merge lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app has been updated. Commit Message changed to: Adds a toggle-able general purpose control key to the functions keys overlay. For more details, see: https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
I agree that it should be in the CTRL bar too, and that it should be clear it's toggled on. -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app
The proposal to merge lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/update-colours2/+merge/284345 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/+merge/282845 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app
Review: Needs Fixing Text conflict... Building tree. Retrieving 'lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state' to put at 'build_dir'. Merging 'lp:ubuntu-docviewer-app/reboot' in to 'build_dir'. Text conflict in po/com.ubuntu.docviewer.pot 1 conflicts encountered. bzr: ERROR: Conflicts from merge Build step 'Execute shell' marked build as failure -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app
Review: Needs Fixing Now I'm getting a completely blank screen:- libust[28446/28448]: Error: Error opening shm /lttng-ust-wait-5 (in get_wait_shm() at lttng-ust-comm.c:958) libust[28446/28448]: Error: Error opening shm /lttng-ust-wait-5 (in get_wait_shm() at lttng-ust-comm.c:958) Loading module: 'libubuntu_application_api_touch_mirclient.so.3.0.0' (process:28446): dconf-WARNING **: Unable to open /custom/xdg/data/dconf/profile/custom: Permission denied (process:28446): dconf-WARNING **: unable to open named profile (custom): using the null configuration. file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.4.756/calendar.qml:382: ReferenceError: reloadTabActions is not defined Changing properties of arguments dynamically is not supported. Changing properties of arguments dynamically is not supported. UbuntuClipboard - Got invalid serialized mime data. Ignoring it. http://people.canonical.com/~alan/screenshots/device-2016-02-02-015628.png http://people.canonical.com/~alan/screenshots/device-2016-02-02-015640.png -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app
Review: Approve That got it! -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app
http://people.canonical.com/~alan/screenshots/device-2016-02-02-005326.png http://people.canonical.com/~alan/screenshots/device-2016-02-02-005337.png -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app
The proposal to merge lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fboucault/ubuntu-filemanager-app/migrate_toolkit_13/+merge/282915 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app
Review: Approve -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284454 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-welcome-wizard into lp:ubuntu-calculator-app
Screenshots for review:- http://people.canonical.com/~alan/screenshots/device-2016-01-29-105654.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105708.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105713.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105718.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105722.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105726.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105731.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105735.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105740.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105744.png http://people.canonical.com/~alan/screenshots/device-2016-01-29-105749.png -- https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-welcome-wizard/+merge/281699 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
