[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~michael-sheldon/ubuntu-terminal-app/fix-1628781 into lp:ubuntu-terminal-app

[David Planella]

The proposal to merge lp:~michael-sheldon/ubuntu-terminal-app/fix-1628781 into 
lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~michael-sheldon/ubuntu-terminal-app/fix-1628781/+merge/307172
-- 
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~michael-sheldon/ubuntu-terminal-app/fix-1628781 into lp:ubuntu-terminal-app

[David Planella]

Review: Approve

Thanks from someone who got bitten by this yesterday :)
-- 
https://code.launchpad.net/~michael-sheldon/ubuntu-terminal-app/fix-1628781/+merge/307172
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~michael-sheldon/ubuntu-terminal-app/packaging-fixes into lp:ubuntu-terminal-app

[David Planella]

Review: Approve

Approved as per changes discussed on bug #1625074
-- 
https://code.launchpad.net/~michael-sheldon/ubuntu-terminal-app/packaging-fixes/+merge/306252
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

[David Planella]

The proposal to merge lp:~popey/ubuntu-terminal-app/add-snapcraft-config into 
lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206
-- 
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

[David Planella]

Review: Approve

Looks good to me, thanks!

I think we can merge it as it is. CLICK_MODE=on is not necessary and installs 
extra files [1], but it seems the snap works, so we might as well leave it as 
it is for a first pass.

[1] 
http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot/view/head:/CMakeLists.txt#L24
-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

[David Planella]

Replied inline again, thanks!

Diff comments:

> 
> === modified file 'src/plugin/qmltermwidget/CMakeLists.txt'
> --- src/plugin/qmltermwidget/CMakeLists.txt   2014-11-15 14:39:05 +
> +++ src/plugin/qmltermwidget/CMakeLists.txt   2016-09-08 11:44:05 +
> @@ -70,6 +70,7 @@
>  
>  # Copy the plugin, the qmldir file and other assets to the build dir for 
> running in QtCreator
>  if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> +file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR})
>  add_custom_target(qmltermwidget-qmldir ALL

Ack, thanks! In that case, I'd say the only thing we need to do in addition to 
this change is to drop the now duplicate L83.

>  COMMAND cp ${CMAKE_CURRENT_SOURCE_DIR}/src/qmldir 
> ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}
>  DEPENDS ${QMLFILES}


-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

[David Planella]

I've added another comment, but I also just noticed that this branch attempts 
to fix the same thing, but adding the CMake rule somewhere else:

https://code.launchpad.net/~larryprice/ubuntu-terminal-app/fix-cmake-xenial/+merge/297394

Diff comments:

> 
> === modified file 'src/plugin/qmltermwidget/CMakeLists.txt'
> --- src/plugin/qmltermwidget/CMakeLists.txt   2014-11-15 14:39:05 +
> +++ src/plugin/qmltermwidget/CMakeLists.txt   2016-09-08 11:44:05 +
> @@ -70,6 +70,7 @@
>  
>  # Copy the plugin, the qmldir file and other assets to the build dir for 
> running in QtCreator
>  if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> +file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR})
>  add_custom_target(qmltermwidget-qmldir ALL

Thanks Dan. I understood that CMake is attempting to create a file where the 
directory should have been created, but I'm not sure I quite follow why. In 
particular, I can't quite follow this bit: "But the add_custom_target' run 
during the build so they were trying to copy [...]".

In any case, good point about removing L83 if it's doing the same. Althought I 
noticed that the way the command is run is different:

L53 -> file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR})
L83 -> COMMAND ${CMAKE_COMMAND} -E make_directory 
${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}

The rest of the CMake file is using the COMMAND syntax. Would it not make sense 
to stick to that for consistency, or is there a compelling reason to use file()?

>  COMMAND cp ${CMAKE_CURRENT_SOURCE_DIR}/src/qmldir 
> ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}
>  DEPENDS ${QMLFILES}


-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

[David Planella]

Review: Needs Information

Nice work!

I've added some comments. Right now, if I understand it correctly, the terminal 
will only run on Unity 7, whereas we'd like to get it running on Unity 8.

I'm just adding it as a reminder, which shouldn't block this MP to get approved 
after reviewing the comments, but it's something to have a look at on the next 
iteration.

To get it running on Unity 8 will either require a wrapper [1] or the 
desktop-launcher to include these lines from the wrapper (plus a couple of 
extra dependencies, which IIRC did not add much to the size of the snap).

[1] 
https://github.com/ubuntu/snappy-playpen/blob/master/ubuntu-clock-app/clock.wrapper#L19

Diff comments:

> === added file 'snapcraft.yaml'
> --- snapcraft.yaml1970-01-01 00:00:00 +
> +++ snapcraft.yaml2016-09-08 11:44:05 +
> @@ -0,0 +1,40 @@
> +name: ubuntu-terminal-app
> +version: 0.7.207
> +summary: Ubuntu Terminal app
> +description: The terminal app for all Ubuntu devices.
> +
> +confinement: strict
> +

Don't we want to make it devmode for now?

> +apps:
> +  ubuntu-terminal-app:
> +# If CLICK_MODE=off
> +#command: desktop-launch $SNAP/usr/lib/*/qt5/bin/qmlscene 
> $SNAP/usr/share/terminal/qml/ubuntu-terminal-app.qml
> +# If CLICK_MODE=on
> +command: desktop-launch $SNAP/usr/lib/*/qt5/bin/qmlscene 
> $SNAP/qml/ubuntu-terminal-app.qml

I'd suggest choosing one of the two and removing the commented code. For clock 
app, as an example, chose to build with CLICK_MODE=off. If I'm not mistaken, 
this will allow executing the terminal without the password prompt on the 
desktop.

> +plugs: [unity7, opengl, network, network-bind, home]
> +
> +parts:
> +  terminal:
> +plugin: cmake
> +configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=on]

See comment above about using CLICK_MODE=off

> +source: .
> +build-packages:
> +  - build-essential
> +  - cmake
> +  - gettext
> +  - intltool
> +  - python3
> +  - qtbase5-dev
> +  - qtdeclarative5-dev
> +  - libqtermwidget5-0-dev
> +  - libpam0g-dev
> +stage-packages:
> +  - ubuntu-sdk-libs
> +  - qtubuntu-desktop
> +  - libqtermwidget5-0
> +  - libqt5systeminfo5
> +  - qml-module-qtsysteminfo
> +snap:
> +  - -usr/share/doc
> +  - -usr/include
> +after: [desktop-qt5]
> 
> === modified file 'src/plugin/qmltermwidget/CMakeLists.txt'
> --- src/plugin/qmltermwidget/CMakeLists.txt   2014-11-15 14:39:05 +
> +++ src/plugin/qmltermwidget/CMakeLists.txt   2016-09-08 11:44:05 +
> @@ -70,6 +70,7 @@
>  
>  # Copy the plugin, the qmldir file and other assets to the build dir for 
> running in QtCreator
>  if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> +file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR})
>  add_custom_target(qmltermwidget-qmldir ALL

Just out of interest, do we know exactly what changed in CMake that stopped the 
previous CMakeList.txt from building?

>  COMMAND cp ${CMAKE_CURRENT_SOURCE_DIR}/src/qmldir 
> ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}
>  DEPENDS ${QMLFILES}


-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into lp:ubuntu-calendar-app

[David Planella]

Thanks Niklas, and good work everyone!

On Wed, Apr 6, 2016 at 10:38 PM, Niklas Wenzel 
wrote:

> Finished merging. Thank you for your patience, Nekhelesh! :)
> --
>
> https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
> You are reviewing the proposed merge of
> lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into
> lp:ubuntu-calendar-app.
>

-- 
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app

[David Planella]

Review: Needs Information

Bug #1512667 seems to have been fixed right now. Are we in a position to land 
this branch?
-- 
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848 into lp:ubuntu-calculator-app

[David Planella]

David Planella has proposed merging 
lp:~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848 into 
lp:ubuntu-calculator-app.

Commit message:
Fix .deb package failure to build

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
  Bug #1551848 in Ubuntu Calculator App: "Debian package fails to build"
  https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1551848

For more details, see:
https://code.launchpad.net/~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848/+merge/287675

This fixes the failure of the .deb package to build.

To test it:

- Simply build the .deb package. Before the fix it fails to build.
- The change should not affect the click package in any way, but it wouldn't 
hurt to build it to be extra certain.
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of lp:~dpm/ubuntu-calculator-app/fix-deb-build-bug-1551848 into 
lp:ubuntu-calculator-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2016-01-13 23:37:57 +
+++ CMakeLists.txt	2016-03-01 17:00:58 +
@@ -85,7 +85,7 @@
 DESTINATION ${CMAKE_INSTALL_BINDIR})
 endif(CLICK_MODE)
 
-install(FILES app/${ICON} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR}/graphics)
+install(FILES app/${ICON_FILE} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR}/graphics)
 
 file(GLOB_RECURSE I18N_SRC_FILES
  RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}/po

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app

[David Planella]

David Planella has proposed merging lp:~dpm/sudoku-app/rm-pot into 
lp:sudoku-app.

Requested reviews:
  Sudoku Touch developers (sudoku-touch-dev)

For more details, see:
https://code.launchpad.net/~dpm/sudoku-app/rm-pot/+merge/285397

The additional sudoku-app.pot file, dating from 2014, is getting Launchpad 
confused. Removing it to allow the only 1 valid .pot file to be imported.
-- 
Your team Sudoku Touch developers is requested to review the proposed merge of 
lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app.
=== removed file 'po/sudoku-app.pot'
--- po/sudoku-app.pot	2014-06-12 11:38:44 +
+++ po/sudoku-app.pot	1970-01-01 00:00:00 +
@@ -1,296 +0,0 @@
-# SOME DESCRIPTIVE TITLE.
-# Copyright (C) YEAR Canonical Ltd.
-# This file is distributed under the same license as the PACKAGE package.
-# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
-#
-#, fuzzy
-msgid ""
-msgstr ""
-"Project-Id-Version: sudoku-app\n"
-"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2014-06-12 19:27+0800\n"
-"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
-"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
-"Language-Team: LANGUAGE <l...@li.org>\n"
-"Language: \n"
-"MIME-Version: 1.0\n"
-"Content-Type: text/plain; charset=CHARSET\n"
-"Content-Transfer-Encoding: 8bit\n"
-"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
-
-#: components/HighscoresTab.qml:25 components/HighscoresTab.qml:73
-#: sudoku-app.qml:24 sudoku-app.qml:153 sudoku-app.qml:206 sudoku-app.qml:237
-msgid "Best scores for all players"
-msgstr ""
-
-#. TRANSLATORS: %1 is user's first name and %2 is last name
-#: components/HighscoresTab.qml:49 sudoku-app.qml:175
-#, qt-format
-msgid "Best scores for %1 %2"
-msgstr ""
-
-#: components/AddProfileDialog.qml:13
-msgid "Add new profile"
-msgstr ""
-
-#: components/AddProfileDialog.qml:31
-msgid "Lastname"
-msgstr ""
-
-#: components/AddProfileDialog.qml:49
-msgid "Firstname"
-msgstr ""
-
-#: components/AddProfileDialog.qml:66 components/ManageProfileDialog.qml:68
-#: sudoku-app.qml:339
-msgid "OK"
-msgstr ""
-
-#: components/AddProfileDialog.qml:82 components/AddProfileDialog.qml:87
-#: components/ManageProfileDialog.qml:94
-msgid "Warning"
-msgstr ""
-
-#: components/AddProfileDialog.qml:82
-msgid "User already exist."
-msgstr ""
-
-#: components/AddProfileDialog.qml:87 components/ManageProfileDialog.qml:94
-msgid "Lastname and firstname must not be empty."
-msgstr ""
-
-#: components/AddProfileDialog.qml:98 components/ManageProfileDialog.qml:126
-#: sudoku-app.qml:491 sudoku-app.qml:941 sudoku-app.qml:991
-#: components/SudokuBlocksGrid.qml:482
-msgid "Cancel"
-msgstr ""
-
-#: components/AboutTab.qml:101
-msgid "Author(s): "
-msgstr ""
-
-#: components/AboutTab.qml:111
-msgid "Contact: "
-msgstr ""
-
-#: components/AboutTab.qml:137
-msgid "Version: "
-msgstr ""
-
-#: components/ManageProfileDialog.qml:13
-msgid "Edit profile"
-msgstr ""
-
-#: components/ManageProfileDialog.qml:107
-msgid "Delete"
-msgstr ""
-
-#: sudoku-app.qml:50 sudoku-app.qml:51 sudoku-app.qml:736
-msgid "New game"
-msgstr ""
-
-#: sudoku-app.qml:58 sudoku-app.qml:59
-msgid "Reveal hint"
-msgstr ""
-
-#: sudoku-app.qml:67 sudoku-app.qml:68
-msgid "Show settings"
-msgstr ""
-
-#: sudoku-app.qml:75 sudoku-app.qml:76
-msgid "Change difficulty to Easy"
-msgstr ""
-
-#: sudoku-app.qml:88 sudoku-app.qml:89
-msgid "Change difficulty to Moderate"
-msgstr ""
-
-#: sudoku-app.qml:101 sudoku-app.qml:102
-msgid "Change difficulty to Hard"
-msgstr ""
-
-#: sudoku-app.qml:114 sudoku-app.qml:115
-msgid "Change difficulty to Ultra Hard"
-msgstr ""
-
-#: sudoku-app.qml:127 sudoku-app.qml:128
-msgid "Change theme to Simple"
-msgstr ""
-
-#: sudoku-app.qml:137 sudoku-app.qml:138
-msgid "Change theme to UbuntuColors"
-msgstr ""
-
-#: sudoku-app.qml:147 sudoku-app.qml:148
-msgid "Show scores for all users"
-msgstr ""
-
-#: sudoku-app.qml:167 sudoku-app.qml:168
-msgid "Show scores for current user"
-msgstr ""
-
-#: sudoku-app.qml:227
-msgid ""
-"You are a cheat... \n"
-"But we give you\n"
-msgstr ""
-
-#: sudoku-app.qml:229
-msgid "points."
-msgstr ""
-
-#: sudoku-app.qml:326
-msgid "Sudoku games played today"
-msgstr ""
-
-#: sudoku-app.qml:327
-msgid "No Sudoku games played today"
-msgstr ""
-
-#: sudoku-app.qml:355
-ms

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into lp:ubuntu-calendar-app

[David Planella]

Review: Needs Fixing

I've just double-checked this again, and I can confirm that the qsTr() call is 
not required. i18n.tr() (gettext) already takes care of the format string, it 
is not necessary to process it again with qsTr().

This can easily be tested with a simple QML app that includes the following 
string:

i18n.tr("%1 %2").arg(Qt.locale().standaloneMonthName(10, 
Locale.LongFormat)).arg("2011")

Diff comments:

> === modified file 'DayView.qml'
> --- DayView.qml   2015-11-23 07:15:20 +
> +++ DayView.qml   2015-12-03 21:28:26 +
> @@ -57,7 +57,9 @@
>  id:monthYear
>  objectName:"monthYearLabel"
>  fontSize: "x-large"
> -text: currentDay.toLocaleString(Qt.locale(),i18n.tr(" "))
> +// TRANSLATORS: This string is used in the header of the month, 
> week and day views.
> +// %1 is going to be replaced by the month name, %2 by the year.
> +text: qsTr(i18n.tr("%1 
> %2")).arg(Qt.locale().standaloneMonthName(currentDay.getMonth(), 
> Locale.LongFormat)).arg(currentDay.getFullYear())

qsTr() is not needed here

>  font.capitalization: Font.Capitalize
>  }
>  }
> 
> === modified file 'MonthView.qml'
> --- MonthView.qml 2015-11-23 07:15:20 +
> +++ MonthView.qml 2015-12-03 21:28:26 +
> @@ -55,10 +55,9 @@
>  contents: Label {
>  objectName:"monthYearLabel"
>  fontSize: "x-large"
> -// TRANSLATORS: this is a time formatting string,
> -// see 
> http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid 
> expressions.
> -// It's used in the header of the month and week views
> -text: currentMonth.toLocaleString(Qt.locale(),i18n.tr(" 
> "))
> +// TRANSLATORS: This string is used in the header of the month, 
> week and day views.
> +// %1 is going to be replaced by the month name, %2 by the year.
> +text: qsTr(i18n.tr("%1 
> %2")).arg(Qt.locale().standaloneMonthName(currentMonth.getMonth(), 
> Locale.LongFormat)).arg(currentMonth.getFullYear())

qsTr() is not needed here

>  font.capitalization: Font.Capitalize
>  }
>  }
> 
> === modified file 'WeekView.qml'
> --- WeekView.qml  2015-10-28 02:12:50 +
> +++ WeekView.qml  2015-12-03 21:28:26 +
> @@ -61,7 +61,9 @@
>  id:monthYear
>  objectName:"monthYearLabel"
>  fontSize: "x-large"
> -text: i18n.tr(dayStart.toLocaleString(Qt.locale(),i18n.tr(" 
> ")))
> +// TRANSLATORS: This string is used in the header of the month, 
> week and day views.
> +// %1 is going to be replaced by the month name, %2 by the year.
> +text: qsTr(i18n.tr("%1 
> %2")).arg(Qt.locale().standaloneMonthName(dayStart.getMonth(), 
> Locale.LongFormat)).arg(dayStart.getFullYear())

qsTr() is not needed here

>  font.capitalization: Font.Capitalize
>  }
>  }


-- 
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into lp:ubuntu-terminal-app

[David Planella]

Review: Needs Fixing

Thanks Evan!

I don't know at which point the original header format was changed, but had I 
seen it, I would have objected so that it would have not generated extra work, 
and we would not have landed in the situation where we are in. That said, we're 
always really thankful for contributions, only that I would have rejected that 
particular change.

I personally prefer the # format, as it's simpler, leaner, easier to type (no 
need to match the number of "===" to the number of characters), easier to 
maintain (no need to add or remove "===" whenever the header text changes) and 
can be easily extended to an infinite number of subheaders (if there are 3 or 
more subheaders, one has to start getting creative with "===", "---", "+++", 
etc.).

However, if now redoing the headers back to the original requires more work 
than updating the remaining READMEs to the new format, I'd choose the path of 
doing less work for everyone.

I've also added a few inline comments after reviewing in detail. If you could 
take a look at them and address them, that'd be great, thanks!

Diff comments:

> === added file 'README.contributing.md'
> --- README.contributing.md1970-01-01 00:00:00 +
> +++ README.contributing.md2015-12-18 13:56:45 +
> @@ -0,0 +1,71 @@
> +Contributing
> +
> +
> +Code Style

Please use sentence case ("Code style" vs. "Code Style")

> +==
> +
> +We are trying to use a common code style throughout the code base to maintain
> +uniformity and improve code clarity. Listed below are the code styles guides
> +that will be followed based on the language used.
> +
> +* [QML](http://qt-project.org/doc/qt-5/qml-codingconventions.html) 
> +* [JS, C++](https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)
> +* [Python](Code should follow PEP8 and Flake regulations)
> +
> +Note: In the QML code convention, ignore the Javascript code section 
> guidelines.
> +So the sections that should be taken into account in the QML conventions are 
> QML 
> +Object Declarations, Grouped Properties and Lists.
> +
> +Running Tests

Please use sentence case ("Running tests")

> +=
> +
> +Please check README.autopilot and README.unittest on how to run the tests.
> +They are quite explanatory and will help you get started.
> +
> +Submitting a patch upstream

We're not using patches, but branches instead. I'd suggest "Submitting changes" 
instead.

> +===
> +
> +After writing your code, here's how to submit it. Before doing this, make 
> sure
> +to run all the tests and make sure your code follows the style guidelines.
> +
> +If the tests fail, you will have to fix them before your change can be
> +approved and merged into trunk. If the tests pass then commit and push your
> +code by,
> +
> +$ bzr commit -m "Commit Message"
> +$ bzr push lp:~launchpadid/ubuntu-terminal-app/branch-name
> +
> +If you're submitting a bug fix, you can include the --fixes flag
> +$ bzr commit -m "Implemented bug fix" --fixes lp:bug-number
> +
> +After you push your code, you can submit a Merge Proposal
> +
> +Prerequisites to approving a Merge Proposal (MP)
> +
> +
> +Over time, it has been found that insufficient testing by reviewers sometimes
> +leads to terminal app trunk not being buildable in Qtcreator due to manifest 
> errors,
> +or translation pot file not updated. As such, please follow the checklist 
> below
> +before top-approving a MP.
> +
> +Checklist
> +=
> +
> +*   Does the MP add/remove user visible strings? If Yes, has the pot file 
> been updated?
> +
> +*   Does the MP change the UI? If Yes, has it been approved by design?
> +
> +*   Did you perform an exploratory manual test run of your code change and 
> any
> +related functionality?
> +
> +*   If the MP fixes a bug or implements a feature, are there accompanying 
> unit
> +and autopilot tests?
> +
> +*   Is the calendar app trunk buildable and runnable using Qtcreator?
> +
> +*   Was the debian changelog updated?
> +
> +*   Was the copyright years updated if necessary?
> +
> +The above checklist is more of a guideline to help the terminal app trunk 
> stay
> +buildable, stable and up to date.
> 
> === added file 'README.developers.md'
> --- README.developers.md  1970-01-01 00:00:00 +
> +++ README.developers.md  2015-12-18 13:56:45 +
> @@ -0,0 +1,78 @@
> +Getting the code
> +
> +
> +$ bzr branch lp:ubuntu-terminal-app branch-name
> +$ cd branch-name
> +
> +Dependencies and Setup

Please use sentence case

> +==
> +
> +Desktops
> +
> +
> +Install the following build dependencies:
> +
> +$ sudo apt-get install libpam0g-dev
> +
> +Then open the CMakeLists.txt file in Qt Creator, and ensure that the kit
> +selected on the left sidebar (just above the green "Run" button) is "Desktop"
> +
> +Devices
> +---
> +
> +If you don't have one 

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app

[David Planella]

David Planella has proposed merging lp:~dpm/reminders-app/fix-deb-build into 
lp:reminders-app.

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Notes app developers (notes-app-dev)
Related bugs:
  Bug #1539482 in Ubuntu Notes app: "Daily builds fail after NotesPage test 
failure "
  https://bugs.launchpad.net/reminders-app/+bug/1539482

For more details, see:
https://code.launchpad.net/~dpm/reminders-app/fix-deb-build/+merge/284423

Fixes the missing dependency on oxide upon build and running the tests on a 
daily PPA:

file:///«BUILDDIR»/reminders-app-0.4+15.04.20141118+bzr529~ubuntu15.10.1/src/app/qml/Reminders.qml:30:1:
 module "com.canonical.Oxide" is not installed
 import com.canonical.Oxide 1.5

Full log: 
https://launchpadlibrarian.net/235626941/buildlog_ubuntu-wily-i386.reminders-app_0.4+15.04.20141118+bzr529~ubuntu15.10.1_BUILDING.txt.gz

Note: for some reason I could not get the tests running on a local build. The 
first test just hangs - not sure if being in Xenial makes a difference, or if 
there was an issue with autopilot or qmltestrunner. So any help on making the 
tests run locally would be greatly appreciated
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge 
of lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app.
=== modified file 'debian/control'
--- debian/control	2015-11-02 21:42:04 +
+++ debian/control	2016-01-29 10:53:49 +
@@ -7,6 +7,7 @@
gettext,
intltool,
libboost-dev,
+   liboxideqt-qmlplugin,
libssl-dev,
pkg-config,
python3-all,

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/desktop-dimensions into lp:ubuntu-terminal-app

[David Planella]

Thanks a lot Evan!

I think this effectively fixes the bug, but on a second iteration, I wonder 
whether we could have dynamic conversion of gu to column width/height, so that 
we could set the default width to e.g. 80 columns by 25 rows and it would 
result in the same column/row size on all displays.
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/desktop-dimensions/+merge/284381
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into lp:ubuntu-terminal-app

[David Planella]

Thanks a lot for the improvements!

As the person who originally wrote the READMEs, please note that on the 
"Formatted READMEs with MarkDown", they are already in valid markdown format.

I would suggest not changing the ## vs == header [1] formatting, as it's a 
subjective preference, and if we change it now for Terminal, we'll need to do 
the change it for all other app's for consistency's sake, which means quite a 
lot of extra work we could be investing in development instead :)

The same with the [Launchpad Translations][] vs [Launchpad 
Translations](https://translations.launchpad.net/ubuntu-terminal-app) links.

Keep up the good work!

[1] https://daringfireball.net/projects/markdown/syntax#header
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/improve_readmes/+merge/280927
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app

[David Planella]

The proposal to merge lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app 
has been updated.

Commit Message changed to:

Fix missing Oxide build dependency

For more details, see:
https://code.launchpad.net/~dpm/reminders-app/fix-deb-build/+merge/284423
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge 
of lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into lp:ubuntu-terminal-app

[David Planella]

It does, although the individual commits are still there and can be seen under 
the main merge commit with tools such as 'bzr qlog' ('sudo apt install qbzr' to 
use it).
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into lp:ubuntu-calendar-app

[David Planella]

Review: Needs Information

Why do you need to call qsTr()? IIRC, it should work with i18n.tr() only 
already.

qsTr(i18n.tr("%1 
%2")).arg(Qt.locale().standaloneMonthName(currentMonth.getMonth(), 
Locale.LongFormat)).arg(currentMonth.getFullYear())
-- 
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into lp:ubuntu-calendar-app

[David Planella]

Review: Needs Information

Sorry, to be more specific:

- Qt.locale() should choose the right locale for you already for the 
standaloneMonthName, without needing qsTr()
- Does currentMonth.getFullYear() not need to be localized as well?
-- 
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint

[David Planella]

Blueprint changed by David Planella:

Work items changed:
  Work items for 2015-07-02:
  [bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects 
page breaks: DONE
  [bjoern-michaelsen] Study the API and report on capabilities that would be 
applicable to the LO viewer: INPROGRESS
  [verzegnassi-stefano] Add capability to detect page breaks to go to a 
particular page: BLOCKED
  [verzegnassi-stefano] Investigate tile rendering approach: DONE
  [mrqtros] Study the docviewer code: DONE
  [mrqtros] Study the LibreOffice Kit API: DONE
  [mrqtros] Implement error detection and recovery: POSTPONED
  
  Work items for 2015-07-09:
  [verzegnassi-stefano] Continue prototyping tile rendering approach 
(https://www.youtube.com/watch?v=GAmBJy9RpQk): DONE
  [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: DONE
  [bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work: 
DONE
  [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a 
short-term alternative: DONE
  
  Work items for 2015-07-16:
  [verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML 
code as a short-term alternative: POSTPONED
  [verzegnassi-stefano] Improve the logic that initialize the tiles: DONE
  [verzegnassi-stefano] Implementing the double buffered cache: DONE
  [bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO
  
  Work items for 2015-07-23:
  Placeholder: TODO
  [verzegnassi-stefano] Finish zoom implementation: INPROGRESS
  
  Work items for 2015-07-30:
  Placeholder: TODO
  
  Work items for 2015-08-06:
  Placeholder: TODO
  
  Work items for 2015-08-13:
  [verzegnassi-stefano] Do a further check to ensure that all signals/slots 
works properly for the zooming feature: DONE
  [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
  [mrqtros] review LO plugin architecture and provide potential improvements: 
TODO
- [mrqtros] use SceneGraph for rendering: TODO
+ [mrqtros] use SceneGraph for rendering: INPROGRESS
  
  Work items for 2015-08-20:
  [verzegnassi-stefano] Centering the zooming on the gesture/page center 
("attempt-fix-zooming-1" branch): INPROGRESS
  [popey] Clone Bjoern's small footprint LibreOffice build PPA: DONE
  
  Work items for 2015-08-27:
  [verzegnassi-stefano] Investigate on future features (text selection and 
keyboard/mouse/touch events): TODO
  [popey] Set up an armhf LibreOffice build for the PPA: INPROGRESS
  [popey] Include the armhf LibreOffice binaries in a docviewer click package: 
TODO
  
  Work items for 2015-09-03:
  [verzegnassi-stefano] Switching from the content hub C++ API to the QML API: 
TODO
  
  Work items for 2015-09-10:
  Placeholder: TODO
  
  Work items for 2015-09-17:
  Placeholder: TODO
  
  Work items for 2015-09-24:
  Final Placeholder: TODO
  
  Work items:
  Placeholder for un-targetted items: DONE

-- 
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint

[David Planella]

Blueprint changed by David Planella:

Work items changed:
  Work items for 2015-07-02:
  [bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects 
page breaks: DONE
  [bjoern-michaelsen] Study the API and report on capabilities that would be 
applicable to the LO viewer: INPROGRESS
  [verzegnassi-stefano] Add capability to detect page breaks to go to a 
particular page: BLOCKED
  [verzegnassi-stefano] Investigate tile rendering approach: DONE
  [mrqtros] Study the docviewer code: DONE
  [mrqtros] Study the LibreOffice Kit API: DONE
  [mrqtros] Implement error detection and recovery: POSTPONED
  
  Work items for 2015-07-09:
  [verzegnassi-stefano] Continue prototyping tile rendering approach 
(https://www.youtube.com/watch?v=GAmBJy9RpQk): DONE
  [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: DONE
  [bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work: 
DONE
  [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a 
short-term alternative: DONE
  
  Work items for 2015-07-16:
  [verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML 
code as a short-term alternative: POSTPONED
  [verzegnassi-stefano] Improve the logic that initialize the tiles: DONE
  [verzegnassi-stefano] Implementing the double buffered cache: DONE
  [bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO
  
  Work items for 2015-07-23:
  Placeholder: TODO
  [verzegnassi-stefano] Finish zoom implementation: INPROGRESS
  
  Work items for 2015-07-30:
  Placeholder: TODO
  
  Work items for 2015-08-06:
  Placeholder: TODO
  
  Work items for 2015-08-13:
  [verzegnassi-stefano] Do a further check to ensure that all signals/slots 
works properly for the zooming feature: DONE
  [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
  [mrqtros] review LO plugin architecture and provide potential improvements: 
TODO
  [mrqtros] use SceneGraph for rendering: TODO
- [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
  
  Work items for 2015-08-20:
  [verzegnassi-stefano] Centering the zooming on the gesture/page center 
("attempt-fix-zooming-1" branch): INPROGRESS
  [popey] Clone Bjoern's small footprint LibreOffice build PPA: DONE
  
  Work items for 2015-08-27:
  [verzegnassi-stefano] Investigate on future features (text selection and 
keyboard/mouse/touch events): TODO
  [popey] Set up an armhf LibreOffice build for the PPA: INPROGRESS
  [popey] Include the armhf LibreOffice binaries in a docviewer click package: 
TODO
  
  Work items for 2015-09-03:
  [verzegnassi-stefano] Switching from the content hub C++ API to the QML API: 
TODO
  
  Work items for 2015-09-10:
  Placeholder: TODO
  
  Work items for 2015-09-17:
  Placeholder: TODO
  
  Work items for 2015-09-24:
  Final Placeholder: TODO
  
  Work items:
  Placeholder for un-targetted items: DONE

-- 
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint

[David Planella]

Blueprint changed by David Planella:

Work items changed:
  Work items for 2015-07-02:
  [bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects 
page breaks: DONE
  [bjoern-michaelsen] Study the API and report on capabilities that would be 
applicable to the LO viewer: INPROGRESS
  [verzegnassi-stefano] Add capability to detect page breaks to go to a 
particular page: BLOCKED
- [verzegnassi-stefano] Investigate tile rendering approach: INPROGRESS
+ [verzegnassi-stefano] Investigate tile rendering approach: DONE
  [mrqtros] Study the docviewer code: DONE
  [mrqtros] Study the LibreOffice Kit API: DONE
  [mrqtros] Implement error detection and recovery: POSTPONED
  
  Work items for 2015-07-09:
- [verzegnassi-stefano] Continue prototyping tile rendering approach 
(https://www.youtube.com/watch?v=GAmBJy9RpQk): INPROGRESS
- [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: INPROGRESS
+ [verzegnassi-stefano] Continue prototyping tile rendering approach 
(https://www.youtube.com/watch?v=GAmBJy9RpQk): DONE
+ [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: DONE
  [bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work: 
DONE
  [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a 
short-term alternative: DONE
  
  Work items for 2015-07-16:
  [verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML 
code as a short-term alternative: POSTPONED
  [verzegnassi-stefano] Improve the logic that initialize the tiles: DONE
  [verzegnassi-stefano] Implementing the double buffered cache: DONE
  [bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO
  
  Work items for 2015-07-23:
  Placeholder: TODO
  [verzegnassi-stefano] Finish zoom implementation: INPROGRESS
  
  Work items for 2015-07-30:
  Placeholder: TODO
  
  Work items for 2015-08-06:
  Placeholder: TODO
  
  Work items for 2015-08-13:
  [verzegnassi-stefano] Do a further check to ensure that all signals/slots 
works properly for the zooming feature: DONE
  [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
  [mrqtros] review LO plugin architecture and provide potential improvements: 
TODO
  [mrqtros] use SceneGraph for rendering: TODO
  [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
  
  Work items for 2015-08-20:
- [verzegnassi-stefano] Centering the zooming on the gesture/page center 
("attempt-fix-zooming-1" branch): TODO
+ [verzegnassi-stefano] Centering the zooming on the gesture/page center 
("attempt-fix-zooming-1" branch): INPROGRESS
  [popey] Clone Bjoern's small footprint LibreOffice build PPA: DONE
  
  Work items for 2015-08-27:
  [verzegnassi-stefano] Investigate on future features (text selection and 
keyboard/mouse/touch events): TODO
  [popey] Set up an armhf LibreOffice build for the PPA: INPROGRESS
  [popey] Include the armhf LibreOffice binaries in a docviewer click package: 
TODO
  
  Work items for 2015-09-03:
  [verzegnassi-stefano] Switching from the content hub C++ API to the QML API: 
TODO
  
  Work items for 2015-09-10:
  Placeholder: TODO
  
  Work items for 2015-09-17:
  Placeholder: TODO
  
  Work items for 2015-09-24:
  Final Placeholder: TODO
  
  Work items:
  Placeholder for un-targetted items: DONE

-- 
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint

[David Planella]

Blueprint changed by David Planella:

Work items changed:
  Work items for 2015-07-02:
  [bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects 
page breaks: DONE
  [bjoern-michaelsen] Study the API and report on capabilities that would be 
applicable to the LO viewer: INPROGRESS
  [verzegnassi-stefano] Add capability to detect page breaks to go to a 
particular page: BLOCKED
  [verzegnassi-stefano] Investigate tile rendering approach: INPROGRESS
  [mrqtros] Study the docviewer code: DONE
  [mrqtros] Study the LibreOffice Kit API: DONE
  [mrqtros] Implement error detection and recovery: POSTPONED
  
  Work items for 2015-07-09:
  [verzegnassi-stefano] Continue prototyping tile rendering approach 
(https://www.youtube.com/watch?v=GAmBJy9RpQk): INPROGRESS
  [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: INPROGRESS
  [bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work: 
DONE
  [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a 
short-term alternative: DONE
  
  Work items for 2015-07-16:
  [verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML 
code as a short-term alternative: POSTPONED
  [verzegnassi-stefano] Improve the logic that initialize the tiles: DONE
  [verzegnassi-stefano] Implementing the double buffered cache: DONE
  [bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO
  
  Work items for 2015-07-23:
  Placeholder: TODO
  [verzegnassi-stefano] Finish zoom implementation: INPROGRESS
  
  Work items for 2015-07-30:
  Placeholder: TODO
  
  Work items for 2015-08-06:
  Placeholder: TODO
  
  Work items for 2015-08-13:
  [verzegnassi-stefano] Do a further check to ensure that all signals/slots 
works properly for the zooming feature: DONE
  [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
  [mrqtros] review LO plugin architecture and provide potential improvements: 
TODO
  [mrqtros] use SceneGraph for rendering: TODO
+ [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
+ [popey] Clone Bjoern's small footprint LibreOffice build PPA: TODO
+ [popey] Set up an armhf LibreOffice build for the PPA: TODO
+ [popey] Include the armhf LibreOffice binaries in a docviewer click package: 
TODO
  
  Work items for 2015-08-20:
- Placeholder: TODO
+ [verzegnassi-stefano] Centering the zooming on the gesture/page center 
(attempt-fix-zooming-1 branch): TODO
  
  Work items for 2015-08-27:
- Placeholder: TODO
+ [verzegnassi-stefano] Investigate on future features (text selection and 
keyboard/mouse/touch events): TODO
  
  Work items for 2015-09-03:
- Placeholder: TODO
+ [verzegnassi-stefano] Switching from the content hub C++ API to the QML API: 
TODO
  
  Work items for 2015-09-10:
  Placeholder: TODO
  
  Work items for 2015-09-17:
  Placeholder: TODO
  
  Work items for 2015-09-24:
  Final Placeholder: TODO
  
  Work items:
  Placeholder for un-targetted items: DONE

-- 
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint

[David Planella]

Blueprint changed by David Planella:

Whiteboard changed:
  Scratch pad at http://pad.ubuntu.com/loviewer
+ 
+ Questions for 14 Aug 2015 (Stefano)
+ 
+ * Status of a convergent UI/UX design for DocViewer.
+ Since our ultimate target is to get a DocViewer version, suitable for both 
PCs and devices, we'd need to have a up-to-date design pattern in order to know 
how to manage zooming with different input devices.
+ 
+ * PDF plugin re-design.
+ Ideally, this should be take just a week, as the tiled rendering for LOK is 
completed (with SG paiting and zooming).
+ 
+ This has been a critical argument during the past meetings, since it's
+ not considered a priority. There's a number of reason why I think it
+ would be an important thing to do.
+ 
+ I decided to design the PDF plugin as I did in October, during the Washington 
D.C. sprint, mainly for three reasons: we needed to make it work ASAP, there 
were already a pre-existent code, and I was not so good in write a proper 
plugin from scratch. :)
+ We have considered to use a Poppler plugin written for the SailfishOS 
Document Viewer, but there were potential issues with the used license.
+ 
+ So we went with the current implementation, which has some issue:
+ 
+ - Multithreading is not perfectly working on all the Ubuntu phones
+ - Zoom management is a mess (see issues with centred zoom) \o/
+ - We are using Qt5 private imports
+ - Consistence of the code would be a lot broken, when we'll go for adding 
overlays (i.e. hypertext links, copy/paste, and search - which are priorities 
for the PDF plugin)
+ - It is not convergence-friendly. Current zoom management would just be a 
mess on desktops (i.e. it doesn't follow the standard way to zoom a PDF 
document of desktop)
+ 
+ * Is it worth to move directly from UITK 1.1 to UITK 1.3?
+  I know that it would be a bit uncomfortable for devs to work on docviewer 
from desktop.
+  This is just a generic question: since our target is to release the reboot 
series in late-September, I think we could do it. Feel free to say no! :)
+ 
+ * Has Jenkyns been enabled for builds from the reboot branch?
+ 
+ * Any news about a new application icon? :D

-- 
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint

[David Planella]

Blueprint changed by David Planella:

Work items changed:
  Work items for 2015-07-02:
  [bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects 
page breaks: DONE
  [bjoern-michaelsen] Study the API and report on capabilities that would be 
applicable to the LO viewer: INPROGRESS
  [verzegnassi-stefano] Add capability to detect page breaks to go to a 
particular page: BLOCKED
  [verzegnassi-stefano] Investigate tile rendering approach: INPROGRESS
  [mrqtros] Study the docviewer code: DONE
  [mrqtros] Study the LibreOffice Kit API: DONE
  [mrqtros] Implement error detection and recovery: POSTPONED
  
  Work items for 2015-07-09:
  [verzegnassi-stefano] Continue prototyping tile rendering approach 
(https://www.youtube.com/watch?v=GAmBJy9RpQk): INPROGRESS
- [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: TODO
+ [mrqtros] Provide support to Stefano on writing/debugging/imroving 
performance of the tiled rendering code: INPROGRESS
  [bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work: 
DONE
- [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a 
short-term alternative: POSTPONED
+ [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a 
short-term alternative: DONE
  
  Work items for 2015-07-16:
  [verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML 
code as a short-term alternative: POSTPONED
  [verzegnassi-stefano] Improve the logic that initialize the tiles: DONE
  [verzegnassi-stefano] Implementing the double buffered cache: DONE
  [bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO
  
  Work items for 2015-07-23:
  Placeholder: TODO
  [verzegnassi-stefano] Finish zoom implementation: INPROGRESS
  
  Work items for 2015-07-30:
  Placeholder: TODO
  
  Work items for 2015-08-06:
  Placeholder: TODO
  
  Work items for 2015-08-13:
  [verzegnassi-stefano] Do a further check to ensure that all signals/slots 
works properly for the zooming feature: TODO
  [mrqtros] review LO plugin architecture and provide potential improvements: 
TODO
  [mrqtros] use SceneGraph for rendering: TODO
  
  Work items for 2015-08-20:
  Placeholder: TODO
  
  Work items for 2015-08-27:
  Placeholder: TODO
  
  Work items for 2015-09-03:
  Placeholder: TODO
  
  Work items for 2015-09-10:
  Placeholder: TODO
  
  Work items for 2015-09-17:
  Placeholder: TODO
  
  Work items for 2015-09-24:
  Final Placeholder: TODO
  
  Work items:
  Placeholder for un-targetted items: DONE

-- 
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/ubuntu-filemanager-app/rename-pam-package into lp:ubuntu-filemanager-app

[David Planella]

The proposal to merge lp:~dpm/ubuntu-filemanager-app/rename-pam-package into 
lp:ubuntu-filemanager-app has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~dpm/ubuntu-filemanager-app/rename-pam-package/+merge/263162
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-docviewer-app/add-authors into lp:ubuntu-docviewer-app

[David Planella]

The proposal to merge lp:~popey/ubuntu-docviewer-app/add-authors into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~popey/ubuntu-docviewer-app/add-authors/+merge/263925
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-docviewer-app/add-authors into 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/ubuntu-terminal-app/bump-deb-version into lp:ubuntu-terminal-app

[David Planella]

David Planella has proposed merging 
lp:~dpm/ubuntu-terminal-app/bump-deb-version into lp:ubuntu-terminal-app.

Commit message:
Bumped Debian changelog version

Requested reviews:
  Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): 
continuous-integration
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1468385 in Ubuntu Terminal App: Debian versioning is older than 
published version
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1468385

For more details, see:
https://code.launchpad.net/~dpm/ubuntu-terminal-app/bump-deb-version/+merge/263826

Bumped Debian changelog version to enable core apps PPA uploads.
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~dpm/ubuntu-terminal-app/bump-deb-version into lp:ubuntu-terminal-app.
=== modified file 'debian/changelog'
--- debian/changelog	2014-10-25 04:42:31 +
+++ debian/changelog	2015-07-04 09:16:43 +
@@ -1,3 +1,9 @@
+ubuntu-terminal-app (0.7) wily; urgency=medium
+
+  * Bumped changelog version (LP: #1468385)
+
+ -- David Planella david.plane...@ubuntu.com  Sat, 04 Jul 2015 10:39:05 +0200
+
 ubuntu-terminal-app (0.5ubuntu2) trusty; urgency=medium
 
   [ Alan Pope ]

=== modified file 'debian/control'
--- debian/control	2014-11-22 14:30:52 +
+++ debian/control	2015-07-04 09:16:43 +
@@ -10,7 +10,7 @@
qtbase5-dev,
qtdeclarative5-dev,
qt5-default,
-Standards-Version: 3.9.5
+Standards-Version: 3.9.6
 Section: misc
 Homepage: https://launchpad.net/ubuntu-terminal-app
 Vcs-Bzr: https://code.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/trunk

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1469283] Re: Naming conflict with Terminal PAM plugin on the core apps PPA

[David Planella]

** Changed in: ubuntu-filemanager-app
   Status: New = Triaged

** Changed in: ubuntu-filemanager-app
   Importance: Undecided = Low

-- 
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
https://bugs.launchpad.net/bugs/1469283

Title:
  Naming conflict with Terminal PAM plugin on the core apps PPA

Status in File Manager application for Ubuntu devices:
  Triaged

Bug description:
  Both the Terminal and File Manager app feature code for a PAM
  authentication plugin.

  Due to the Jenkins testing setup we decided at the time of
  implementing them, to have the same code on both projects, which
  effectively means some duplication. While that has worked fine until
  now, one thing that does not work is to have both PAM Debian binary
  packages at the same time on the core apps PPA, as they share the same
  name, but different version.

  For a while, the File Manager uploads to the core apps PPA have been
  failing because of that conflict. As a workaround, renaming the binary
  package name would work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1469283/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app

[David Planella]

The proposal to merge 
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into 
lp:ubuntu-calculator-app has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix/+merge/262799
-- 
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1469283] Re: Naming conflict with Terminal PAM plugin on the core apps PPA

[David Planella]

** Branch linked: lp:~dpm/ubuntu-filemanager-app/rename-pam-package

-- 
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
https://bugs.launchpad.net/bugs/1469283

Title:
  Naming conflict with Terminal PAM plugin on the core apps PPA

Status in File Manager application for Ubuntu devices:
  New

Bug description:
  Both the Terminal and File Manager app feature code for a PAM
  authentication plugin.

  Due to the Jenkins testing setup we decided at the time of
  implementing them, to have the same code on both projects, which
  effectively means some duplication. While that has worked fine until
  now, one thing that does not work is to have both PAM Debian binary
  packages at the same time on the core apps PPA, as they share the same
  name, but different version.

  For a while, the File Manager uploads to the core apps PPA have been
  failing because of that conflict. As a workaround, renaming the binary
  package name would work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1469283/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/ubuntu-filemanager-app/rename-pam-package into lp:ubuntu-filemanager-app

[David Planella]

David Planella has proposed merging 
lp:~dpm/ubuntu-filemanager-app/rename-pam-package into 
lp:ubuntu-filemanager-app.

Requested reviews:
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)
Related bugs:
  Bug #1469283 in Ubuntu File Manager App: Naming conflict with Terminal PAM 
plugin on the core apps PPA
  https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1469283

For more details, see:
https://code.launchpad.net/~dpm/ubuntu-filemanager-app/rename-pam-package/+merge/263162

Rename the PAM authentication plugin binary package so that it can coexist with 
the Terminal app's one in the same PPA.
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~dpm/ubuntu-filemanager-app/rename-pam-package into 
lp:ubuntu-filemanager-app.
=== modified file 'debian/changelog'
--- debian/changelog	2014-04-25 13:25:58 +
+++ debian/changelog	2015-06-26 19:38:11 +
@@ -1,3 +1,9 @@
+ubuntu-filemanager-app (0.4) wily; urgency=medium
+
+  * Renamed PAM module to not conflict with the Terminal one.
+
+ -- David Planella david.plane...@ubuntu.com  Fri, 26 Jun 2015 20:56:51 +0200
+
 ubuntu-filemanager-app (0.3) trusty; urgency=medium
 
   * Get the click package to run on devices. (LP: #1294301)

=== modified file 'debian/control'
--- debian/control	2015-03-10 21:52:56 +
+++ debian/control	2015-06-26 19:38:11 +
@@ -24,7 +24,7 @@
  ${shlibs:Depends},
  qtdeclarative5-nemo-qml-plugin-folderlistmodel,
  qtdeclarative5-placesmodel0.1,
- qtdeclarative5-pamauthentication0.1,
+ qtdeclarative5-fm-pamauthentication0.1,
  qtdeclarative5-archives0.1,
  qtdeclarative5-qtquick2-plugin,
  qtdeclarative5-u1db1.0,
@@ -57,7 +57,7 @@
  This package contains a plugin that enables QML apps to list and
  modify a set of places (bookmarks) in the file system.
 
-Package: qtdeclarative5-pamauthentication0.1
+Package: qtdeclarative5-fm-pamauthentication0.1
 Architecture: any
 Multi-Arch: same
 Depends: ${misc:Depends},

=== renamed file 'debian/qtdeclarative5-pamauthentication0.1.install' = 'debian/qtdeclarative5-fm-pamauthentication0.1.install'
-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app

[David Planella]

Review: Approve

Added an inline comment to the debian/changelog, but approving nevertheless. 
Good work!

Diff comments:

 === modified file 'CMakeLists.txt'
 --- CMakeLists.txt2015-04-14 16:42:56 +
 +++ CMakeLists.txt2015-06-25 20:39:01 +
 @@ -31,18 +31,17 @@
  set(APP_HARDCODEubuntu-calculator-app)
  set(AUTOPILOT_DIR   ubuntu_calculator_app)
  set(MAIN_QML${APP_HARDCODE}.qml)
 -set(ICON${APP_HARDCODE}.png)
 +set(ICON_FILE   ${APP_HARDCODE}.png)
  set(DESKTOP_FILE${APP_HARDCODE}.desktop)
 -set(AUTOPILOT_DIR   ubuntu_calculator_app)
  set(APP_VERSION 2.0)
 +set(AUTOPILOT_DIR   ubuntu_calculator_app)
  
  if(CLICK_MODE)
set(CMAKE_INSTALL_PREFIX /)
set(UBUNTU-CALCULATOR-APP_DIR${CMAKE_INSTALL_DATADIR}/qml)
  
set(QT_IMPORTS_DIR ${CMAKE_INSTALL_LIBDIR})
 -  set(EXEC qmlscene $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 -  set(MODULE_PATH ${QT_IMPORTS_DIR})
 +  set(EXEC qmlscene -qt5 $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
if(NOT BZR_REVNO)
  execute_process(
COMMAND bzr revno
 @@ -76,8 +75,14 @@
configure_file(${UBUNTU_MANIFEST_PATH} 
 ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
install(FILES ${APP_HARDCODE}.apparmor DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
 +  set(ICON ${ICON_FILE})
  else(CLICK_MODE)
 -  set(EXEC qmlscene $@ -I ${MODULE_PATH}  
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 +  set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${ICON_FILE})
 +  set(EXEC ${APP_NAME})
 +  configure_file(app/${APP_HARDCODE}.in
 +${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})
 +  install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
 +DESTINATION ${CMAKE_INSTALL_BINDIR})
  endif(CLICK_MODE)
  
  file(GLOB_RECURSE I18N_SRC_FILES
 
 === modified file 'app/CMakeLists.txt'
 --- app/CMakeLists.txt2015-04-14 16:42:56 +
 +++ app/CMakeLists.txt2015-06-25 20:39:01 +
 @@ -3,12 +3,8 @@
add_custom_target(ubuntu-calculator-app_QMlFiles ALL SOURCES 
 ${QML_JS_FILES})
  endif(NOT ${CMAKE_CURRENT_SOURCE_DIR} STREQUAL 
 ${CMAKE_CURRENT_BINARY_DIR})
  
 -if(CLICK_MODE)
 -  set(ICON ${ICON})
 -  install(FILES graphics/${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
 -endif(CLICK_MODE)
 -
 -install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES graphics/${ICON_FILE} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES ${MAIN_QML} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
  
  add_subdirectory(engine)
  add_subdirectory(graphics)
 
 === added file 'app/ubuntu-calculator-app.in'
 --- app/ubuntu-calculator-app.in  1970-01-01 00:00:00 +
 +++ app/ubuntu-calculator-app.in  2015-06-25 20:39:01 +
 @@ -0,0 +1,3 @@
 +#!/bin/sh
 +export QT_SELECT=qt5
 +exec qmlscene @CMAKE_INSTALL_PREFIX@/@UBUNTU-CALCULATOR-APP_DIR@/@MAIN_QML@
 
 === modified file 'debian/changelog'
 --- debian/changelog  2014-12-11 11:09:09 +
 +++ debian/changelog  2015-06-25 20:39:01 +
 @@ -1,3 +1,39 @@
 +ubuntu-calculator-app (2.0.197) UNRELEASED; urgency=low
 +
 +  [ Bartosz Kosiorek ]
 +  * Fixes in creating .deb package (LP: #1466518) (LP: #1466530) (LP: 
 #1468385)

In the future, it would be better to have a bullet point for each bug. Each one 
of these are related, but they are all different.

 +  * Do not allow swiping in Landscape mode (LP: #1466635)
 +  * Fix keyboard shortcuts (eg. Ctrl+C) (LP: #1466634)
 +  * Add additional comments to logaritm and modulo 
 +to avoid confusion during translation (LP: #1465297)
 +  * Fix display issue (LP: #1465996)
 +
 +  [ Nicholas Skaggs ]
 +  * Fix testability for screen components.
 +
 +  [ Niklas Wenzel ]
 +  * Use longer swipe in autopilot tests for 
 +revealing the scientific keyboard (LP: #1464571)
 +  * Fix typing special characters on hardware keyboards (LP: #1449037)
 +
 +  [ Victor Thompson ]
 +  * Change favorites translatable string (LP: #1464463)
 +
 + -- Bartosz Kosiorek gan...@poczta.onet.pl  Thu, 25 Jun 2015 19:56:42 +0200
 +
 +ubuntu-calculator-app (2.0.182) vivid; urgency=medium
 +  * Add haptic feedback to buttons
 +  * Update math.js library (LP: #1439846)
 +  * Enable 'bug number' support to fix floating point math (LP: #1445152)
 +  * Modify splash screen. (LP: #1377638)
 +  * Fix keyboard focus and disappearing cursor bug. (LP: #1431548)
 +  * Fix directory layout for AP tests. (LP: #1443680)
 +  * Modified layout to fit design
 +  * Fix issue with building which corrupted translations
 +  * Updated translations
 +
 + -- Bartosz Kosiorek gan...@poczta.onet.pl  Thu, 15 Jun 2015 12:00:05 +0100
 +
  ubuntu-calculator-app (0.1) vivid; urgency=low
  
* Initial release
 


-- 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app

[David Planella]

Review: Needs Fixing

Just a few additional comments on debian/changelog and the launcher script. 
Looking good now, though!

Diff comments:

 === modified file 'CMakeLists.txt'
 --- CMakeLists.txt2015-04-14 16:42:56 +
 +++ CMakeLists.txt2015-06-24 20:32:08 +
 @@ -27,22 +27,21 @@
  
  include(GNUInstallDirs)
  
 -set(APP_NAMEubuntu-calculator-app)
 +set(APP_NAMEcalculator-app)
  set(APP_HARDCODEubuntu-calculator-app)
  set(AUTOPILOT_DIR   ubuntu_calculator_app)
  set(MAIN_QML${APP_HARDCODE}.qml)
 -set(ICON${APP_HARDCODE}.png)
 +set(ICON_FILE   ${APP_HARDCODE}.png)
  set(DESKTOP_FILE${APP_HARDCODE}.desktop)
 -set(AUTOPILOT_DIR   ubuntu_calculator_app)
  set(APP_VERSION 2.0)
 +set(AUTOPILOT_DIR   ubuntu_calculator_app)
  
  if(CLICK_MODE)
set(CMAKE_INSTALL_PREFIX /)
set(UBUNTU-CALCULATOR-APP_DIR${CMAKE_INSTALL_DATADIR}/qml)
  
set(QT_IMPORTS_DIR ${CMAKE_INSTALL_LIBDIR})
 -  set(EXEC qmlscene $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 -  set(MODULE_PATH ${QT_IMPORTS_DIR})
 +  set(EXEC qmlscene -qt5 $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
if(NOT BZR_REVNO)
  execute_process(
COMMAND bzr revno
 @@ -76,8 +75,14 @@
configure_file(${UBUNTU_MANIFEST_PATH} 
 ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
install(FILES ${APP_HARDCODE}.apparmor DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
 +  set(ICON ${ICON_FILE})
  else(CLICK_MODE)
 -  set(EXEC qmlscene $@ -I ${MODULE_PATH}  
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 +  set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${ICON_FILE})
 +  set(EXEC ${APP_NAME})
 +  configure_file(app/${APP_NAME}.in
 +${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME})
 +  install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME}
 +DESTINATION ${CMAKE_INSTALL_BINDIR})
  endif(CLICK_MODE)
  
  file(GLOB_RECURSE I18N_SRC_FILES
 
 === modified file 'app/CMakeLists.txt'
 --- app/CMakeLists.txt2015-04-14 16:42:56 +
 +++ app/CMakeLists.txt2015-06-24 20:32:08 +
 @@ -3,12 +3,8 @@
add_custom_target(ubuntu-calculator-app_QMlFiles ALL SOURCES 
 ${QML_JS_FILES})
  endif(NOT ${CMAKE_CURRENT_SOURCE_DIR} STREQUAL 
 ${CMAKE_CURRENT_BINARY_DIR})
  
 -if(CLICK_MODE)
 -  set(ICON ${ICON})
 -  install(FILES graphics/${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
 -endif(CLICK_MODE)
 -
 -install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES graphics/${ICON_FILE} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES ${MAIN_QML} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
  
  add_subdirectory(engine)
  add_subdirectory(graphics)
 
 === added file 'app/calculator-app.in'
 --- app/calculator-app.in 1970-01-01 00:00:00 +
 +++ app/calculator-app.in 2015-06-24 20:32:08 +
 @@ -0,0 +1,3 @@
 +#!/bin/bash

Just a nitpick, and more a question than a required fix. Do we need bash 
features for this small script? Could it not be just #!/bin/sh ?

 +export QT_SELECT=qt5
 +exec qmlscene @CMAKE_INSTALL_PREFIX@/@UBUNTU-CALCULATOR-APP_DIR@/@MAIN_QML@
 
 === modified file 'debian/changelog'
 --- debian/changelog  2014-12-11 11:09:09 +
 +++ debian/changelog  2015-06-24 20:32:08 +
 @@ -1,3 +1,45 @@
 +ubuntu-calculator-app (2.0.197) vivid; urgency=medium
 +
 +  [ Bartosz Kosiorek ]
 +  * Do not allow swiping in Landscape mode. 
 +Fixes: https://bugs.launchpad.net/bugs/1466635.

Please use the  (LP: #bug number) syntax instead of full bug URLs. E.g.:

* Do not allow swiping in Landscape mode (LP: #1466635).

See http://packaging.ubuntu.com/html/fixing-a-bug-example.html for more details.

 +  * Fix keyboard shortcuts (eg. Ctrl+C). 
 +Fixes: https://bugs.launchpad.net/bugs/1466634.

Please use the  (LP: #bug number) syntax instead of full bug URLs.

 +  * Add additional comments to logaritm and modulo 
 +to avoid confusion during translation. 
 +Fixes: https://bugs.launchpad.net/bugs/1465297.

Please use the  (LP: #bug number) syntax instead of full bug URLs.

 +  * Fix display issue. 
 +Fixes: https://bugs.launchpad.net/bugs/1465996.

Please use the  (LP: #bug number) syntax instead of full bug URLs.

 +
 +  [ Nicholas Skaggs ]
 +  * Fix testability for screen components.
 +
 +  [ Niklas Wenzel ]
 +  * Use longer swipe in autopilot tests for revealing the scientific 
 keyboard. 
 +Fixes: https://bugs.launchpad.net/bugs/1464571.

Please use the  (LP: #bug number) syntax instead of full bug URLs.

 +  * Fix typing special characters on hardware keyboards. 
 +Fixes: https://bugs.launchpad.net/bugs/1449037.

Please use the  (LP: #bug number) syntax instead of full 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-docviewer-app/fix-layouts-with-icons into lp:ubuntu-docviewer-app

[David Planella]

Did this branch ever land?

It's marked as Approved instead of Merged, so it appears in the list of 
branches to review. If it landed, could it be marked as Merged, or 
alternatively as Rejected?

Thanks!
-- 
https://code.launchpad.net/~mzanetti/ubuntu-docviewer-app/fix-layouts-with-icons/+merge/254072
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-docviewer-app/ubuntu-docviewer-app-icon-fix into lp:ubuntu-docviewer-app

[David Planella]

The proposal to merge 
lp:~gang65/ubuntu-docviewer-app/ubuntu-docviewer-app-icon-fix into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-docviewer-app/ubuntu-docviewer-app-icon-fix/+merge/262911
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-docviewer-app/ubuntu-docviewer-app-icon-fix into lp:ubuntu-docviewer-app

[David Planella]

Review: Approve

Looks good, and after testing it, works well too. Thanks!

Just a couple of notes that should not block this from landing:

1) On debian/changelog, you can use the (LP: #bug number) syntax to mark 
bugs as closed, instead of a URL. See [1] for details.

2) While building the package, Lintian complains with the following errors and 
warnings:

W: ubuntu-docviewer-app source: diff-contains-bzr-control-dir .bzr
E: ubuntu-docviewer-app source: build-depends-on-metapackage build-depends: 
qt5-default
E: ubuntu-docviewer-app: missing-dependency-on-libc needed by 
usr/bin/ubuntu-docviewer-app and 2 others
W: ubuntu-docviewer-app: binary-without-manpage usr/bin/ubuntu-docviewer-app
W: ubuntu-docviewer-app: desktop-mime-but-no-exec-code 
usr/share/applications/com.ubuntu.docviewer.desktop

I've not looked at all of them, but I think the last one [2] could be fixed by 
specifying an argument to the Exec line in the .desktop file.

[1] http://packaging.ubuntu.com/html/fixing-a-bug-example.html
[2] https://lintian.debian.org/tags/desktop-mime-but-no-exec-code.html
-- 
https://code.launchpad.net/~gang65/ubuntu-docviewer-app/ubuntu-docviewer-app-icon-fix/+merge/262911
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app

[David Planella]

Added my replies inline, thanks!

Diff comments:

 === modified file 'CMakeLists.txt'
 --- CMakeLists.txt2015-04-14 16:42:56 +
 +++ CMakeLists.txt2015-06-23 23:33:27 +
 @@ -27,13 +27,12 @@
  
  include(GNUInstallDirs)
  
 -set(APP_NAMEubuntu-calculator-app)
 +set(APP_NAMEcalculator-app)
  set(APP_HARDCODEubuntu-calculator-app)
  set(AUTOPILOT_DIR   ubuntu_calculator_app)
  set(MAIN_QML${APP_HARDCODE}.qml)
 -set(ICON${APP_HARDCODE}.png)
 +set(ICON_FILE   ${APP_HARDCODE}.png)
  set(DESKTOP_FILE${APP_HARDCODE}.desktop)
 -set(AUTOPILOT_DIR   ubuntu_calculator_app)

Ok, thanks a lot for the follow up. Perhaps this and the rest of the cleanup 
fixes can be put in another CMake files cleanup MP, then.

  set(APP_VERSION 2.0)
  
  if(CLICK_MODE)
 @@ -41,8 +40,7 @@
set(UBUNTU-CALCULATOR-APP_DIR${CMAKE_INSTALL_DATADIR}/qml)
  
set(QT_IMPORTS_DIR ${CMAKE_INSTALL_LIBDIR})
 -  set(EXEC qmlscene $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 -  set(MODULE_PATH ${QT_IMPORTS_DIR})
 +  set(EXEC qmlscene -qt5 $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
if(NOT BZR_REVNO)
  execute_process(
COMMAND bzr revno
 @@ -76,8 +74,14 @@
configure_file(${UBUNTU_MANIFEST_PATH} 
 ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
install(FILES ${APP_HARDCODE}.apparmor DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
 +  set(ICON ${ICON_FILE})
  else(CLICK_MODE)
 -  set(EXEC qmlscene $@ -I ${MODULE_PATH}  
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 +  set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${ICON_FILE})
 +  set(EXEC ${APP_NAME})
 +  configure_file(app/${APP_NAME}.in

Ah, gotcha. That makes sense, thanks for the clarification.

 +${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME})
 +  install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME}
 +DESTINATION ${CMAKE_INSTALL_BINDIR})
  endif(CLICK_MODE)
  
  file(GLOB_RECURSE I18N_SRC_FILES
 
 === modified file 'app/CMakeLists.txt'
 --- app/CMakeLists.txt2015-04-14 16:42:56 +
 +++ app/CMakeLists.txt2015-06-23 23:33:27 +
 @@ -3,12 +3,8 @@
add_custom_target(ubuntu-calculator-app_QMlFiles ALL SOURCES 
 ${QML_JS_FILES})
  endif(NOT ${CMAKE_CURRENT_SOURCE_DIR} STREQUAL 
 ${CMAKE_CURRENT_BINARY_DIR})
  
 -if(CLICK_MODE)
 -  set(ICON ${ICON})
 -  install(FILES graphics/${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
 -endif(CLICK_MODE)
 -
 -install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES graphics/${ICON_FILE} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES ${MAIN_QML} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
  
  add_subdirectory(engine)
  add_subdirectory(graphics)
 
 === modified file 'app/graphics/CMakeLists.txt'
 --- app/graphics/CMakeLists.txt   2015-03-11 09:13:18 +
 +++ app/graphics/CMakeLists.txt   2015-06-23 23:33:27 +
 @@ -1,4 +1,7 @@
 -file(GLOB GRAPHICS_FILES *.svg)
 +set(GRAPHICS_FILES 
 +  select_none.svg  
 +  select.svg
 +)
  
  install(FILES ${GRAPHICS_FILES} DESTINATION 
 ${UBUNTU-CALCULATOR-APP_DIR}/graphics)
  
 
 === removed file 'app/graphics/toolbari...@8.png'
 Binary files app/graphics/toolbari...@8.png   2014-11-10 09:28:27 + and 
 app/graphics/toolbari...@8.png1970-01-01 00:00:00 + differ
 === modified file 'debian/changelog'
 --- debian/changelog  2014-12-11 11:09:09 +
 +++ debian/changelog  2015-06-23 23:33:27 +
 @@ -1,3 +1,45 @@
 +ubuntu-calculator-app (2.0.197) vivid; urgency=medium
 +
 +  [ Bartosz Kosiorek ]
 +  * Do not allow swiping in Landscape mode. 
 +Fixes: https://bugs.launchpad.net/bugs/1466635.
 +  * Fix keyboard shortcuts (eg. Ctrl+C). 
 +Fixes: https://bugs.launchpad.net/bugs/1466634.
 +  * Add additional comments to logaritm and modulo 
 +to avoid confusion during translation. 
 +Fixes: https://bugs.launchpad.net/bugs/1465297.
 +  * Fix display issue. 
 +Fixes: https://bugs.launchpad.net/bugs/1465996.
 +
 +  [ Nicholas Skaggs ]
 +  * Fix testability for screen components.
 +
 +  [ Niklas Wenzel ]
 +  * Use longer swipe in autopilot tests for revealing the scientific 
 keyboard. 
 +Fixes: https://bugs.launchpad.net/bugs/1464571.
 +  * Fix typing special characters on hardware keyboards. 
 +Fixes: https://bugs.launchpad.net/bugs/1449037.
 +
 +  [ Victor Thompson ]
 +  * Change favorites translatable string. 
 +Fixes: https://bugs.launchpad.net/bugs/1464463.
 +
 + -- Bartosz Kosiorek gan...@poczta.onet.pl  Fri, 24 Jul 2015 12:00:05 +0100
 +
 +ubuntu-calculator-app (2.0.182) vivid; urgency=medium
 +  * Add haptic feedback to buttons
 +  * Update math.js library. http://pad.lv/1439846
 +  * 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app

[David Planella]

Review: Needs Fixing

Hi Bartosz,

Thanks so much for looking into this! As you asked me for a review, I'll try to 
be thorough:

1. On the commit message for r199, there is no need to duplicate the Debian 
changelog on the commit message itself. Commit messages should be concise and 
to the point (e.g. Updated Debian changelog), in particular when the exact 
information can be seen in the commit (debian/changelog diff). This is not 
something that can be fixed now, or even an issue, it's just a recommendation 
for future commits.

2. In general, for each merge proposal, please only limit the changes related 
to the fix. This fix should only be a few lines and self-contained. I see many 
changes on this one that are not related, which make it difficult to review and 
make it more prone to introduce other issues.

3. I'm not sure why the change in r200 was introduced: as far as I know, there 
is no calculator app binary, and it makes the tests in Jenkins fail.

4. The rest of comments I've added inline in the merge proposal.

Diff comments:

 === modified file 'CMakeLists.txt'
 --- CMakeLists.txt2015-04-14 16:42:56 +
 +++ CMakeLists.txt2015-06-23 23:33:27 +
 @@ -27,13 +27,12 @@
  
  include(GNUInstallDirs)
  
 -set(APP_NAMEubuntu-calculator-app)
 +set(APP_NAMEcalculator-app)

Why is it needed to change the app name?

  set(APP_HARDCODEubuntu-calculator-app)
  set(AUTOPILOT_DIR   ubuntu_calculator_app)
  set(MAIN_QML${APP_HARDCODE}.qml)
 -set(ICON${APP_HARDCODE}.png)
 +set(ICON_FILE   ${APP_HARDCODE}.png)
  set(DESKTOP_FILE${APP_HARDCODE}.desktop)
 -set(AUTOPILOT_DIR   ubuntu_calculator_app)

Why is it needed to remove the AUTOPILOT_DIR variable? Even if it's necessary 
to remove it, please do it as a separate merge proposal. As far as I can tell, 
this is not related to any of the bugs targetted in the merge proposal.

  set(APP_VERSION 2.0)
  
  if(CLICK_MODE)
 @@ -41,8 +40,7 @@
set(UBUNTU-CALCULATOR-APP_DIR${CMAKE_INSTALL_DATADIR}/qml)
  
set(QT_IMPORTS_DIR ${CMAKE_INSTALL_LIBDIR})
 -  set(EXEC qmlscene $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 -  set(MODULE_PATH ${QT_IMPORTS_DIR})
 +  set(EXEC qmlscene -qt5 $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
if(NOT BZR_REVNO)
  execute_process(
COMMAND bzr revno
 @@ -76,8 +74,14 @@
configure_file(${UBUNTU_MANIFEST_PATH} 
 ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
install(FILES ${APP_HARDCODE}.apparmor DESTINATION 
 ${CMAKE_INSTALL_PREFIX})
 +  set(ICON ${ICON_FILE})
  else(CLICK_MODE)
 -  set(EXEC qmlscene $@ -I ${MODULE_PATH}  
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML})
 +  set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${ICON_FILE})
 +  set(EXEC ${APP_NAME})
 +  configure_file(app/${APP_NAME}.in

Why is a separate app/${APP_NAME}.in file required? Can't we just set EXEC in 
the same way we do for the click package and just have the .desktop file start 
the app? In any case, if we end up using a separate file, this 
ubuntu-calculator-app.in file needs to be added to the source code. Right now 
it's missing, so it will not work.

 +${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME})
 +  install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME}
 +DESTINATION ${CMAKE_INSTALL_BINDIR})

Depending on the outcome of the comment above, this might not be needed.

  endif(CLICK_MODE)
  
  file(GLOB_RECURSE I18N_SRC_FILES
 
 === modified file 'app/CMakeLists.txt'
 --- app/CMakeLists.txt2015-04-14 16:42:56 +
 +++ app/CMakeLists.txt2015-06-23 23:33:27 +
 @@ -3,12 +3,8 @@
add_custom_target(ubuntu-calculator-app_QMlFiles ALL SOURCES 
 ${QML_JS_FILES})
  endif(NOT ${CMAKE_CURRENT_SOURCE_DIR} STREQUAL 
 ${CMAKE_CURRENT_BINARY_DIR})
  
 -if(CLICK_MODE)
 -  set(ICON ${ICON})
 -  install(FILES graphics/${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
 -endif(CLICK_MODE)
 -
 -install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES graphics/${ICON_FILE} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
 +install(FILES ${MAIN_QML} DESTINATION 
 ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
  
  add_subdirectory(engine)
  add_subdirectory(graphics)
 
 === modified file 'app/graphics/CMakeLists.txt'
 --- app/graphics/CMakeLists.txt   2015-03-11 09:13:18 +
 +++ app/graphics/CMakeLists.txt   2015-06-23 23:33:27 +
 @@ -1,4 +1,7 @@
 -file(GLOB GRAPHICS_FILES *.svg)
 +set(GRAPHICS_FILES 
 +  select_none.svg  
 +  select.svg
 +)
  

This is not related to this bug. If there is any cleanup required, please do it 
in a separate merge proposal.

  install(FILES ${GRAPHICS_FILES} DESTINATION 
 

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-viewer into lp:ubuntu-docviewer-app

[David Planella]

David Planella has proposed merging 
lp:~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-viewer into 
lp:ubuntu-docviewer-app.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-viewer/+merge/262686

Added sample code as the first step to the LibreOffice viewer feature of 
docviewer. The code was provided by Bjoern Michaelsen, the Ubuntu LO maintaner, 
as a way to use the LO Toolkit API.

Right now the sample code uses the LO Toolkit API to read a given document into 
a buffer and then it writes a .png file using libpng.

For docviewer, we can probably convert the C++ code to Qt and assess whether 
it's needed to do the .png writing (I guess docviewer can use the buffer 
directly?), and create a QML plugin.

The requirement for this to work is to have LibreOffice 5.0 installed (easily 
available from a PPA as described in the .cxx's file comments).

I believe the easiest way to start experimenting is to develop on the desktop, 
prove that it works for Qt/QML and then we can worry about converting it to a 
.click once we've done that step.


-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-viewer into 
lp:ubuntu-docviewer-app.
=== added directory 'src/plugin/libreofficetoolkit-qml-plugin'
=== added file 'src/plugin/libreofficetoolkit-qml-plugin/libreoffice2png.cxx'
--- src/plugin/libreofficetoolkit-qml-plugin/libreoffice2png.cxx	1970-01-01 00:00:00 +
+++ src/plugin/libreofficetoolkit-qml-plugin/libreoffice2png.cxx	2015-06-23 11:22:09 +
@@ -0,0 +1,133 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+// This short example shows how to use LibreOfficeKit to render (parts of) a
+// document. As-is, it renders a full view of a document into a 250x250 pixel
+// png, ignoring aspect ratio. Its using hardcoded Ubuntu/Debian paths to find
+// the LibreOffice installation.
+//
+// Please install prerequisites if you havent done so:
+//
+// sudo apt install libreofficekit-dev libreoffice libpng12-dev
+//
+// Note that you need LibreOffice 5.0 -- a prerelease is currently available 
+// at the prereleases ppa:
+//
+// https://launchpad.net/~libreoffice/+archive/ubuntu/libreoffice-prereleases
+//
+// That ppa has versions for Ubuntu 15.10, 15.04, 14.04 LTS and 12.04 LTS.
+// Although this should work on all releases, it has only been tested on Ubuntu
+// 15.04 (vivid) so far.
+//
+// This example comes without a build system as presumably you would want to
+// use a different one anyway.
+// To compile/link this, save this file as libreoffice2png.cxx and run:
+/*
+g++ --std=c++11 -I/usr/include/LibreOfficeKit/ `pkg-config --cflags libpng` libreoffice2png.cxx `pkg-config --libs libpng` -ldl -o ./libreoffice2png
+# or run this sh pipe : grep g++ ./libreoffice2png.cxx | sh
+*/
+// You should be able to easily teach your build system of choice how to build
+// based on the above.
+
+
+#include iostream
+#include memory
+#include png.h
+#include assert.h
+#define LOK_USE_UNSTABLE_API
+#include LibreOfficeKitInit.h
+#include LibreOfficeKit.hxx
+
+constexpr png_uint_32 nCanvasHeight = 256;
+constexpr png_uint_32 nCanvasWidth = 256;
+constexpr png_uint_32 nCanvasDepth = 8;
+constexpr png_uint_32 nBytesPerPixel = 4;
+
+// a simple RGBA buffer to render a document to
+png_byte image[nCanvasHeight][nCanvasWidth*nBytesPerPixel];
+void write_png(const char*);
+
+int main(int argc, char** argv)
+{
+	long nDocWidth(0);
+	long nDocHeight(0);
+	if(argc != 3)
+	{
+		std::cerr  libreoffice2png renders a document to a png file.  std::endl;
+		std::cerr  usage: ./libreoffice2png input-document output-png  std::endl;
+		return -1;
+	}
+	std::unique_ptrlok::Office pOffice(lok::lok_cpp_init(/usr/lib/libreoffice/program/));
+	std::unique_ptrlok::Document pDocument(pOffice-documentLoad(argv[1]));
+	pDocument-initializeForRendering();
+	std::cout  Document type:   pDocument-getDocumentType()  std::endl;
+	pDocument-getDocumentSize(nDocWidth, nDocHeight);
+	std::cout  Document size:   nDocWidth  x  nDocHeight   twips  std::endl;
+	pDocument-paintTile(image[0][0], nCanvasHeight, nCanvasWidth, 0, 0, nDocWidth, nDocHeight);
+	write_png(argv[2]);
+	pDocument.reset(nullptr);
+	pOffice.reset(nullptr);
+	return 0;
+}
+
+// only png writer code below this
+#ifndef png_jmpbuf
+#  define png_jmpbuf(png_ptr) ((png_ptr)-jmpbuf)
+#endif
+
+void write_png(const char* file_name)
+{
+
+	FILE* fp = fopen(file_name, wb);
+	if (!fp)
+		return;
+
+	png_structp png_ptr = png_create_write_struct(PNG_LIBPNG_VER_STRING

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app

[David Planella]

Review: Needs Fixing

Thanks for the fix! Looks good to me, I'd just suggest to add a translator 
comment here. (See inline comment)

Diff comments:

 === modified file 'TimeLineHeader.qml'
 --- TimeLineHeader.qml2015-02-26 16:44:43 +
 +++ TimeLineHeader.qml2015-03-05 08:07:05 +
 @@ -45,7 +45,7 @@
  Label{
  id: weekNumLabel
  objectName: weeknumber
 -text: i18n.tr(W) + root.weekNumber

Please add a comment so that translators have got some context for how to 
translate this. E.g.
// TRANSLATORS: W refers to Week, followed by the actual week number (%1)

 +text: i18n.tr(W%1).arg(root.weekNumber)
  fontSize: small
  height: units.gu(5)
  width: parent.width
 
 === modified file 'po/com.ubuntu.calendar.pot'
 --- po/com.ubuntu.calendar.pot2015-02-18 19:11:05 +
 +++ po/com.ubuntu.calendar.pot2015-03-05 08:07:05 +
 @@ -8,7 +8,7 @@
  msgstr 
  Project-Id-Version: \n
  Report-Msgid-Bugs-To: \n
 -POT-Creation-Date: 2015-02-18 19:09+\n
 +POT-Creation-Date: 2015-03-05 09:04+0100\n
  PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
  Last-Translator: FULL NAME EMAIL@ADDRESS\n
  Language-Team: LANGUAGE l...@li.org\n
 @@ -23,21 +23,21 @@
  msgid Today
  msgstr 
  
 -#: ../AgendaView.qml:91
 +#: ../AgendaView.qml:92
  msgid No upcoming events
  msgstr 
  
 -#: ../AgendaView.qml:94
 +#: ../AgendaView.qml:95
  msgid You have no calendars enabled
  msgstr 
  
 -#: ../AgendaView.qml:104
 +#: ../AgendaView.qml:105
  msgid Enable calendars
  msgstr 
  
  #. TRANSLATORS: the first argument (%1) refers to a start time for an event,
  #. while the second one (%2) refers to the end time
 -#: ../AgendaView.qml:166 ../EventBubble.qml:131
 +#: ../AgendaView.qml:168 ../EventBubble.qml:131
  #, qt-format
  msgid %1 - %2
  msgstr 
 @@ -59,7 +59,7 @@
  msgstr[0] 
  msgstr[1] 
  
 -#: ../CalendarChoicePopup.qml:33 ../EventActions.qml:41
 +#: ../CalendarChoicePopup.qml:33 ../EventActions.qml:59
  msgid Calendars
  msgstr 
  
 @@ -69,11 +69,11 @@
  
  #. TRANSLATORS: Please translate this string  to 15 characters only.
  #. Currently ,there is no way we can increase width of action menu currently.
 -#: ../CalendarChoicePopup.qml:51
 +#: ../CalendarChoicePopup.qml:51 ../EventActions.qml:36
  msgid Sync
  msgstr 
  
 -#: ../CalendarChoicePopup.qml:51
 +#: ../CalendarChoicePopup.qml:51 ../EventActions.qml:36
  msgid Syncing
  msgstr 
  
 @@ -101,7 +101,7 @@
  #. TRANSLATORS: this is a time formatting string,
  #. see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid 
 expressions.
  #. It's used in the header of the month and week views
 -#: ../DayView.qml:58 ../MonthView.qml:56 ../WeekView.qml:60
 +#: ../DayView.qml:59 ../MonthView.qml:57 ../WeekView.qml:61
  msgid  
  msgstr 
  
 @@ -154,7 +154,7 @@
  msgid Edit this
  msgstr 
  
 -#: ../EventActions.qml:32 ../NewEvent.qml:283
 +#: ../EventActions.qml:50 ../NewEvent.qml:283
  msgid New Event
  msgstr 
  
 @@ -390,15 +390,16 @@
  msgid 2 weeks
  msgstr 
  
 -#: ../TimeLineHeader.qml:47
 -msgid W
 +#: ../TimeLineHeader.qml:48
 +#, qt-format
 +msgid W%1
  msgstr 
  
 -#: ../TimeLineHeader.qml:59
 +#: ../TimeLineHeader.qml:60
  msgid All Day
  msgstr 
  
 -#: ../YearView.qml:53
 +#: ../YearView.qml:54
  #, qt-format
  msgid Year %1
  msgstr 
 


-- 
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app

[David Planella]

The proposal to merge lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 
into lp:ubuntu-calendar-app has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
-- 
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app

[David Planella]

Review: Approve

Looks good to me, thanks!
-- 
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app

[David Planella]

Review: Needs Fixing

Thanks Richard, that's all that needs to be done. I.e. applying the fix, 
committing and pushing it. Then when everything is fine, a core app dev will 
approve the merge proposal, automated tests will be run against it and when 
they pass it will be merged to trunk.

That said, there is something that still needs to be fixed: the translator 
comment line uses tabs where the rest of the file uses spaces. Could you 
replace the tabs with spaces to be consistent with the rest of the code?

Thanks!
-- 
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434210 into lp:help-app

[David Planella]

Review: Approve

LGTM now, thanks!

Just one typo on the HACKING doc `make appl` - `make app`
-- 
https://code.launchpad.net/~dholbach/help-app/1434210/+merge/254706
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434210 into lp:help-app

[David Planella]

The proposal to merge lp:~dholbach/help-app/1434210 into lp:help-app has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~dholbach/help-app/1434210/+merge/254706
-- 
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app

[David Planella]

Review: Approve

Looks good to me, just added two notes.

Diff comments:

 === modified file 'app/alarm/AlarmSettingsPage.qml'
 --- app/alarm/AlarmSettingsPage.qml   2014-10-16 19:03:51 +
 +++ app/alarm/AlarmSettingsPage.qml   2015-03-12 23:25:02 +
 @@ -50,10 +50,10 @@
  Component.onCompleted: initialise()
  
  function initialise() {
 -durationModel.append({ duration: 10, text: i18n.tr(%1 
 minutes).arg(10) })
 -durationModel.append({ duration: 20, text: i18n.tr(%1 
 minutes).arg(20) })
 -durationModel.append({ duration: 30, text: i18n.tr(%1 
 minutes).arg(30) })
 -durationModel.append({ duration: 60, text: i18n.tr(%1 
 minutes).arg(60) })
 +durationModel.append({ duration: 10, text: i18n.tr(%1 
 minute, %1 minutes, 10).arg(10) })
 +durationModel.append({ duration: 20, text: i18n.tr(%1 
 minute, %1 minutes, 20).arg(20) })
 +durationModel.append({ duration: 30, text: i18n.tr(%1 
 minute, %1 minutes, 30).arg(30) })
 +durationModel.append({ duration: 60, text: i18n.tr(%1 
 minute, %1 minutes, 60).arg(60) })
  }

It's a bit of a strange case, as the string will always be plural, but I think 
it's better like this, as this way we'll leave the plural handling of gettext 
manage which plural form to use for those languages with more complex plural 
requirements.

  }
  
 @@ -62,10 +62,10 @@
  Component.onCompleted: initialise()
  
  function initialise() {
 -snoozeModel.append({ duration: 2, text: i18n.tr(%1 
 minutes).arg(2) })
 -snoozeModel.append({ duration: 4, text: i18n.tr(%1 
 minutes).arg(4) })
 -snoozeModel.append({ duration: 5, text: i18n.tr(%1 
 minutes).arg(5) })
 -snoozeModel.append({ duration: 10, text: i18n.tr(%1 
 minutes).arg(10) })
 +snoozeModel.append({ duration: 2, text: i18n.tr(%1 minute, 
 %1 minutes, 2).arg(2) })
 +snoozeModel.append({ duration: 4, text: i18n.tr(%1 minute, 
 %1 minutes, 4).arg(4) })
 +snoozeModel.append({ duration: 5, text: i18n.tr(%1 minute, 
 %1 minutes, 5).arg(5) })
 +snoozeModel.append({ duration: 10, text: i18n.tr(%1 
 minute, %1 minutes, 10).arg(10) })
  }

Same as the comment above

  }
  
 @@ -143,7 +143,7 @@
  SubtitledListItem {
  id: _header
  text: i18n.tr(Silence after)
 -subText: i18n.tr(%1 
 minutes).arg(alarmSettings.duration)
 +subText: i18n.tr(%1 minute, %1 minutes, 
 alarmSettings.duration).arg(alarmSettings.duration)
  onClicked: _alarmDuration.expanded = true
  
  Icon {
 @@ -212,7 +212,7 @@
  SubtitledListItem {
  id: _snoozeHeader
  text: i18n.tr(Snooze for)
 -subText: i18n.tr(%1 
 minutes).arg(alarmSettings.snoozeDuration)
 +subText: i18n.tr(%1 minute, %1 minutes, 
 alarmSettings.snoozeDuration).arg(alarmSettings.snoozeDuration)
  onClicked: _alarmSnooze.expanded = true
  
  Icon {
 
 === modified file 'debian/changelog'
 --- debian/changelog  2015-03-06 17:12:24 +
 +++ debian/changelog  2015-03-12 23:25:02 +
 @@ -10,7 +10,8 @@
* Fixed predefined cities and countries not being translatable in the 
 timezone
  selection dialog (LP: #1354466)
* Fixed empty state description not wrapping (LP: #1428165)
 -  * Fixed edit alarm crash issue in vivid (thanks to Zsombor)
 +  * Fixed edit alarm crash issue in vivid (thanks to Zsombor) (LP: #1429273)
 +  * Fixed strings not following gettext-style plural forms. (LP: #1431446)
  
[Brendan Donegan]
* Fixed AP failure by waiting for the bottom edge tip visible property to 
 be true
 
 === modified file 'po/com.ubuntu.clock.pot'
 --- po/com.ubuntu.clock.pot   2015-03-06 17:11:42 +
 +++ po/com.ubuntu.clock.pot   2015-03-12 23:25:02 +
 @@ -8,7 +8,7 @@
  msgstr 
  Project-Id-Version: \n
  Report-Msgid-Bugs-To: \n
 -POT-Creation-Date: 2015-03-06 17:09+\n
 +POT-Creation-Date: 2015-03-13 00:18+0100\n
  PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
  Last-Translator: FULL NAME EMAIL@ADDRESS\n
  Language-Team: LANGUAGE l...@li.org\n
 @@ -16,6 +16,7 @@
  MIME-Version: 1.0\n
  Content-Type: text/plain; charset=UTF-8\n
  Content-Transfer-Encoding: 8bit\n
 +Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n
  
  #: ../app/alarm/AlarmLabel.qml:30 ../app/alarm/AlarmLabel.qml:56
  #: ../app/alarm/EditAlarmPage.qml:291
 @@ -71,8 +72,10 @@
  #: ../app/alarm/AlarmSettingsPage.qml:146
  #: ../app/alarm/AlarmSettingsPage.qml:215
  #, qt-format
 -msgid %1 minutes
 -msgstr 
 +msgid %1 minute
 +msgid_plural %1 minutes
 +msgstr[0] 
 +msgstr[1] 
  
  #: 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app

[David Planella]

Review: Approve

I believe we don't need GETTEXT_LOCALEDIR unless we're explicitly using it 
somewhere.

IIRC we use LOCALEDIR to install the .mo files in the right locations in clock, 
which is probably defined here:

http://bazaar.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0/view/head:/CMakeLists.txt#L33
-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-translation-issues into lp:ubuntu-docviewer-app

[David Planella]

Looks good to me, just added one comment. Not sure if it can be worked around?

Diff comments:

 === modified file 'po/com.ubuntu.docviewer.pot'
 --- po/com.ubuntu.docviewer.pot   2015-03-04 12:28:46 +
 +++ po/com.ubuntu.docviewer.pot   2015-03-04 17:51:36 +
 @@ -8,7 +8,7 @@
  msgstr 
  Project-Id-Version: \n
  Report-Msgid-Bugs-To: \n
 -POT-Creation-Date: 2015-03-04 13:28+0100\n
 +POT-Creation-Date: 2015-03-04 18:46+0100\n
  PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
  Last-Translator: FULL NAME EMAIL@ADDRESS\n
  Language-Team: LANGUAGE l...@li.org\n
 @@ -16,6 +16,7 @@
  MIME-Version: 1.0\n
  Content-Type: text/plain; charset=CHARSET\n
  Content-Transfer-Encoding: 8bit\n
 +Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n
  
  #: ../src/app/qml/common/DetailsPage.qml:27
  #: ../src/app/qml/pdfView/PdfViewDefaultHeader.qml:91
 @@ -52,7 +53,7 @@
  msgstr 
  
  #: ../src/app/qml/common/ErrorDialog.qml:28
 -#: ../src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml:31
 +#: ../src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml:32
  #: ../src/app/qml/pdfView/PdfViewDefaultHeader.qml:61
  #: ../src/app/qml/textView/TextViewDefaultHeader.qml:61
  msgid Close
 @@ -76,31 +77,56 @@
  msgid No
  msgstr 
  
 -#: ../src/app/qml/documentPage/DeleteFileDialog.qml:27
 +#. TRANSLATORS: %1 is the size of a file, expressed in GB
 +#: ../src/app/qml/common/utils.js:22
 +#, qt-format
 +msgid %1 GB
 +msgstr 
 +
 +#. TRANSLATORS: %1 is the size of a file, expressed in MB
 +#: ../src/app/qml/common/utils.js:26
 +#, qt-format
 +msgid %1 MB
 +msgstr 
 +
 +#. TRANSLATORS: %1 is the size of a file, expressed in kB
 +#: ../src/app/qml/common/utils.js:30
 +#, qt-format
 +msgid %1 kB
 +msgstr 
 +
 +#. TRANSLATORS: %1 is the size of a file, expressed in byte
 +#: ../src/app/qml/common/utils.js:33
 +#, qt-format
 +msgid %1 byte
 +msgstr 
 +
 +#: ../src/app/qml/documentPage/DeleteFileDialog.qml:28
  msgid Delete file
  msgstr 
  
 -#: ../src/app/qml/documentPage/DeleteFileDialog.qml:28
 -#, qt-format
 -msgid Delete %1 files
 -msgstr 
 -
  #: ../src/app/qml/documentPage/DeleteFileDialog.qml:29
 +#, qt-format
 +msgid Delete %1 file
 +msgid_plural Delete %1 files
 +msgstr[0] 
 +msgstr[1] 
 +
 +#: ../src/app/qml/documentPage/DeleteFileDialog.qml:30
 +#: ../src/app/qml/documentPage/DeleteFileDialog.qml:31
  msgid Are you sure you want to permanently delete this file?
 -msgstr 
 -
 -#: ../src/app/qml/documentPage/DeleteFileDialog.qml:30
 -msgid Are you sure you want to permanently delete these files?
 -msgstr 
 -
 -#: ../src/app/qml/documentPage/DeleteFileDialog.qml:33
 +msgid_plural Are you sure you want to permanently delete these files?
 +msgstr[0] 
 +msgstr[1] 
 +
 +#: ../src/app/qml/documentPage/DeleteFileDialog.qml:36
  #: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:27
  #: ../src/app/qml/pdfView/PdfViewGotoDialog.qml:52
  msgid Cancel
  msgstr 
  
 -#: ../src/app/qml/documentPage/DeleteFileDialog.qml:38
 -#: ../src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml:81
 +#: ../src/app/qml/documentPage/DeleteFileDialog.qml:41
 +#: ../src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml:82
  msgid Delete
  msgstr 
  
 @@ -114,24 +140,30 @@
  folder.
  msgstr 
  
 -#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:33
 -msgid Today, 
 +#. TRANSLATORS: %1 refers to a time formatted as Locale.ShortFormat (e.g. 
 hh:mm). It depends on system settings.
 +#. http://qt-project.org/doc/qt-4.8/qlocale.html#FormatType-enum
 +#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:35
 +#, qt-format
 +msgid Today, %1
  msgstr 
  
 -#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:36
 -msgid Yesterday, 
 +#. TRANSLATORS: %1 refers to a time formatted as Locale.ShortFormat (e.g. 
 hh:mm). It depends on system settings.
 +#. http://qt-project.org/doc/qt-4.8/qlocale.html#FormatType-enum
 +#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:40
 +#, qt-format
 +msgid Yesterday, %1
  msgstr 
  
  #. TRANSLATORS: this is a datetime formatting string,
  #. see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid 
 expressions.
 -#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:41
 +#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:45
  #: ../src/app/qml/documentPage/DocumentListDelegate.qml:35
  msgid , hh:mm
  msgstr 
  
  #. TRANSLATORS: this is a datetime formatting string,
  #. see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid 
 expressions.
 -#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:45
 +#: ../src/app/qml/documentPage/DocumentGridDelegate.qml:49
  #: ../src/app/qml/documentPage/DocumentListDelegate.qml:39
  msgid dd-MM- hh:mm
  msgstr 
 @@ -157,7 +189,7 @@
  msgstr 
  
  #: ../src/app/qml/documentPage/DocumentPage.qml:25
 -#: /tmp/tmp.VrJNVy5Wgh/po/com.ubuntu.docviewer.desktop.in.in.h:1
 +#: