Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/run-qml-tests-on-build into lp:ubuntu-clock-app
Review: Disapprove Let's make this explicit in jenkins instead -- https://code.launchpad.net/~nskaggs/ubuntu-clock-app/run-qml-tests-on-build/+merge/289065 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/run-qml-tests-on-build/+merge/289063 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/run-qml-tests-on-build into lp:ubuntu-clock-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-clock-app/run-qml-tests-on-build into lp:ubuntu-clock-app.
Commit message:
Always run unit tests on build
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/run-qml-tests-on-build/+merge/289065
Always run unit tests on build
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of
lp:~nskaggs/ubuntu-clock-app/run-qml-tests-on-build into lp:ubuntu-clock-app.
=== modified file 'tests/unit/CMakeLists.txt'
--- tests/unit/CMakeLists.txt 2015-09-17 15:23:08 +
+++ tests/unit/CMakeLists.txt 2016-03-15 15:59:26 +
@@ -47,6 +47,12 @@
)
add_custom_target(tst_QmlFiles ALL SOURCES ${QML_TST_FILES})
+add_custom_command(
+TARGET tst_QmlFiles
+POST_BUILD
+COMMAND ctest --output-on-failure
+)
+
set(QML_TST_UTILS
MockClockApp.qml
ClockTestCase.qml
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app.
Commit message:
Always run qml tests when building
Requested reviews:
Ubuntu Notes app developers (notes-app-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/reminders-app/run-qml-tests-on-build/+merge/289063
Let's make sure qml tests run whenever we build.
--
Your team Ubuntu Notes app developers is requested to review the proposed merge
of lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app.
=== modified file 'tests/qml/CMakeLists.txt'
--- tests/qml/CMakeLists.txt 2015-03-19 23:01:15 +
+++ tests/qml/CMakeLists.txt 2016-03-15 15:44:15 +
@@ -46,3 +46,8 @@
endif()
add_custom_target(tst_QmlFiles ALL SOURCES ${QML_TST_FILES})
+add_custom_command(
+TARGET tst_QmlFiles
+POST_BUILD
+COMMAND ctest --output-on-failure
+)
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-rssreader-app/add-ap-template into lp:ubuntu-rssreader-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-rssreader-app/add-ap-template into lp:ubuntu-rssreader-app.
Commit message:
Re-add autopilot shell
Requested reviews:
Ubuntu Shorts Developers (ubuntu-shorts-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-rssreader-app/add-ap-template/+merge/288840
Re-add autopilot shell
--
Your team Ubuntu Shorts Developers is requested to review the proposed merge of
lp:~nskaggs/ubuntu-rssreader-app/add-ap-template into lp:ubuntu-rssreader-app.
=== added directory 'tests'
=== added directory 'tests/autopilot'
=== added directory 'tests/autopilot/shorts_app'
=== added file 'tests/autopilot/shorts_app/__init__.py'
--- tests/autopilot/shorts_app/__init__.py 1970-01-01 00:00:00 +
+++ tests/autopilot/shorts_app/__init__.py 2016-03-11 21:33:09 +
@@ -0,0 +1,41 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Copyright (C) 2013-2016 Canonical Ltd.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation; version 3.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+"""Shorts app autopilot helpers."""
+
+import ubuntuuitoolkit
+
+
+class ShortsApp(object):
+
+"""Autopilot helper object for the shorts application."""
+
+def __init__(self, app_proxy):
+self.app = app_proxy
+self.main_view = self.app.select_single(MainView)
+
+@property
+def pointing_device(self):
+return self.app.pointing_device
+
+
+class MainView(ubuntuuitoolkit.MainView):
+
+"""Autopilot custom proxy object for the MainView."""
+
+def __init__(self, *args):
+super(MainView, self).__init__(*args)
+self.visible.wait_for(True)
=== added directory 'tests/autopilot/shorts_app/tests'
=== added file 'tests/autopilot/shorts_app/tests/__init__.py'
--- tests/autopilot/shorts_app/tests/__init__.py 1970-01-01 00:00:00 +
+++ tests/autopilot/shorts_app/tests/__init__.py 2016-03-11 21:33:09 +
@@ -0,0 +1,100 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright 2013-2016 Canonical
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+
+"""Shorts app autopilot tests."""
+
+import os.path
+import fixtures
+import logging
+import tempfile
+import gi
+
+from autopilot import logging as autopilot_logging
+from autopilot.testcase import AutopilotTestCase
+import ubuntuuitoolkit
+
+import shorts_app
+gi.require_version('Click', '0.4')
+from gi.repository import Click
+
+
+logger = logging.getLogger(__name__)
+
+
+class ShortsTestCase(AutopilotTestCase):
+
+"""A common testcase class that provides useful methods for the shorts
+app.
+
+"""
+
+local_build_location = os.path.dirname(os.path.dirname(os.getcwd()))
+sdk_build_location = os.path.join(os.path.dirname(local_build_location),
+ os.path.basename(local_build_location)
+ + '-build')
+
+local_build_location_qml = os.path.join(
+local_build_location, 'shorts', 'qml', 'shorts-app.qml')
+local_build_location_binary = os.path.join(local_build_location,
+ 'shorts', 'shorts-app')
+sdk_build_location_qml = os.path.join(
+sdk_build_location, 'shorts', 'qml', 'shorts-app.qml')
+sdk_build_location_binary = os.path.join(sdk_build_location,
+ 'shorts', 'shorts-app')
+installed_location_binary = os.path.join('usr', 'bin',
+ 'shorts-app')
+installed_location_qml = os.path.join('usr', 'share',
+ 'shorts-app', 'qml',
+ 'shorts-app.qml')
+
+def setUp(self):
+super(ShortsTestCase, self).setUp()
+launcher_method, _ = self.get_launcher_method_and_type()
+self.app = shorts_app.ShortsApp(launcher_method())
+
+def get_launcher_method_and_type(self):
+if os.path.exists(self.local_build_location_binary):
+launcher = self.launch_test_local
+test_type = 'local'
+elif os.path.exists(self.sdk_build_location_binary):
+
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into lp:ubuntu-filemanager-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into
lp:ubuntu-filemanager-app with lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache
as a prerequisite.
Commit message:
Remove unneeded _copy_xauthority_file
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
Related bugs:
Bug #1220607 in Ubuntu File Manager App: "Autopilot tests fail due to
XAuthority bug"
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1220607
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-xauthority/+merge/288838
Remove unneeded _copy_xauthority_file
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into
lp:ubuntu-filemanager-app.
=== modified file 'tests/autopilot/filemanager/tests/__init__.py'
--- tests/autopilot/filemanager/tests/__init__.py 2016-03-07 15:15:45 +
+++ tests/autopilot/filemanager/tests/__init__.py 2016-03-11 21:17:45 +
@@ -157,23 +157,6 @@
directory = registry.get_path(package_name)
return version, directory
-def _copy_xauthority_file(self, directory):
-""" Copy .Xauthority file to directory, if it exists in /home
-"""
-# If running under xvfb, as jenkins does,
-# xsession will fail to start without xauthority file
-# Thus if the Xauthority file is in the home directory
-# make sure we copy it to our temp home directory
-
-xauth = os.path.expanduser(os.path.join(os.environ.get('HOME'),
- '.Xauthority'))
-if os.path.isfile(xauth):
-logger.debug("Copying .Xauthority to %s" % directory)
-shutil.copyfile(
-os.path.expanduser(os.path.join(os.environ.get('HOME'),
- '.Xauthority')),
-os.path.join(directory, '.Xauthority'))
-
def patch_home(self):
""" mock /home for testing purposes to preserve user data
"""
@@ -188,7 +171,6 @@
temp_dir = temp_dir_fixture.path
# before we set fixture, copy xauthority if needed
-self._copy_xauthority_file(temp_dir)
self.useFixture(fixtures.EnvironmentVariable('HOME',
newvalue=temp_dir))
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into lp:ubuntu-filemanager-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into
lp:ubuntu-filemanager-app.
Commit message:
Remove unneeded _copy_xauthority_file
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
Related bugs:
Bug #1220607 in Ubuntu File Manager App: "Autopilot tests fail due to
XAuthority bug"
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1220607
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-xauthority/+merge/288837
Remove unneeded _copy_xauthority_file
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into
lp:ubuntu-filemanager-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-10-20 18:28:30 +
+++ CMakeLists.txt 2016-03-11 21:17:15 +
@@ -73,22 +73,41 @@
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json filemanager.apparmor ${CONTENT_HUB_EXPORTER} DESTINATION ${CMAKE_INSTALL_PREFIX})
- MESSAGE("Grabbing upstream libs to ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs")
-execute_process(
-COMMAND mkdir ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/get-click-deps -d ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json ${CLICK_ARCH} ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-)
- MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
- file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
- foreach(ITEM ${UPSTREAM_LIBS})
- IF( IS_DIRECTORY "${ITEM}" )
- LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
- ELSE()
- LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
- ENDIF()
- endforeach()
- MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
- INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
+set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
+
+#grab dependencies
+set(GET_CLICK_DEPS_TOOL ${CMAKE_SOURCE_DIR}/get-click-deps)
+set(DEPS_MANIFEST ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json)
+MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
+
+get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
+set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-filemanager/${BLD_CONFIGURATION_NAME})
+MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
+
+if(EXISTS "${UPSTREAM_CACHE}")
+ MESSAGE("Upstream libs cache exists.")
+ file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
+else()
+ MESSAGE("Cache miss, downloading from network.")
+ file(MAKE_DIRECTORY ${UPSTREAM_LIBS_DIR})
+ file(MAKE_DIRECTORY ${UPSTREAM_CACHE})
+ execute_process(
+COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
+ )
+ # Cache for next usage
+ file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
+endif()
+MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
+file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
+foreach(ITEM ${UPSTREAM_LIBS})
+ IF( IS_DIRECTORY "${ITEM}" )
+ LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
+ ELSE()
+ LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
+ ENDIF()
+endforeach()
+MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
+INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
else(CLICK_MODE)
execute_process(
COMMAND qmake -query QT_INSTALL_QML
=== modified file 'tests/autopilot/filemanager/tests/__init__.py'
--- tests/autopilot/filemanager/tests/__init__.py 2016-03-07 15:15:45 +
+++ tests/autopilot/filemanager/tests/__init__.py 2016-03-11 21:17:15 +
@@ -157,23 +157,6 @@
directory = registry.get_path(package_name)
return version, directory
-def _copy_xauthority_file(self, directory):
-""" Copy .Xauthority file to directory, if it exists in /home
-"""
-# If running under xvfb, as jenkins does,
-# xsession will fail to start without xauthority file
-# Thus if the Xauthority file is in the home directory
-# make sure we copy it to our temp home directory
-
-xauth = os.path.expanduser(os.path.join(os.environ.get('HOME'),
- '.Xauthority'))
-if os.path.isfile(xauth):
-logger.debug("Copying .Xauthority to %s" % directory)
-shutil.copyfile(
-
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-xauthority/+merge/288837 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-xauthority into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app
This was done to help jenkins, but it appears it's not needed. Still, being explicit isn't a bad idea, and it's better than using mkdir. -- https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling/+merge/288557 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app
Glorious working builds! -- https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app with
lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template as a prerequisite.
Commit message:
Create cache folder during cmake copy
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
Create cache folder during cmake copy
--
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app.
=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake 2016-02-22 22:44:48 +
+++ cmake/modules/Click.cmake 2016-03-10 22:26:53 +
@@ -17,7 +17,7 @@
set(CUSTOM_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/click/disable-lo-features.sh)
set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
- MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
+ MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
if(NO_CACHE)
# It has been specified not to cache .click dependencies on the machine.
@@ -39,6 +39,7 @@
else()
MESSAGE("Cache miss, downloading from network.")
execute_process(
+COMMAND mkdir ${UPSTREAM_CACHE}
COMMAND mkdir ${UPSTREAM_LIBS_DIR}
COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} -c ${CUSTOM_SCRIPT} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
)
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Description changed to: Add dependency cache for click depends downloads For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-tests/+merge/288189 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Commit Message changed to: Add dependency cache for click depends downloads For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
with lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests as a prerequisite.
Commit message:
Add dependency cache for click depends downloads
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714
Add dependency cache for click depends downloads
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into
lp:ubuntu-filemanager-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-10-20 18:28:30 +
+++ CMakeLists.txt 2016-03-10 22:13:49 +
@@ -73,22 +73,40 @@
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json filemanager.apparmor ${CONTENT_HUB_EXPORTER} DESTINATION ${CMAKE_INSTALL_PREFIX})
- MESSAGE("Grabbing upstream libs to ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs")
-execute_process(
-COMMAND mkdir ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/get-click-deps -d ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json ${CLICK_ARCH} ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-)
- MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
- file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
- foreach(ITEM ${UPSTREAM_LIBS})
- IF( IS_DIRECTORY "${ITEM}" )
- LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
- ELSE()
- LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
- ENDIF()
- endforeach()
- MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
- INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
+set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
+
+#grab dependencies
+set(GET_CLICK_DEPS_TOOL ${CMAKE_SOURCE_DIR}/get-click-deps)
+set(DEPS_MANIFEST ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json)
+MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
+
+get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
+set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-filemanager/${BLD_CONFIGURATION_NAME})
+MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
+
+if(EXISTS "${UPSTREAM_CACHE}")
+ MESSAGE("Upstream libs cache exists.")
+ file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
+else()
+ MESSAGE("Cache miss, downloading from network.")
+ execute_process(
+COMMAND mkdir ${UPSTREAM_LIBS_DIR}
+COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
+ )
+ # Cache for next usage.
+ file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
+endif()
+MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
+file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
+foreach(ITEM ${UPSTREAM_LIBS})
+ IF( IS_DIRECTORY "${ITEM}" )
+ LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
+ ELSE()
+ LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
+ ENDIF()
+endforeach()
+MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
+INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
else(CLICK_MODE)
execute_process(
COMMAND qmake -query QT_INSTALL_QML
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-tests/+merge/288189 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-tests/+merge/288189 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app
Wow, that looks great Joey. Why didn't we merge that? It would still be useful to do so. README's are helpful! -- https://code.launchpad.net/~nskaggs/ubuntu-rssreader-app/add-ap-readme/+merge/288405 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Review: Approve It seems this never actually landed in trunk! Whoops, let's get this top approved and landed! -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/ap-readme-cleanup/+merge/288352 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/add-jenkins-info/+merge/288161 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/add-jenkins-info/+merge/288161 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/add-jenkins-info/+merge/288161 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/add-jenkins-info/+merge/288161 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/ap-readme-cleanup/+merge/288352 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/ap-readme-cleanup/+merge/288352 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/add-jenkins-info/+merge/288161 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/ap-readme-cleanup/+merge/288352 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app
The proposal to merge lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-rssreader-app/add-ap-readme/+merge/288405 -- Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app
Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app. Commit message: Add readme for autopilot tests Requested reviews: Ubuntu Shorts Developers (ubuntu-shorts-dev) For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-rssreader-app/add-ap-readme/+merge/288405 Add readme for autopilot tests -- Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-rssreader-app/add-ap-readme into lp:ubuntu-rssreader-app. === added file 'README.Autopilot.md' --- README.Autopilot.md 1970-01-01 00:00:00 + +++ README.Autopilot.md 2016-03-08 14:03:00 + @@ -0,0 +1,74 @@ +Running Autopilot tests +=== +If you are looking for more info about Autopilot or writing AP tests, here are some useful links to help you: + +- [Ubuntu - Quality](http://developer.ubuntu.com/start/quality) +- [Autopilot - Python](https://developer.ubuntu.com/api/autopilot/python/1.5.0/) + +For help and options on running tests, see: + +- [Autopilot tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/) + +Prerequisites += + +Install the following autopilot packages required to run the tests, + +$ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis + +Running tests on the desktop + + +Using terminal: + +* Branch the code + +$ bzr branch lp:ubuntu-rssreader-app + +* Navigate to the tests/autopilot directory. + +$ cd tests/autopilot + +* run all tests. + +$ autopilot3 run -vv shorts_app + +* to list all tests: + +$ autopilot3 list shorts_app + + To run only one test + +$ autopilot3 run -vv shorts.tests.test_name + +* Debugging tests using autopilot vis + +$ autopilot3 launch -i Qt qmlscene shorts/qml/shorts-app.qml + +$ autopilot3 vis + +Running tests using Ubuntu SDK +== + +Refer this [tutorial](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/) to run tests on Ubuntu SDK: + +Running tests on device or emulator: + + +Using autopkg: + +* Branch the code + +$ bzr branch lp:ubuntu-rssreader-app + +* Navigate to the source directory. + +$ cd ubuntu-rssreader-app + +* Build a click package + +$ click-buddy . + +* Run the tests on device (assumes only one click package in the directory) + +$ adt-run . *.click --- ssh -s adb -- -p \ No newline at end of file -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app
Absolutely; I fixed things and ran flake8: flake8 ubuntu_terminal_app/*.py ubuntu_terminal_app/tests/*.py ubuntu_terminal_app/tests/__init__.py:22:1: E402 module level import not at top of file ubuntu_terminal_app/tests/__init__.py:38:39: W503 line break before binary operator Both those warnings are ok -- we have to use the require before import to avoid other issues. -- https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app
https://core-apps-jenkins.ubuntu.com/view/Release/job/run-ap-tests-release/11/console -- https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347 Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/ap-readme-cleanup/+merge/288352 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app.
Commit message:
AP docs and cleanup
Requested reviews:
Ubuntu Notes app developers (notes-app-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/reminders-app/ap-readme-cleanup/+merge/288352
AP docs and cleanup
--
Your team Ubuntu Notes app developers is requested to review the proposed merge
of lp:~nskaggs/reminders-app/ap-readme-cleanup into lp:reminders-app.
=== added file 'README-Autopilot.md'
--- README-Autopilot.md 1970-01-01 00:00:00 +
+++ README-Autopilot.md 2016-03-07 22:12:47 +
@@ -0,0 +1,74 @@
+Running Autopilot tests
+===
+If you are looking for more info about Autopilot or writing AP tests, here are some useful links to help you:
+
+- [Ubuntu - Quality](http://developer.ubuntu.com/start/quality)
+- [Autopilot - Python](https://developer.ubuntu.com/api/autopilot/python/1.5.0/)
+
+For help and options on running tests, see:
+
+- [Autopilot tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)
+
+Prerequisites
+=
+
+Install the following autopilot packages required to run the tests,
+
+$ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis
+
+Running tests on the desktop
+
+
+Using terminal:
+
+* Branch the Music app code, for example,
+
+$ bzr branch lp:reminders-app
+
+* Navigate to the tests/autopilot directory.
+
+$ cd tests/autopilot
+
+* run all tests.
+
+$ autopilot3 run -vv reminders
+
+* to list all tests:
+
+$ autopilot3 list reminders
+
+ To run only one test
+
+$ autopilot3 run -vv reminders.tests.test_name
+
+* Debugging tests using autopilot vis
+
+$ autopilot3 launch -i Qt qmlscene src/app/terminal
+
+$ autopilot3 vis
+
+Running tests using Ubuntu SDK
+==
+
+Refer this [tutorial](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/) to run tests on Ubuntu SDK:
+
+Running tests on device or emulator:
+
+
+Using autopkg:
+
+* Branch the Music app code, for example,
+
+$ bzr branch lp:reminders-app
+
+* Navigate to the source directory.
+
+$ cd reminders-app
+
+* Build a click package
+
+$ click-buddy .
+
+* Run the tests on device (assumes only one click package in the directory)
+
+$ adt-run . *.click --- ssh -s adb -- -p
\ No newline at end of file
=== added file 'README.Mergeproposal.md'
--- README.Mergeproposal.md 1970-01-01 00:00:00 +
+++ README.Mergeproposal.md 2016-03-07 22:12:47 +
@@ -0,0 +1,32 @@
+Prerequisites to approving a Merge Proposal (MP)
+
+
+Over time, it has been found that insufficient testing by reviewers sometimes leads to reminders trunk not buildable in Qtcreator due to manifest errors, or translation pot file not updated. As such, please follow the checklist below before top-approving a MP.
+
+Checklist
+=
+
+* Does the MP add/remove user visible strings? If Yes, has the pot file been
+updated?
+
+* Does the MP change the UI? If Yes, has it been approved by design?
+
+* Did you perform an exploratory manual test run of your code change and any
+related functionality?
+
+* If the MP fixes a bug or implements a feature, are there accompanying unit
+and autopilot tests?
+
+* Is the reminders trunk buildable and runnable using Qtcreator?
+
+* Was the debian changelog updated?
+
+* Was the copyright years updated if necessary?
+
+The above checklist is more of a guideline to help reminders trunk stay buildable,
+stable and up to date.
+
+
+Jenkins
+===
+In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins)
=== modified file 'tests/autopilot/reminders/tests/__init__.py'
--- tests/autopilot/reminders/tests/__init__.py 2016-02-25 20:04:31 +
+++ tests/autopilot/reminders/tests/__init__.py 2016-03-07 22:12:47 +
@@ -186,12 +186,6 @@
temp_dir = temp_dir_fixture.path
temp_xdg_config_home = os.path.join(temp_dir, '.config')
-# If running under xvfb, as jenkins does,
-# xsession will fail to start without xauthority file
-# Thus if the Xauthority file is in the home directory
-# make sure we copy it to our temp home directory
-self._copy_xauthority_file(temp_dir)
-
self.useFixture(
fixtures.EnvironmentVariable('HOME', newvalue=temp_dir))
self.useFixture(
@@ -202,15 +196,6 @@
return temp_dir
-def _copy_xauthority_file(self, directory):
-"""Copy .Xauthority fi
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app.
Commit message:
Add back templates for autopilot
add autopilot readme
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
Add back templates for autopilot
add autopilot readme
--
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into
lp:ubuntu-terminal-app.
=== added file 'README.autopilot.md'
--- README.autopilot.md 1970-01-01 00:00:00 +
+++ README.autopilot.md 2016-03-07 21:17:09 +
@@ -0,0 +1,74 @@
+Running Autopilot tests
+===
+If you are looking for more info about Autopilot or writing AP tests, here are some useful links to help you:
+
+- [Ubuntu - Quality](http://developer.ubuntu.com/start/quality)
+- [Autopilot - Python](https://developer.ubuntu.com/api/autopilot/python/1.5.0/)
+
+For help and options on running tests, see:
+
+- [Autopilot tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)
+
+Prerequisites
+=
+
+Install the following autopilot packages required to run the tests,
+
+$ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis
+
+Running tests on the desktop
+
+
+Using terminal:
+
+* Branch the Music app code, for example,
+
+$ bzr branch lp:ubuntu-terminal-app
+
+* Navigate to the tests/autopilot directory.
+
+$ cd tests/autopilot
+
+* run all tests.
+
+$ autopilot3 run -vv ubuntu_terminal_app
+
+* to list all tests:
+
+$ autopilot3 list ubuntu_terminal_app
+
+ To run only one test
+
+$ autopilot3 run -vv ubuntu_terminal_app.tests.test_name
+
+* Debugging tests using autopilot vis
+
+$ autopilot3 launch -i Qt qmlscene src/app/terminal
+
+$ autopilot3 vis
+
+Running tests using Ubuntu SDK
+==
+
+Refer this [tutorial](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/) to run tests on Ubuntu SDK:
+
+Running tests on device or emulator:
+
+
+Using autopkg:
+
+* Branch the Music app code, for example,
+
+$ bzr branch lp:ubuntu-terminal-app
+
+* Navigate to the source directory.
+
+$ cd ubuntu-terminal-app
+
+* Build a click package
+
+$ click-buddy .
+
+* Run the tests on device (assumes only one click package in the directory)
+
+$ adt-run . *.click --- ssh -s adb -- -p
\ No newline at end of file
=== removed directory 'old-tests'
=== removed file 'old-tests/CMakeLists.txt'
--- old-tests/CMakeLists.txt 2014-10-25 04:42:31 +
+++ old-tests/CMakeLists.txt 1970-01-01 00:00:00 +
@@ -1,1 +0,0 @@
-add_subdirectory(autopilot)
=== removed directory 'old-tests/autopilot'
=== removed file 'old-tests/autopilot/CMakeLists.txt'
--- old-tests/autopilot/CMakeLists.txt 2014-10-25 04:42:31 +
+++ old-tests/autopilot/CMakeLists.txt 1970-01-01 00:00:00 +
@@ -1,8 +0,0 @@
-if(INSTALL_TESTS)
-execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
-OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
-
-install(DIRECTORY ${AUTOPILOT_DIR}
-DESTINATION ${PYTHON_PACKAGE_DIR}
-)
-endif(INSTALL_TESTS)
=== removed directory 'old-tests/autopilot/ubuntu_terminal_app'
=== removed file 'old-tests/autopilot/ubuntu_terminal_app/__init__.py'
--- old-tests/autopilot/ubuntu_terminal_app/__init__.py 2014-10-25 04:42:31 +
+++ old-tests/autopilot/ubuntu_terminal_app/__init__.py 1970-01-01 00:00:00 +
@@ -1,174 +0,0 @@
-# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
-#
-# Copyright (C) 2013 Canonical Ltd.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU Lesser General Public License as published by
-# the Free Software Foundation; version 3.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU Lesser General Public License for more details.
-#
-# You should have received a copy of the GNU Lesser General Public License
-# along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-"""Terminal app autopilot helpers."""
-
-from time import sleep
-import sqlite3
-import os.path
-import ubuntuuitoolkit
-
-
-class TerminalApp(object):
-
-"""Autopilot helper object for the terminal application."""
-
-def __init__(self, app_proxy):
-self.app = app_proxy
-self.main_view = self.app.select_single(MainView)
-
-@property
-def pointing_device(self):
-
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info into lp:ubuntu-terminal-app
Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info into lp:ubuntu-terminal-app. Commit message: add jenkins info and mp readme Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/add-jenkins-info/+merge/288165 add jenkins info and mp readme -- Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info into lp:ubuntu-terminal-app. === added file 'README.mergeproposal.md' --- README.mergeproposal.md 1970-01-01 00:00:00 + +++ README.mergeproposal.md 2016-03-04 20:09:15 + @@ -0,0 +1,32 @@ +Prerequisites to approving a Merge Proposal (MP) + + +Over time, it has been found that insufficient testing by reviewers sometimes leads to terminal trunk not buildable in Qtcreator due to manifest errors, or translation pot file not updated. As such, please follow the checklist below before top-approving a MP. + +Checklist += + +* Does the MP add/remove user visible strings? If Yes, has the pot file been +updated? + +* Does the MP change the UI? If Yes, has it been approved by design? + +* Did you perform an exploratory manual test run of your code change and any +related functionality? + +* If the MP fixes a bug or implements a feature, are there accompanying unit +and autopilot tests? + +* Is the terminal trunk buildable and runnable using Qtcreator? + +* Was the debian changelog updated? + +* Was the copyright years updated if necessary? + +The above checklist is more of a guideline to help terminal trunk stay buildable, +stable and up to date. + + +Jenkins +=== +In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins) -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/music-app/add-jenkins-info into lp:music-app
blargh. I try one last time. -- https://code.launchpad.net/~nskaggs/music-app/add-jenkins-info/+merge/288155 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-weather-app/add-jenkins-info into lp:ubuntu-weather-app
Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-weather-app/add-jenkins-info into lp:ubuntu-weather-app. Commit message: add jenkins info Requested reviews: Ubuntu Weather Developers (ubuntu-weather-dev) For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-weather-app/add-jenkins-info/+merge/288160 add jenkins info -- Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-weather-app/add-jenkins-info into lp:ubuntu-weather-app. === modified file 'README-Mergeproposal.md' --- README-Mergeproposal.md 2015-12-18 00:21:58 + +++ README-Mergeproposal.md 2016-03-04 20:00:15 + @@ -28,3 +28,6 @@ The above checklist is more of a guideline to help weather app trunk stay buildable, stable and up to date. +Jenkins +=== +In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins) \ No newline at end of file -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/music-app/add-jenkins-info into lp:music-app
Nicholas Skaggs has proposed merging lp:~nskaggs/music-app/add-jenkins-info into lp:music-app. Commit message: Add jenkins info to readme Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Music App Developers (music-app-dev) For more details, see: https://code.launchpad.net/~nskaggs/music-app/add-jenkins-info/+merge/288155 Add jenkins info to readme -- Your team Music App Developers is requested to review the proposed merge of lp:~nskaggs/music-app/add-jenkins-info into lp:music-app. === modified file 'README-Mergeproposal.md' --- README-Mergeproposal.md 2015-12-17 20:43:26 + +++ README-Mergeproposal.md 2016-03-04 19:59:35 + @@ -26,3 +26,6 @@ The above checklist is more of a guideline to help music app trunk stay buildable, stable and up to date. +Jenkins +=== +In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins) \ No newline at end of file === modified file 'po/com.ubuntu.music.pot' --- po/com.ubuntu.music.pot 2016-02-28 01:18:29 + +++ po/com.ubuntu.music.pot 2016-03-04 19:59:35 + @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: music-app\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2016-02-27 19:11-0600\n" +"POT-Creation-Date: 2016-02-22 16:45-0500\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" "Language-Team: LANGUAGE <l...@li.org>\n" @@ -287,7 +287,7 @@ #: ../app/ui/SongsView.qml:291 ../app/ui/SongsView.qml:292 #, qt-format msgid "%1 track" -msgid_plural "%1 tracks" +msgid_plural "%1 track" msgstr[0] "" msgstr[1] "" -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/add-jenkins-info into lp:ubuntu-calendar-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-calendar-app/add-jenkins-info into lp:ubuntu-calendar-app.
Commit message:
Add jenkins info
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/add-jenkins-info/+merge/288158
Add jenkins info
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~nskaggs/ubuntu-calendar-app/add-jenkins-info into lp:ubuntu-calendar-app.
=== modified file 'README.mergeproposal'
--- README.mergeproposal 2015-12-13 22:01:52 +
+++ README.mergeproposal 2016-03-04 19:54:53 +
@@ -29,3 +29,6 @@
The above checklist is more of a guideline to help calendar app trunk stay buildable,
stable and up to date.
+Jenkins
+===
+In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins)
\ No newline at end of file
=== modified file 'tests/autopilot/calendar_app/__init__.py'
--- tests/autopilot/calendar_app/__init__.py 2016-02-01 19:48:19 +
+++ tests/autopilot/calendar_app/__init__.py 2016-03-04 19:54:53 +
@@ -70,55 +70,13 @@
# click on tab action
tab_button = self.wait_select_single(objectName='tab_%s_button'%tabName)
-self.pointing_device.click_object(tab_button)
+self.pointing_device.click_object(tab_button)
@autopilot.logging.log_action(logger.info)
def click_action_button(self, action):
current_tab = self.select_single('Tab', visible=True)
button = current_tab.wait_select_single(objectName='%s_button'%action)
-self.pointing_device.click_object(button)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_month_view(self):
-"""Open the month view.
-
-:return: The Month View page.
-
-"""
-month_tab = self.select_single('Tab', objectName='monthTab')
-if not month_tab.visible:
-self.switch_to_tab('monthTab')
-else:
-logger.debug('The month View page is already opened.')
-return self.get_month_view(month_tab)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_week_view(self):
-"""Open the week view.
-
-:return: The Week View page.
-
-"""
-week_tab = self.select_single('Tab', objectName='weekTab')
-if not week_tab.visible:
-self.switch_to_tab('weekTab')
-else:
-logger.debug('The week View page is already opened.')
-return self.get_week_view(week_tab)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_year_view(self):
-"""Open the year view.
-
-:return: The Year View page.
-
-"""
-year_tab = self.select_single('Tab', objectName='yearTab')
-if not year_tab.visible:
-self.switch_to_tab('yearTab')
-else:
-logger.debug('The Year View page is already opened.')
-return self.get_year_view(year_tab)
+self.pointing_device.click_object(button)
@autopilot.logging.log_action(logger.info)
def go_to_day_view(self):
@@ -169,121 +127,26 @@
return self.wait_select_single(
CalendarChoicePopup, objectName="calendarchoicepopup")
-def set_picker(self, field, mode, value):
-# open picker
-self.pointing_device.click_object(field)
-# valid options are date or time; assume date if invalid/no option
-if mode == 'time':
-mode_value = 'Hours|Minutes'
-else:
-mode_value = 'Years|Months|Days'
-picker = self.wait_select_single(
-ubuntuuitoolkit.pickers.DatePicker, mode=mode_value, visible=True)
-if mode_value == 'Hours|Minutes':
-picker.pick_time(value)
-else:
-picker.pick_date(value)
-# close picker
-self.pointing_device.click_object(field)
-
-def get_event_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single("EventView")
-
def get_event_details(self, parent_object=None):
if parent_object is None:
parent_object = self
return parent_object.wait_select_single(EventDetails,
objectName='eventDetails')
-
-def get_month_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single(MonthView,
-obj
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/add-jenkins-info into lp:ubuntu-clock-app
Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-clock-app/add-jenkins-info into lp:ubuntu-clock-app. Commit message: Add jenkins info to readme Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Ubuntu Clock Developers (ubuntu-clock-dev) For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-clock-app/add-jenkins-info/+merge/288157 Add jenkins info to readme -- Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/add-jenkins-info into lp:ubuntu-clock-app. === modified file 'README.mergeproposal' --- README.mergeproposal 2015-08-12 19:16:03 + +++ README.mergeproposal 2016-03-04 19:51:27 + @@ -29,5 +29,6 @@ The above checklist is more of a guideline to help clock app trunk stay buildable, stable and up to date. -Note: As of vivid 15.04, Autopilot are broken in trunk. As such autopilot failures -can be excused until they are fixed in trunk. +Jenkins +=== +In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins) \ No newline at end of file -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app.
Commit message:
Remove all the AP tests that involve views, these can be test using qml tests.
Reduce unneeded helpers
Workaround toolkit AP helper bug
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
Remove all the AP tests that involve views, these can be test using qml tests.
Reduce unneeded helpers
Workaround toolkit AP helper bug
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app.
=== modified file 'tests/autopilot/calendar_app/__init__.py'
--- tests/autopilot/calendar_app/__init__.py 2016-02-01 19:48:19 +
+++ tests/autopilot/calendar_app/__init__.py 2016-03-03 17:10:48 +
@@ -70,55 +70,13 @@
# click on tab action
tab_button = self.wait_select_single(objectName='tab_%s_button'%tabName)
-self.pointing_device.click_object(tab_button)
+self.pointing_device.click_object(tab_button)
@autopilot.logging.log_action(logger.info)
def click_action_button(self, action):
current_tab = self.select_single('Tab', visible=True)
button = current_tab.wait_select_single(objectName='%s_button'%action)
-self.pointing_device.click_object(button)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_month_view(self):
-"""Open the month view.
-
-:return: The Month View page.
-
-"""
-month_tab = self.select_single('Tab', objectName='monthTab')
-if not month_tab.visible:
-self.switch_to_tab('monthTab')
-else:
-logger.debug('The month View page is already opened.')
-return self.get_month_view(month_tab)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_week_view(self):
-"""Open the week view.
-
-:return: The Week View page.
-
-"""
-week_tab = self.select_single('Tab', objectName='weekTab')
-if not week_tab.visible:
-self.switch_to_tab('weekTab')
-else:
-logger.debug('The week View page is already opened.')
-return self.get_week_view(week_tab)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_year_view(self):
-"""Open the year view.
-
-:return: The Year View page.
-
-"""
-year_tab = self.select_single('Tab', objectName='yearTab')
-if not year_tab.visible:
-self.switch_to_tab('yearTab')
-else:
-logger.debug('The Year View page is already opened.')
-return self.get_year_view(year_tab)
+self.pointing_device.click_object(button)
@autopilot.logging.log_action(logger.info)
def go_to_day_view(self):
@@ -169,121 +127,26 @@
return self.wait_select_single(
CalendarChoicePopup, objectName="calendarchoicepopup")
-def set_picker(self, field, mode, value):
-# open picker
-self.pointing_device.click_object(field)
-# valid options are date or time; assume date if invalid/no option
-if mode == 'time':
-mode_value = 'Hours|Minutes'
-else:
-mode_value = 'Years|Months|Days'
-picker = self.wait_select_single(
-ubuntuuitoolkit.pickers.DatePicker, mode=mode_value, visible=True)
-if mode_value == 'Hours|Minutes':
-picker.pick_time(value)
-else:
-picker.pick_date(value)
-# close picker
-self.pointing_device.click_object(field)
-
-def get_event_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single("EventView")
-
def get_event_details(self, parent_object=None):
if parent_object is None:
parent_object = self
return parent_object.wait_select_single(EventDetails,
objectName='eventDetails')
-
-def get_month_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single(MonthView,
-objectName='monthViewPage')
-
-def get_year_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single(YearView,
-objectName='yearViewPage')
-
def get_day_view(self, parent_object=None):
if parent_object is None:
parent_object = self
return parent_object.wait_select_single(Day
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
The proposal to merge lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app has been updated. Description changed to: Autopilot test cleanup for clock * fix launching and add option for building with SDK * remove fixtures * Remove debug print_trees For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 -- Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
Thanks Max! -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Commit Message changed to: This branch updates the test code to import specific gi versions, fixing lp#1546782. For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/fix-ap-tests into lp:reminders-app
Nicholas Skaggs has proposed merging lp:~nskaggs/reminders-app/fix-ap-tests into lp:reminders-app. Commit message: Adds support for running autopilot tests with SDK out of tree builds Fix reminders.tests.test_reminders.RemindersTestCaseWithoutAccount tests Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/fix-ap-tests/+merge/286422 Adds support for running autopilot tests with SDK out of tree builds Fix reminders.tests.test_reminders.RemindersTestCaseWithoutAccount tests -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/fix-ap-tests into lp:reminders-app. === modified file 'tests/autopilot/reminders/__init__.py' --- tests/autopilot/reminders/__init__.py 2014-11-25 16:36:33 + +++ tests/autopilot/reminders/__init__.py 2016-02-17 22:23:49 + @@ -41,7 +41,20 @@ def __init__(self, app_proxy): self.app = app_proxy -self.main_view = self.app.select_single(MainView) +# Use only objectName due to bug 1350532 +self.main_view = self.app.wait_select_single(objectName="mainView") + + +@property +def no_account_dialog(self): +try: +self._no_account_dialog = self.app.wait_select_single( +objectName='noAccountDialog') +except dbus.StateNotFoundError: +raise RemindersAppException( +'The No Account dialog is not present') +else: +return self._no_account_dialog def open_notebooks(self): """Open the Notebooks page. @@ -61,19 +74,7 @@ def __init__(self, *args): super(MainView, self).__init__(*args) self.visible.wait_for(True) -try: -self._no_account_dialog = self.select_single( -objectName='noAccountDialog') -except dbus.StateNotFoundError: -self._no_account_dialog = None -@property -def no_account_dialog(self): -if self._no_account_dialog is None: -raise RemindersAppException( -'The No Account dialog is not present') -else: -return self._no_account_dialog class NoAccountDialog(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase): @@ -108,7 +109,8 @@ super(_Page, self).__init__(*args) # XXX we need a better way to keep reference to the main view. # --elopio - 2014-02-26 -self.main_view = self.get_root_instance().select_single(MainView) +self.main_view = \ +self.get_root_instance().wait_select_single(objectName="mainView") class PulldownListView(ubuntuuitoolkit.QQuickListView): === modified file 'tests/autopilot/reminders/tests/__init__.py' --- tests/autopilot/reminders/tests/__init__.py 2014-11-13 10:30:34 + +++ tests/autopilot/reminders/tests/__init__.py 2016-02-17 22:23:49 + @@ -41,11 +41,16 @@ """ -local_location = os.path.dirname(os.path.dirname(os.getcwd())) +local_build_location = os.path.dirname(os.path.dirname(os.getcwd())) +sdk_build_location = os.path.join(os.path.dirname(local_build_location), +os.path.basename(local_build_location) + '-build') -local_location_qml = os.path.join( -local_location, 'src/app/qml/reminders.qml') -local_location_binary = os.path.join(local_location, 'src/app/reminders') +local_build_location_qml = os.path.join( +local_build_location, 'src/app/qml/reminders.qml') +local_build_location_binary = os.path.join(local_build_location, 'src/app/reminders') +sdk_build_location_qml = os.path.join( +sdk_build_location, 'src/app/qml/reminders.qml') +sdk_build_location_binary = os.path.join(sdk_build_location, 'src/app/reminders') installed_location_binary = '/usr/bin/reminders' installed_location_qml = '/usr/share/reminders/qml/reminders.qml' @@ -63,9 +68,12 @@ subprocess.call(['pkill', '-9', 'signond']) def get_launcher_method_and_type(self): -if os.path.exists(self.local_location_binary): +if os.path.exists(self.local_build_location_binary): launcher = self.launch_test_local test_type = 'local' +elif os.path.exists(self.sdk_build_location_binary): +launcher = self.launch_test_sdk +test_type = 'sdk' elif os.path.exists(self.installed_location_binary): launcher = self.launch_test_installed test_type = 'deb' @@ -78,9 +86,20 @@ def launch_test_local(self): self.useFixture(fixtures.EnvironmentVariable( 'QML2_IMPORT_PATH', -newvalue=os.path.join(self.local_location, 'src/plugin'))) -return self.launch_test_application( -self.local_location_binary, +newvalue=os.path.join(self.local_build_location, 'src/plugi
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app
The proposal to merge lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1543058/+merge/285327 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app
The proposal to merge lp:~popey/ubuntu-filemanager-app/fix-1543058 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1543058/+merge/285327 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1515722/+merge/278759 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into lp:ubuntu-docviewer-app
Review: Needs Fixing Text conflict in po/com.ubuntu.docviewer.pot 1 conflicts encountered. Everytime something lands, you get this lovely conflict. Not sure if there's a better way for you to avoid this :-) -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider/+merge/282878 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into lp:ubuntu-docviewer-app
In other news, jenkins should build and run this cleanly now. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider/+merge/282878 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
Review: Needs Fixing I'm not sure what is wrong with the branch, but bzr REALLY REALLY doesn't like it. It also doesn't merge cleanly anymore :-( Text conflict in DayView.qml Text conflict in HeaderDateComponent.qml Text conflict in MonthComponentDateDelegate.qml Text conflict in MonthView.qml Text conflict in ViewHeader.qml Text conflict in WeekView.qml Text conflict in YearView.qml Text conflict in calendar.qml Text conflict in po/com.ubuntu.calendar.pot 9 conflicts encountered. Can you fix the conflicts or better -- create a fresh branch from trunk and submit? -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp:ubuntu-terminal-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument/+merge/283786 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/fix-1538863 into lp:music-app
The proposal to merge lp:~vthompson/music-app/fix-1538863 into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~vthompson/music-app/fix-1538863/+merge/284387 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/fix-1538863 into lp:music-app
The proposal to merge lp:~vthompson/music-app/fix-1538863 into lp:music-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~vthompson/music-app/fix-1538863/+merge/284387 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-welcome-wizard into lp:ubuntu-calculator-app
The proposal to merge lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-welcome-wizard into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-welcome-wizard/+merge/281699 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app
Review: Needs Fixing Text conflict in po/com.ubuntu.docviewer.pot 1 conflicts encountered. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/+merge/282845 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support into lp:ubuntu-docviewer-app
Review: Needs Fixing Text conflict in po/com.ubuntu.docviewer.pot Conflict adding file po/ja.po. Moved existing file to po/ja.po.moved. Conflict adding file po/ro.po. Moved existing file to po/ro.po.moved. Text conflict in src/app/qml/loView/LOViewPage.qml Text conflict in src/app/qml/pdfView/PdfView.qml 5 conflicts encountered. bzr: ERROR: Conflicts from merge -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support/+merge/282639 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/reboot-add-opml-support into lp:ubuntu-rssreader-app
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/reboot-add-opml-support into lp:ubuntu-rssreader-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/reboot-add-opml-support/+merge/282608 -- Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~qqworini/ubuntu-rssreader-app/reboot-add-opml-support into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations into lp:ubuntu-weather-app
The proposal to merge lp:~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations into lp:ubuntu-weather-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations/+merge/282988 -- Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations into lp:ubuntu-weather-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations into lp:ubuntu-weather-app
Top --approving to land. Whew jenkins. -- https://code.launchpad.net/~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations/+merge/282988 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations into lp:ubuntu-weather-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing into lp:ubuntu-clock-app
The proposal to merge lp:~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing/+merge/283021 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/lighter-now-playing-toolbar into lp:music-app
Review: Needs Fixing Text conflict in app/ui/NowPlaying.qml 1 conflicts encountered. -- https://code.launchpad.net/~vthompson/music-app/lighter-now-playing-toolbar/+merge/279654 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app
The proposal to merge lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-fix-1534540 into lp:ubuntu-rssreader-app
The proposal to merge lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-fix-1534540 into lp:ubuntu-rssreader-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-fix-1534540/+merge/282841 -- Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-fix-1534540 into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/+merge/282845 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/music-app/songs-fastscroll into lp:music-app
The proposal to merge lp:~mcintire-evan/music-app/songs-fastscroll into lp:music-app has been updated. Commit Message changed to: Add fastscroll to the song list For more details, see: https://code.launchpad.net/~mcintire-evan/music-app/songs-fastscroll/+merge/281471 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix/+merge/281414 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app
The proposal to merge lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dpm/reminders-app/fix-deb-build/+merge/284423 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing into lp:ubuntu-clock-app
Andrew, do you need help with this? -- https://code.launchpad.net/~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing/+merge/283021 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml/+merge/282674 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app
Retrying. I believe we solved this issue last week. If not we can disable it fix things so it doesn't block -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml/+merge/282674 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
Review: Needs Fixing :-( Text conflict in po/com.ubuntu.terminal.pot 1 conflicts encountered. bzr: ERROR: Conflicts from merge -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
This needs to land after updating so pot file doesn't cause havoc again. -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app
Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app. Commit message: Fix autopilot tests in trunk -- UI element types changed slightly. Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Ubuntu File Manager Developers (ubuntu-filemanager-dev) For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 Fix autopilot tests in trunk -- UI element types changed slightly. -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app. === modified file 'tests/autopilot/filemanager/__init__.py' --- tests/autopilot/filemanager/__init__.py 2015-03-12 21:39:41 + +++ tests/autopilot/filemanager/__init__.py 2016-01-14 16:46:35 + @@ -108,7 +108,7 @@ """Bring the places page to the screen""" try: action_item = self.wait_select_single( -'ShapeItem', objectName='bottomEdgeTip') +'UCUbuntuShape', objectName='bottomEdgeTip') action_item.visible.wait_for(True) action_item.isAnimating.wait_for(False) start_x = (action_item.globalRect.x + @@ -396,7 +396,7 @@ def _split_header_text(self): header_text = self.select_single( -'Header', objectName='listViewSmallHeader').text +'ListItemHeader', objectName='listViewSmallHeader').text match = re.match(self.SPLIT_HEADER_REGEX, header_text) if match: path = match.group(1) @@ -432,7 +432,7 @@ def _split_header_text(self): header_text = self.select_single( -'Header', objectName='iconViewHeader').text +'ListItemHeader', objectName='iconViewHeader').text match = re.match(self.SPLIT_HEADER_REGEX, header_text) if match: path = match.group(1) -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app
The proposal to merge lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app
Review: Needs Fixing all the failures I see seem correct. I run the test by hand and it doesn't work as the test says it should. Are you sure the functionality is correct? run3:10: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_adding_comma_without_number_on_temp_result run3:44: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_simple_calculation_via_keyboard run3:78: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_temporarly_result -- https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app
Turns out the human is at fault here. The autolanding job(s) were a bit misconfigured on a couple params. -- https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
