[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve Nice! Thanks for the quick update. -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve Pushed this patch to krillin and run the tests -> $ phablet-test-run music_app Loading tests from: /home/phablet/autopilot Tests running... Ran 20 tests in 520.130s O -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:1018 https://core-apps-jenkins.ubuntu.com/job/music-app-ci/111/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/968/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/music-app-ci/111/rebuild -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:1017 https://core-apps-jenkins.ubuntu.com/job/music-app-ci/110/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/967/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/music-app-ci/110/rebuild -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:1016 https://core-apps-jenkins.ubuntu.com/job/music-app-ci/109/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/966/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/music-app-ci/109/rebuild -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app has been updated. Description changed to: * Fix for autopilot using switch_to_tab instead of leadingActionBar * Fix for duplicate Toolbars being created, confusing autopilot For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:1015 https://core-apps-jenkins.ubuntu.com/job/music-app-ci/108/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/965/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/music-app-ci/108/rebuild -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app has been updated. Commit Message changed to: * Fix for autopilot using switch_to_tab instead of leadingActionBar * Fix for duplicate Toolbars being created, confusing autopilot For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Abstain This is now passing autopilot \o/ adt-run [23:42:32]: test autopilot: - - - - - - - - - - results - - - - - - - - - - autopilotPASS -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:1014 https://core-apps-jenkins.ubuntu.com/job/music-app-ci/107/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/964/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/music-app-ci/107/rebuild -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:1013 https://core-apps-jenkins.ubuntu.com/job/music-app-ci/106/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/963/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/music-app-ci/106/rebuild -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Andrew Hayzen has proposed merging
lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app.
Commit message:
* Fix for autopilot using switch_to_tab instead of leadingActionBar
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1613328 in Ubuntu Music App: "Autopilot tests fail"
https://bugs.launchpad.net/music-app/+bug/1613328
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955
* Fix for autopilot using switch_to_tab instead of leadingActionBar
--
Your team Music App Developers is requested to review the proposed merge of
lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app.
=== modified file 'app/components/HeadState/EmptyHeadState.qml'
--- app/components/HeadState/EmptyHeadState.qml 2016-03-28 09:50:01 +
+++ app/components/HeadState/EmptyHeadState.qml 2016-08-15 16:33:06 +
@@ -32,6 +32,7 @@
backActionComponent
}
}
+objectName: "tabsLeadingActionBar"
}
title: thisPage.title
visible: thisPage.state === "default"
=== modified file 'app/components/HeadState/PlaylistHeadState.qml'
--- app/components/HeadState/PlaylistHeadState.qml 2016-03-28 09:50:01 +
+++ app/components/HeadState/PlaylistHeadState.qml 2016-08-15 16:33:06 +
@@ -34,6 +34,7 @@
backActionComponent
}
}
+objectName: "tabsLeadingActionBar"
}
title: thisPage.title
trailingActionBar {
=== modified file 'app/components/HeadState/PlaylistsHeadState.qml'
--- app/components/HeadState/PlaylistsHeadState.qml 2016-03-28 09:50:01 +
+++ app/components/HeadState/PlaylistsHeadState.qml 2016-08-15 16:33:06 +
@@ -36,6 +36,7 @@
backActionComponent
}
}
+objectName: "tabsLeadingActionBar"
}
title: thisPage.title
trailingActionBar {
=== modified file 'app/components/HeadState/QueueHeadState.qml'
--- app/components/HeadState/QueueHeadState.qml 2016-04-06 02:18:12 +
+++ app/components/HeadState/QueueHeadState.qml 2016-08-15 16:33:06 +
@@ -37,6 +37,7 @@
backActionComponent
}
}
+objectName: "tabsLeadingActionBar"
}
title: thisPage.title
trailingActionBar {
=== modified file 'app/components/HeadState/SearchableHeadState.qml'
--- app/components/HeadState/SearchableHeadState.qml 2016-03-04 04:28:21 +
+++ app/components/HeadState/SearchableHeadState.qml 2016-08-15 16:33:06 +
@@ -35,6 +35,7 @@
backActionComponent
}
}
+objectName: "tabsLeadingActionBar"
}
title: thisPage.title
trailingActionBar {
=== modified file 'app/components/MusicPage.qml'
--- app/components/MusicPage.qml 2016-03-28 09:02:31 +
+++ app/components/MusicPage.qml 2016-08-15 16:33:06 +
@@ -53,6 +53,7 @@
null
}
}
+objectName: "tabsLeadingActionBar"
}
title: thisPage.title
=== modified file 'app/components/NowPlayingSidebar.qml'
--- app/components/NowPlayingSidebar.qml 2016-03-04 03:14:29 +
+++ app/components/NowPlayingSidebar.qml 2016-08-15 16:33:06 +
@@ -34,6 +34,7 @@
thisHeader {
leadingActionBar {
actions: [] // hide tab bar
+objectName: "sideLeadingActionBar"
}
z: 100 // put on top of content
}
@@ -61,6 +62,7 @@
id: pageHeader
leadingActionBar {
actions: nowPlayingSidebar.head.backAction
+objectName: "sideLeadingActionBar"
}
flickable: queue
trailingActionBar {
=== modified file 'app/music-app.qml'
--- app/music-app.qml 2016-08-03 21:15:31 +
+++ app/music-app.qml 2016-08-15 16:33:06 +
@@ -640,6 +640,7 @@
property list tabActions: [
Action {
enabled: recentTabRepeater.count > 0
+objectName: "recentTabAction"
text: enabled ? recentTabRepeater.itemAt(0).title : ""
visible: enabled
@@ -650,22 +651,27 @@
}
},
Action {
+objectName: "artistsTabAction"
text: artistsTab.title
onTriggered: tabs.selectedTabIndex = artistsTab.index
},
Action {
+objectName: "albumsTabAction"
text: albumsTab.title
onTriggered: tabs.selectedTabIndex = albumsTab.index
},
Action {
+objectName: "genresTabAction"
text: genresTab.title
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1613328-autopilot-tests into lp:music-app
Review: Needs Information Still need to do a full run of this, as I need to move my music and rescan mediascanner2, will try this later :-) -- https://code.launchpad.net/~ahayzen/music-app/fix-1613328-autopilot-tests/+merge/302955 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
