[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
The proposal to merge lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve
+1 from me, but do change the logger.warn to something else before top
approving.
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-06 20:12:16 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-04 21:48+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#:
/home/letozaf/autopilot-tests/build-test-toc-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:38
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#:
/home/letozaf/autopilot-tests/build-test-toc-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-06 20:12:16 +
@@ -22,6 +22,12 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+// this property will have to be removed when bug #1341671 will be fixed.
+property string testProperty: for page name issue
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
title: i18n.tr(Contents)
@@ -57,6 +63,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +71,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +81,7 @@
:
Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +100,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +112,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold :
Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06
+
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-06 20:12:16
+
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,10 +59,20 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
+@autopilot_logging.log_action(logger.info)
def go_to_page_from_dialog(self, page_no):
Go to page from get_PfdViewGotoDialog
textfield = self.wait_select_single(
@@ -70,6 +81,12 @@
go_button = self.wait_select_single(Button, objectName=GOButton)
self.pointing_device.click_object(go_button)
+@autopilot_logging.log_action(logger.info)
+def click_go_to_page_button(self):
+Click the go_to_page header button.
+header = self.get_header()
+
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:146 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/216/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2730 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2730/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/113 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/119 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/216/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Fixed the part of the while loop. -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:145 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/215/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2716 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2716/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/112 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/118 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/215/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Needs Fixing
A few more comments :-)
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-06 19:01:20 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-04 21:48+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#:
/home/letozaf/autopilot-tests/build-test-toc-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:38
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#:
/home/letozaf/autopilot-tests/build-test-toc-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-06 19:01:20 +
@@ -22,6 +22,12 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+// this property will have to be removed when bug #1341671 will be fixed.
+property string testProperty: for page name issue
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
title: i18n.tr(Contents)
@@ -57,6 +63,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +71,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +81,7 @@
:
Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +100,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +112,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold :
Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06
+
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-06 19:01:20
+
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,10 +59,20 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
+@autopilot_logging.log_action(logger.info)
def go_to_page_from_dialog(self, page_no):
Go to page from get_PfdViewGotoDialog
textfield = self.wait_select_single(
@@ -70,6 +81,12 @@
go_button = self.wait_select_single(Button, objectName=GOButton)
self.pointing_device.click_object(go_button)
+@autopilot_logging.log_action(logger.info)
+def click_go_to_page_button(self):
+Click the go_to_page header button.
+header = self.get_header()
+header.click_action_button('gotopage')
+
class
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Forgot to ask: should I wait for balloons' review, before top-approve it? -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
I am not sure if Nicholas has to approve it too, maybe just ask him :), I usually always ask him to reiview,but maybe it is not necessary. -- Carla Sella email: carla.se...@gmail.com http://about.me/carla.sella On Tue, May 5, 2015 at 3:02 PM, Stefano Verzegnassi stefano92@gmail.com wrote: Forgot to ask: should I wait for balloons' review, before top-approve it? -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 You are the owner of lp:~carla-sella/ubuntu-docviewer-app/test-toc. https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:143 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/213/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2713 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2713/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/110 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/116 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/213/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:143 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/213/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2713 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2713/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/110 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/116 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/213/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Thanks Stefano. Your fixes worked so your knowledge of Autopilot is good :-). -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Carla Sella has proposed merging lp:~carla-sella/ubuntu-docviewer-app/test-toc
into lp:ubuntu-docviewer-app.
Commit message:
First test for testing Docviewer app TOC.
Requested reviews:
Nicholas Skaggs (nskaggs)
Stefano Verzegnassi (verzegnassi-stefano)
Related bugs:
Bug #1418652 in Ubuntu Document Viewer App: Autopilot Testcase Needed: Test
PDF table of contents
https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1418652
For more details, see:
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
First test for testing Docviewer app TOC.
--
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-02 09:36:53 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-01 16:54+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#: /home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#: /home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:31
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:37
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#: /home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#: /home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-02 09:36:53 +
@@ -22,6 +22,11 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+property string testProperty: for page name issue
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF document.
title: i18n.tr(Contents)
@@ -57,6 +62,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +70,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +80,7 @@
: Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +99,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +111,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold : Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06 +
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-02 09:36:53 +
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,6 +59,15 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
@@ -82,7 +92,34 @@
self.main_view = self.get_root_instance().select_single(MainView)
-class PdfView(Page):
+class PageWithBottomEdge(MainView):
+
+An emulator class that makes it easy to
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:140 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/210/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2694 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2694/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/107 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/113 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/210/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
\o/ passed :). -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:141 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/211/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2695 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2695/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/108 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/114 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/211/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Needs Fixing
Hi Carla,
thanks for the MP!
There is an issue that makes tests fail on my PC.
I've added two in-line comment (at lines 56 and 168).
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-02 10:27:39 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-01 16:54+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#:
/home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:31
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:37
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#:
/home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-02 10:27:39 +
@@ -22,6 +22,11 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+property string testProperty: for page name issue
I tried to grep -r 'testProperty' . in the whole project, and I didn't found
any usage of this property.
Is it still used?
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
title: i18n.tr(Contents)
@@ -57,6 +62,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +70,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +80,7 @@
:
Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +99,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +111,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold :
Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06
+
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-02 10:27:39
+
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,10 +59,20 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
+@autopilot_logging.log_action(logger.info)
def go_to_page_from_dialog(self, page_no):
Go to page from get_PfdViewGotoDialog
textfield = self.wait_select_single(
@@ -70,6 +81,12 @@
go_button = self.wait_select_single(Button, objectName=GOButton)
self.pointing_device.click_object(go_button)
+@autopilot_logging.log_action(logger.info)
+def
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Hi Stefano,
I left replies to your comments.
I will find a fix for your problem and let you know so you can test it.
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-02 10:27:39 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-01 16:54+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#:
/home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:31
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:37
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#:
/home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-02 10:27:39 +
@@ -22,6 +22,11 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+property string testProperty: for page name issue
I just added this property for this test. Without it the pdfContents page is
seen as Page11 in Autopilot3 vis this is a know issue:
https://bugs.launchpad.net/autopilot-qt/+bug/1341671, nik90 has found this
workaround, so I applied it.
When the bug gets fixed we can remove it.
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
title: i18n.tr(Contents)
@@ -57,6 +62,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +70,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +80,7 @@
:
Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +99,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +111,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold :
Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06
+
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-02 10:27:39
+
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,10 +59,20 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
+@autopilot_logging.log_action(logger.info)
def go_to_page_from_dialog(self, page_no):
Go to page from get_PfdViewGotoDialog
textfield = self.wait_select_single(
@@ -70,6 +81,12 @@
go_button = self.wait_select_single(Button, objectName=GOButton)
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
By the way, Stefano, can you send me the error output you get on your computer
as this does not occur on my Desktop. The strange thing for me is that
self.bottomEdgePageLoaded.wait_for(True) (line 112 of __init__.py) should
work but looks like it's not for you.
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-02 10:27:39 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-01 16:54+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#:
/home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:31
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:37
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#:
/home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-02 10:27:39 +
@@ -22,6 +22,11 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+property string testProperty: for page name issue
I left a comment in PdfContentsPage.qml so we will remember to remove the
property when the bug is fixed
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
title: i18n.tr(Contents)
@@ -57,6 +62,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +70,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +80,7 @@
:
Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +99,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +111,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold :
Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06
+
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-02 10:27:39
+
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,10 +59,20 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
+@autopilot_logging.log_action(logger.info)
def go_to_page_from_dialog(self, page_no):
Go to page from get_PfdViewGotoDialog
textfield = self.wait_select_single(
@@ -70,6 +81,12 @@
go_button = self.wait_select_single(Button, objectName=GOButton)
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Another thing, you are using autopilot3 run -vv test-name to launch the tests, right? -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:142 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/212/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2700 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2700/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/109 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/115 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/212/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Carla Sella has proposed merging lp:~carla-sella/ubuntu-docviewer-app/test-toc
into lp:ubuntu-docviewer-app.
Commit message:
First test for testing Docviewer app TOC.
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Related bugs:
Bug #1418652 in Ubuntu Document Viewer App: Autopilot Testcase Needed: Test
PDF table of contents
https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1418652
For more details, see:
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
First test for testing Docviewer app TOC.
--
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-01 21:01:09 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-01 16:54+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#: /home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#: /home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:31
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:37
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#: /home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#: /home/letozaf/autopilot-tests/build-ubuntu-docviewer-app-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-01 21:01:09 +
@@ -22,6 +22,11 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+property string testProperty: for page name issue
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF document.
title: i18n.tr(Contents)
@@ -57,6 +62,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +70,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +80,7 @@
: Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +99,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +111,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold : Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06 +
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-01 21:01:09 +
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,6 +59,15 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
@@ -82,7 +92,34 @@
self.main_view = self.get_root_instance().select_single(MainView)
-class PdfView(Page):
+class PageWithBottomEdge(MainView):
+
+An emulator class that makes it easy to interact with the bottom edge
+
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Still have to fix scrolling. -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
The proposal to merge lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
