Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Review: Approve continuous-integration -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
The proposal to merge lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 -- Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
The proposal to merge lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 -- Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Review: Approve It seems this never actually landed in trunk! Whoops, let's get this top approved and landed! -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Review: Needs Information Looks good so far! However for weather [0] we decided to use the markdown format, so that would mean renaming the files and updating some of the links to be in the format [Title](URL). I believe that we should be consistent over the coreapps, what do you guys think? 0 - https://code.launchpad.net/~emailgirishrawat/ubuntu-weather-app/markdown-readmes -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
I have added them as markdowns. Check it now. -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Oh you could add yourself to the debian/changelog if you wanted :-) Just run $ dch -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Here is the final edit. -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Review: Approve Awesome, thanks for those extra changes :-) I'll let Joey do the final top approval. -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
The proposal to merge lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app has been updated. Commit Message changed to: Add readme's for Google Code In task. For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 -- Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Review: Approve I'm OK with this MR -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app
Aditya has proposed merging lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app. Requested reviews: Nicholas Skaggs (nskaggs): google code in For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Add readme's for Google Code In task. -- Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. === added file 'README' --- README 1970-01-01 00:00:00 + +++ README 2015-12-22 10:10:10 + @@ -0,0 +1,17 @@ +ReadMe - Ubuntu Shorts App += + +Ubuntu Shorts App is the official rss reader app for Ubuntu Touch. We follow an open +source model where the code is available to anyone to branch and hack on. The +ubuntu shorts app follows a test driven development (TDD) where tests are +written in parallel to feature implementation to help spot regressions easier. + +Useful Links + + +Here are some useful links with regards to the Clock App development. + +* Home Page - https://developer.ubuntu.com/en/community/core-apps/shorts/ +* Project page - https://launchpad.net/ubuntu-rssreader-app + + === added file 'README.autopilot' --- README.autopilot 1970-01-01 00:00:00 + +++ README.autopilot 2015-12-22 10:10:10 + @@ -0,0 +1,52 @@ +Running Autopilot tests +=== + +Ubuntu Shorts App follows a test driven development where autopilot tests are +run before every merge into trunk. If you are submitting your bugfix/patch to +the shorts app, please follow the following steps below to ensure that all tests +pass before proposing a merge request. + +If you are looking for more info about Autopilot or writing AP tests for the +shorts app, here are some useful links to help you: + +* http://developer.ubuntu.com/start/quality +* https://developer.ubuntu.com/api/autopilot/python/1.5.0/ + +For help and options on running tests, see: + +* https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/ + +Prerequisites += + +Install the following autopilot packages required to run the tests, +$ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis + +Running tests on the desktop + + +Using terminal: + +* Branch the shorts app code, +$ bzr branch lp:ubuntu-rssreader-app + +* Build the shorts app, +$ mkdir builddir && cd builddir +$ cmake .. && cmake --build . -- -j 3 +$ cd .. + +* Navigate to the tests/autopilot directory. +$ cd shorts/tests/autopilot + +* run all tests. +$ autopilot3 run -vv shorts_app + +to list all tests: +$ autopilot3 list shorts_app + +To run only one test (for instance: test_add_single_type_alarm_must_add_to_alarm_list in TestAlarm.py): +$ autopilot3 run -vv ubuntu_shorts_app.tests.test_alarm.TestMainWindow.test_add_feed_to_new_topic + +Debugging tests using autopilot vis +$ autopilot3 launch -i Qt qmlscene shorts/qml/shorts-app.qml -I shorts +$ autopilot3 vis === added file 'README.developers' --- README.developers 1970-01-01 00:00:00 + +++ README.developers 2015-12-22 10:10:10 + @@ -0,0 +1,78 @@ +Building and running on Vivid Desktop (15.04) += + +Building and running the Ubuntu Shorts App is quite simple. You will require +Ubuntu 15.04 and higher to run on the desktop. + + $ bzr branch lp:ubuntu-rssreader-app branch-name + $ cd branch-name + $ mkdir builddir && cd builddir + $ cmake .. && cmake --build . -- -j 3 + $ qmlscene ../shorts/qml/shorts-app.qml -I ../shorts/ + +Submitting a patch upstream +=== + +If you want to submit a bug fix you can do so by branching the code as shown +above, implementing the fixes and running to see if it fixed the issue. We also +request that you run the Autopilot and Unit tests to check if anything +regressed due to the bug fix. + +If the tests fail, you will have to fix them before your bug fix can be +approved and merged into trunk. If the tests pass then commit and push your +code by, + + $ bzr commit -m "Implemented bug fix" --fixes lp:bug-number + $ bzr push lp:~launchpadid/ubuntu-rssreader-app/branch-name + +Running Tests += + +Please check README.autopilot and README.unittest on how to run the tests. +They are quite explanatory and will help you get started. + +Code Style +== + +We are trying to use a common code style throughout the code base to maintain +uniformity and improve code clarity. Listed below are the code styles guides +that will be followed based on the language used. + +* QML- http://qt-project.org/doc/qt-5/qml-codingconventions.html +* JS, C++- https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml +* Python - Code should follow PEP8 and Flake regulations + +Note: In the QML code convention, ignore the Javascript code section guidelines. +So the sections that should be taken into
