Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

[Mihir Soni]

Hi Gray, 

I understood that , I introduce that to just make code clean and more 
understandable.
-- 
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

[Gary.Wang]

Review: Needs Fixing

Personally,I don't think there is a need to introduce new 
property(eventDuration) in this case,since we have properties startdate and 
enddate now.

Pls take a look at this patch:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_147
-- 
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

[Mihir Soni]

Mihir Soni has proposed merging lp:~mihirsoni/ubuntu-calendar-app/147 into 
lp:ubuntu-calendar-app.

Commit message:
Fixed bug #147

Requested reviews:
  Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
  Bug #147 in Ubuntu Calendar App: Changing start date and time resets end 
date and time
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/147

For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763

Fixed bug #147
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge 
of lp:~mihirsoni/ubuntu-calendar-app/147 into lp:ubuntu-calendar-app.
=== modified file 'NewEvent.qml'
--- NewEvent.qml	2015-06-19 13:05:13 +
+++ NewEvent.qml	2015-06-23 17:04:44 +
@@ -38,6 +38,7 @@
 
 property var startDate;
 property var endDate;
+property var eventDuration;
 
 property alias scrollY: flickable.contentY
 property bool isEdit: false
@@ -127,6 +128,7 @@
 }
 startDate =new Date(e.startDateTime);
 endDate = new Date(e.endDateTime);
+eventDuration = endDate - startDate;
 
 if(e.displayLabel) {
 titleEdit.text = e.displayLabel;
@@ -273,8 +275,8 @@
 }
 
 function adjustEndDateToStartDate() {
-// set time forward to one hour
-var time_forward = 360;
+// set time forward to the event duration , if event is new then forward it to one hour
+var time_forward = eventDuration ? eventDuration : 360;
 endDate = new Date( startDate.getTime() + time_forward );
 }
 
@@ -369,6 +371,7 @@
 }
 onDateTimeChanged: {
 startDate = dateTime;
+eventDuration =  endDate - startDate;
 }
 }
 
@@ -382,6 +385,7 @@
 }
 onDateTimeChanged: {
 endDate = dateTime;
+eventDuration = endDate-startDate
 }
 }
 

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

[Mihir Soni]

The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/147 into 
lp:ubuntu-calendar-app has been updated.

Commit Message changed to:

Fixed bug #147

For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge 
of lp:~mihirsoni/ubuntu-calendar-app/147 into lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:678
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1202/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2993
deb: 
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2993/artifact/work/output/*zip*/output.zip
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/673
SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/199

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1202/rebuild

-- 
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763
Your team Ubuntu Calendar Developers is requested to review the proposed merge 
of lp:~mihirsoni/ubuntu-calendar-app/147 into lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp