[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-06 Thread Carlos Jose Mazieri 
The proposal to merge lp:~mterry/ubuntu-filemanager-app/ok into 
lp:ubuntu-filemanager-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-06 Thread noreply 
The proposal to merge lp:~mterry/ubuntu-filemanager-app/ok into 
lp:ubuntu-filemanager-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-03 Thread Carlos Jose Mazieri 
Review: Needs Information

Have you looked at the entire repository code?   

It may have any .cpp or .h code using the same, some messages come from c++ 
code.
-- 
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-03 Thread Michael Terry 
Yup, the rest of the code looks fine.
-- 
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-08-30 Thread Michael Terry 
Michael Terry has proposed merging lp:~mterry/ubuntu-filemanager-app/ok into 
lp:ubuntu-filemanager-app.

Commit message:
Update spelling of Ok to OK.

Ok isn't really a word.  It's either OK or Okay.  Ok looks like it should be 
pronounced ock.

http://www.merriam-webster.com/dictionary/ok

Requested reviews:
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)

For more details, see:
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578

Update spelling of Ok to OK.

Ok isn't really a word.  It's either OK or Okay.  Ok looks like it should be 
pronounced ock.

http://www.merriam-webster.com/dictionary/ok
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app.
=== modified file 'src/app/qml/ui/AuthenticationDialog.qml'
--- src/app/qml/ui/AuthenticationDialog.qml	2014-10-28 22:21:55 +
+++ src/app/qml/ui/AuthenticationDialog.qml	2015-08-30 14:17:55 +
@@ -46,7 +46,7 @@
 id: okButton
 objectName: okButton
 
-text: i18n.tr(Ok)
+text: i18n.tr(OK)
 
 onClicked: {
 passwordEntered(passwordField.text)

=== modified file 'src/app/qml/ui/ConfirmDialog.qml'
--- src/app/qml/ui/ConfirmDialog.qml	2014-09-20 10:49:51 +
+++ src/app/qml/ui/ConfirmDialog.qml	2015-08-30 14:17:55 +
@@ -28,7 +28,7 @@
 Button {
 id: okButton
 objectName: okButton
-text: i18n.tr(Ok)
+text: i18n.tr(OK)
 onClicked: {
 accepted()
 PopupUtils.close(root)

=== modified file 'src/app/qml/ui/ConfirmDialogWithInput.qml'
--- src/app/qml/ui/ConfirmDialogWithInput.qml	2014-09-20 10:49:51 +
+++ src/app/qml/ui/ConfirmDialogWithInput.qml	2015-08-30 14:17:55 +
@@ -44,7 +44,7 @@
 
 Button {
 objectName: okButton
-text: i18n.tr(Ok)
+text: i18n.tr(OK)
 enabled: input.acceptableInput
 onClicked: {
 accepted()

=== modified file 'src/app/qml/ui/NotifyDialog.qml'
--- src/app/qml/ui/NotifyDialog.qml	2014-09-20 10:49:51 +
+++ src/app/qml/ui/NotifyDialog.qml	2015-08-30 14:17:55 +
@@ -22,7 +22,7 @@
 Dialog {
 id: root
 Button {
-text: i18n.tr(Ok)
+text: i18n.tr(OK)
 onClicked: {
 PopupUtils.close(root)
 }

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp