[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app

2016-03-07 Thread noreply
The proposal to merge lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into 
lp:ubuntu-calendar-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
-- 
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp


Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app

2016-03-07 Thread Nekhelesh Ramananthan
Review: Approve

Not too happy with removing existing tests, but I suppose if we can get QML 
tests up and running then its a good thing.
-- 
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp


[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app

2016-03-07 Thread Nekhelesh Ramananthan
The proposal to merge lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into 
lp:ubuntu-calendar-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
-- 
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp


[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app

2016-03-03 Thread Nicholas Skaggs
Nicholas Skaggs has proposed merging 
lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app.

Commit message:
Remove all the AP tests that involve views, these can be test using qml tests.
Reduce unneeded helpers
Workaround toolkit AP helper bug

Requested reviews:
  Ubuntu Calendar Developers (ubuntu-calendar-dev)

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972

Remove all the AP tests that involve views, these can be test using qml tests.
Reduce unneeded helpers
Workaround toolkit AP helper bug
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge 
of lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app.
=== modified file 'tests/autopilot/calendar_app/__init__.py'
--- tests/autopilot/calendar_app/__init__.py	2016-02-01 19:48:19 +
+++ tests/autopilot/calendar_app/__init__.py	2016-03-03 17:10:48 +
@@ -70,55 +70,13 @@
 
 # click on tab action
 tab_button = self.wait_select_single(objectName='tab_%s_button'%tabName)
-self.pointing_device.click_object(tab_button)   
+self.pointing_device.click_object(tab_button)
 
 @autopilot.logging.log_action(logger.info)
 def click_action_button(self, action):
 current_tab = self.select_single('Tab', visible=True)
 button = current_tab.wait_select_single(objectName='%s_button'%action)
-self.pointing_device.click_object(button)   
-
-@autopilot.logging.log_action(logger.info)
-def go_to_month_view(self):
-"""Open the month view.
-
-:return: The Month View page.
-
-"""
-month_tab = self.select_single('Tab', objectName='monthTab')
-if not month_tab.visible:
-self.switch_to_tab('monthTab')
-else:
-logger.debug('The month View page is already opened.')
-return self.get_month_view(month_tab)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_week_view(self):
-"""Open the week view.
-
-:return: The Week View page.
-
-"""
-week_tab = self.select_single('Tab', objectName='weekTab')
-if not week_tab.visible:
-self.switch_to_tab('weekTab')
-else:
-logger.debug('The week View page is already opened.')
-return self.get_week_view(week_tab)
-
-@autopilot.logging.log_action(logger.info)
-def go_to_year_view(self):
-"""Open the year view.
-
-:return: The Year View page.
-
-"""
-year_tab = self.select_single('Tab', objectName='yearTab')
-if not year_tab.visible:
-self.switch_to_tab('yearTab')
-else:
-logger.debug('The Year View page is already opened.')
-return self.get_year_view(year_tab)
+self.pointing_device.click_object(button)
 
 @autopilot.logging.log_action(logger.info)
 def go_to_day_view(self):
@@ -169,121 +127,26 @@
 return self.wait_select_single(
 CalendarChoicePopup, objectName="calendarchoicepopup")
 
-def set_picker(self, field, mode, value):
-# open picker
-self.pointing_device.click_object(field)
-# valid options are date or time; assume date if invalid/no option
-if mode == 'time':
-mode_value = 'Hours|Minutes'
-else:
-mode_value = 'Years|Months|Days'
-picker = self.wait_select_single(
-ubuntuuitoolkit.pickers.DatePicker, mode=mode_value, visible=True)
-if mode_value == 'Hours|Minutes':
-picker.pick_time(value)
-else:
-picker.pick_date(value)
-# close picker
-self.pointing_device.click_object(field)
-
-def get_event_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single("EventView")
-
 def get_event_details(self, parent_object=None):
 if parent_object is None:
 parent_object = self
 return parent_object.wait_select_single(EventDetails,
 objectName='eventDetails')
-
-def get_month_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single(MonthView,
-objectName='monthViewPage')
-
-def get_year_view(self, parent_object=None):
-if parent_object is None:
-parent_object = self
-return parent_object.wait_select_single(YearView,
-objectName='yearViewPage')
-
 def get_day_view(self, parent_object=None):
 if parent_object is None:
 parent_object = self
 return parent_object.wait_select_single(DayView,
 objectName='dayViewPage')
 
-def get_week_view(self, paren

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app

2016-03-03 Thread Jenkins Bot
Review: Approve continuous-integration

PASSED: Continuous integration, rev:767
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/770/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/680/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/770/rebuild

-- 
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
Your team Ubuntu Calendar Developers is requested to review the proposed merge 
of lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp