[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve Passes tests, approved -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/78/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/787/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/78/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/73/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/782/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/73/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/72/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/781/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/72/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/71/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/776/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/71/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/70/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/774/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/70/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/69/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/773/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/69/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/68/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/772/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/68/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/67/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/771/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/67/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/66/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/770/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/66/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/65/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/768/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/65/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/60/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/760/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/60/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/64/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/767/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/64/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/63/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/765/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/63/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/62/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/763/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/62/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/61/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/762/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/61/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:534 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/59/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/759/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/59/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:533 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/58/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/756/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/58/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:533 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/57/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/754/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/57/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:532 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/56/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/753/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/56/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:532 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/55/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/752/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/55/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Description changed to: Add dependency cache for click depends downloads For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app.
Commit message:
Add dependency cache for click depends downloads
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713
Add dependency cache for click depends downloads
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into
lp:ubuntu-filemanager-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-10-20 18:28:30 +
+++ CMakeLists.txt 2016-03-10 22:12:44 +
@@ -73,22 +73,40 @@
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json filemanager.apparmor ${CONTENT_HUB_EXPORTER} DESTINATION ${CMAKE_INSTALL_PREFIX})
- MESSAGE("Grabbing upstream libs to ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs")
-execute_process(
-COMMAND mkdir ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/get-click-deps -d ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json ${CLICK_ARCH} ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-)
- MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
- file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
- foreach(ITEM ${UPSTREAM_LIBS})
- IF( IS_DIRECTORY "${ITEM}" )
- LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
- ELSE()
- LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
- ENDIF()
- endforeach()
- MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
- INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
+set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
+
+#grab dependencies
+set(GET_CLICK_DEPS_TOOL ${CMAKE_SOURCE_DIR}/get-click-deps)
+set(DEPS_MANIFEST ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json)
+MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
+
+get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
+set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-filemanager/${BLD_CONFIGURATION_NAME})
+MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
+
+if(EXISTS "${UPSTREAM_CACHE}")
+ MESSAGE("Upstream libs cache exists.")
+ file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
+else()
+ MESSAGE("Cache miss, downloading from network.")
+ execute_process(
+COMMAND mkdir ${UPSTREAM_LIBS_DIR}
+COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
+ )
+ # Cache for next usage.
+ file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
+endif()
+MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
+file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
+foreach(ITEM ${UPSTREAM_LIBS})
+ IF( IS_DIRECTORY "${ITEM}" )
+ LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
+ ELSE()
+ LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
+ ENDIF()
+endforeach()
+MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
+INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
else(CLICK_MODE)
execute_process(
COMMAND qmake -query QT_INSTALL_QML
=== modified file 'README-Mergeproposal'
--- README-Mergeproposal 2015-12-19 07:34:45 +
+++ README-Mergeproposal 2016-03-10 22:12:44 +
@@ -26,3 +26,7 @@
The above checklist is more of a guideline to help file manager app trunk stay buildable,
stable and up to date.
+
+Jenkins
+===
+In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins)
=== modified file 'tests/autopilot/filemanager/__init__.py'
--- tests/autopilot/filemanager/__init__.py 2016-01-14 16:44:26 +
+++ tests/autopilot/filemanager/__init__.py 2016-03-10 22:12:44 +
@@ -606,7 +606,7 @@
"""FileDetailsPopover Autopilot emulator."""
def get_path(self):
-return self.select_single('Label', objectName='pathLabel').text
+return self.select_single('UCLabel', objectName='pathLabel').text
class PathBar(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
=== modified file 'tests/autopilot/filemanager/tests/__init__.py'
--- tests/autopilot/filemanager/tests/__init__.py 2015-03-12 20:58:23 +
+++ tests/autopilot/filemanager/tests/__init__.py 2016-03-10 22:12:44 +
@@ -32,6 +
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app has been updated. Commit Message changed to: Add dependency cache for click depends downloads For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:532 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/54/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/751/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/54/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288713 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into lp:ubuntu-filemanager-app
with lp:~nskaggs/ubuntu-filemanager-app/fix-ap-tests as a prerequisite.
Commit message:
Add dependency cache for click depends downloads
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/add-dep-cache/+merge/288714
Add dependency cache for click depends downloads
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~nskaggs/ubuntu-filemanager-app/add-dep-cache into
lp:ubuntu-filemanager-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-10-20 18:28:30 +
+++ CMakeLists.txt 2016-03-10 22:13:49 +
@@ -73,22 +73,40 @@
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json filemanager.apparmor ${CONTENT_HUB_EXPORTER} DESTINATION ${CMAKE_INSTALL_PREFIX})
- MESSAGE("Grabbing upstream libs to ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs")
-execute_process(
-COMMAND mkdir ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/get-click-deps -d ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json ${CLICK_ARCH} ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
-)
- MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
- file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
- foreach(ITEM ${UPSTREAM_LIBS})
- IF( IS_DIRECTORY "${ITEM}" )
- LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
- ELSE()
- LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
- ENDIF()
- endforeach()
- MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
- INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
+set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
+
+#grab dependencies
+set(GET_CLICK_DEPS_TOOL ${CMAKE_SOURCE_DIR}/get-click-deps)
+set(DEPS_MANIFEST ${CMAKE_CURRENT_SOURCE_DIR}/filemanager-libs.json)
+MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
+
+get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
+set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-filemanager/${BLD_CONFIGURATION_NAME})
+MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
+
+if(EXISTS "${UPSTREAM_CACHE}")
+ MESSAGE("Upstream libs cache exists.")
+ file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
+else()
+ MESSAGE("Cache miss, downloading from network.")
+ execute_process(
+COMMAND mkdir ${UPSTREAM_LIBS_DIR}
+COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
+ )
+ # Cache for next usage.
+ file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
+endif()
+MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
+file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
+foreach(ITEM ${UPSTREAM_LIBS})
+ IF( IS_DIRECTORY "${ITEM}" )
+ LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
+ ELSE()
+ LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
+ ENDIF()
+endforeach()
+MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
+INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
else(CLICK_MODE)
execute_process(
COMMAND qmake -query QT_INSTALL_QML
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
