[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-20 Thread noreply 
The proposal to merge lp:~popey/ubuntu-filemanager-app/set-bzr-revno into 
lp:ubuntu-filemanager-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri 
The proposal to merge lp:~popey/ubuntu-filemanager-app/set-bzr-revno into 
lp:ubuntu-filemanager-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri 
Review: Approve

Nice, Thanks.
-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-19 Thread Ubuntu Phone Apps Jenkins Bot 
Review: Approve continuous-integration

PASSED: Continuous integration, rev:481
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/561/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/183

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/561/rebuild

-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/set-bzr-revno into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-19 Thread Alan Pope  
The proposal to merge lp:~popey/ubuntu-filemanager-app/set-bzr-revno into 
lp:ubuntu-filemanager-app has been updated.

Commit Message changed to:

Correctly set the bzr revno during build. Otherwise in some circumstances it 
builds with "latest" in the filename, where we standardised on the bzr revision 
number in the filename. This fixes that.

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/set-bzr-revno into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-19 Thread Alan Pope  
Alan Pope  has proposed merging lp:~popey/ubuntu-filemanager-app/set-bzr-revno 
into lp:ubuntu-filemanager-app.

Requested reviews:
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/set-bzr-revno into 
lp:ubuntu-filemanager-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-10-13 16:49:05 +
+++ CMakeLists.txt	2015-10-19 22:15:50 +
@@ -25,6 +25,13 @@
 add_definitions(-D_LARGEFILE_SOURCE)
 add_definitions(-D_FILE_OFFSET_BITS=64)
 
+# Sets BZR_REVNO
+execute_process(
+COMMAND bzr revno ${CMAKE_SOURCE_DIR}
+OUTPUT_VARIABLE BZR_REVNO
+OUTPUT_STRIP_TRAILING_WHITESPACE
+)
+
 if(CLICK_MODE)
 if(NOT DEFINED BZR_SOURCE)
 set(BZR_SOURCE "lp:${LP_PROJECT}")

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp