[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

[Alan Pope ]

Alan Pope  has proposed merging 
lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into 
lp:ubuntu-filemanager-app.

Commit message:
Found a few more places in the UI where the OSK uses predictive text. Disabled 
these.

Requested reviews:
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into 
lp:ubuntu-filemanager-app.
=== modified file 'src/app/qml/ui/GoToDialog.qml'
--- src/app/qml/ui/GoToDialog.qml	2014-11-30 10:26:19 +
+++ src/app/qml/ui/GoToDialog.qml	2015-10-20 10:05:20 +
@@ -36,7 +36,7 @@
 id: locationField
 objectName: "inputField"
 
-inputMethodHints: Qt.ImhNoAutoUppercase
+inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
 
 property bool valid: pathExists(text)
 

=== modified file 'src/app/qml/ui/PlacesPage.qml'
--- src/app/qml/ui/PlacesPage.qml	2015-01-06 19:56:17 +
+++ src/app/qml/ui/PlacesPage.qml	2015-10-20 10:05:20 +
@@ -54,7 +54,7 @@
 margins: units.gu(1)
 }
 
-inputMethodHints: Qt.ImhNoAutoUppercase
+inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
 
 property bool valid: pathExists(text)
 

=== modified file 'src/app/qml/ui/ViewPopover.qml'
--- src/app/qml/ui/ViewPopover.qml	2014-09-20 10:49:51 +
+++ src/app/qml/ui/ViewPopover.qml	2015-10-20 10:05:20 +
@@ -140,7 +140,7 @@
 margins: units.gu(1)
 }
 
-inputMethodHints: Qt.ImhNoAutoUppercase
+inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
 
 text: pageModel.nameFilters
 

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:482
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/562/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/184

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/562/rebuild

-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

[Carlos Jose Mazieri]

Review: Approve

OK, Thanks.
-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

[Carlos Jose Mazieri]

The proposal to merge lp:~popey/ubuntu-filemanager-app/suppress-predictive-text 
into lp:ubuntu-filemanager-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

[noreply]

The proposal to merge lp:~popey/ubuntu-filemanager-app/suppress-predictive-text 
into lp:ubuntu-filemanager-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
-- 
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp