Re: [Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
On Thu, Feb 09, 2012 at 06:27:11PM -, Avi Greenbury wrote: > I still get this sort of behaviour - I was asked once for a password for > the video data and again for the data for my kernel. This is on 12.04 > when Compiz crashed. The way apport works, it can't hold onto the root password between function calls. This bug was "solved" by attaching all three gdm files in one function call. However, the display manager data and the kernel data require separate function calls, and since both require sudo to do so, you get prompted twice. Still an undesired behavior, but not this bug. -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in Ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apport/+bug/716595/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
I still get this sort of behaviour - I was asked once for a password for the video data and again for the data for my kernel. This is on 12.04 when Compiz crashed. -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in Ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apport/+bug/716595/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
This bug was fixed in the package xorg - 1:7.6~3ubuntu5 --- xorg (1:7.6~3ubuntu5) natty; urgency=low * apport/source_xorg.py: - Add 'locale' information (for keyboards) - Drop 'glxinfo' since it's been demoted to universe (LP: #714784) - Switch to new attach_root_command_outputs() call. Prevents prompting for password 3 times for 3 gdm files (thanks Pitti!) (LP: #716595) -- Bryce HarringtonThu, 17 Feb 2011 11:42:58 -0800 ** Changed in: xorg (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
** Changed in: xorg (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
This bug was fixed in the package apport - 1.18-0ubuntu1 --- apport (1.18-0ubuntu1) natty; urgency=low [ Martin Pitt ] * New upstream release: - Ensure that symptom scripts define a run() function, and don't show them if not. - Do not show symptom scripts which start with an underscore. These can be used for private libraries for the actual symptom scripts. - Update bash completion. Thanks Philip Muškovac. - etc/default/apport: Remove obsolete "maxsize" setting. (LP: #719564) - Remove explicit handling of KDE *.ui files in setup.py, as python-distutils-extra 2.24 fixes this. Bump version check. - hookutils.py: Add attach_root_command_outputs() to run several commands at once. This avoids asking for the password several times. (LP: #716595) * debian/apport.postinst: Add missing debhelper token. * debian/rules: Drop dump_acpi_tables.py chmod workaround, it's upstream now and has the proper permissions. * Add etc/apport/blacklist.d/apport and drop the creation of it in /debian/rules. This is easier to maintain and more obvious. Also move README.blacklist from python-apport to apport, it fits better there. * etc/apport/blacklist.d/apport: Add the binaries of nspluginwrapper, as we can't do anything about them anyway. (LP: #717468) [ Brian Murray ] * data/package-hooks/source_linux.py: Properly set regression-release tag if the reporter chooses "I do not know". -- Martin PittWed, 16 Feb 2011 14:29:36 +0100 ** Branch linked: lp:~ubuntu-core-dev/ubuntu/natty/apport/ubuntu ** Changed in: apport (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
** Changed in: xorg (Ubuntu) Assignee: Martin Pitt (pitti) => Bryce Harrington (bryce) -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
This patch against the current hook uses the new API. Bryce, as I can't commit to the xorg git, would you mind committing/uploading this yourself? Thanks! ** Patch added: "source_xorg.py patch" https://bugs.launchpad.net/ubuntu/+source/apport/+bug/716595/+attachment/1853762/+files/source_xorg.py.patch -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
Fixed upstream. I added a new method def attach_root_command_outputs(report, command_map): '''Execute multiple commands as root and put their outputs into report. command_map is a keyname -> 'shell command' dictionary with the commands to run. They are all run through /bin/sh, so you need to take care of shell escaping yourself. To include stderr output of a command, end it with "2>&1". Just like root_command_output() this will use gksu, kdesudo, or sudo for gaining root privileges, depending on the running desktop environment. This is preferrable to using root_command_output() multiple times, as that will ask for the password every time. ''' ** Changed in: apport (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
** Branch linked: lp:apport -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
Bryce Harrington [2011-02-15 20:16 -]: > What is your recommendation for how we can work around this in the hook? You need to cat all gdm log files at once, and then pick them apart yourself (or just store them in one key). I have to think about how to run multiple programs and store their individual outputs in one go. I have an idea, but it will take some more effort to implement. I hope I can get to that in the next week, though. -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
On Tue, Feb 15, 2011 at 04:15:18PM -, Martin Pitt wrote: > Restoring back to xorg (for updating the hook) and apport (for providing > better API). What is your recommendation for how we can work around this in the hook? (Or should I wait for the better API?) -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
So, we can't fix that in sudo or libgksu; with "forkpty" it's even worse, as a new TTY will be allocated every time. Restoring back to xorg (for updating the hook) and apport (for providing better API). ** Summary changed: - gksu ask for password each time with stdout redirection + Apport hook prompts 3 times for password ** Package changed: gksu (Ubuntu) => xorg (Ubuntu) ** Changed in: apport (Ubuntu) Importance: Undecided => Medium ** Changed in: apport (Ubuntu) Status: Invalid => Triaged ** Changed in: apport (Ubuntu) Assignee: (unassigned) => Martin Pitt (pitti) -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
@Martin, do you have a suggestion for how to better attach three files as separate apport items without incurring three password prompts? -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
Unfortunately, in looking into this it's not easy to fix, at least not in the apport hook itself. The code in question is: report['GdmLog'] = root_collect_file_contents('/var/log/gdm/:0.log') report['GdmLog1'] = root_collect_file_contents('/var/log/gdm/:0.log.1') report['GdmLog2'] = root_collect_file_contents('/var/log/gdm/:0.log.2') Each of the root_collect_file_contents() calls essentially calls and return root_command_output(['cat', path]). root_command_output() is one of the stock apport lib routines. So the question is, why isn't root_command_output() caching the sudo permission from one call to the next? ** Changed in: xorg (Ubuntu) Status: New => Triaged ** Changed in: xorg (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 716595] Re: Apport hook prompts 3 times for password
-- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg in ubuntu. https://bugs.launchpad.net/bugs/716595 Title: Apport hook prompts 3 times for password ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp