[PATCH] Drop GNU make 3.80 compatibility
The "$(and" operator requires GNU make 3.81. On 3.80 it is a no-op. Consequently, strange build problems (failure to compile madvise.c) pop up when using make 3.80. Since nobody else is reporting these types of problems, I'm going to guess that I am one of the last remaining holdouts still running 3.80. So we might as well officially require 3.81. Signed-off-by: Kevin Cernekee --- Rules.mak |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Rules.mak b/Rules.mak index 0aa6843..70fb851 100644 --- a/Rules.mak +++ b/Rules.mak @@ -17,8 +17,8 @@ # check for proper make version -ifneq ($(findstring x3.7,x$(MAKE_VERSION)),) -$(error Your make is too old $(MAKE_VERSION). Go get at least 3.80) +ifneq ($(filter 3.7% 3.80,$(MAKE_VERSION)),) +$(error Your make is too old $(MAKE_VERSION). Go get at least 3.81) endif #--- -- 1.7.4.2 ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
Re: [PATCH] Drop GNU make 3.80 compatibility
On Fri, Apr 1, 2011 at 11:23 AM, Kevin Cernekee wrote: > The "$(and" operator requires GNU make 3.81. On 3.80 it is a no-op. > Consequently, strange build problems (failure to compile madvise.c) pop > up when using make 3.80. > > Since nobody else is reporting these types of problems, I'm going to > guess that I am one of the last remaining holdouts still running 3.80. > So we might as well officially require 3.81. if that's the only reason, then let's drop the $(and) usage instead. -mike ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
Re: [PATCH] Drop GNU make 3.80 compatibility
On Fri, Apr 1, 2011 at 1:43 PM, Mike Frysinger wrote: > On Fri, Apr 1, 2011 at 11:23 AM, Kevin Cernekee wrote: >> The "$(and" operator requires GNU make 3.81. On 3.80 it is a no-op. >> Consequently, strange build problems (failure to compile madvise.c) pop >> up when using make 3.80. >> >> Since nobody else is reporting these types of problems, I'm going to >> guess that I am one of the last remaining holdouts still running 3.80. >> So we might as well officially require 3.81. > > if that's the only reason, then let's drop the $(and) usage instead. A month or two ago, "else ifeq" broke make 3.80. I suspect that everybody else is using 3.81/3.82 and so 3.80 is not getting any test coverage. This allows small incompatibilities to creep into the Makefiles. Personally, I'd rather not upgrade because I try to make my release buildable on any stock RHEL4/RHEL5 system. But I don't want to have to keep debugging things that only break because I'm using make 3.80. ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
Re: [PATCH] Drop GNU make 3.80 compatibility
On Fri, 2011-04-01 at 14:24 -0700, Kevin Cernekee wrote: > On Fri, Apr 1, 2011 at 1:43 PM, Mike Frysinger wrote: > > On Fri, Apr 1, 2011 at 11:23 AM, Kevin Cernekee wrote: > >> The "$(and" operator requires GNU make 3.81. On 3.80 it is a no-op. > >> Consequently, strange build problems (failure to compile madvise.c) pop > >> up when using make 3.80. > >> > >> Since nobody else is reporting these types of problems, I'm going to > >> guess that I am one of the last remaining holdouts still running 3.80. > >> So we might as well officially require 3.81. > > > > if that's the only reason, then let's drop the $(and) usage instead. > > A month or two ago, "else ifeq" broke make 3.80. > > I suspect that everybody else is using 3.81/3.82 and so 3.80 is not > getting any test coverage. This allows small incompatibilities to > creep into the Makefiles. > > Personally, I'd rather not upgrade because I try to make my release > buildable on any stock RHEL4/RHEL5 system. But I don't want to have > to keep debugging things that only break because I'm using make 3.80. I think it would be nice to keep it working with make 3.80 even though its 10 years old. Are these problems widespread ? if not then consider cooking up a patch :) -- -Khem ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
Re: [PATCH] Drop GNU make 3.80 compatibility
On Fri, Apr 8, 2011 at 5:34 PM, Khem Raj wrote: > I think it would be nice to keep it working with make 3.80 even though > its 10 years old. Are these problems widespread ? if not then consider > cooking up a patch :) Done. There is one more occurrence in the link.asneeded function (Rules.mak) which I was not sure what to do with. It was introduced over 2 years ago and I have not noticed any ill effects, but I guess it should probably be sorted out at some point since it will eventually bite somebody. ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
