RE: [PATCH] ldso: fix fdpic support broken from prelink patch
> -Original Message- > From: Henderson, Stuart [mailto:stuart.hender...@analog.com] > Sent: Tuesday, March 06, 2012 7:23 PM > To: Filippo ARCIDIACONO; uclibc@uclibc.org > Subject: RE: [PATCH] ldso: fix fdpic support broken from prelink patch > > >> In the meantime any comments are welcome. > > bfin fdpic build fails with error: > > In file included from ldso/ldso/ldso.c:1432: > ldso/ldso/dl-elf.c: In function '_dl_load_elf_shared_library': > ldso/ldso/dl-elf.c:757: error: request for member 'map' in something > not a structure or union > > e.g. > tpnt->ppnt = (ElfW(Phdr) *) DL_RELOC_ADDR(tpnt->mapaddr, epnt- > >e_phoff); > so > epnt->e_phoff is an Elf32_Off and DL_RELOC_ADDR on fdpic tries: > #define DL_RELOC_ADDR(LOADADDR, ADDR) ((ElfW(Addr))__reloc_pointer > ((void*)(ADDR), (LOADADDR).map)) Yes you are right, I missed this one, for these archs has to be use the tpnt->loadaddr. I'll post another version of the patch. > > Stu Thanks, Filippo. ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
RE: [PATCH] ldso: fix fdpic support broken from prelink patch
>> In the meantime any comments are welcome. bfin fdpic build fails with error: In file included from ldso/ldso/ldso.c:1432: ldso/ldso/dl-elf.c: In function '_dl_load_elf_shared_library': ldso/ldso/dl-elf.c:757: error: request for member 'map' in something not a structure or union e.g. tpnt->ppnt = (ElfW(Phdr) *) DL_RELOC_ADDR(tpnt->mapaddr, epnt->e_phoff); so epnt->e_phoff is an Elf32_Off and DL_RELOC_ADDR on fdpic tries: #define DL_RELOC_ADDR(LOADADDR, ADDR) ((ElfW(Addr))__reloc_pointer ((void*)(ADDR), (LOADADDR).map)) Stu ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
RE: [PATCH] ldso: fix fdpic support broken from prelink patch
> -Original Message- > From: Filippo ARCIDIACONO [mailto:filippo.arcidiac...@st.com] > Sent: Monday, March 05, 2012 7:17 PM > To: uclibc@uclibc.org > Cc: 'Filippo ARCIDIACONO' > Subject: RE: [PATCH] ldso: fix fdpic support broken from prelink patch > > > > > -Original Message- > > From: Filippo ARCIDIACONO [mailto:filippo.arcidiac...@st.com] > > Sent: Monday, March 05, 2012 7:12 PM > > To: uclibc@uclibc.org > > Cc: Filippo Arcidiacono > > Subject: [PATCH] ldso: fix fdpic support broken from prelink patch > > > > The fdpic support has been broken since the prelink support was > added, > > because it doesn't take into account DL_LOADADDR_TYPE could be a > > type different of ElfW(Addr). > > > > Signed-off-by: Filippo Arcidiacono > > --- > > ldso/include/dl-defs.h | 11 +++ > > ldso/ldso/c6x/dl-sysdep.h |9 + > > ldso/ldso/dl-elf.c | 22 ++ > > ldso/ldso/dl-startup.c |8 +++- > > ldso/ldso/fdpic/dl-sysdep.h | 10 ++ > > ldso/ldso/ldso.c| 17 +++-- > > 6 files changed, 58 insertions(+), 19 deletions(-) > > > > [SNIP] > > I'm testing this patch for sh archs. I'll let you know the results. I run both uClibc and prelink testsuite and no regression has been raised. > In the meantime any comments are welcome. > > Regards, > Filippo Arcidiacono ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
RE: [PATCH] ldso: fix fdpic support broken from prelink patch
> -Original Message- > From: Filippo ARCIDIACONO [mailto:filippo.arcidiac...@st.com] > Sent: Monday, March 05, 2012 7:12 PM > To: uclibc@uclibc.org > Cc: Filippo Arcidiacono > Subject: [PATCH] ldso: fix fdpic support broken from prelink patch > > The fdpic support has been broken since the prelink support was added, > because it doesn't take into account DL_LOADADDR_TYPE could be a > type different of ElfW(Addr). > > Signed-off-by: Filippo Arcidiacono > --- > ldso/include/dl-defs.h | 11 +++ > ldso/ldso/c6x/dl-sysdep.h |9 + > ldso/ldso/dl-elf.c | 22 ++ > ldso/ldso/dl-startup.c |8 +++- > ldso/ldso/fdpic/dl-sysdep.h | 10 ++ > ldso/ldso/ldso.c| 17 +++-- > 6 files changed, 58 insertions(+), 19 deletions(-) > [SNIP] I'm testing this patch for sh archs. I'll let you know the results. In the meantime any comments are welcome. Regards, Filippo Arcidiacono ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
