Re: [PATCH] mmap()->sys_mmap2: do unsigned shift of offset
On Thursday 17 May 2012 07:47:11 James Hogan wrote: > Is it always correct to cast __off_t to __u_long? I'm a bit unclear > whether it's still correct on 64bit architectures or with long file > support. this isn't mmap64 (which uses __off64_t), so it's fine. you can see that everyone defines __off_t to __SLONGWORD_TYPE regardless of bitsize. if no one else has feedback, i'll merge this in a bit -mike signature.asc Description: This is a digitally signed message part. ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
Re: [PATCH] mmap()->sys_mmap2: do unsigned shift of offset
On Friday 18 May 2012 22:09:46 Mike Frysinger wrote: > On Thursday 17 May 2012 07:47:11 James Hogan wrote: > > Is it always correct to cast __off_t to __u_long? I'm a bit unclear > > whether it's still correct on 64bit architectures or with long file > > support. > > this isn't mmap64 (which uses __off64_t), so it's fine. you can see that > everyone defines __off_t to __SLONGWORD_TYPE regardless of bitsize. > > if no one else has feedback, i'll merge this in a bit i ended up applying the other one you sent since this resend is slightly corrupted thanks! -mike signature.asc Description: This is a digitally signed message part. ___ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
