Re: [uClinux-dev] qemu/m68k
Hi Geert, On 22/08/14 17:12, Geert Uytterhoeven wrote: Hi Greg, On Fri, Aug 22, 2014 at 2:40 AM, Greg Ungerer wrote: qemu: hardware error: mcf_fec_read: Bad address 0x1c4 Hmmm, yeah, it does stop there. Not sure why. I will need to look more closely at that. Did you found anything? Yep. The problem is that the FEC driver is writing to registers that don't exist in the FEC hardware module on the ColdFire family. Support for some of the extended registers used on the FEC are used on ARM implementations, and they had added support for those in more recent years. I never picked those up on real hardware. Accesses to those on addresses cause no (visible) problems. Anyway, attached is a patch I propose to fix it. I will be sending this to the linux net-dev list soon. Instead of sprinkling the driver with (more) #ifdefs, wouldn't it be better to use FEC_QUIRK_* flags in fec_devtype / platform data? This patch only added one more #ifdef... But your right, it would be nice to have a lot less. I'll take another look at this. Thanks Greg ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] qemu/m68k
Hi Greg,
On Fri, Aug 22, 2014 at 2:40 AM, Greg Ungerer wrote:
qemu: hardware error: mcf_fec_read: Bad address 0x1c4
>>>
>>>
>>> Hmmm, yeah, it does stop there. Not sure why. I will need to look
>>> more closely at that.
>>
>>
>> Did you found anything?
>
> Yep. The problem is that the FEC driver is writing to registers
> that don't exist in the FEC hardware module on the ColdFire
> family. Support for some of the extended registers used on
> the FEC are used on ARM implementations, and they had added
> support for those in more recent years.
>
> I never picked those up on real hardware. Accesses to those
> on addresses cause no (visible) problems.
>
> Anyway, attached is a patch I propose to fix it. I will be
> sending this to the linux net-dev list soon.
Instead of sprinkling the driver with (more) #ifdefs, wouldn't it be
better to use FEC_QUIRK_* flags in fec_devtype / platform data?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
