Re: [uClinux-dev] [PATCH] BSP for Savant CPU card
Hi Wilson, Wilson Callan wrote: Thank you for applying the BSP patch, and the Encode Chip Select QSPI patch. Sorry about the bad m523xsim.h patch. I've attached a patch just for this, but actually you dont need it because you've applied the qspiCS.patch which contained this file. Yeah, I noticed that after I applied the first patch, but before I had hit the others :-) In fact, this patch will probably now fail against the latest because they differ. I changed it because there was a bad, but harmless, merge in my m5235xsim.h before which i recently fixed. A patch of the fix would look like this below, which may be what you want to run. UART0, PIT1 and QSPI were repeated again below, out of order, with the same numbers. sorry for the confusion. No problem. Patch below applied too. Regards Greg --- uClinux-dist-bsp/linux-2.6.x/include/asm-m68knommu/m523xsim.h 2007-07-16 16:44:53.0 -0400 +++ uClinux-dist-patch-bsp/linux-2.6.x/include/asm-m68knommu/m523xsim.h 2007-07-25 14:18:12.0 -0400 @@ -30,9 +30,6 @@ /* INTC0 */ #defineMCFINT_VECBASE64/* Vector base number */ -#defineMCFINT_UART013/* Interrupt number for UART0 */ -#defineMCFINT_PIT136/* Interrupt number for PIT1 */ -#defineMCFINT_QSPI18/* Interrupt number for QSPI */ #defineMCFINT_EPF22/* Interrupt number for EPORT2 */ #defineMCFINT_EPF33/* Interrupt number for EPORT3 */ #defineMCFINT_EPF44/* Interrupt number for EPORT4 */ Wilson On Jul 25, 2007, at 12:00 PM, [EMAIL PROTECTED] wrote: -- Message: 3 Date: Wed, 25 Jul 2007 14:19:36 +1000 From: Greg Ungerer [EMAIL PROTECTED] Subject: Re: [uClinux-dev] [PATCH] BSP for Savant CPU card To: uClinux development list uclinux-dev@uclinux.org Message-ID: [EMAIL PROTECTED] Content-Type: text/plain; charset=ISO-8859-1; format=flowed Hi Wilson, Wilson Callan wrote: Hi, attached is a patch file to support our CPU card on patch 20070718. Changes from my previous submit: 1) removed change in setup.c 2) made a separate function for changes needed in config_BSP() I suspect the bootparm code will not be acceptable to mainline. But I committed it to the uClinux sources. Except m523xsim.h, which didn't patch cleanly: goober patch -p1 /home/gerg/tmp/patches/savantBSP20070718-2.patch patching file linux-2.6.x/arch/m68knommu/defconfig patching file linux-2.6.x/arch/m68knommu/Kconfig patching file linux-2.6.x/arch/m68knommu/Makefile patching file linux-2.6.x/drivers/serial/mcfserial.c patching file linux-2.6.x/include/asm-m68knommu/m523xsim.h patch: malformed patch at line 110: @@ -42,4 +73,122 @@ Can you generate a patch just for this and send please? Regards Greg Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED] Secure Computing CorporationPHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com -- ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev -- Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED] Secure Computing CorporationPHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
[uClinux-dev] [PATCH] BSP for Savant CPU card
Hi Greg, Thank you for applying the BSP patch, and the Encode Chip Select QSPI patch. Sorry about the bad m523xsim.h patch. I've attached a patch just for this, but actually you dont need it because you've applied the qspiCS.patch which contained this file. In fact, this patch will probably now fail against the latest because they differ. I changed it because there was a bad, but harmless, merge in my m5235xsim.h before which i recently fixed. A patch of the fix would look like this below, which may be what you want to run. UART0, PIT1 and QSPI were repeated again below, out of order, with the same numbers. sorry for the confusion. --- uClinux-dist-bsp/linux-2.6.x/include/asm-m68knommu/m523xsim.h 2007-07-16 16:44:53.0 -0400 +++ uClinux-dist-patch-bsp/linux-2.6.x/include/asm-m68knommu/ m523xsim.h 2007-07-25 14:18:12.0 -0400 @@ -30,9 +30,6 @@ /* INTC0 */ #define MCFINT_VECBASE 64 /* Vector base number */ -#defineMCFINT_UART013 /* Interrupt number for UART0 */ -#defineMCFINT_PIT1 36 /* Interrupt number for PIT1 */ -#defineMCFINT_QSPI 18 /* Interrupt number for QSPI */ #define MCFINT_EPF2 2 /* Interrupt number for EPORT2 */ #define MCFINT_EPF3 3 /* Interrupt number for EPORT3 */ #define MCFINT_EPF4 4 /* Interrupt number for EPORT4 */ savantInclude.patch Description: Binary data Wilson On Jul 25, 2007, at 12:00 PM, [EMAIL PROTECTED] wrote: -- Message: 3 Date: Wed, 25 Jul 2007 14:19:36 +1000 From: Greg Ungerer [EMAIL PROTECTED] Subject: Re: [uClinux-dev] [PATCH] BSP for Savant CPU card To: uClinux development list uclinux-dev@uclinux.org Message-ID: [EMAIL PROTECTED] Content-Type: text/plain; charset=ISO-8859-1; format=flowed Hi Wilson, Wilson Callan wrote: Hi, attached is a patch file to support our CPU card on patch 20070718. Changes from my previous submit: 1) removed change in setup.c 2) made a separate function for changes needed in config_BSP() I suspect the bootparm code will not be acceptable to mainline. But I committed it to the uClinux sources. Except m523xsim.h, which didn't patch cleanly: goober patch -p1 /home/gerg/tmp/patches/savantBSP20070718-2.patch patching file linux-2.6.x/arch/m68knommu/defconfig patching file linux-2.6.x/arch/m68knommu/Kconfig patching file linux-2.6.x/arch/m68knommu/Makefile patching file linux-2.6.x/drivers/serial/mcfserial.c patching file linux-2.6.x/include/asm-m68knommu/m523xsim.h patch: malformed patch at line 110: @@ -42,4 +73,122 @@ Can you generate a patch just for this and send please? Regards Greg -- -- Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED] Secure Computing CorporationPHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http:// www.SnapGear.com -- ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH] BSP for Savant CPU card
Hi Wilson, Wilson Callan wrote: Hi, attached is a patch file to support our CPU card on patch 20070718. Changes from my previous submit: 1) added change to setup.c. CONFIG_BOOTPARAM has been moved here in the latest patch, but it was put below config_BSP(). i suggest it makes more sense above config_BSP() because this allows the BSP to alter command_line[]. It makes sense considering command_line[] has always been sent to config_BSP() for this purpose. But that changes the behavior that has existed for all of 2.6.x for this architecture. The existence of CONFIG_BOOTPARM has always been taken to be an override of any runtime passed in boot parameters. 2) merged config.c with latest patch code. At the very least can you pull out the CONFIG_SAVANT code to a separate function? I am not sure that the console manipulation within the command line string is the best way to do this... 3) removed vectors.c change because its not wanted and we will be removing it some day anyway. 4) removed vmlinux.lds.S change since its not needed with the new scheme. The rest looks ok. Regards Greg On Jul 18, 2007, at 11:32 AM, Wilson Callan wrote: Hi, attached is a patch file that adds a config option to use encoded chip selects in the qspi driver. The patch is against the 20070130 distro. The encoded CS code was there but commented out. Now there is an option to enable it. Wilson qspiCS.patch ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev -- Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED] Secure Computing CorporationPHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
[uClinux-dev] [PATCH] BSP for Savant CPU card
Hi, attached is a patch file to support our CPU card on patch 20070718. Changes from my previous submit: 1) removed change in setup.c 2) made a separate function for changes needed in config_BSP() thanks, wilson savantBSP20070718-2.patch.gz Description: GNU Zip compressed data ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH] BSP for Savant CPU card
Hi Wilson, Wilson Callan wrote: Hi, attached is a patch file to support our CPU card on patch 20070718. Changes from my previous submit: 1) removed change in setup.c 2) made a separate function for changes needed in config_BSP() I suspect the bootparm code will not be acceptable to mainline. But I committed it to the uClinux sources. Except m523xsim.h, which didn't patch cleanly: goober patch -p1 /home/gerg/tmp/patches/savantBSP20070718-2.patch patching file linux-2.6.x/arch/m68knommu/defconfig patching file linux-2.6.x/arch/m68knommu/Kconfig patching file linux-2.6.x/arch/m68knommu/Makefile patching file linux-2.6.x/drivers/serial/mcfserial.c patching file linux-2.6.x/include/asm-m68knommu/m523xsim.h patch: malformed patch at line 110: @@ -42,4 +73,122 @@ Can you generate a patch just for this and send please? Regards Greg Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED] Secure Computing CorporationPHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
[uClinux-dev] [PATCH] BSP for Savant CPU card
Hi, attached is a patch file to support our CPU card on patch 20070718. Changes from my previous submit: 1) added change to setup.c. CONFIG_BOOTPARAM has been moved here in the latest patch, but it was put below config_BSP(). i suggest it makes more sense above config_BSP() because this allows the BSP to alter command_line[]. It makes sense considering command_line[] has always been sent to config_BSP() for this purpose. 2) merged config.c with latest patch code. 3) removed vectors.c change because its not wanted and we will be removing it some day anyway. 4) removed vmlinux.lds.S change since its not needed with the new scheme. thanks, wilson savantBSP20070718.patch.gz Description: GNU Zip compressed data On Jul 18, 2007, at 11:32 AM, Wilson Callan wrote: Hi, attached is a patch file that adds a config option to use encoded chip selects in the qspi driver. The patch is against the 20070130 distro. The encoded CS code was there but commented out. Now there is an option to enable it. Wilson qspiCS.patch ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH] BSP for Savant CPU card
Hi Greg, 1. The linker script changes don't conform to the modern way of setting the base and size of kernel RAM 2. Why the special case for vectors 240-255? (I am unlikely to merge any special cases in that code) 1. I'm not sure what you mean by this. config.linux-2.6.x looks the same as M5235EVB regarding CONFIG_RAMBASE and SIZE. Are you talking about config.c? 2. I dont blame you for not wanting that code. That grew out of the fact that i changed to boot image.bin at 0x400, but then changed to needing the u-boot mkimage header before the image start. there were already boot roms out there so i couldnt move the start up to something logical. I want to get away from the that hack ASAP so i'll resubmit the BSP without that after i understand what is needed to fix issue #1. Thanks, Wilson ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH] BSP for Savant CPU card
Hi Wilson, Something else I just thought of too :-) Wilson Callan wrote: 1. The linker script changes don't conform to the modern way of setting the base and size of kernel RAM 2. Why the special case for vectors 240-255? (I am unlikely to merge any special cases in that code) 1. I'm not sure what you mean by this. config.linux-2.6.x looks the same as M5235EVB regarding CONFIG_RAMBASE and SIZE. Are you talking about config.c? Given your changes to config.c you should have a look at the most recent platform changes I have made to all these config.c files. Look in either of: http://www.uclinux.org/pub/uClinux/uClinux-2.6.x/linux-2.6.22-uc0.patch.gz http://www.uclinux.org/pub/uClinux/dist/patches/uClinux-dist-20070130-20070718.patch.gz The patch won't apply as is, and could be made to fit in the platform setup as well. Regards Greg 2. I dont blame you for not wanting that code. That grew out of the fact that i changed to boot image.bin at 0x400, but then changed to needing the u-boot mkimage header before the image start. there were already boot roms out there so i couldnt move the start up to something logical. I want to get away from the that hack ASAP so i'll resubmit the BSP without that after i understand what is needed to fix issue #1. Thanks, Wilson ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev -- Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED] Secure Computing CorporationPHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
[uClinux-dev] [PATCH] BSP for Savant CPU card
Hi, attached is a patch file to support our CPU card on distro 20070130. these are the bare bones files to use uClinux as we do on our board. I will submit separate, complete, patch files for various changes, fixes and additions to Serial, SPI, I2C, eTPU, etc. thanks, wilson savantBsp.patch.gz Description: GNU Zip compressed data ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
