Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
Ah , Bloody Hell , we should punish this reflecter but still 23 emails are too much for 1 bloody min ? no ? On Thu, Apr 26, 2012 at 3:07 AM, Greg Ungerer g...@snapgear.com wrote: Hi Alex, On 04/26/2012 10:53 AM, Alex LI wrote: You sent 50 mails in 1 min. I sent 23. And both list archives (linux-m68k and uclinux-dev) only show the 23 emails. Maybe the uclinux-dev reflecter is sending dupes to list recpients? Regards Greg Sent from my Sony Ericsson Xperia arc S Greg Ungererg...@snapgear.com ?: On 04/26/2012 10:36 AM, mohamed nabil wrote: that's a Fucking spam man !! Huh? Thats how open source development works. If you don't like it don't subscribe to a developers list. Regards Greg On Thu, Apr 26, 2012 at 2:26 AM,g...@snapgear.com mailto:g...@snapgear.com wrote: From: Greg Ungererg...@uclinux.org**mailto:g...@uclinux.org The GPIO data struct setup is now the only remaining code in the platform gpio.c file. So move it to the platform config.c code and remove the gpio.c file. Signed-off-by: Greg Ungererg...@uclinux.org**mailto: g...@uclinux.org --- arch/m68k/platform/532x/**Makefile |2 +- arch/m68k/platform/532x/**config.c | 25 ++ arch/m68k/platform/532x/gpio.c | 43 --** 3 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 arch/m68k/platform/532x/gpio.c diff --git a/arch/m68k/platform/532x/**Makefile b/arch/m68k/platform/532x/**Makefile index ce01669..c0d8cf8 100644 --- a/arch/m68k/platform/532x/**Makefile +++ b/arch/m68k/platform/532x/**Makefile @@ -15,4 +15,4 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 #obj-y := config.o usb-mcf532x.o spi-mcf532x.o -obj-y := config.o gpio.o +obj-y := config.o diff --git a/arch/m68k/platform/532x/**config.c b/arch/m68k/platform/532x/**config.c index 2bec347..a4dd3d8 100644 --- a/arch/m68k/platform/532x/**config.c +++ b/arch/m68k/platform/532x/**config.c @@ -26,10 +26,35 @@ #includeasm/mcfsim.h #includeasm/mcfuart.h #includeasm/mcfdma.h +#includeasm/mcfgpio.h #includeasm/mcfwdebug.h /*** / +struct mcf_gpio_chip mcf_gpio_chips[] = { + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), + MCFGPF(FECH, 8, 8), + MCFGPF(FECL, 16, 8), + MCFGPF(SSI, 24, 5), + MCFGPF(BUSCTL, 32, 4), + MCFGPF(BE, 40, 4), + MCFGPF(CS, 49, 5), + MCFGPF(PWM, 58, 4), + MCFGPF(FECI2C, 64, 4), + MCFGPF(UART, 72, 8), + MCFGPF(QSPI, 80, 6), + MCFGPF(TIMER, 88, 4), + MCFGPF(LCDDATAH, 96, 2), + MCFGPF(LCDDATAM, 104, 8), + MCFGPF(LCDDATAL, 112, 8), + MCFGPF(LCDCTLH, 120, 1), + MCFGPF(LCDCTLL, 128, 8), +}; + +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); + +/** */ + #ifdef CONFIG_SPI_COLDFIRE_QSPI static void __init m532x_qspi_init(void) diff --git a/arch/m68k/platform/532x/**gpio.c b/arch/m68k/platform/532x/**gpio.c deleted file mode 100644 index 3e1b71d..000 --- a/arch/m68k/platform/532x/**gpio.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Coldfire generic GPIO support - * - * (C) Copyright 2009, Steven Kingsfk...@fdwdc.com mailto:sfk...@fdwdc.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. -*/ - -#includelinux/kernel.h -#includelinux/init.h - -#includeasm/coldfire.h -#includeasm/mcfsim.h -#includeasm/mcfgpio.h - -struct mcf_gpio_chip mcf_gpio_chips[] = { - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), - MCFGPF(FECH, 8, 8), - MCFGPF(FECL, 16, 8), - MCFGPF(SSI, 24, 5), - MCFGPF(BUSCTL, 32, 4), - MCFGPF(BE, 40, 4), - MCFGPF(CS, 49, 5), - MCFGPF(PWM, 58, 4), - MCFGPF(FECI2C, 64, 4), - MCFGPF(UART, 72, 8), - MCFGPF(QSPI, 80, 6), - MCFGPF(TIMER, 88, 4), - MCFGPF(LCDDATAH, 96, 2), - MCFGPF(LCDDATAM,
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
Hi, On Wed, Apr 25, 2012 at 10:10 PM, mohamed nabil m.nabil.ha...@gmail.com wrote: Ah , Bloody Hell , we should punish this reflecter but still 23 emails are too much for 1 bloody min ? no ? Personally, I care more about people *not* top-posting and *not* sending html mails, than in getting 100 mails in 1 second, since any modern client can filter that. Just a thought. Ezequiel. ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
Maybe Alex is registered twice. I received only the 23 mails that Greg mentions. It's good to see that uCLinux is still alive and kicking :) Johan. -Original Message- From: uclinux-dev-boun...@uclinux.org [mailto:uclinux-dev-boun...@uclinux.org] On Behalf Of Greg Ungerer Sent: donderdag 26 april 2012 3:08 To: Alex LI Cc: mohamed nabil; linux-m...@vger.kernel.org; uClinux development list; Greg Ungerer Subject: Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup Hi Alex, On 04/26/2012 10:53 AM, Alex LI wrote: You sent 50 mails in 1 min. I sent 23. And both list archives (linux-m68k and uclinux-dev) only show the 23 emails. Maybe the uclinux-dev reflecter is sending dupes to list recpients? Regards Greg Sent from my Sony Ericsson Xperia arc S Greg Ungererg...@snapgear.com ?: On 04/26/2012 10:36 AM, mohamed nabil wrote: that's a Fucking spam man !! Huh? Thats how open source development works. If you don't like it don't subscribe to a developers list. Regards Greg On Thu, Apr 26, 2012 at 2:26 AM,g...@snapgear.com mailto:g...@snapgear.com wrote: From: Greg Ungererg...@uclinux.orgmailto:g...@uclinux.org The GPIO data struct setup is now the only remaining code in the platform gpio.c file. So move it to the platform config.c code and remove the gpio.c file. Signed-off-by: Greg Ungererg...@uclinux.orgmailto:g...@uclinux.org --- arch/m68k/platform/532x/Makefile |2 +- arch/m68k/platform/532x/config.c | 25 ++ arch/m68k/platform/532x/gpio.c | 43 -- 3 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 arch/m68k/platform/532x/gpio.c diff --git a/arch/m68k/platform/532x/Makefile b/arch/m68k/platform/532x/Makefile index ce01669..c0d8cf8 100644 --- a/arch/m68k/platform/532x/Makefile +++ b/arch/m68k/platform/532x/Makefile @@ -15,4 +15,4 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 #obj-y := config.o usb-mcf532x.o spi-mcf532x.o -obj-y := config.o gpio.o +obj-y := config.o diff --git a/arch/m68k/platform/532x/config.c b/arch/m68k/platform/532x/config.c index 2bec347..a4dd3d8 100644 --- a/arch/m68k/platform/532x/config.c +++ b/arch/m68k/platform/532x/config.c @@ -26,10 +26,35 @@ #includeasm/mcfsim.h #includeasm/mcfuart.h #includeasm/mcfdma.h +#includeasm/mcfgpio.h #includeasm/mcfwdebug.h /*** / +struct mcf_gpio_chip mcf_gpio_chips[] = { + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), + MCFGPF(FECH, 8, 8), + MCFGPF(FECL, 16, 8), + MCFGPF(SSI, 24, 5), + MCFGPF(BUSCTL, 32, 4), + MCFGPF(BE, 40, 4), + MCFGPF(CS, 49, 5), + MCFGPF(PWM, 58, 4), + MCFGPF(FECI2C, 64, 4), + MCFGPF(UART, 72, 8), + MCFGPF(QSPI, 80, 6), + MCFGPF(TIMER, 88, 4), + MCFGPF(LCDDATAH, 96, 2), + MCFGPF(LCDDATAM, 104, 8), + MCFGPF(LCDDATAL, 112, 8), + MCFGPF(LCDCTLH, 120, 1), + MCFGPF(LCDCTLL, 128, 8), +}; + +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); + +/***/ + #ifdef CONFIG_SPI_COLDFIRE_QSPI static void __init m532x_qspi_init(void) diff --git a/arch/m68k/platform/532x/gpio.c b/arch/m68k/platform/532x/gpio.c deleted file mode 100644 index 3e1b71d..000 --- a/arch/m68k/platform/532x/gpio.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Coldfire generic GPIO support - * - * (C) Copyright 2009, Steven Kingsfk...@fdwdc.com mailto:sfk...@fdwdc.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. -*/ - -#includelinux/kernel.h -#includelinux/init.h - -#includeasm/coldfire.h -#includeasm/mcfsim.h -#includeasm/mcfgpio.h - -struct mcf_gpio_chip mcf_gpio_chips[] = { - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), - MCFGPF(FECH, 8, 8), - MCFGPF(FECL
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
On Thu, Apr 26, 2012 at 02:36:20AM +0200, mohamed nabil wrote: that's a Fucking spam man !! It was an overview and 22 patch files, sent in standard git email style. Very organized, all in one thread, easy to read. Nothing wrong with it. -- Len Sorensen ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
can somebody stop this please? Date: Thu, 26 Apr 2012 12:14:17 -0400 To: uclinux-dev@uclinux.org From: lsore...@csclub.uwaterloo.ca CC: linux-m...@vger.kernel.org; g...@uclinux.org Subject: Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup On Thu, Apr 26, 2012 at 02:36:20AM +0200, mohamed nabil wrote: that's a Fucking spam man !! It was an overview and 22 patch files, sent in standard git email style. Very organized, all in one thread, easy to read. Nothing wrong with it. -- Len Sorensen ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
that's a Fucking spam man !! On Thu, Apr 26, 2012 at 2:26 AM, g...@snapgear.com wrote: From: Greg Ungerer g...@uclinux.org The GPIO data struct setup is now the only remaining code in the platform gpio.c file. So move it to the platform config.c code and remove the gpio.c file. Signed-off-by: Greg Ungerer g...@uclinux.org --- arch/m68k/platform/532x/Makefile |2 +- arch/m68k/platform/532x/config.c | 25 ++ arch/m68k/platform/532x/gpio.c | 43 -- 3 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 arch/m68k/platform/532x/gpio.c diff --git a/arch/m68k/platform/532x/Makefile b/arch/m68k/platform/532x/Makefile index ce01669..c0d8cf8 100644 --- a/arch/m68k/platform/532x/Makefile +++ b/arch/m68k/platform/532x/Makefile @@ -15,4 +15,4 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 #obj-y := config.o usb-mcf532x.o spi-mcf532x.o -obj-y := config.o gpio.o +obj-y := config.o diff --git a/arch/m68k/platform/532x/config.c b/arch/m68k/platform/532x/config.c index 2bec347..a4dd3d8 100644 --- a/arch/m68k/platform/532x/config.c +++ b/arch/m68k/platform/532x/config.c @@ -26,10 +26,35 @@ #include asm/mcfsim.h #include asm/mcfuart.h #include asm/mcfdma.h +#include asm/mcfgpio.h #include asm/mcfwdebug.h /***/ +struct mcf_gpio_chip mcf_gpio_chips[] = { + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), + MCFGPF(FECH, 8, 8), + MCFGPF(FECL, 16, 8), + MCFGPF(SSI, 24, 5), + MCFGPF(BUSCTL, 32, 4), + MCFGPF(BE, 40, 4), + MCFGPF(CS, 49, 5), + MCFGPF(PWM, 58, 4), + MCFGPF(FECI2C, 64, 4), + MCFGPF(UART, 72, 8), + MCFGPF(QSPI, 80, 6), + MCFGPF(TIMER, 88, 4), + MCFGPF(LCDDATAH, 96, 2), + MCFGPF(LCDDATAM, 104, 8), + MCFGPF(LCDDATAL, 112, 8), + MCFGPF(LCDCTLH, 120, 1), + MCFGPF(LCDCTLL, 128, 8), +}; + +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); + +/***/ + #ifdef CONFIG_SPI_COLDFIRE_QSPI static void __init m532x_qspi_init(void) diff --git a/arch/m68k/platform/532x/gpio.c b/arch/m68k/platform/532x/gpio.c deleted file mode 100644 index 3e1b71d..000 --- a/arch/m68k/platform/532x/gpio.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Coldfire generic GPIO support - * - * (C) Copyright 2009, Steven King sfk...@fdwdc.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. -*/ - -#include linux/kernel.h -#include linux/init.h - -#include asm/coldfire.h -#include asm/mcfsim.h -#include asm/mcfgpio.h - -struct mcf_gpio_chip mcf_gpio_chips[] = { - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), - MCFGPF(FECH, 8, 8), - MCFGPF(FECL, 16, 8), - MCFGPF(SSI, 24, 5), - MCFGPF(BUSCTL, 32, 4), - MCFGPF(BE, 40, 4), - MCFGPF(CS, 49, 5), - MCFGPF(PWM, 58, 4), - MCFGPF(FECI2C, 64, 4), - MCFGPF(UART, 72, 8), - MCFGPF(QSPI, 80, 6), - MCFGPF(TIMER, 88, 4), - MCFGPF(LCDDATAH, 96, 2), - MCFGPF(LCDDATAM, 104, 8), - MCFGPF(LCDDATAL, 112, 8), - MCFGPF(LCDCTLH, 120, 1), - MCFGPF(LCDCTLL, 128, 8), -}; - -unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); -- 1.7.0.4 ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev -- __ Mohamed Nabil Hafez Embedded Software Engineer ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
On 04/26/2012 10:36 AM, mohamed nabil wrote: that's a Fucking spam man !! Huh? Thats how open source development works. If you don't like it don't subscribe to a developers list. Regards Greg On Thu, Apr 26, 2012 at 2:26 AM, g...@snapgear.com mailto:g...@snapgear.com wrote: From: Greg Ungerer g...@uclinux.org mailto:g...@uclinux.org The GPIO data struct setup is now the only remaining code in the platform gpio.c file. So move it to the platform config.c code and remove the gpio.c file. Signed-off-by: Greg Ungerer g...@uclinux.org mailto:g...@uclinux.org --- arch/m68k/platform/532x/Makefile |2 +- arch/m68k/platform/532x/config.c | 25 ++ arch/m68k/platform/532x/gpio.c | 43 -- 3 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 arch/m68k/platform/532x/gpio.c diff --git a/arch/m68k/platform/532x/Makefile b/arch/m68k/platform/532x/Makefile index ce01669..c0d8cf8 100644 --- a/arch/m68k/platform/532x/Makefile +++ b/arch/m68k/platform/532x/Makefile @@ -15,4 +15,4 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 #obj-y := config.o usb-mcf532x.o spi-mcf532x.o -obj-y := config.o gpio.o +obj-y := config.o diff --git a/arch/m68k/platform/532x/config.c b/arch/m68k/platform/532x/config.c index 2bec347..a4dd3d8 100644 --- a/arch/m68k/platform/532x/config.c +++ b/arch/m68k/platform/532x/config.c @@ -26,10 +26,35 @@ #include asm/mcfsim.h #include asm/mcfuart.h #include asm/mcfdma.h +#include asm/mcfgpio.h #include asm/mcfwdebug.h /***/ +struct mcf_gpio_chip mcf_gpio_chips[] = { + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), + MCFGPF(FECH, 8, 8), + MCFGPF(FECL, 16, 8), + MCFGPF(SSI, 24, 5), + MCFGPF(BUSCTL, 32, 4), + MCFGPF(BE, 40, 4), + MCFGPF(CS, 49, 5), + MCFGPF(PWM, 58, 4), + MCFGPF(FECI2C, 64, 4), + MCFGPF(UART, 72, 8), + MCFGPF(QSPI, 80, 6), + MCFGPF(TIMER, 88, 4), + MCFGPF(LCDDATAH, 96, 2), + MCFGPF(LCDDATAM, 104, 8), + MCFGPF(LCDDATAL, 112, 8), + MCFGPF(LCDCTLH, 120, 1), + MCFGPF(LCDCTLL, 128, 8), +}; + +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); + +/***/ + #ifdef CONFIG_SPI_COLDFIRE_QSPI static void __init m532x_qspi_init(void) diff --git a/arch/m68k/platform/532x/gpio.c b/arch/m68k/platform/532x/gpio.c deleted file mode 100644 index 3e1b71d..000 --- a/arch/m68k/platform/532x/gpio.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Coldfire generic GPIO support - * - * (C) Copyright 2009, Steven King sfk...@fdwdc.com mailto:sfk...@fdwdc.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. -*/ - -#include linux/kernel.h -#include linux/init.h - -#include asm/coldfire.h -#include asm/mcfsim.h -#include asm/mcfgpio.h - -struct mcf_gpio_chip mcf_gpio_chips[] = { - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), - MCFGPF(FECH, 8, 8), - MCFGPF(FECL, 16, 8), - MCFGPF(SSI, 24, 5), - MCFGPF(BUSCTL, 32, 4), - MCFGPF(BE, 40, 4), - MCFGPF(CS, 49, 5), - MCFGPF(PWM, 58, 4), - MCFGPF(FECI2C, 64, 4), - MCFGPF(UART, 72, 8), - MCFGPF(QSPI, 80, 6), - MCFGPF(TIMER, 88, 4), - MCFGPF(LCDDATAH, 96, 2), - MCFGPF(LCDDATAM, 104, 8), - MCFGPF(LCDDATAL, 112, 8), - MCFGPF(LCDCTLH, 120, 1), - MCFGPF(LCDCTLL, 128, 8), -}; - -unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); -- 1.7.0.4 ___ uClinux-dev mailing list uClinux-dev@uclinux.org mailto:uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org mailto:uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev -- __ Mohamed Nabil Hafez Embedded Software Engineer --
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
Greg, You sent 50 mails in 1 min. Sent from my Sony Ericsson Xperia arc S Greg Ungerer g...@snapgear.com 寫: On 04/26/2012 10:36 AM, mohamed nabil wrote: that's a Fucking spam man !! Huh? Thats how open source development works. If you don't like it don't subscribe to a developers list. Regards Greg On Thu, Apr 26, 2012 at 2:26 AM, g...@snapgear.com mailto:g...@snapgear.com wrote: From: Greg Ungerer g...@uclinux.org mailto:g...@uclinux.org The GPIO data struct setup is now the only remaining code in the platform gpio.c file. So move it to the platform config.c code and remove the gpio.c file. Signed-off-by: Greg Ungerer g...@uclinux.org mailto:g...@uclinux.org --- arch/m68k/platform/532x/Makefile |2 +- arch/m68k/platform/532x/config.c | 25 ++ arch/m68k/platform/532x/gpio.c | 43 -- 3 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 arch/m68k/platform/532x/gpio.c diff --git a/arch/m68k/platform/532x/Makefile b/arch/m68k/platform/532x/Makefile index ce01669..c0d8cf8 100644 --- a/arch/m68k/platform/532x/Makefile +++ b/arch/m68k/platform/532x/Makefile @@ -15,4 +15,4 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 #obj-y := config.o usb-mcf532x.o spi-mcf532x.o -obj-y := config.o gpio.o +obj-y := config.o diff --git a/arch/m68k/platform/532x/config.c b/arch/m68k/platform/532x/config.c index 2bec347..a4dd3d8 100644 --- a/arch/m68k/platform/532x/config.c +++ b/arch/m68k/platform/532x/config.c @@ -26,10 +26,35 @@ #include asm/mcfsim.h #include asm/mcfuart.h #include asm/mcfdma.h +#include asm/mcfgpio.h #include asm/mcfwdebug.h /***/ +struct mcf_gpio_chip mcf_gpio_chips[] = { + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), + MCFGPF(FECH, 8, 8), + MCFGPF(FECL, 16, 8), + MCFGPF(SSI, 24, 5), + MCFGPF(BUSCTL, 32, 4), + MCFGPF(BE, 40, 4), + MCFGPF(CS, 49, 5), + MCFGPF(PWM, 58, 4), + MCFGPF(FECI2C, 64, 4), + MCFGPF(UART, 72, 8), + MCFGPF(QSPI, 80, 6), + MCFGPF(TIMER, 88, 4), + MCFGPF(LCDDATAH, 96, 2), + MCFGPF(LCDDATAM, 104, 8), + MCFGPF(LCDDATAL, 112, 8), + MCFGPF(LCDCTLH, 120, 1), + MCFGPF(LCDCTLL, 128, 8), +}; + +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); + +/***/ + #ifdef CONFIG_SPI_COLDFIRE_QSPI static void __init m532x_qspi_init(void) diff --git a/arch/m68k/platform/532x/gpio.c b/arch/m68k/platform/532x/gpio.c deleted file mode 100644 index 3e1b71d..000 --- a/arch/m68k/platform/532x/gpio.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Coldfire generic GPIO support - * - * (C) Copyright 2009, Steven King sfk...@fdwdc.com mailto:sfk...@fdwdc.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. -*/ - -#include linux/kernel.h -#include linux/init.h - -#include asm/coldfire.h -#include asm/mcfsim.h -#include asm/mcfgpio.h - -struct mcf_gpio_chip mcf_gpio_chips[] = { - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), - MCFGPF(FECH, 8, 8), - MCFGPF(FECL, 16, 8), - MCFGPF(SSI, 24, 5), - MCFGPF(BUSCTL, 32, 4), - MCFGPF(BE, 40, 4), - MCFGPF(CS, 49, 5), - MCFGPF(PWM, 58, 4), - MCFGPF(FECI2C, 64, 4), - MCFGPF(UART, 72, 8), - MCFGPF(QSPI, 80, 6), - MCFGPF(TIMER, 88, 4), - MCFGPF(LCDDATAH, 96, 2), - MCFGPF(LCDDATAM, 104, 8), - MCFGPF(LCDDATAL, 112, 8), - MCFGPF(LCDCTLH, 120, 1), - MCFGPF(LCDCTLL, 128, 8), -}; - -unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); -- 1.7.0.4 ___ uClinux-dev mailing list uClinux-dev@uclinux.org mailto:uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This
Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
Hi Alex, On 04/26/2012 10:53 AM, Alex LI wrote: You sent 50 mails in 1 min. I sent 23. And both list archives (linux-m68k and uclinux-dev) only show the 23 emails. Maybe the uclinux-dev reflecter is sending dupes to list recpients? Regards Greg Sent from my Sony Ericsson Xperia arc S Greg Ungererg...@snapgear.com ?: On 04/26/2012 10:36 AM, mohamed nabil wrote: that's a Fucking spam man !! Huh? Thats how open source development works. If you don't like it don't subscribe to a developers list. Regards Greg On Thu, Apr 26, 2012 at 2:26 AM,g...@snapgear.com mailto:g...@snapgear.com wrote: From: Greg Ungererg...@uclinux.orgmailto:g...@uclinux.org The GPIO data struct setup is now the only remaining code in the platform gpio.c file. So move it to the platform config.c code and remove the gpio.c file. Signed-off-by: Greg Ungererg...@uclinux.orgmailto:g...@uclinux.org --- arch/m68k/platform/532x/Makefile |2 +- arch/m68k/platform/532x/config.c | 25 ++ arch/m68k/platform/532x/gpio.c | 43 -- 3 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 arch/m68k/platform/532x/gpio.c diff --git a/arch/m68k/platform/532x/Makefile b/arch/m68k/platform/532x/Makefile index ce01669..c0d8cf8 100644 --- a/arch/m68k/platform/532x/Makefile +++ b/arch/m68k/platform/532x/Makefile @@ -15,4 +15,4 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 #obj-y := config.o usb-mcf532x.o spi-mcf532x.o -obj-y := config.o gpio.o +obj-y := config.o diff --git a/arch/m68k/platform/532x/config.c b/arch/m68k/platform/532x/config.c index 2bec347..a4dd3d8 100644 --- a/arch/m68k/platform/532x/config.c +++ b/arch/m68k/platform/532x/config.c @@ -26,10 +26,35 @@ #includeasm/mcfsim.h #includeasm/mcfuart.h #includeasm/mcfdma.h +#includeasm/mcfgpio.h #includeasm/mcfwdebug.h /***/ +struct mcf_gpio_chip mcf_gpio_chips[] = { + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), + MCFGPF(FECH, 8, 8), + MCFGPF(FECL, 16, 8), + MCFGPF(SSI, 24, 5), + MCFGPF(BUSCTL, 32, 4), + MCFGPF(BE, 40, 4), + MCFGPF(CS, 49, 5), + MCFGPF(PWM, 58, 4), + MCFGPF(FECI2C, 64, 4), + MCFGPF(UART, 72, 8), + MCFGPF(QSPI, 80, 6), + MCFGPF(TIMER, 88, 4), + MCFGPF(LCDDATAH, 96, 2), + MCFGPF(LCDDATAM, 104, 8), + MCFGPF(LCDDATAL, 112, 8), + MCFGPF(LCDCTLH, 120, 1), + MCFGPF(LCDCTLL, 128, 8), +}; + +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); + +/***/ + #ifdef CONFIG_SPI_COLDFIRE_QSPI static void __init m532x_qspi_init(void) diff --git a/arch/m68k/platform/532x/gpio.c b/arch/m68k/platform/532x/gpio.c deleted file mode 100644 index 3e1b71d..000 --- a/arch/m68k/platform/532x/gpio.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Coldfire generic GPIO support - * - * (C) Copyright 2009, Steven Kingsfk...@fdwdc.com mailto:sfk...@fdwdc.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. -*/ - -#includelinux/kernel.h -#includelinux/init.h - -#includeasm/coldfire.h -#includeasm/mcfsim.h -#includeasm/mcfgpio.h - -struct mcf_gpio_chip mcf_gpio_chips[] = { - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR), - MCFGPF(FECH, 8, 8), - MCFGPF(FECL, 16, 8), - MCFGPF(SSI, 24, 5), - MCFGPF(BUSCTL, 32, 4), - MCFGPF(BE, 40, 4), - MCFGPF(CS, 49, 5), - MCFGPF(PWM, 58, 4), - MCFGPF(FECI2C, 64, 4), - MCFGPF(UART, 72, 8), - MCFGPF(QSPI, 80, 6), - MCFGPF(TIMER, 88, 4), - MCFGPF(LCDDATAH, 96, 2), - MCFGPF(LCDDATAM, 104, 8), - MCFGPF(LCDDATAL, 112, 8), - MCFGPF(LCDCTLH, 120, 1), - MCFGPF(LCDCTLL, 128, 8), -}; - -unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); -- 1.7.0.4