[Bug 1100328] [NEW] [sponsor-patch] Exits, deleting temporary directory, when dput fails.

2013-01-16 Thread Iain Lane
Public bug reported:

Full disclosure: I'm using dput-ng. I have
DEBUILD_DPKG_BUILDPACKAGE_OPTS=-i -ICVS -I.svn -I_darcs -I.git -I.bzr
-us -uc

I tried to sponsor a patch. dput failed because the source package
changesfile and dsc weren't signed.

,
| Do you want to upload the package to the official Ubuntu archive [y|e|N|?]? 
yes
| Uploading roundcube-plugins-extra using ftp to ubuntu (host: 
upload.ubuntu.com; directory: /)
| running allowed-distribution: check whether a local profile permits uploads 
to the target distribution
| running checksum: verify checksums before uploading
| running suite-mismatch: check the target distribution for common errors
| running check-debs: makes sure the upload contains a binary package
| running gpg: check GnuPG signatures before the upload
| gpg: no valid OpenPGP data found.
| gpg: the signature could not be verified.
| Please remember that the signature file (.sig or .asc)
| should be the first file given on the command line.
| 
| No valid signature on 
roundcube-plugins-extra_0.6-20111030ubuntu1_source.changes: No signature on
| sponsor-patch: Error: Upload of 
roundcube-plugins-extra_0.6-20111030ubuntu1_source.changes to ubuntu failed.
`

sponsor-patch then exited. After this the working files had been deleted
so I had to rebuild the source package.

It'd be good to handle this specific case and run debsign for the user,
but also more generally to trap failures of spawned programs and offer
the user the chance to fix stuff up rather than deleting the temporary
files outright.

** Affects: ubuntu-dev-tools (Ubuntu)
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of MOTU,
which is subscribed to ubuntu-dev-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1100328

Title:
  [sponsor-patch] Exits, deleting temporary directory, when dput fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1100328/+subscriptions

-- 
universe-bugs mailing list
universe-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/universe-bugs


[Bug 1100333] [NEW] [sponsor-patch] Sometimes downloads packages for the wrong release

2013-01-16 Thread Iain Lane
Public bug reported:

I tried to sponsor an SRU where the bug didn't have a task for the
release being SRUed into. sponsor-patch downloaded the current
development release version of the package and failed to apply the
supplied patch.

I'm not sure what it could have done instead. Some ideas

  - DTRT and download the target release package (thus looking at the changelog 
provided in the diff instead of the bug), then prompt to add a task for the 
release (or offer to do it!)
  -  Warned at the start when it sees that the target was wrong (again looking 
at the changelog)
  - Provide a commandline option to override the target release
  - If the patch fails to apply, simply explain to the user that sponsor-patch 
requires the bug tasks to be set correctly as a hint as to what might be going 
wrong.

** Affects: ubuntu-dev-tools (Ubuntu)
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of MOTU,
which is subscribed to ubuntu-dev-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1100333

Title:
  [sponsor-patch] Sometimes downloads packages for the wrong release

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1100333/+subscriptions

-- 
universe-bugs mailing list
universe-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/universe-bugs


[Bug 1100333] Re: [sponsor-patch] Sometimes downloads packages for the wrong release

2013-01-16 Thread Benjamin Drung
** Changed in: ubuntu-dev-tools (Ubuntu)
   Importance: Undecided = Low

-- 
You received this bug notification because you are a member of MOTU,
which is subscribed to ubuntu-dev-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1100333

Title:
  [sponsor-patch] Sometimes downloads packages for the wrong release

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1100333/+subscriptions

-- 
universe-bugs mailing list
universe-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/universe-bugs


[Bug 1100328] Re: [sponsor-patch] Exits, deleting temporary directory, when dput fails.

2013-01-16 Thread Benjamin Drung
** Changed in: ubuntu-dev-tools (Ubuntu)
   Importance: Undecided = Medium

-- 
You received this bug notification because you are a member of MOTU,
which is subscribed to ubuntu-dev-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1100328

Title:
  [sponsor-patch] Exits, deleting temporary directory, when dput fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1100328/+subscriptions

-- 
universe-bugs mailing list
universe-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/universe-bugs