[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
This bug was fixed in the package ubuntu-dev-tools - 0.120
---
ubuntu-dev-tools (0.120) unstable; urgency=low
[ Felix Geyer ]
* pull-lp-source.1: Document -d option.
[ Stefano Rivera ]
* ubuntutools.archive: Filter rmadison results. (LP: #710579)
- Canonicalise suites (use code-names) before passing them to rmadison.
* pull-{lp,debian}-source: Download requested versions, as well as simply
the latest version in a release.
* pull-{lp,debian}-source, pull-debian-debdiff: Catch KeyboardInterrupt.
(LP: #713845)
* pull-debian-source: Handle -p-u and -security suites.
* Bump X-Python-Version to >= 2.6, now that python-launchpadlib no longer
supports Python 2.5.
[ Julian Taylor ]
* add support for cowbuilder and cowbuilder-dist in builder.py
- allows use in sponsor-patch and backportpackage (LP: #728751)
[ Benjamin Drung ]
* data/ubuntu.csv: Add Oneiric Ocelot to the list of know releases.
* ubuntutools.distro_info: Fix TypeError crash and add a test case to
catch regressions (LP: #731398).
-- Stefano RiveraSat, 12 Mar 2011 22:07:47 +0200
** Changed in: ubuntu-dev-tools (Ubuntu)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of MOTU,
which is subscribed to ubuntu-dev-tools in ubuntu.
https://bugs.launchpad.net/bugs/728751
Title:
[sponsor-patch] support cowbuilder and cowbuilder-dist
--
universe-bugs mailing list
universe-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
** Changed in: ubuntu-dev-tools (Ubuntu) Importance: Undecided => Wishlist ** Changed in: ubuntu-dev-tools (Ubuntu) Status: New => Fix Committed ** Changed in: ubuntu-dev-tools (Ubuntu) Assignee: (unassigned) => Julian Taylor (jtaylor) -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
** Branch linked: lp:ubuntu-dev-tools -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
Coming from a more British-english background, I've always been taught not to use it (although I sometimes choose to). I also like the proposed dict + lambda approach. -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
well its disputed: http://en.wikipedia.org/wiki/Serial_comma
its probably better to reformat the message instead, e.g:
>sponsor-patch: Error: Unsupported builder specified: gsgs.
>sponsor-patch: Error: Supported builders: cowbuilder, cowbuilder-dist,
>pbuilder, pbuilder-dist, sbuild
maybe also get rid of the long if clause in get_builder too?
e.g. like this:
supported = {
"cowbuilder": lambda: Pbuilder("cowbuilder"),
"cowbuilder-dist": lambda: Pbuilderdist("cowbuilderdist"),
"pbuilder":lambda: Pbuilder(),
"pbuilder-dist": lambda: Pbuilderdist(),
"sbuild": lambda: Sbuild()
}
if builder in supported:
return supported[builder]()
Logger.error("Unsupported builder specified: %s." % builder)
Logger.error("Supported builders: %s" % ", ".join(sorted(supported.keys(
--
You received this bug notification because you are a member of MOTU,
which is subscribed to ubuntu-dev-tools in ubuntu.
https://bugs.launchpad.net/bugs/728751
Title:
[sponsor-patch] support cowbuilder and cowbuilder-dist
--
universe-bugs mailing list
universe-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
5. My English teacher said, that both variants are used, but using a comma in front of an 'and' makes it clearer. -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
4. done 5. I don't think you should place a comma in front of an 'and' 6. done -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
4. Can you sort the "elif builder == foo" part too? 5. Missing comma in the error message: "pbuilder, pbuilder-dist and sbuild" -> "pbuilder, pbuilder-dist, and sbuild" 6. Can you add a changelog entry? -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
done, backportpackage also works with cowbuilder so that manpage is also updated. -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
[Bug 728751] Re: [sponsor-patch] support cowbuilder and cowbuilder-dist
I reviewed your changes: 1. Can you make command in internal variable (self.command -> self._command)? 2. Can you sort the pbuilder-dist, cowbuilder, ... list alphabetical? 3. The man pages needs to be updated. -- You received this bug notification because you are a member of MOTU, which is subscribed to ubuntu-dev-tools in ubuntu. https://bugs.launchpad.net/bugs/728751 Title: [sponsor-patch] support cowbuilder and cowbuilder-dist -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
