Re: [uportal-dev] uPortal skin CSS

2009-11-20 Thread Eric Dalquist
Correct, all CSS & JS will be included directly in the  of the 
page. The work also includes a runtime toggle to switch between the raw 
CSS/JS and the compress and aggregated versions which will hopefully 
make development a bit easier.


I think all the points of the proposal sound great, +1 from me.

What sort of time frame do you think you'd have for this work?

-Eric

Gary Thompson wrote:

Eric,

If I understand the work done for UP-2505, there will not be a need 
for a main CSS file that imports other CSS files as this new 
aggregator will be doing that?


With that consideration, and some further thought on naming, I would 
like to propose this for uPortal skins:


[skinDirectory]
   - portal.css
   - portlet.css
   - thumb.gif
   - [images]

1. [skinDirectory]
This directory is named with the skin name.  Everything contained in 
this folder should be named generically (i.e., not include the skin 
name in file names).


2. portal.css
The primary, portal-scoped CSS file and the new version of the 
"fluid.theme.skinname.css" file.  Includes the Fluid Skinning System 
theme and uPortal-specific CSS.  Overrides to FSS or jQueryui will be 
done in this file, if necessary.  This will eliminate the previous 
"jquery.css" file.


3. portlet.css
Portlet-scoped CSS file that replaces the previous 
"uportal3_portlet_content.css" and includes the JSR-168 CSS spec.  
Eliminates the previous "jsr168_portlet_spec.css".


4. thumb.gif
Remove the skin name from the file name.  Every skin's thumbnail file 
will be named "thumb.gif".


5. [images]
The images directory remains unchagned.  Any skin-specific images go here.

As part of these changes, we retire these CSS files:
 - skinname.css (no longer needed with the new aggregator)
 - jquery.css (overrides to jQueryui to be done in the new portal.css)
 - jsr168_portlet_spec.css (included in portlet.css)
 - skinname_legacy.css (no longer needed)
 - skinname_ie6overrides.css (with the sunset of IE6, this is not 
needed by default; can be added as necessary)


For namespacing, I suggest adding the "up" namespace and keeping the 
"fluid-theme-name" classes on the  of the document:




This keeps support for the Fluid Skinning System and other Fluid 
components, while allowing for the global "up" namespace that will 
facilitate not having to change that namespace in all the CSS files.


As is the current uPortal 3.x setup, Universality skins will continue 
to include these common (non-skinned) files:

- layout.css
- print.css

Overrides to layout.css should be done in portal.css or portlet.css as 
needed.


Gary Thompson
User Experience Leader
Unicon | www.unicon.net

- Original Message -
From: "Eric Dalquist" 
To: uportal-dev@lists.ja-sig.org
Cc: "Jen Bourey" , "Matt Polizzotti" 
, "Alex Bussa" , 
"uportal-dev" 
Sent: Friday, November 20, 2009 7:29:33 AM GMT -07:00 U.S. Mountain 
Time (Arizona)

Subject: Re:[uportal-dev] uPortal skin CSS

This sounds like a great proposal both for simplifying the skin file 
names as well as the CSS class names.


I just wanted to make sure that you're also aware of the work that 
Nick Blair has been doing on http://www.ja-sig.org/issues/browse/UP-2505


The result of this work will be a skin.xml file in each skin 
directory. This file will list all CSS and JS files the skin uses in 
the order they should be imported. I don't think these two sets of 
changes will cause each other any issues.


Something that will help with the aggregation that this new skin.xml 
and plugin provides is to as much as possible have CSS files listed so 
that files in the same directory are next to each other. The reason is 
if skin.xml lists:


/path/to/skin/main.css
/path/to/common/common.css
/path/to/skin/portlet.css

That can't be aggregated to reduce the number of files the browser 
downloads, where as the following:


/path/to/common/common.css
/path/to/skin/main.css
/path/to/skin/portlet.css

Could be aggregated down to a two files for the users browser to download.

-Eric

Gary Thompson wrote:

As you know, we've been looking at refining uPortal CSS files.  A
significant part of this is to accomplish UP-2389
(http://www.ja-sig.org/issues/browse/UP-2389), and in general to
make the process of creating and maintaining skins easier.  I
wanted to run this proposal past you and get any feedback before I
post it to the list.

Here's the proposal:

The root skin directory alone contains the unique skin name, for
example "uportal3".  Each skin would contain these files:

[skinDirectory]
   - main.css
   - fss-theme-uportal.css
   - portlet.css
   - thumb.gif
   - [images]

The new structure does the following:

1. main.css
A repalcement of the previous, skin-specific "uportal3.css" file,
this CSS will contain imports of any other skin CSS files, and is
the file linked to from the portal .

2. fss-theme-uportal.css
The primary, portal-scoped CSS file and the new versi

Re: [uportal-dev] uPortal skin CSS

2009-11-20 Thread Gary Thompson
Eric, 

If I understand the work done for UP-2505, there will not be a need for a main 
CSS file that imports other CSS files as this new aggregator will be doing 
that? 

With that consideration, and some further thought on naming, I would like to 
propose this for uPortal skins: 

[skinDirectory] 
- portal.css 
- portlet.css 
- thumb.gif 
- [images] 

1. [skinDirectory] 
This directory is named with the skin name. Everything contained in this folder 
should be named generically (i.e., not include the skin name in file names). 

2. portal.css 
The primary, portal-scoped CSS file and the new version of the 
"fluid.theme.skinname.css" file. Includes the Fluid Skinning System theme and 
uPortal-specific CSS. Overrides to FSS or jQueryui will be done in this file, 
if necessary. This will eliminate the previous "jquery.css" file. 

3. portlet.css 
Portlet-scoped CSS file that replaces the previous 
"uportal3_portlet_content.css" and includes the JSR-168 CSS spec. Eliminates 
the previous "jsr168_portlet_spec.css" . 

4. thumb.gif 
Remove the skin name from the file name. Every skin's thumbnail file will be 
named "thumb.gif". 

5. [images] 
The images directory remains unchagned. Any skin-specific images go here. 

As part of these changes, we retire these CSS files: 
- skinname.css (no longer needed with the new aggregator) 
- jquery.css (overrides to jQueryui to be done in the new portal.css) 
- jsr168_portlet_spec.css (included in portlet.css) 
- skinname_legacy.css (no longer needed) 
- skinname_ie6overrides.css (with the sunset of IE6, this is not needed by 
default; can be added as necessary) 

For namespacing, I suggest adding the "up" namespace and keeping the 
"fluid-theme-name" classes on the  of the document: 

 

This keeps support for the Fluid Skinning System and other Fluid components, 
while allowing for the global "up" namespace that will facilitate not having to 
change that namespace in all the CSS files. 

As is the current uPortal 3.x setup, Universality skins will continue to 
include these common (non-skinned) files: 
- layout.css 
- print.css 

Overrides to layout.css should be done in portal.css or portlet.css as needed. 

Gary Thompson 
User Experience Leader 
Unicon | www.unicon.net 

- Original Message - 
From: "Eric Dalquist"  
To: uportal-dev@lists.ja-sig.org 
Cc: "Jen Bourey" , "Matt Polizzotti" 
, "Alex Bussa" , "uportal-dev" 
 
Sent: Friday, November 20, 2009 7:29:33 AM GMT -07:00 U.S. Mountain Time 
(Arizona) 
Subject: Re:[uportal-dev] uPortal skin CSS 

This sounds like a great proposal both for simplifying the skin file names as 
well as the CSS class names. 

I just wanted to make sure that you're also aware of the work that Nick Blair 
has been doing on http://www.ja-sig.org/issues/browse/UP-2505 

The result of this work will be a skin.xml file in each skin directory. This 
file will list all CSS and JS files the skin uses in the order they should be 
imported. I don't think these two sets of changes will cause each other any 
issues. 

Something that will help with the aggregation that this new skin.xml and plugin 
provides is to as much as possible have CSS files listed so that files in the 
same directory are next to each other. The reason is if skin.xml lists: 

/path/to/skin/main.css 
/path/to/common/common.css 
/path/to/skin/portlet.css 

That can't be aggregated to reduce the number of files the browser downloads, 
where as the following: 

/path/to/common/common.css 
/path/to/skin/main.css 
/path/to/skin/portlet.css 

Could be aggregated down to a two files for the users browser to download. 

-Eric 

Gary Thompson wrote: 




As you know, we've been looking at refining uPortal CSS files. A significant 
part of this is to accomplish UP-2389 ( 
http://www.ja-sig.org/issues/browse/UP-2389 ), and in general to make the 
process of creating and maintaining skins easier. I wanted to run this proposal 
past you and get any feedback before I post it to the list. 

Here's the proposal: 

The root skin directory alone contains the unique skin name, for example 
"uportal3". Each skin would contain these files: 

[skinDirectory] 
- main.css 
- fss-theme-uportal.css 
- portlet.css 
- thumb.gif 
- [images] 

The new structure does the following: 

1. main.css 
A repalcement of the previous, skin-specific "uportal3.css" file, this CSS will 
contain imports of any other skin CSS files, and is the file linked to from the 
portal . 

2. fss-theme-uportal.css 
The primary, portal-scoped CSS file and the new version of the 
"fluid.theme.uportal3.css" file. Formatted as Fluid Skinning System theme and 
follows the updated FSS file naming. Overrides to FSS or jQueryui will be done 
in this file, if necessary. This will eliminate the previous "jquery.css" file 

3. portlet.css 
Portlet-scoped CSS file that replaces the previous 
"uportal3_portlet_content.css" and includes the JSR-168 CSS spec. Eliminates 
the previous "jsr168_portlet_spec.css" 

As a by-product, we will retire

Re:[uportal-dev] uPortal skin CSS

2009-11-20 Thread Eric Dalquist
This sounds like a great proposal both for simplifying the skin file 
names as well as the CSS class names.


I just wanted to make sure that you're also aware of the work that Nick 
Blair has been doing on http://www.ja-sig.org/issues/browse/UP-2505


The result of this work will be a skin.xml file in each skin directory. 
This file will list all CSS and JS files the skin uses in the order they 
should be imported. I don't think these two sets of changes will cause 
each other any issues.


Something that will help with the aggregation that this new skin.xml and 
plugin provides is to as much as possible have CSS files listed so that 
files in the same directory are next to each other. The reason is if 
skin.xml lists:


/path/to/skin/main.css
/path/to/common/common.css
/path/to/skin/portlet.css

That can't be aggregated to reduce the number of files the browser 
downloads, where as the following:


/path/to/common/common.css
/path/to/skin/main.css
/path/to/skin/portlet.css

Could be aggregated down to a two files for the users browser to download.

-Eric

Gary Thompson wrote:
As you know, we've been looking at refining uPortal CSS files.  A 
significant part of this is to accomplish UP-2389 
(http://www.ja-sig.org/issues/browse/UP-2389), and in general to make 
the process of creating and maintaining skins easier.  I wanted to run 
this proposal past you and get any feedback before I post it to the list.


Here's the proposal:

The root skin directory alone contains the unique skin name, for 
example "uportal3".  Each skin would contain these files:


[skinDirectory]
   - main.css
   - fss-theme-uportal.css
   - portlet.css
   - thumb.gif
   - [images]

The new structure does the following:

1. main.css
A repalcement of the previous, skin-specific "uportal3.css" file, this 
CSS will contain imports of any other skin CSS files, and is the file 
linked to from the portal .


2. fss-theme-uportal.css
The primary, portal-scoped CSS file and the new version of the 
"fluid.theme.uportal3.css" file.  Formatted as Fluid Skinning System 
theme and follows the updated FSS file naming.  Overrides to FSS or 
jQueryui will be done in this file, if necessary.  This will eliminate 
the previous "jquery.css" file


3. portlet.css
Portlet-scoped CSS file that replaces the previous 
"uportal3_portlet_content.css" and includes the JSR-168 CSS spec.  
Eliminates the previous "jsr168_portlet_spec.css"


As a by-product, we will retire both "uportal3_legacy.css" and 
"uportal3_ie6overrride.css".  The legacy file had support for the 
deprecated "uportal-" classes.  An IE6-specific file will not be 
provided by default, but can be created as-needed.  We may have an IE 
conditional CSS call in the theme.


We will also be changing the uPortal CSS namespace.  Previously, the 
skin name was put as a class on the body, and all CSS classes used 
this as a namespace.  We want to move away from using the skin name, 
and instead use a global uPortal namespace.  I am suggesting we use 
the class "up".  For example:




and in the CSS:

.up .classname ...

instead of the previous:

.fluid-theme-uportal3 .classname ...

Let me know your thoughts.

Gary Thompson
User Experience Leader
Unicon | www.unicon.net


smime.p7s
Description: S/MIME Cryptographic Signature


Re: [uportal-dev] maven plugin tests again

2009-11-20 Thread Nicholas Blair
Good catch - fix is checked into trunk.

On Thu, Nov 19, 2009 at 10:40 PM, Susan Bramhall
 wrote:
> I am attempting to add additional info messages to the deploy ear mojo to
> track down problems we are having with maven plugin and discovered that the
> tests in M2 and trunk fail for me.  The issue is that the hard coded
> filenames in ResourcesAggregatorImplTest do not match the names generated
> when I run the test.  It looks they are using some sort of guid which is not
> always the same on every machine.  I changed the Assert statements in
> question to use the file names in the lists returned from
> ResourceAggregatorImpl.  Not sure if this tests what you intend but it
> passes.  Patch is below.
> Susan
> ==patch=
> Index:
> src/test/java/org/jasig/portal/web/skin/ResourcesAggregatorImplTest.java
> ===
> ---
> src/test/java/org/jasig/portal/web/skin/ResourcesAggregatorImplTest.java
> (revision 47213)
> +++
> src/test/java/org/jasig/portal/web/skin/ResourcesAggregatorImplTest.java
> (working copy)
> @@ -154,13 +154,13 @@
>      Assert.assertEquals(6, cssList.size());
>      List jsList = result.getJs();
>      Assert.assertEquals(1, jsList.size());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/css/fluid/uportal3_aggr1_A3661D3474000B0B06BC01EA644DBE07.css").exists());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/css/uportal3_aggr2_0A62110C5DBE25EECD978B41EE455466.css").exists());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/css/uportal3_aggr2_0A62110C5DBE25EECD978B41EE455466.css").exists());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/uportal3/uportal3_aggr3_3334333FF8A41D7D6BCE5C8AE5B71B4A.css").exists());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/uportal3/uportal3_aggr5_0EC69539BB6BA6C8B611BAC539C67794.css").exists());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/uportal3/uportal3_aggr6_F21DFDA90E2DFAEB81BC098A037A458C.css").exists());
> -        Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/javascript/uportal/uportal3_aggr7_158C92140AC7355300F2708F20D66DB2.js").exists());
> +
> +    Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/" + cssList.get(0).getValue()).exists());
> +    Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/" + cssList.get(1).getValue()).exists());
> +    Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/uportal3/" + cssList.get(2).getValue()).exists());
> +    Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/uportal3/" + cssList.get(4).getValue()).exists());
> +    Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/uportal3/" + cssList.get(5).getValue()).exists());
> +    Assert.assertTrue(new File(getTestOutputRoot() +
> "/skin-universality/common/" + jsList.get(0).getValue()).exists());
>  }
>
>  /**
>
> --
>
> Susan Bramhall (susan.bramh...@yale.edu)
> Senior Developer, Infrastructure Systems and Architecture (formerly T&P)
> Yale University Information Technology Services (ITS)
> 25 Science Park, 150 Munson St, New Haven, CT 06520
> Phone:  203 432 6697
>
> --
>
> You are currently subscribed to uportal-dev@lists.ja-sig.org as:
> nicholas.bl...@gmail.com
> To unsubscribe, change settings or access archives, see
> http://www.ja-sig.org/wiki/display/JSG/uportal-dev

-- 
You are currently subscribed to uportal-dev@lists.ja-sig.org as: 
arch...@mail-archive.com
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/uportal-dev