Re: Semaphore Stuck when no acquirers to assign permit

[Denis Magda]

Igniters,

Who can check out Tim’s fix for the semaphore?

pull request: https://github.com/apache/ignite/pull/3138 

jira: https://issues.apache.org/jira/browse/IGNITE-7090 


—
Denis

> On Jan 15, 2018, at 12:02 PM, Timay  wrote:
> 
> I saw a release date set for 2.4 but have not had any feedback on the jira so
> i wanted to check in on this. Can this make it into the 2.4 release?
> 
> Thanks
> Tim
> 
> 
> 
> --
> Sent from: http://apache-ignite-users.70518.x6.nabble.com/

Re: Semaphore Stuck when no acquirers to assign permit

[Timay]

I saw a release date set for 2.4 but have not had any feedback on the jira so
i wanted to check in on this. Can this make it into the 2.4 release?

Thanks
Tim



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/

Re: Semaphore Stuck when no acquirers to assign permit

[Nikolai Tikhonov]

Tim,

Thank you for your contribution! I'll look at your changes and leave my
comment to jira ticket.

On Tue, Dec 5, 2017 at 6:18 AM, Timay  wrote:

> From what i found, it looks like the DataStructuresProcessor EventListener
> get invoked after the dsMap has been cleared which prevents the
> onNodeRemoved from being invoked. I created a pull request which will
> invoke
> the onNodeRemove from the stop method. Also added my test to the data
> structure test suite.
>
> Please take a look, and let me know what your thoughts are on it.
>
> pull request: https://github.com/apache/ignite/pull/3138
> jira: https://issues.apache.org/jira/browse/IGNITE-7090
>
> Tim
>
>
>
> --
> Sent from: http://apache-ignite-users.70518.x6.nabble.com/
>

Re: Semaphore Stuck when no acquirers to assign permit

[Timay]

>From what i found, it looks like the DataStructuresProcessor EventListener
get invoked after the dsMap has been cleared which prevents the
onNodeRemoved from being invoked. I created a pull request which will invoke
the onNodeRemove from the stop method. Also added my test to the data
structure test suite. 

Please take a look, and let me know what your thoughts are on it. 

pull request: https://github.com/apache/ignite/pull/3138
jira: https://issues.apache.org/jira/browse/IGNITE-7090

Tim



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/

Re: Semaphore Stuck when no acquirers to assign permit

[Nikolai Tikhonov]

Hi Tim!

Yes, it looks as bug. Thank you for investigation!
Feel free to contribute. ;)

On Fri, Dec 1, 2017 at 8:39 PM, Timay  wrote:

> Hey all,
>
> We experienced an issue when trying to establish a semaphore after a single
> instanced client node goes down hard (kill -9). Which afterwards we cannot
> acquire a permit on the existing semaphore. However, if the client is
> redundant, the permit is transferred successfully.
>
> I created a modified test of the SemaphoreFailoverSafeReleasePermitsTest,
> which will close the initial semephore ignite instance then try and acquire
> a permit and fail.
>
> SemaphoreFailoverNoWaitingAcquirerTest.java
>  SemaphoreFailoverNoWaitingAcquirerTest.java>
>
> I created a jira (https://issues.apache.org/jira/browse/IGNITE-7090) to
> track as well, may try and dig further but wanted to get it out to the
> group.
>
> Tim
>
>
>
> --
> Sent from: http://apache-ignite-users.70518.x6.nabble.com/
>

Semaphore Stuck when no acquirers to assign permit

[Timay]

Hey all, 

We experienced an issue when trying to establish a semaphore after a single
instanced client node goes down hard (kill -9). Which afterwards we cannot
acquire a permit on the existing semaphore. However, if the client is
redundant, the permit is transferred successfully. 

I created a modified test of the SemaphoreFailoverSafeReleasePermitsTest,
which will close the initial semephore ignite instance then try and acquire
a permit and fail. 

SemaphoreFailoverNoWaitingAcquirerTest.java

  

I created a jira (https://issues.apache.org/jira/browse/IGNITE-7090) to
track as well, may try and dig further but wanted to get it out to the
group. 

Tim



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/