Re: JMeter 3.1 httpclient4.retrycount does not work
> > +DELETE also like sebb said. > > > True but iIt was not concerned by bug. Maybe I got something wrong, but you did paste DELETE originally as non-idemponent in list of non-retryable methods: > > - Idempotent HTTP methods which are by default those that do not implement > > HttpEntityEnclosingRequest, so not POST, PUT,DELETE, PATCH, GET With body > 1/ To diagnose set those classes in debug mode: > org.apache.http.impl.client.DefaultRequestDirector > > You should see: > Retrying connect to > Retrying request to > > Log level can be set in log4j2.xml Ok, with latest nightly build, retrying works just fine, I got: 2017-03-10 08:50:57,856 INFO o.a.j.p.h.s.HTTPHC4Impl$3: I/O exception (org.apache.http.NoHttpResponseException) caught when processing request to {}->http://client-api.perf.ew1.cosmos-ci.fsapi.com:80: The target server failed to respond 2017-03-10 08:50:57,856 INFO o.a.j.p.h.s.HTTPHC4Impl$3: Retrying request to {}->http://client-api.perf.ew1.cosmos-ci.fsapi.com:80 However, with exact same testplan/configuration/scenario, retrying just does not work with HC4 on JMeter 3.1. Unfortunately, I wasn't able to configure logging on JMeter 3.1 so that it would print similar lines. I tried adding to user.properties: log_level.org.apache.http.impl.client.DefaultRequestDirector=DEBUG But that didn't do anything. Also tried tuning bin/log4j.conf. Maybe that class does not exist in JMeter 3.1? Anyway, I can confirm that retying with HC4 does not work on JMeter 3.1 but does work on latest nightly. Not for me at least (I don't believe I have anything special in my JMeter 3.1 installation, just same plugins that I downloaded into nightly build also). > I have added a property that you can set and try in user.properties: > httpclient4.request_sent_retry_enabled=true > Please give your feedback rapidly, so that we decide what to do if it has an effect. Unfortunately, I don't have a test case with non-idempotent method at hand just now. I can give it a try at the start of next week. > But setting httpclient4.validate_after_inactivity=0 means you disable the > validation which is not a good idea as you'll end up having broken > connection. Maybe httpclient4.validate_after_inactivity=1 then? I assume that's pretty much the same as the old stale check? Tuukka On Thu, Mar 9, 2017 at 10:38 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > On Thu, Mar 9, 2017 at 5:28 PM, Tuukka Mustonen > > wrote: > > > Sorry for the late reply, > > > > About customizing retry method whitelist: > > > > > You case is a bit soecific no ? > > > > True, it's very undesirable scenario, but that's what you get with AWS > ALB > > for now - I believe there are lots and lots of other users that will face > > the same problem. > > > > I have added a property that you can set and try in user.properties: > httpclient4.request_sent_retry_enabled=true > > Please give your feedback rapidly, so that we decide what to do if it has > an effect. > > Having said that, I am in discussion with AWS about if they will fix it and > > with what timeline - current behavior is complete nonsense... > > > > > In this case, the bug is larger than what I thought as for now we > > consider > > > PUT as non idempotent. > > > > +DELETE also like sebb said. > > > True but iIt was not concerned by bug. > > > > > > 1/ To diagnose set those classes in debug mode: > > > org.apache.http.impl.client.DefaultRequestDirector > > > > > > You should see: > > > Retrying connect to > > > Retrying request to > > > > > > Log level can be set in log4j2.xml > > > > Thanks! I'll try to find time to check that tomorrow... > > > > > 2/ I confirm stalecheck is still available. > > > > Can you clarify what is the difference to having > > httpclient4.validate_after_inactivity=0? > > > > It was an optimisation added by HC4 to replace stalecheck which was very > costly. > But setting httpclient4.validate_after_inactivity=0 means you disable the > validation which is not a good idea as you'll end up having broken > connection. > This value should be set to a value lower than the keepalive set on server > side. > > > > Tuukka > > > > > > On Thu, Mar 9, 2017 at 2:23 PM, Philippe Mouawad < > > philippe.moua...@gmail.com > > > wrote: > > > > > Thanks for link sebb. > > > > > > In this case, the bug is larger than what I thought as for now we > > consider > > > PUT as non idempotent. > > > > > > I'll commit a new fix. > > > Regards > > > > > > On Thu, Mar 9, 2017 at 12:20 PM, sebb wrote: > > > > > > > On 9 March 2017 at 06:42, Philippe Mouawad < > philippe.moua...@gmail.com > > > > > > > wrote: > > > > > On Thursday, March 9, 2017, Tuukka Mustonen < > > tuukka.musto...@gmail.com > > > > > > > > > wrote: > > > > > > > > > >> Hi Philippe and thanks for speedy actions! > > > > >> > > > > >> 1) Retrying only idempotent requests makes sense, as usual. But > this > > > > (retry > > > > >> on idempotent) seems to be only documented on wiki page ( > > > > >> https://wiki.apache.org
Re: JMeter 3.1 httpclient4.retrycount does not work
On Thu, Mar 9, 2017 at 5:28 PM, Tuukka Mustonen wrote: > Sorry for the late reply, > > About customizing retry method whitelist: > > > You case is a bit soecific no ? > > True, it's very undesirable scenario, but that's what you get with AWS ALB > for now - I believe there are lots and lots of other users that will face > the same problem. > > I have added a property that you can set and try in user.properties: httpclient4.request_sent_retry_enabled=true Please give your feedback rapidly, so that we decide what to do if it has an effect. Having said that, I am in discussion with AWS about if they will fix it and > with what timeline - current behavior is complete nonsense... > > > In this case, the bug is larger than what I thought as for now we > consider > > PUT as non idempotent. > > +DELETE also like sebb said. > True but iIt was not concerned by bug. > > > 1/ To diagnose set those classes in debug mode: > > org.apache.http.impl.client.DefaultRequestDirector > > > > You should see: > > Retrying connect to > > Retrying request to > > > > Log level can be set in log4j2.xml > > Thanks! I'll try to find time to check that tomorrow... > > > 2/ I confirm stalecheck is still available. > > Can you clarify what is the difference to having > httpclient4.validate_after_inactivity=0? > It was an optimisation added by HC4 to replace stalecheck which was very costly. But setting httpclient4.validate_after_inactivity=0 means you disable the validation which is not a good idea as you'll end up having broken connection. This value should be set to a value lower than the keepalive set on server side. > Tuukka > > > On Thu, Mar 9, 2017 at 2:23 PM, Philippe Mouawad < > philippe.moua...@gmail.com > > wrote: > > > Thanks for link sebb. > > > > In this case, the bug is larger than what I thought as for now we > consider > > PUT as non idempotent. > > > > I'll commit a new fix. > > Regards > > > > On Thu, Mar 9, 2017 at 12:20 PM, sebb wrote: > > > > > On 9 March 2017 at 06:42, Philippe Mouawad > > > > wrote: > > > > On Thursday, March 9, 2017, Tuukka Mustonen < > tuukka.musto...@gmail.com > > > > > > > wrote: > > > > > > > >> Hi Philippe and thanks for speedy actions! > > > >> > > > >> 1) Retrying only idempotent requests makes sense, as usual. But this > > > (retry > > > >> on idempotent) seems to be only documented on wiki page ( > > > >> https://wiki.apache.org/jmeter/JMeterSocketClosed). You should add > it > > > also > > > >> to http://jmeter.apache.org/usermanual/component_reference.html. > > > >> > > > >> 2) In this case, the requests are GETs (and without body) so they > > > should be > > > >> retried. > > > > > > > > Yes. > > > > I debugged it and I confirm they are unless you face the exceptions I > > > > mentionned. > > > > > > > >> > > > >> So the bug you fixed shouldn't affect this scenario. > > > > > > > > Yes > > > > > > > >> > > > >> There must be > > > >> something else - any pointers to what logging module/level I should > > > enable > > > >> to inspect the (failing) retry logic? > > > > > > > > As you can see there is no logging in this HC4 class > > > > Try the calling class. I' ll provide its name later > > > > > > > >> > > > >> 3) AFAIK PUT is idempotent - shouldn't you retry also that? > > > > > > > > No it's not IMU, it changes state of server. > > > > > > PUT *is* idempotent. > > > > > > It may change the state of the server the first time it is sent, but > > > subsequent PUTs should not change the state further. > > > So it can be repeated as required. > > > > > > Similarly for DELETE > > > > > > https://tools.ietf.org/html/rfc2616#section-9.1.2 > > > > > > >> > > > >> 4) In this case, once I add tests for POST/PATCH/DELETE etc. I also > > > want to > > > >> retry these non-idempotent requests (to tolerate ALBs ugly > behavior). > > > These > > > >> are "just" performance tests so I don't care if I'm creating > duplicate > > > >> data. Is there way to specify custom method whitelist to retry any > > HTTP > > > >> method? I see requestSentRetryEnabled in HC4 source code - can I > > enable > > > >> that somehow? > > > > > > > > Not for now. > > > > You case is a bit soecific no ? > > > > > > > >> > > > >> 5) *Related question: > > > >> is http.connection.stalecheck$Boolean=false (in hc.parameters file) > > > valid > > > >> anymore on JMeter 3.x with improved retry/stale logic > > > >> (and httpclient4.validate_after_inactivity)? The line is still > there > > in > > > >> bundled hc.parameters file...* > > > > > > > > i'll double check > > > > > > > >> > > > >> Tuukka > > > >> > > > >> > > > >> On Thu, Mar 9, 2017 at 12:25 AM, Philippe Mouawad < > > > >> philippe.moua...@gmail.com > wrote: > > > >> > > > >> > Hello, > > > >> > The issue with Get with body should be fixed now: > > > >> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60837 > > > >> > > > > >> > Regards > > > >> > Philippe > > > >> > > > > >> > On Wed, Mar 8, 2017 at 8:53 PM, Philippe Mouawad < > > > >> > philippe.moua...@gma
Re: JMeter 3.1 httpclient4.retrycount does not work
Sorry for the late reply, About customizing retry method whitelist: > You case is a bit soecific no ? True, it's very undesirable scenario, but that's what you get with AWS ALB for now - I believe there are lots and lots of other users that will face the same problem. Having said that, I am in discussion with AWS about if they will fix it and with what timeline - current behavior is complete nonsense... > In this case, the bug is larger than what I thought as for now we consider > PUT as non idempotent. +DELETE also like sebb said. > 1/ To diagnose set those classes in debug mode: > org.apache.http.impl.client.DefaultRequestDirector > > You should see: > Retrying connect to > Retrying request to > > Log level can be set in log4j2.xml Thanks! I'll try to find time to check that tomorrow... > 2/ I confirm stalecheck is still available. Can you clarify what is the difference to having httpclient4.validate_after_inactivity=0? Tuukka On Thu, Mar 9, 2017 at 2:23 PM, Philippe Mouawad wrote: > Thanks for link sebb. > > In this case, the bug is larger than what I thought as for now we consider > PUT as non idempotent. > > I'll commit a new fix. > Regards > > On Thu, Mar 9, 2017 at 12:20 PM, sebb wrote: > > > On 9 March 2017 at 06:42, Philippe Mouawad > > wrote: > > > On Thursday, March 9, 2017, Tuukka Mustonen > > > > wrote: > > > > > >> Hi Philippe and thanks for speedy actions! > > >> > > >> 1) Retrying only idempotent requests makes sense, as usual. But this > > (retry > > >> on idempotent) seems to be only documented on wiki page ( > > >> https://wiki.apache.org/jmeter/JMeterSocketClosed). You should add it > > also > > >> to http://jmeter.apache.org/usermanual/component_reference.html. > > >> > > >> 2) In this case, the requests are GETs (and without body) so they > > should be > > >> retried. > > > > > > Yes. > > > I debugged it and I confirm they are unless you face the exceptions I > > > mentionned. > > > > > >> > > >> So the bug you fixed shouldn't affect this scenario. > > > > > > Yes > > > > > >> > > >> There must be > > >> something else - any pointers to what logging module/level I should > > enable > > >> to inspect the (failing) retry logic? > > > > > > As you can see there is no logging in this HC4 class > > > Try the calling class. I' ll provide its name later > > > > > >> > > >> 3) AFAIK PUT is idempotent - shouldn't you retry also that? > > > > > > No it's not IMU, it changes state of server. > > > > PUT *is* idempotent. > > > > It may change the state of the server the first time it is sent, but > > subsequent PUTs should not change the state further. > > So it can be repeated as required. > > > > Similarly for DELETE > > > > https://tools.ietf.org/html/rfc2616#section-9.1.2 > > > > >> > > >> 4) In this case, once I add tests for POST/PATCH/DELETE etc. I also > > want to > > >> retry these non-idempotent requests (to tolerate ALBs ugly behavior). > > These > > >> are "just" performance tests so I don't care if I'm creating duplicate > > >> data. Is there way to specify custom method whitelist to retry any > HTTP > > >> method? I see requestSentRetryEnabled in HC4 source code - can I > enable > > >> that somehow? > > > > > > Not for now. > > > You case is a bit soecific no ? > > > > > >> > > >> 5) *Related question: > > >> is http.connection.stalecheck$Boolean=false (in hc.parameters file) > > valid > > >> anymore on JMeter 3.x with improved retry/stale logic > > >> (and httpclient4.validate_after_inactivity)? The line is still there > in > > >> bundled hc.parameters file...* > > > > > > i'll double check > > > > > >> > > >> Tuukka > > >> > > >> > > >> On Thu, Mar 9, 2017 at 12:25 AM, Philippe Mouawad < > > >> philippe.moua...@gmail.com > wrote: > > >> > > >> > Hello, > > >> > The issue with Get with body should be fixed now: > > >> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60837 > > >> > > > >> > Regards > > >> > Philippe > > >> > > > >> > On Wed, Mar 8, 2017 at 8:53 PM, Philippe Mouawad < > > >> > philippe.moua...@gmail.com > > >> > > wrote: > > >> > > > >> > > Hello Tuukka, > > >> > > > > >> > > In my recent tests I didn't face any issue with > > httpclient4.retrycount. > > >> > > For me it works but be aware that JMeter (HC4) does not retry all > > >> > > requests, it only retries those it is allowed to : > > >> > > - Idempotent HTTP methods which are by default those that do not > > >> > implement > > >> > > HttpEntityEnclosingRequest, so not POST, PUT,DELETE, PATCH, GET > With > > >> body > > >> > > (<= That might be a bug thinking more about it) > > >> > > - Non retriable exceptions (InterruptedIOException.class, > > >> > > UnknownHostException.class, ConnectException.class, > > >> SSLException.class) > > >> > > - + Some other reasons > > >> > > > > >> > > See: > > >> > > https://github.com/apache/httpclient/blob/4.5.x/ > > >> > > httpclient/src/main/java/org/apache/http/impl/client/ > > >> > > DefaultHttpRequestRetryHandler.java#L129 > > >> > > > > >> > > > >
Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
Hello, When migrating you should always before read this: http://jmeter.apache.org/changes.html http://jmeter.apache.org/changes_history.html The time spent reading it will make you gain a lot of time during migration and you will hopefully discover new features that you may not be aware of. Regards On Thu, Mar 9, 2017 at 12:41 PM, Stuart Kenworthy wrote: > And SignIn.jmx definitely has a test fragment object at the parent level? > > -Original Message- > From: Munaf Sheikh [mailto:mu...@virtrics.com] > Sent: 09 March 2017 11:34 > To: JMeter Users List > Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest > > Hi, thanks for your response, > > I've just tried the same on JMeter 3.1. The error I see in both is the > following: No test Fragment found > > 2017/03/09 13:32:00 INFO - jmeter.control.IncludeController: > loadIncludedElements -- try to load included module: > G:\jmeter-investigation\SignIn.jmx > 2017/03/09 13:32:00 INFO - jmeter.save.SaveService: Loading file: > G:\jmeter-investigation\SignIn.jmx > 2017/03/09 13:32:00 WARN - jmeter.control.IncludeController: No Test > Fragment was found in included Test Plan, returning empty HashTree > > The SignIn.jmx file works when I run it by itself. > > Regards > > On Thu, 9 Mar 2017 at 13:26 Stuart Kenworthy > wrote: > > > What exactly is the problem with the includes? > > > > Is it that the controllers are not recognised as a usable object or > > they have lost the fragment they are including? > > > > Thanks > > > > -Original Message- > > From: Felix Schumacher [mailto:felix.schumac...@internetallee.de] > > Sent: 09 March 2017 11:20 > > To: JMeter Users List > > Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest > > > > > > > > Am 9. März 2017 12:03:51 MEZ schrieb Munaf Sheikh : > > >Hi there, > > > > > >We have a large test suite of JMeter files written using version 2.9 > > >(with Json Plugin). We're seeing various problems opening the test > > >suite in JMeter 3.0. One issue is that the include controllers aren't > > >working any more. > > > > > >Is this a known issue? Is there a work around? Or could I have done > > >something wrong? > > > > We can't help you without detailed error messages. Have a look at the > > log files. > > > > Latest JMeter version is 3.1. > > > > Include controllers as such should work. > > > > Regards, > > Felix > > > > > > > >Regards > > > > > >~M > > > > > > > > >[image: Email Signature.png] > > >-- > > > > - > > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > > For additional commands, e-mail: user-h...@jmeter.apache.org > > > > > > The information included in this email and any files transmitted with > > it may contain information that is confidential and it must not be > > used by, or its contents or attachments copied or disclosed to, > > persons other than the intended addressee. If you have received this > > email in error, please notify BJSS. In the absence of written > > agreement to the contrary BJSS' relevant standard terms of contract > > for any work to be undertaken will apply. Please carry out virus or > > such other checks as you consider appropriate in respect of this > > email. BJSS does not accept responsibility for any adverse effect upon > > your system or data in relation to this email or any files transmitted > > with it. BJSS Limited, a company registered in England and Wales > > (Company Number 2777575), VAT Registration Number 613295452, Registered > Office Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW. > > > > - > > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > > For additional commands, e-mail: user-h...@jmeter.apache.org > > > -- > > The information included in this email and any files transmitted with it > may contain information that is confidential and it must not be used by, or > its contents or attachments copied or disclosed to, persons other than the > intended addressee. If you have received this email in error, please notify > BJSS. In the absence of written agreement to the contrary BJSS' relevant > standard terms of contract for any work to be undertaken will apply. Please > carry out virus or such other checks as you consider appropriate in respect > of this email. BJSS does not accept responsibility for any adverse effect > upon your system or data in relation to this email or any files transmitted > with it. BJSS Limited, a company registered in England and Wales (Company > Number 2777575), VAT Registration Number 613295452, Registered Office > Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW. > -- Cordialement. Philippe Mouawad.
Re: JMeter 3.1 httpclient4.retrycount does not work
Thanks for link sebb. In this case, the bug is larger than what I thought as for now we consider PUT as non idempotent. I'll commit a new fix. Regards On Thu, Mar 9, 2017 at 12:20 PM, sebb wrote: > On 9 March 2017 at 06:42, Philippe Mouawad > wrote: > > On Thursday, March 9, 2017, Tuukka Mustonen > > wrote: > > > >> Hi Philippe and thanks for speedy actions! > >> > >> 1) Retrying only idempotent requests makes sense, as usual. But this > (retry > >> on idempotent) seems to be only documented on wiki page ( > >> https://wiki.apache.org/jmeter/JMeterSocketClosed). You should add it > also > >> to http://jmeter.apache.org/usermanual/component_reference.html. > >> > >> 2) In this case, the requests are GETs (and without body) so they > should be > >> retried. > > > > Yes. > > I debugged it and I confirm they are unless you face the exceptions I > > mentionned. > > > >> > >> So the bug you fixed shouldn't affect this scenario. > > > > Yes > > > >> > >> There must be > >> something else - any pointers to what logging module/level I should > enable > >> to inspect the (failing) retry logic? > > > > As you can see there is no logging in this HC4 class > > Try the calling class. I' ll provide its name later > > > >> > >> 3) AFAIK PUT is idempotent - shouldn't you retry also that? > > > > No it's not IMU, it changes state of server. > > PUT *is* idempotent. > > It may change the state of the server the first time it is sent, but > subsequent PUTs should not change the state further. > So it can be repeated as required. > > Similarly for DELETE > > https://tools.ietf.org/html/rfc2616#section-9.1.2 > > >> > >> 4) In this case, once I add tests for POST/PATCH/DELETE etc. I also > want to > >> retry these non-idempotent requests (to tolerate ALBs ugly behavior). > These > >> are "just" performance tests so I don't care if I'm creating duplicate > >> data. Is there way to specify custom method whitelist to retry any HTTP > >> method? I see requestSentRetryEnabled in HC4 source code - can I enable > >> that somehow? > > > > Not for now. > > You case is a bit soecific no ? > > > >> > >> 5) *Related question: > >> is http.connection.stalecheck$Boolean=false (in hc.parameters file) > valid > >> anymore on JMeter 3.x with improved retry/stale logic > >> (and httpclient4.validate_after_inactivity)? The line is still there in > >> bundled hc.parameters file...* > > > > i'll double check > > > >> > >> Tuukka > >> > >> > >> On Thu, Mar 9, 2017 at 12:25 AM, Philippe Mouawad < > >> philippe.moua...@gmail.com > wrote: > >> > >> > Hello, > >> > The issue with Get with body should be fixed now: > >> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60837 > >> > > >> > Regards > >> > Philippe > >> > > >> > On Wed, Mar 8, 2017 at 8:53 PM, Philippe Mouawad < > >> > philippe.moua...@gmail.com > >> > > wrote: > >> > > >> > > Hello Tuukka, > >> > > > >> > > In my recent tests I didn't face any issue with > httpclient4.retrycount. > >> > > For me it works but be aware that JMeter (HC4) does not retry all > >> > > requests, it only retries those it is allowed to : > >> > > - Idempotent HTTP methods which are by default those that do not > >> > implement > >> > > HttpEntityEnclosingRequest, so not POST, PUT,DELETE, PATCH, GET With > >> body > >> > > (<= That might be a bug thinking more about it) > >> > > - Non retriable exceptions (InterruptedIOException.class, > >> > > UnknownHostException.class, ConnectException.class, > >> SSLException.class) > >> > > - + Some other reasons > >> > > > >> > > See: > >> > > https://github.com/apache/httpclient/blob/4.5.x/ > >> > > httpclient/src/main/java/org/apache/http/impl/client/ > >> > > DefaultHttpRequestRetryHandler.java#L129 > >> > > > >> > > > >> > > Regards > >> > > Philippe > >> > > > >> > > > >> > > On Wed, Mar 8, 2017 at 2:14 PM, Tuukka Mustonen < > >> > tuukka.musto...@gmail.com > >> > > > wrote: > >> > > > >> > >> My problem is that AWS Application Load Balancer (ALB) terminates > all > >> > >> existing connections during configuration changes (including > >> > >> auto-scaling). > >> > >> As my perf tests trigger auto-scaling, I want to retry failed > requests > >> > >> that > >> > >> ALB connection termination causes. > >> > >> > >> > >> This results in a bunch of NoHttpResponseException whenever scaling > >> > occurs > >> > >> (=when ALB terminates existing connections). > >> > >> > >> > >> (And yeah, this load balancer behavior is weird and ugly but it's > what > >> > >> they > >> > >> confirmed). > >> > >> > >> > >> Using HttpClient 4, In user.properties I have set: > >> > >> > >> > >> httpclient4.retrycount=1 > >> > >> > >> > >> But that does nothing. I even tried: > >> > >> > >> > >> httpclient4.retrycount=1 > >> > >> > >> > >> But zero effect. > >> > >> > >> > >> Switching to HttpClient 3.1 reproduces the problem. However, with > >> > >> HttpClient 3 and: > >> > >> > >> > >> httpclient3.retrycount=1 > >> > >> > >> > >> The problem vanishes so I assume retrying then wo
RE: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
And SignIn.jmx definitely has a test fragment object at the parent level? -Original Message- From: Munaf Sheikh [mailto:mu...@virtrics.com] Sent: 09 March 2017 11:34 To: JMeter Users List Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest Hi, thanks for your response, I've just tried the same on JMeter 3.1. The error I see in both is the following: No test Fragment found 2017/03/09 13:32:00 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: G:\jmeter-investigation\SignIn.jmx 2017/03/09 13:32:00 INFO - jmeter.save.SaveService: Loading file: G:\jmeter-investigation\SignIn.jmx 2017/03/09 13:32:00 WARN - jmeter.control.IncludeController: No Test Fragment was found in included Test Plan, returning empty HashTree The SignIn.jmx file works when I run it by itself. Regards On Thu, 9 Mar 2017 at 13:26 Stuart Kenworthy wrote: > What exactly is the problem with the includes? > > Is it that the controllers are not recognised as a usable object or > they have lost the fragment they are including? > > Thanks > > -Original Message- > From: Felix Schumacher [mailto:felix.schumac...@internetallee.de] > Sent: 09 March 2017 11:20 > To: JMeter Users List > Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest > > > > Am 9. März 2017 12:03:51 MEZ schrieb Munaf Sheikh : > >Hi there, > > > >We have a large test suite of JMeter files written using version 2.9 > >(with Json Plugin). We're seeing various problems opening the test > >suite in JMeter 3.0. One issue is that the include controllers aren't > >working any more. > > > >Is this a known issue? Is there a work around? Or could I have done > >something wrong? > > We can't help you without detailed error messages. Have a look at the > log files. > > Latest JMeter version is 3.1. > > Include controllers as such should work. > > Regards, > Felix > > > > >Regards > > > >~M > > > > > >[image: Email Signature.png] > >-- > > - > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > For additional commands, e-mail: user-h...@jmeter.apache.org > > > The information included in this email and any files transmitted with > it may contain information that is confidential and it must not be > used by, or its contents or attachments copied or disclosed to, > persons other than the intended addressee. If you have received this > email in error, please notify BJSS. In the absence of written > agreement to the contrary BJSS' relevant standard terms of contract > for any work to be undertaken will apply. Please carry out virus or > such other checks as you consider appropriate in respect of this > email. BJSS does not accept responsibility for any adverse effect upon > your system or data in relation to this email or any files transmitted > with it. BJSS Limited, a company registered in England and Wales > (Company Number 2777575), VAT Registration Number 613295452, Registered > Office Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW. > > - > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > For additional commands, e-mail: user-h...@jmeter.apache.org > -- The information included in this email and any files transmitted with it may contain information that is confidential and it must not be used by, or its contents or attachments copied or disclosed to, persons other than the intended addressee. If you have received this email in error, please notify BJSS. In the absence of written agreement to the contrary BJSS' relevant standard terms of contract for any work to be undertaken will apply. Please carry out virus or such other checks as you consider appropriate in respect of this email. BJSS does not accept responsibility for any adverse effect upon your system or data in relation to this email or any files transmitted with it. BJSS Limited, a company registered in England and Wales (Company Number 2777575), VAT Registration Number 613295452, Registered Office Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW.
Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
Hi again, I replaced the controller in the included script with a test fragment and that seems to have solved that issue. Thanks for the hints. ~M On Thu, 9 Mar 2017 at 13:34 Munaf Sheikh wrote: Hi, thanks for your response, I've just tried the same on JMeter 3.1. The error I see in both is the following: No test Fragment found 2017/03/09 13:32:00 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: G:\jmeter-investigation\SignIn.jmx 2017/03/09 13:32:00 INFO - jmeter.save.SaveService: Loading file: G:\jmeter-investigation\SignIn.jmx 2017/03/09 13:32:00 WARN - jmeter.control.IncludeController: No Test Fragment was found in included Test Plan, returning empty HashTree The SignIn.jmx file works when I run it by itself. Regards On Thu, 9 Mar 2017 at 13:26 Stuart Kenworthy wrote: What exactly is the problem with the includes? Is it that the controllers are not recognised as a usable object or they have lost the fragment they are including? Thanks -Original Message- From: Felix Schumacher [mailto:felix.schumac...@internetallee.de] Sent: 09 March 2017 11:20 To: JMeter Users List Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest Am 9. März 2017 12:03:51 MEZ schrieb Munaf Sheikh : >Hi there, > >We have a large test suite of JMeter files written using version 2.9 >(with Json Plugin). We're seeing various problems opening the test >suite in JMeter 3.0. One issue is that the include controllers aren't >working any more. > >Is this a known issue? Is there a work around? Or could I have done >something wrong? We can't help you without detailed error messages. Have a look at the log files. Latest JMeter version is 3.1. Include controllers as such should work. Regards, Felix > >Regards > >~M > > >[image: Email Signature.png] >-- - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org The information included in this email and any files transmitted with it may contain information that is confidential and it must not be used by, or its contents or attachments copied or disclosed to, persons other than the intended addressee. If you have received this email in error, please notify BJSS. In the absence of written agreement to the contrary BJSS' relevant standard terms of contract for any work to be undertaken will apply. Please carry out virus or such other checks as you consider appropriate in respect of this email. BJSS does not accept responsibility for any adverse effect upon your system or data in relation to this email or any files transmitted with it. BJSS Limited, a company registered in England and Wales (Company Number 2777575), VAT Registration Number 613295452, Registered Office Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- --
Re: JMeter 3.1 httpclient4.retrycount does not work
On 9 March 2017 at 06:42, Philippe Mouawad wrote: > On Thursday, March 9, 2017, Tuukka Mustonen > wrote: > >> Hi Philippe and thanks for speedy actions! >> >> 1) Retrying only idempotent requests makes sense, as usual. But this (retry >> on idempotent) seems to be only documented on wiki page ( >> https://wiki.apache.org/jmeter/JMeterSocketClosed). You should add it also >> to http://jmeter.apache.org/usermanual/component_reference.html. >> >> 2) In this case, the requests are GETs (and without body) so they should be >> retried. > > Yes. > I debugged it and I confirm they are unless you face the exceptions I > mentionned. > >> >> So the bug you fixed shouldn't affect this scenario. > > Yes > >> >> There must be >> something else - any pointers to what logging module/level I should enable >> to inspect the (failing) retry logic? > > As you can see there is no logging in this HC4 class > Try the calling class. I' ll provide its name later > >> >> 3) AFAIK PUT is idempotent - shouldn't you retry also that? > > No it's not IMU, it changes state of server. PUT *is* idempotent. It may change the state of the server the first time it is sent, but subsequent PUTs should not change the state further. So it can be repeated as required. Similarly for DELETE https://tools.ietf.org/html/rfc2616#section-9.1.2 >> >> 4) In this case, once I add tests for POST/PATCH/DELETE etc. I also want to >> retry these non-idempotent requests (to tolerate ALBs ugly behavior). These >> are "just" performance tests so I don't care if I'm creating duplicate >> data. Is there way to specify custom method whitelist to retry any HTTP >> method? I see requestSentRetryEnabled in HC4 source code - can I enable >> that somehow? > > Not for now. > You case is a bit soecific no ? > >> >> 5) *Related question: >> is http.connection.stalecheck$Boolean=false (in hc.parameters file) valid >> anymore on JMeter 3.x with improved retry/stale logic >> (and httpclient4.validate_after_inactivity)? The line is still there in >> bundled hc.parameters file...* > > i'll double check > >> >> Tuukka >> >> >> On Thu, Mar 9, 2017 at 12:25 AM, Philippe Mouawad < >> philippe.moua...@gmail.com > wrote: >> >> > Hello, >> > The issue with Get with body should be fixed now: >> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60837 >> > >> > Regards >> > Philippe >> > >> > On Wed, Mar 8, 2017 at 8:53 PM, Philippe Mouawad < >> > philippe.moua...@gmail.com >> > > wrote: >> > >> > > Hello Tuukka, >> > > >> > > In my recent tests I didn't face any issue with httpclient4.retrycount. >> > > For me it works but be aware that JMeter (HC4) does not retry all >> > > requests, it only retries those it is allowed to : >> > > - Idempotent HTTP methods which are by default those that do not >> > implement >> > > HttpEntityEnclosingRequest, so not POST, PUT,DELETE, PATCH, GET With >> body >> > > (<= That might be a bug thinking more about it) >> > > - Non retriable exceptions (InterruptedIOException.class, >> > > UnknownHostException.class, ConnectException.class, >> SSLException.class) >> > > - + Some other reasons >> > > >> > > See: >> > > https://github.com/apache/httpclient/blob/4.5.x/ >> > > httpclient/src/main/java/org/apache/http/impl/client/ >> > > DefaultHttpRequestRetryHandler.java#L129 >> > > >> > > >> > > Regards >> > > Philippe >> > > >> > > >> > > On Wed, Mar 8, 2017 at 2:14 PM, Tuukka Mustonen < >> > tuukka.musto...@gmail.com >> > > > wrote: >> > > >> > >> My problem is that AWS Application Load Balancer (ALB) terminates all >> > >> existing connections during configuration changes (including >> > >> auto-scaling). >> > >> As my perf tests trigger auto-scaling, I want to retry failed requests >> > >> that >> > >> ALB connection termination causes. >> > >> >> > >> This results in a bunch of NoHttpResponseException whenever scaling >> > occurs >> > >> (=when ALB terminates existing connections). >> > >> >> > >> (And yeah, this load balancer behavior is weird and ugly but it's what >> > >> they >> > >> confirmed). >> > >> >> > >> Using HttpClient 4, In user.properties I have set: >> > >> >> > >> httpclient4.retrycount=1 >> > >> >> > >> But that does nothing. I even tried: >> > >> >> > >> httpclient4.retrycount=1 >> > >> >> > >> But zero effect. >> > >> >> > >> Switching to HttpClient 3.1 reproduces the problem. However, with >> > >> HttpClient 3 and: >> > >> >> > >> httpclient3.retrycount=1 >> > >> >> > >> The problem vanishes so I assume retrying then works. >> > >> >> > >> I couldn't find where retry-attempts are logged so I have no "proof" >> > that >> > >> HttpClient 4 wouldn't actually retry, but a) retrycount makes >> difference >> > >> on >> > >> HttpClient 3.1 but not on 4 b) I would assume my whole process should >> > >> crash >> > >> with retrycount=1 if it was really applied. >> > >> >> > >> Related question: is http.connection.stalecheck$Boolean=false (in >> > >> hc.parameters file) valid anymore on JMeter 3.x with improved >> > retr
Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
Hi, thanks for your response, I've just tried the same on JMeter 3.1. The error I see in both is the following: No test Fragment found 2017/03/09 13:32:00 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: G:\jmeter-investigation\SignIn.jmx 2017/03/09 13:32:00 INFO - jmeter.save.SaveService: Loading file: G:\jmeter-investigation\SignIn.jmx 2017/03/09 13:32:00 WARN - jmeter.control.IncludeController: No Test Fragment was found in included Test Plan, returning empty HashTree The SignIn.jmx file works when I run it by itself. Regards On Thu, 9 Mar 2017 at 13:26 Stuart Kenworthy wrote: > What exactly is the problem with the includes? > > Is it that the controllers are not recognised as a usable object or they > have lost the fragment they are including? > > Thanks > > -Original Message- > From: Felix Schumacher [mailto:felix.schumac...@internetallee.de] > Sent: 09 March 2017 11:20 > To: JMeter Users List > Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest > > > > Am 9. März 2017 12:03:51 MEZ schrieb Munaf Sheikh : > >Hi there, > > > >We have a large test suite of JMeter files written using version 2.9 > >(with Json Plugin). We're seeing various problems opening the test > >suite in JMeter 3.0. One issue is that the include controllers aren't > >working any more. > > > >Is this a known issue? Is there a work around? Or could I have done > >something wrong? > > We can't help you without detailed error messages. Have a look at the log > files. > > Latest JMeter version is 3.1. > > Include controllers as such should work. > > Regards, > Felix > > > > >Regards > > > >~M > > > > > >[image: Email Signature.png] > >-- > > - > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > For additional commands, e-mail: user-h...@jmeter.apache.org > > > The information included in this email and any files transmitted with it > may contain information that is confidential and it must not be used by, or > its contents or attachments copied or disclosed to, persons other than the > intended addressee. If you have received this email in error, please notify > BJSS. In the absence of written agreement to the contrary BJSS' relevant > standard terms of contract for any work to be undertaken will apply. Please > carry out virus or such other checks as you consider appropriate in respect > of this email. BJSS does not accept responsibility for any adverse effect > upon your system or data in relation to this email or any files transmitted > with it. BJSS Limited, a company registered in England and Wales (Company > Number 2777575), VAT Registration Number 613295452, Registered Office > Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW. > > - > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > For additional commands, e-mail: user-h...@jmeter.apache.org > --
RE: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
What exactly is the problem with the includes? Is it that the controllers are not recognised as a usable object or they have lost the fragment they are including? Thanks -Original Message- From: Felix Schumacher [mailto:felix.schumac...@internetallee.de] Sent: 09 March 2017 11:20 To: JMeter Users List Subject: Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest Am 9. März 2017 12:03:51 MEZ schrieb Munaf Sheikh : >Hi there, > >We have a large test suite of JMeter files written using version 2.9 >(with Json Plugin). We're seeing various problems opening the test >suite in JMeter 3.0. One issue is that the include controllers aren't >working any more. > >Is this a known issue? Is there a work around? Or could I have done >something wrong? We can't help you without detailed error messages. Have a look at the log files. Latest JMeter version is 3.1. Include controllers as such should work. Regards, Felix > >Regards > >~M > > >[image: Email Signature.png] >-- - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org The information included in this email and any files transmitted with it may contain information that is confidential and it must not be used by, or its contents or attachments copied or disclosed to, persons other than the intended addressee. If you have received this email in error, please notify BJSS. In the absence of written agreement to the contrary BJSS' relevant standard terms of contract for any work to be undertaken will apply. Please carry out virus or such other checks as you consider appropriate in respect of this email. BJSS does not accept responsibility for any adverse effect upon your system or data in relation to this email or any files transmitted with it. BJSS Limited, a company registered in England and Wales (Company Number 2777575), VAT Registration Number 613295452, Registered Office Address, First Floor, Coronet House, Queen Street, Leeds, LS1 2TW. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
Am 9. März 2017 12:03:51 MEZ schrieb Munaf Sheikh : >Hi there, > >We have a large test suite of JMeter files written using version 2.9 >(with >Json Plugin). We're seeing various problems opening the test suite in >JMeter 3.0. One issue is that the include controllers aren't working >any >more. > >Is this a known issue? Is there a work around? Or could I have done >something wrong? We can't help you without detailed error messages. Have a look at the log files. Latest JMeter version is 3.1. Include controllers as such should work. Regards, Felix > >Regards > >~M > > >[image: Email Signature.png] >-- - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Upgrading Jmeter scripts from 2.9 (with JSON) to Latest
Hi there, We have a large test suite of JMeter files written using version 2.9 (with Json Plugin). We're seeing various problems opening the test suite in JMeter 3.0. One issue is that the include controllers aren't working any more. Is this a known issue? Is there a work around? Or could I have done something wrong? Regards ~M [image: Email Signature.png] --