Re: Patch for stopping karaf

[dieder]

Hi JB,

Thanx very much for the info, we are running 4.3.6 on windows as a 
service. I've noticed the karaf.bat stop command is using the class:
org.apache.karaf.main.Stop. This is called from the service wrapper on 
windows.
This class is still calling a loopback port with the 'stop-command-uuid' 
 (this is where I've found the issue).


Looking at the code I see it also has an option to stop karaf using the 
pidfile. I will try what happens on windows when I remove the property 
karaf.shutdown.port.file and set karaf.shutdown.port to 0.
We migrated that from the old project, but if we can use the PID it will 
be safer and more stable.


I will still create a pull request for the issue so that if other users 
have the explicit need to use the stop loopback (or remote shutdown) it 
will be more stable.


kind regards
  Dieder Timmers


Jean-Baptiste Onofré schreef op 2023-03-29 08:48:

Hi,

some info:
1. for security reason, the command loopback port has been disabled
while ago. It now use the PID.
2. which version are you using?

Regards
JB

On Mon, Mar 27, 2023 at 11:50 AM dieder  wrote:


Hi All,

Recently I restarted using Karaf. We got an old project and started
upgrading it.
Now I think I've discovered a bug in shutting down Karaf from the
loopback port. Sometimes Karaf does not stop after issuing the stop
command. I've analyzed it and created a fix. Now I'd like to follow 
the
correct path for submitting a Jira issue and after that al pull 
request.

However I cannot seem to get approved for the Jira. I've requested
access last week and still no response.
What is the best way forward, retry to get on jira or create a pull
request for the fix (without an issue that feels ugly).

kind regards
   Dieder Timmers

Re: Patch for stopping karaf

[dieder]

Hi,

I could be wrong but looking at the code a bit more and downloading the 
karaf 4.4.3 binary distribution the default setting for the karaf 
shutdown is using loopback.

the config.properties still defines the property:
karaf.shutdown.port.file
The default configuration results in the creation of a listening 
loopback shutdown port. Shouldn't we change the default configuration to 
use the PID. I've tested this and it works correctly if I remove the 
karaf.shutdown.port.file property.


kind regards
  Dieder Timmers



Jean-Baptiste Onofré schreef op 2023-03-29 08:48:

Hi,

some info:
1. for security reason, the command loopback port has been disabled
while ago. It now use the PID.
2. which version are you using?

Regards
JB

On Mon, Mar 27, 2023 at 11:50 AM dieder  wrote:


Hi All,

Recently I restarted using Karaf. We got an old project and started
upgrading it.
Now I think I've discovered a bug in shutting down Karaf from the
loopback port. Sometimes Karaf does not stop after issuing the stop
command. I've analyzed it and created a fix. Now I'd like to follow 
the
correct path for submitting a Jira issue and after that al pull 
request.

However I cannot seem to get approved for the Jira. I've requested
access last week and still no response.
What is the best way forward, retry to get on jira or create a pull
request for the fix (without an issue that feels ugly).

kind regards
   Dieder Timmers