Re: Is LoadAwareShuffleGrouping The Default?

2016-11-22 Thread Kevin Peek
My apologies, the code I referenced above is old. I believe the correct
references are these:

https://github.com/apache/storm/blob/cd5c9e8f904205a6ca6eee9222ca954ca8b37ec3/storm-core/src/jvm/org/apache/storm/daemon/GrouperFactory.java#L63

https://github.com/apache/storm/blob/master/conf/defaults.yaml#L261

Based on these, I believe the LoadAwareShuffleGrouping is the default. Can
anyone more familiar with the code confirm this?

On Tue, Nov 22, 2016 at 11:43 AM, Kevin Peek <kp...@salesforce.com> wrote:

> Hello. I have a question about the load aware shuffle grouping.
>
> If I create a grouping like below, will I end up with a
> LoadAwareShuffleGrouping by default?
>
> topologyBuilder.setBolt("boltId", new SomeBolt()).shuffleGrouping("
> otherBoltId");
>
> I would expect this to result in a traditional ShuffleGrouping, but I
> think it does not based on the following:
>
> (1) the config option TOPOLOGY-DISABLE-LOADAWARE-MESSAGING defaults to
> false.
> (2) This block of code seems to create a LoadAwareShuffleGrouping
> automatically if load messaging is enabled (the default).
> https://github.com/revans2/incubator-storm/blob/
> 024ff263800e4032d7b2395fbbf072e0183ebb5b/storm-core/src/clj/
> backtype/storm/daemon/executor.clj#L66
>
>
> Is this correct? Is load aware the default behavior in Storm 1.0.x?
>


Is LoadAwareShuffleGrouping The Default?

2016-11-22 Thread Kevin Peek
Hello. I have a question about the load aware shuffle grouping.

If I create a grouping like below, will I end up with a
LoadAwareShuffleGrouping by default?

topologyBuilder.setBolt("boltId", new
SomeBolt()).shuffleGrouping("otherBoltId");

I would expect this to result in a traditional ShuffleGrouping, but I think
it does not based on the following:

(1) the config option TOPOLOGY-DISABLE-LOADAWARE-MESSAGING defaults to
false.
(2) This block of code seems to create a LoadAwareShuffleGrouping
automatically if load messaging is enabled (the default).
https://github.com/revans2/incubator-storm/blob/024ff263800e4032d7b2395fbbf072e0183ebb5b/storm-core/src/clj/backtype/storm/daemon/executor.clj#L66


Is this correct? Is load aware the default behavior in Storm 1.0.x?