Re: Struts 2.1.8 + SiteMesh 2.4.2 + FreeMarkerPageFilter Broken

2009-10-02 Thread Scott Hong

As suggested, the following issue has been created.

https://issues.apache.org/struts/browse/WW-3275


Musachy Barroso wrote:
> 
> can you please file a jira ticket with the details?
> 
> thanks
> musachy
> 
> On Fri, Oct 2, 2009 at 12:52 PM, Scott Hong  wrote:
>>
>>
>> The dependency of Struts 2.1.8 on SiteMesh 2.4.2 breaks
>> FreeMarkerPageFilter
>> as a decorator.
>>
>> If the web.xml is setup as follows and using Freemarker as the SiteMesh
>> decorator,
>> sitemesh cannot render the decorated page properly. After tracking down
>> the
>> source,
>> the root cause of the issue is that the PageFilter in deprecated and
>> SiteMesh developer
>> have to force existing application to use the new SiteMeshFilter by using
>> the following
>> implementation!!! This deprecated change seems to be heavy handed on the
>> SiteMesh
>> side!
>>
>> public class PageFilter extends SiteMeshFilter {
>> }
>>
>> One solution is to use older version of sitemesh (2.2.1) and it would
>> work
>> normally.
>> Until "struts-sitemesh-plugin" is updated to address this issue either by
>> moving the
>> old SiteMesh 2.2.1's implementation of PageFilter or fixed current
>> implementation
>> using the new SiteMeshFilter.
>>
>> web.xml setup...
>>
>>    
>>        struts-cleanup
>>
>> org.apache.struts2.dispatcher.ActionContextCleanUp
>>    
>>    
>>        sitemesh
>>
>> org.apache.struts2.sitemesh.FreeMarkerPageFilter
>>    
>>    
>>        struts
>>
>> org.apache.struts2.dispatcher.FilterDispatcher
>>        
>>            actionPackages
>>            org.acme.*Action
>>        
>>    
>>    
>>        struts-cleanup
>>        /*
>>        REQUEST
>>        FORWARD
>>    
>>    
>>        sitemesh
>>        /*
>>        REQUEST
>>        FORWARD
>>        INCLUDE
>>    
>>    
>>        struts
>>        /*
>>        REQUEST
>>        FORWARD
>>    
>>
>> -- Scott
>> --
>> View this message in context:
>> http://www.nabble.com/Struts-2.1.8-%2B-SiteMesh-2.4.2-%2B-FreeMarkerPageFilter-Broken-tp25721587p25721587.html
>> Sent from the Struts - User mailing list archive at Nabble.com.
>>
>>
>> -
>> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
>> For additional commands, e-mail: user-h...@struts.apache.org
>>
>>
> 
> 
> 
> -- 
> "Hey you! Would you help me to carry the stone?" Pink Floyd
> 
> -
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
> 
> 
> 

-- 
View this message in context: 
http://www.nabble.com/Struts-2.1.8-%2B-SiteMesh-2.4.2-%2B-FreeMarkerPageFilter-Broken-tp25721587p25724696.html
Sent from the Struts - User mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org



Re: Struts 2.1.8 + SiteMesh 2.4.2 + FreeMarkerPageFilter Broken

2009-10-02 Thread Musachy Barroso
can you please file a jira ticket with the details?

thanks
musachy

On Fri, Oct 2, 2009 at 12:52 PM, Scott Hong  wrote:
>
>
> The dependency of Struts 2.1.8 on SiteMesh 2.4.2 breaks FreeMarkerPageFilter
> as a decorator.
>
> If the web.xml is setup as follows and using Freemarker as the SiteMesh
> decorator,
> sitemesh cannot render the decorated page properly. After tracking down the
> source,
> the root cause of the issue is that the PageFilter in deprecated and
> SiteMesh developer
> have to force existing application to use the new SiteMeshFilter by using
> the following
> implementation!!! This deprecated change seems to be heavy handed on the
> SiteMesh
> side!
>
> public class PageFilter extends SiteMeshFilter {
> }
>
> One solution is to use older version of sitemesh (2.2.1) and it would work
> normally.
> Until "struts-sitemesh-plugin" is updated to address this issue either by
> moving the
> old SiteMesh 2.2.1's implementation of PageFilter or fixed current
> implementation
> using the new SiteMeshFilter.
>
> web.xml setup...
>
>    
>        struts-cleanup
>
> org.apache.struts2.dispatcher.ActionContextCleanUp
>    
>    
>        sitemesh
>
> org.apache.struts2.sitemesh.FreeMarkerPageFilter
>    
>    
>        struts
>
> org.apache.struts2.dispatcher.FilterDispatcher
>        
>            actionPackages
>            org.acme.*Action
>        
>    
>    
>        struts-cleanup
>        /*
>        REQUEST
>        FORWARD
>    
>    
>        sitemesh
>        /*
>        REQUEST
>        FORWARD
>        INCLUDE
>    
>    
>        struts
>        /*
>        REQUEST
>        FORWARD
>    
>
> -- Scott
> --
> View this message in context: 
> http://www.nabble.com/Struts-2.1.8-%2B-SiteMesh-2.4.2-%2B-FreeMarkerPageFilter-Broken-tp25721587p25721587.html
> Sent from the Struts - User mailing list archive at Nabble.com.
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
>
>



-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org