Re: [uml-devel] Re: SKAS0 test tree against 2.6.12
On Friday 08 July 2005 12:29, antoine wrote: > > Ok, it's there. I've simply adapted the two SKAS0 patches for 2.6.12 > > (backporting a cleanup and fixing some trivial rejects). More info at the > > web page. > > > > Testing is welcome. In particular, any regression in SKAS3 mode should be > > prompty reported to me and Jeff, because they are not expected at all. > > > > I'll add a simplified "proc_mm=0" switch (it's not the Bodo's patch > > because that is more intrusive and splits that further into proc_mm and > > faultinfo switches). > Don't know if you're interested in this report but it does not build for > x86_64: > SYMLINK arch/um/sys-x86_64/semaphore.c > CC arch/um/sys-x86_64/semaphore.o > CC arch/um/sys-x86_64/sigcontext.o > CC arch/um/sys-x86_64/signal.o > arch/um/sys-x86_64/signal.c: In function ‘setup_signal_stack_si’: > arch/um/sys-x86_64/signal.c:171: error: invalid lvalue in assignment > make[1]: *** [arch/um/sys-x86_64/signal.o] Error 1 > make: *** [arch/um/sys-x86_64] Error 2 I remember this report, only I just suggested the fix and didn't post it (was busy at that time). It's SKAS0 - unrelated I think (I may be wrong, but the whole patchset does not include it) but triggered by GCC4. > Could you include the pcap patch in bb? Yes, I'll do. > Thanks > Antoine -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade This is refused by GCC 4, so here's the fix. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- vanilla-linux-2.6.12-paolo/arch/um/sys-x86_64/signal.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/um/sys-x86_64/signal.c~uml-fix-for-gcc4-lvalue arch/um/sys-x86_64/signal.c --- vanilla-linux-2.6.12/arch/um/sys-x86_64/signal.c~uml-fix-for-gcc4-lvalue 2005-07-09 12:02:27.0 +0200 +++ vanilla-linux-2.6.12-paolo/arch/um/sys-x86_64/signal.c 2005-07-09 12:02:51.0 +0200 @@ -168,7 +168,7 @@ int setup_signal_stack_si(unsigned long frame = (struct rt_sigframe __user *) round_down(stack_top - sizeof(struct rt_sigframe), 16) - 8; - ((unsigned char *) frame) -= 128; + frame -= 128 / sizeof(frame); if (!access_ok(VERIFY_WRITE, fp, sizeof(struct _fpstate))) goto out; _
[uml-devel] [patch 1/1] uml: fix lvalue for gcc4
This construct is refused by GCC 4, so here's the fix. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- linux-2.6.git-paolo/arch/um/sys-x86_64/signal.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/um/sys-x86_64/signal.c~uml-fix-for-gcc4-lvalue arch/um/sys-x86_64/signal.c --- linux-2.6.git/arch/um/sys-x86_64/signal.c~uml-fix-for-gcc4-lvalue 2005-07-09 13:01:03.0 +0200 +++ linux-2.6.git-paolo/arch/um/sys-x86_64/signal.c 2005-07-09 13:01:03.0 +0200 @@ -168,7 +168,7 @@ int setup_signal_stack_si(unsigned long frame = (struct rt_sigframe __user *) round_down(stack_top - sizeof(struct rt_sigframe), 16) - 8; - ((unsigned char *) frame) -= 128; + frame -= 128 / sizeof(frame); if (!access_ok(VERIFY_WRITE, fp, sizeof(struct _fpstate))) goto out; _ --- This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar ___ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
[uml-devel] Re: [patch 1/1] uml: fix lvalue for gcc4
On Sat, Jul 09, 2005 at 01:01:33PM +0200, [EMAIL PROTECTED] wrote: > diff -puN arch/um/sys-x86_64/signal.c~uml-fix-for-gcc4-lvalue > arch/um/sys-x86_64/signal.c > --- linux-2.6.git/arch/um/sys-x86_64/signal.c~uml-fix-for-gcc4-lvalue > 2005-07-09 13:01:03.0 +0200 > +++ linux-2.6.git-paolo/arch/um/sys-x86_64/signal.c 2005-07-09 > 13:01:03.0 +0200 > @@ -168,7 +168,7 @@ int setup_signal_stack_si(unsigned long > > frame = (struct rt_sigframe __user *) > round_down(stack_top - sizeof(struct rt_sigframe), 16) - 8; > - ((unsigned char *) frame) -= 128; > + frame -= 128 / sizeof(frame); Are you sure these two are identical? The above code fragment looks suspicious anyway, particularly: frame = (struct rt_sigframe __user *) round_down(stack_top - sizeof(struct rt_sigframe), 16) - 8; which will put the frame at 8 * sizeof(struct rt_sigframe) below the point which round_down() would return (which would be 1 struct rt_sigframe below stack_top, rounded down). -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core --- This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar ___ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
[uml-devel] [Bug 49277] Compile of usermode-sources-2.6.x fails
Clear-Text: http://bugs.gentoo.org/show_bug.cgi?id=49277 Secure: https://bugs.gentoo.org/show_bug.cgi?id=49277 --- Additional Comments From [EMAIL PROTECTED] 2005-07-09 15:41 PDT --- (In reply to comment #52) > usermode-sources-2.6.12 is in portage. Please test it (see comment #51) as it > should solve the NPTL issues. Hi, I'm using glibc-2.3.4.20041102-r1 compiled with the USE="nptl nptlonly". Finally i was able to build an uml kernel from the source with this "mix"!!! i patched the host kernel (gentoo-sources-2.6.12-r4) with this patch: http://www.user-mode-linux.org/~blaisorblade/patches/skas3-2.6/skas-2.6.12-rc4-v9-pre4/skas-2.6.12-rc4-v9-pre4.patch.bz2 then i emerged the usermode-sources-2.6.12 and in the kernel configuration i disabled CONFIG_MODE_TT and enabled CONFIG_SKAS (see comment #41 by BlaisorBlade) NOTE1: when CONFIG_MODE_TT is disabled in the guest kernel (uml) the host kernel must be patched with the skas patch. NOTE2: i would like to thank you all! :D my emerge info: - Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.5-20050130, glibc-2.3.4.20041102-r1, 2.6.12-gentoo-r4-skas3-v9-pre4 i686) = System uname: 2.6.12-gentoo-r4-skas3-v9-pre4 i686 Intel(R) Pentium(R) 4 CPU 2.53GHz Gentoo Base System version 1.6.12 Python: dev-lang/python-2.3.5 [2.3.5 (#1, Apr 28 2005, 17:46:54)] dev-lang/python: 2.3.5 sys-apps/sandbox:[Not Present] sys-devel/autoconf: 2.59-r6, 2.13 sys-devel/automake: 1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.5 sys-devel/binutils: 2.15.92.0.2-r10 sys-devel/libtool: 1.5.18-r1 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CFLAGS="-march=pentium4 -O2 -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d" CXXFLAGS="-O2 -mcpu=i686 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms strict" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/Linux/distributions/gentoo"; LANG="[EMAIL PROTECTED]" LINGUAS="it" MAKEOPTS="-j1" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync1.it.gentoo.org/gentoo-portage" USE="x86 X aalib acpi alsa apm arts avi berkdb bitmap-fonts cdr crypt cups curl dvd dvdr emboss encode esd fam flac foomaticdb fortran gdbm gif gnome gpm gtk gtk2 imagemagick imlib ipv6 java jpeg junit kde libg++ libwww mad mikmod mmx motif mp3 mpeg mysql ncurses nls nptl nptlonly odbc ogg oggvorbis opengl oss pam pdflib perl png python qt quicktime readline samba sdl slang spell ssl svga tcpd tiff truetype truetype-fonts type1-fonts unicode usb vorbis xine xinerama xml xml2 xmms xv zlib linguas_it userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS -- Configure bugmail: http://bugs.gentoo.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. --- This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar ___ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
