Re: warning on startup of consumer app with 0.8.2 rc2
The issue with embedding the version in the code is that you have to update the version in two places, the build script and the code. Thanks, Jun On Sun, Jan 25, 2015 at 7:05 PM, Jason Rosenberg j...@squareup.com wrote: I don't think it's really unusual for deployment environments to produce single shaded jars for an app. Thus, I'm wondering if we can't rethink this here? E.g. just have a constant in code which states the version? Rather than emit the confusing warning, especially for client apps? Jason On Fri, Jan 23, 2015 at 5:24 PM, Jun Rao j...@confluent.io wrote: The only impact is that you don't get the mbean that tells you the version of the jar. That's why it's just a warning. Thanks, Jun On Fri, Jan 23, 2015 at 1:04 PM, Jason Rosenberg j...@squareup.com wrote: What are the ramifications if it can't find the version? It looks like it uses it set a yammer Gauge metric. Anything more than that? Jason On Fri, Jan 23, 2015 at 3:24 PM, Jun Rao j...@confluent.io wrote: Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
Or you could have your build generate a static constant class from the build version. On Mon, Jan 26, 2015 at 12:06 AM, Jun Rao j...@confluent.io wrote: The issue with embedding the version in the code is that you have to update the version in two places, the build script and the code. Thanks, Jun On Sun, Jan 25, 2015 at 7:05 PM, Jason Rosenberg j...@squareup.com wrote: I don't think it's really unusual for deployment environments to produce single shaded jars for an app. Thus, I'm wondering if we can't rethink this here? E.g. just have a constant in code which states the version? Rather than emit the confusing warning, especially for client apps? Jason On Fri, Jan 23, 2015 at 5:24 PM, Jun Rao j...@confluent.io wrote: The only impact is that you don't get the mbean that tells you the version of the jar. That's why it's just a warning. Thanks, Jun On Fri, Jan 23, 2015 at 1:04 PM, Jason Rosenberg j...@squareup.com wrote: What are the ramifications if it can't find the version? It looks like it uses it set a yammer Gauge metric. Anything more than that? Jason On Fri, Jan 23, 2015 at 3:24 PM, Jun Rao j...@confluent.io wrote: Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
That maybe possible. Do you want to file a jira to track this? Thanks, Jun On Sun, Jan 25, 2015 at 9:56 PM, Jason Rosenberg j...@squareup.com wrote: Or you could have your build generate a static constant class from the build version. On Mon, Jan 26, 2015 at 12:06 AM, Jun Rao j...@confluent.io wrote: The issue with embedding the version in the code is that you have to update the version in two places, the build script and the code. Thanks, Jun On Sun, Jan 25, 2015 at 7:05 PM, Jason Rosenberg j...@squareup.com wrote: I don't think it's really unusual for deployment environments to produce single shaded jars for an app. Thus, I'm wondering if we can't rethink this here? E.g. just have a constant in code which states the version? Rather than emit the confusing warning, especially for client apps? Jason On Fri, Jan 23, 2015 at 5:24 PM, Jun Rao j...@confluent.io wrote: The only impact is that you don't get the mbean that tells you the version of the jar. That's why it's just a warning. Thanks, Jun On Fri, Jan 23, 2015 at 1:04 PM, Jason Rosenberg j...@squareup.com wrote: What are the ramifications if it can't find the version? It looks like it uses it set a yammer Gauge metric. Anything more than that? Jason On Fri, Jan 23, 2015 at 3:24 PM, Jun Rao j...@confluent.io wrote: Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
I don't think it's really unusual for deployment environments to produce single shaded jars for an app. Thus, I'm wondering if we can't rethink this here? E.g. just have a constant in code which states the version? Rather than emit the confusing warning, especially for client apps? Jason On Fri, Jan 23, 2015 at 5:24 PM, Jun Rao j...@confluent.io wrote: The only impact is that you don't get the mbean that tells you the version of the jar. That's why it's just a warning. Thanks, Jun On Fri, Jan 23, 2015 at 1:04 PM, Jason Rosenberg j...@squareup.com wrote: What are the ramifications if it can't find the version? It looks like it uses it set a yammer Gauge metric. Anything more than that? Jason On Fri, Jan 23, 2015 at 3:24 PM, Jun Rao j...@confluent.io wrote: Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
The only impact is that you don't get the mbean that tells you the version of the jar. That's why it's just a warning. Thanks, Jun On Fri, Jan 23, 2015 at 1:04 PM, Jason Rosenberg j...@squareup.com wrote: What are the ramifications if it can't find the version? It looks like it uses it set a yammer Gauge metric. Anything more than that? Jason On Fri, Jan 23, 2015 at 3:24 PM, Jun Rao j...@confluent.io wrote: Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
What are the ramifications if it can't find the version? It looks like it uses it set a yammer Gauge metric. Anything more than that? Jason On Fri, Jan 23, 2015 at 3:24 PM, Jun Rao j...@confluent.io wrote: Yes, that's probably the issue. If you repackage the Kafka jar, you need to include the following in the repacked jar that was included in the original Kafka jar. Our code looks for version info from there. META-INF/ META-INF/MANIFEST.MF Thanks, Jun On Fri, Jan 23, 2015 at 11:59 AM, Jason Rosenberg j...@squareup.com wrote: In this case, we have a single shaded jar for our app for deployment (so just 1 jar on the classpath). Could that be the issue? E.g. all dependent jars are unpacked into a single jar within our deployment system On Thu, Jan 22, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote: Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
Re: warning on startup of consumer app with 0.8.2 rc2
Hmm, kafka-console-consumer in 0.8.2 rc2 is running fine. Do you have multiple kafka jars in your classpath? Thanks, Jun On Thu, Jan 22, 2015 at 4:58 PM, Jason Rosenberg j...@squareup.com wrote: 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
warning on startup of consumer app with 0.8.2 rc2
2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
