Re: [OMPI users] bug in MPI_Cart_create?

2009-10-26 Thread Jeff Squyres
I can confirm that it is fixed on both the trunk and will be included  
in the upcoming 1.3.4 release.  The code now reads:


re_order = (0 == reorder)? false : true;

Thanks for the heads-up!


On Oct 26, 2009, at 6:40 AM, Kiril Dichev wrote:


Hi David,

I believe this particular bug was fixed in the trunk some weeks ago
shortly before your post.

Regards,
Kiril

On Tue, 2009-10-13 at 17:54 +1100, David Singleton wrote:
> Looking back through the archives, a lot of people have hit error
> messages like
>
>  > [bl302:26556] *** An error occurred in MPI_Cart_create
>  > [bl302:26556] *** on communicator MPI_COMM_WORLD
>  > [bl302:26556] *** MPI_ERR_ARG: invalid argument of some other  
kind
>  > [bl302:26556] *** MPI_ERRORS_ARE_FATAL (your MPI job will now  
abort)

>
> One of the reasons people *may* be hitting this is what I believe to
> be an incorrect test in MPI_Cart_create():
>
>  if (0 > reorder || 1 < reorder) {
>  return OMPI_ERRHANDLER_INVOKE (old_comm, MPI_ERR_ARG,
>FUNC_NAME);
>  }
>
> reorder is a "logical" argument and "2.5.2 C bindings" in the MPI  
1.3

> standard says:
>
>  Logical flags are integers with value 0 meaning “false” and a
>  non-zero value meaning “true.”
>
> So I'm not sure there should be any argument test.
>
>
> We hit this because we (sorta erroneously) were trying to use a  
GNU build
> of Open MPI with Intel compilers.  gfortran has true=1 while ifort  
has
> true=-1.  It seems to all work (by luck, I know) except this  
test.  Are

> there any other tests like this in Open MPI?
>
> David
> ___
> users mailing list
> us...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/users
--
Dipl.-Inf. Kiril Dichev
Tel.: +49 711 685 60492
E-mail: dic...@hlrs.de
High Performance Computing Center Stuttgart (HLRS)
Universität Stuttgart
70550 Stuttgart
Germany


___
users mailing list
us...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/users




--
Jeff Squyres
jsquy...@cisco.com




[OMPI users] bug in MPI_Cart_create?

2009-10-13 Thread David Singleton


Looking back through the archives, a lot of people have hit error
messages like

> [bl302:26556] *** An error occurred in MPI_Cart_create
> [bl302:26556] *** on communicator MPI_COMM_WORLD
> [bl302:26556] *** MPI_ERR_ARG: invalid argument of some other kind
> [bl302:26556] *** MPI_ERRORS_ARE_FATAL (your MPI job will now abort)

One of the reasons people *may* be hitting this is what I believe to
be an incorrect test in MPI_Cart_create():

if (0 > reorder || 1 < reorder) {
return OMPI_ERRHANDLER_INVOKE (old_comm, MPI_ERR_ARG,
  FUNC_NAME);
}

reorder is a "logical" argument and "2.5.2 C bindings" in the MPI 1.3
standard says:

Logical flags are integers with value 0 meaning “false” and a
non-zero value meaning “true.”

So I'm not sure there should be any argument test.


We hit this because we (sorta erroneously) were trying to use a GNU build
of Open MPI with Intel compilers.  gfortran has true=1 while ifort has
true=-1.  It seems to all work (by luck, I know) except this test.  Are
there any other tests like this in Open MPI?

David