Re: [OpenSIPS-Users] Problem with uac_replace_from
Hi Steven, The reason for not storing/restoring the display name is simple: this information has no value in regards to the SIP dialog (it does not affect or interfere with the dialog state, as the FROM URI does) and it is used only in the initial invites - to be displayed when receiving a call ; in the sequential requests, it is not used at all. A good practice (or at least what we do on our systems) is to delete the display name in the sequential requests if the display in initial invite was changed (more for privacy purposes). Regards, Bogdan On 02/17/2012 11:26 AM, Steven Lam, KeenSystems B.V. wrote: I think this behavior is wrong, if the function has the feature to overrule the display it should behave the same as any other feature the function has. If there are some good reasons why this is not the case it should be mentioned in the documentation is think. -- Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users
Re: [OpenSIPS-Users] Problem with uac_replace_from
Hello, In the current implementation, the display name is current not saved, and obviously, not restored. Regards, Vlad Paiu OpenSIPS Developer http://www.opensips-solutions.com On 02/17/2012 11:26 AM, Steven Lam, KeenSystems B.V. wrote: Hi, Thank you for your answer! You are right, this is what I discovered. I think this behavior is wrong, if the function has the feature to overrule the display it should behave the same as any other feature the function has. If there are some good reasons why this is not the case it should be mentioned in the documentation is think. Do you know IF there is a good reason for not storing the overruled display? Steven -Original Message- From: users-boun...@lists.opensips.org [mailto:users- boun...@lists.opensips.org] On Behalf Of Razvan Crainea Sent: vrijdag 17 februari 2012 9:26 To: users@lists.opensips.org Subject: Re: [OpenSIPS-Users] Problem with uac_replace_from Hi, Steven! The dialog module only stores the TO and FROM URIs, not the display names. Also, the uac_replace_from function keeps track only of the URIs. Therefore, the display names are ignored and they will not be automatically restored on any sequential requests. Regards, -- Răzvan Crainea OpenSIPS Developer http://www.opensips-solutions.com On 02/16/2012 07:08 PM, Steven Lam, KeenSystems B.V. wrote: Hi, Replying to myself... Also looking at the "opensipsctl fifo dlg_list_ctx" output I can see only the changed uri is stored in the dialog. Should the display not be stored? or am I missing something here? Steven -Original Message- From: users-boun...@lists.opensips.org [mailto:users- boun...@lists.opensips.org] On Behalf Of Steven Lam, KeenSystems B.V. Sent: donderdag 16 februari 2012 17:49 To: users@lists.opensips.org Subject: [OpenSIPS-Users] Problem with uac_replace_from Hi list! When playing with uac_replace_from to replace both display and uri like this: uac_replace_from("anonymous","sip:anonymous@anonymous.invalid"); I found that on subsequential (ACK) messages only the uri was changed again and display had the original value. Also when using uac_replace_from to replace only uri and remove display like this: uac_replace_from("","sip:anonymous@anonymous.invalid"); On subsequential (ACK) messages the uri is changed as expected but display had the original value. To me this looks wrong. Steven ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users
Re: [OpenSIPS-Users] Problem with uac_replace_from
Hi, Thank you for your answer! You are right, this is what I discovered. I think this behavior is wrong, if the function has the feature to overrule the display it should behave the same as any other feature the function has. If there are some good reasons why this is not the case it should be mentioned in the documentation is think. Do you know IF there is a good reason for not storing the overruled display? Steven > -Original Message- > From: users-boun...@lists.opensips.org [mailto:users- > boun...@lists.opensips.org] On Behalf Of Razvan Crainea > Sent: vrijdag 17 februari 2012 9:26 > To: users@lists.opensips.org > Subject: Re: [OpenSIPS-Users] Problem with uac_replace_from > > Hi, Steven! > > The dialog module only stores the TO and FROM URIs, not the display names. > Also, the uac_replace_from function keeps track only of the URIs. > Therefore, the display names are ignored and they will not be automatically > restored on any sequential requests. > > Regards, > > -- > Răzvan Crainea > OpenSIPS Developer > http://www.opensips-solutions.com > > > On 02/16/2012 07:08 PM, Steven Lam, KeenSystems B.V. wrote: > > Hi, > > > > Replying to myself... > > > > Also looking at the "opensipsctl fifo dlg_list_ctx" output I can see only > > the > changed uri is stored in the dialog. > > > > Should the display not be stored? or am I missing something here? > > > > Steven > > > >> -Original Message- > >> From: users-boun...@lists.opensips.org [mailto:users- > >> boun...@lists.opensips.org] On Behalf Of Steven Lam, KeenSystems B.V. > >> Sent: donderdag 16 februari 2012 17:49 > >> To: users@lists.opensips.org > >> Subject: [OpenSIPS-Users] Problem with uac_replace_from > >> > >> Hi list! > >> > >> When playing with uac_replace_from to replace both display and uri like > this: > >> > uac_replace_from("anonymous","sip:anonymous@anonymous.invalid"); > >> I found that on subsequential (ACK) messages only the uri was changed > >> again and display had the original value. > >> > >> Also when using uac_replace_from to replace only uri and remove > >> display like this: > >> uac_replace_from("","sip:anonymous@anonymous.invalid"); > >> On subsequential (ACK) messages the uri is changed as expected but > >> display had the original value. > >> > >> To me this looks wrong. > >> > >> Steven > >> > >> > >> ___ > >> Users mailing list > >> Users@lists.opensips.org > >> http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > > > > > ___ > > Users mailing list > > Users@lists.opensips.org > > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > ___ > Users mailing list > Users@lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users
Re: [OpenSIPS-Users] Problem with uac_replace_from
Hi, Steven! The dialog module only stores the TO and FROM URIs, not the display names. Also, the uac_replace_from function keeps track only of the URIs. Therefore, the display names are ignored and they will not be automatically restored on any sequential requests. Regards, -- Răzvan Crainea OpenSIPS Developer http://www.opensips-solutions.com On 02/16/2012 07:08 PM, Steven Lam, KeenSystems B.V. wrote: Hi, Replying to myself... Also looking at the "opensipsctl fifo dlg_list_ctx" output I can see only the changed uri is stored in the dialog. Should the display not be stored? or am I missing something here? Steven -Original Message- From: users-boun...@lists.opensips.org [mailto:users- boun...@lists.opensips.org] On Behalf Of Steven Lam, KeenSystems B.V. Sent: donderdag 16 februari 2012 17:49 To: users@lists.opensips.org Subject: [OpenSIPS-Users] Problem with uac_replace_from Hi list! When playing with uac_replace_from to replace both display and uri like this: uac_replace_from("anonymous","sip:anonymous@anonymous.invalid"); I found that on subsequential (ACK) messages only the uri was changed again and display had the original value. Also when using uac_replace_from to replace only uri and remove display like this: uac_replace_from("","sip:anonymous@anonymous.invalid"); On subsequential (ACK) messages the uri is changed as expected but display had the original value. To me this looks wrong. Steven ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users
Re: [OpenSIPS-Users] Problem with uac_replace_from
Hi, Replying to myself... Also looking at the "opensipsctl fifo dlg_list_ctx" output I can see only the changed uri is stored in the dialog. Should the display not be stored? or am I missing something here? Steven > -Original Message- > From: users-boun...@lists.opensips.org [mailto:users- > boun...@lists.opensips.org] On Behalf Of Steven Lam, KeenSystems B.V. > Sent: donderdag 16 februari 2012 17:49 > To: users@lists.opensips.org > Subject: [OpenSIPS-Users] Problem with uac_replace_from > > Hi list! > > When playing with uac_replace_from to replace both display and uri like this: > uac_replace_from("anonymous","sip:anonymous@anonymous.invalid"); > I found that on subsequential (ACK) messages only the uri was changed again > and display had the original value. > > Also when using uac_replace_from to replace only uri and remove display > like this: > uac_replace_from("","sip:anonymous@anonymous.invalid"); > On subsequential (ACK) messages the uri is changed as expected but display > had the original value. > > To me this looks wrong. > > Steven > > > ___ > Users mailing list > Users@lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users
[OpenSIPS-Users] Problem with uac_replace_from
Hi list! When playing with uac_replace_from to replace both display and uri like this: uac_replace_from("anonymous","sip:anonymous@anonymous.invalid"); I found that on subsequential (ACK) messages only the uri was changed again and display had the original value. Also when using uac_replace_from to replace only uri and remove display like this: uac_replace_from("","sip:anonymous@anonymous.invalid"); On subsequential (ACK) messages the uri is changed as expected but display had the original value. To me this looks wrong. Steven ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users