Re: Ant Goal

2003-11-10 Thread John Keyes
The Ant plugin is a simplified version of what Maven provides. It
definitely doesn't do all Maven does, nor does it provide the same
customisability.
Thats fine.  Thanks for the response dIon.

-John K

--
dIon Gillard, Multitask Consulting
Blog:  http://blogs.codehaus.org/people/dion/
Pub Key:http://blogs.codehaus.org/people/dion/public-key.asc
John Keyes <[EMAIL PROTECTED]> wrote on 10/11/2003 11:25:18 PM:

Have any maven committers any input on this?

I use Maven to generate an Ant file so people do not need
to install Maven to build a source distribution (those
crazy people :-).  I recently added the 'maven.javadoc.links'
property to my project.properties.  The issue is that when
I generate the Ant file there is no  child element of
the  element.  I haven't looked at the implementation
of the Ant plugin but I presume it only examines the
project descriptor and not the associated properties file
also.  Is this the case?
Thanks,
-John K
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Ant Goal

2003-11-10 Thread John Keyes
Have any maven committers any input on this?

I use Maven to generate an Ant file so people do not need
to install Maven to build a source distribution (those
crazy people :-).  I recently added the 'maven.javadoc.links'
property to my project.properties.  The issue is that when
I generate the Ant file there is no  child element of
the  element.  I haven't looked at the implementation
of the Ant plugin but I presume it only examines the
project descriptor and not the associated properties file
also.  Is this the case?
Thanks,
-John K
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Checkstyle Configuration

2003-11-09 Thread John Keyes
I'll broach the subject with the Checkstyle developers.  I asked here
first to see if anyone had any dealings in the matter.  I wasn't
suggesting Maven should solve the hierarchical configuration issue
just wondering what people thought of the idea.  I'll raise the
thread on the Checkstyle list and see what they have to say on
the matter.
Thanks for everyone's input.

-John K

On 9 Nov 2003, at 02:48, __matthewHawthorne wrote:

The way I see it, Maven doesn't want to get involved with configuring 
Checkstyle.  It just calls Checkstyle for you with a user provided 
file, or a default.  Adding some heirarchical configuration loader for 
Checkstyle sounds nice, but then Maven would have to consider doing 
the same for a lot of other plugins.  It seems easiest and most 
efficient to keep things separate.

However, this may be a nice workaround:

I like the Checkstyle plugin for Eclipse.  I believe that the defaults 
that it uses are based on the Sun standards.  You can create a copy of 
the default, rename it, customize it to your liking, and then export 
it to an xml file.  Perhaps you could then use this file in Maven?

Hope this helps.



John Keyes wrote:
Is it possible to override configuration settings in the
current Checkstyle plugin like it was possible when
properties files were used?


maven.checkstyle.properties=my-checkstyle.xml
Yes but I have to specify all of the rules again in that file.  I
think it should be extensible.
For example, I would like to use the sun coding standard as the
base for my coding standard and I want to change some of the
settings.


a) Be warned, the sun_checks.xml do not implement the sun coding
   standard.
Why not?  It's bad that it doesn't work as advertised.
b) Have you seen Jalopy? http://jalopy.sourceforge.net/
   There is a 'jalopy' goal.
Yeah, but it doesn't haven any relevance to this discussion.
I just like the idea of being able to import a base standard
and customize that as I see fit.
-John K


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Checkstyle Configuration

2003-11-08 Thread John Keyes
Yes but I have to specify all of the rules again in that file.  I
think it should be extensible.
I don't see why. Its a configuration file. Create your own
configuration. It is just as easy to copy the file and edit it.
Of course you can.  I just think its a step backwards in
comparison to the previous version.
For example, I would like to use the sun coding standard as the
base for my coding standard and I want to change some of the
settings.
a) Be warned, the sun_checks.xml do not implement the sun coding
  standard.
Why not?  It's bad that it doesn't work as advertised.
Read the Sun coding standards. They don't AvoidInlineConditionals,
for example. The Sun coding standard says nothing about
DesignForExtension, since design is not an aspect of formatting.
Correct your RedundantThrows and then there is no way to javadoc a
method that might throw both an IOException and a
FileNotFoundException. Loath FinalParameters.
Well then the file should not be called sun_checks.xml, it is
just another user configuration.  The sun coding standard
support should do exactly what it says on the tin and nothing
more.
b) Have you seen Jalopy? http://jalopy.sourceforge.net/
  There is a 'jalopy' goal.

Yeah, but it doesn't haven any relevance to this discussion.  I
just like the idea of being able to import a base standard and
customize that as I see fit.
It is relevent. With Jalopy your code will comply to the Sun coding
standards. Is that now what you want?
"For example, I would like to use the sun coding standard as the
 base for my coding standard and I want to change some of the
 settings."
I know how to resolve the issue, I am just highlighting an area
of weakness (IMO) with the current version.
Cheers,
-John K
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Checkstyle Configuration

2003-11-08 Thread John Keyes
Is it possible to override configuration settings in the
current Checkstyle plugin like it was possible when
properties files were used?
maven.checkstyle.properties=my-checkstyle.xml
Yes but I have to specify all of the rules again in that file.  I
think it should be extensible.
For example, I would like to use the sun coding standard as the
base for my coding standard and I want to change some of the
settings.
a) Be warned, the sun_checks.xml do not implement the sun coding
   standard.
Why not?  It's bad that it doesn't work as advertised.

b) Have you seen Jalopy? http://jalopy.sourceforge.net/
   There is a 'jalopy' goal.
Yeah, but it doesn't haven any relevance to this discussion.
I just like the idea of being able to import a base standard
and customize that as I see fit.
-John K

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Checkstyle Configuration

2003-11-08 Thread John Keyes
Hi,

Is it possible to override configuration settings in the
current Checkstyle plugin like it was possible when
properties files were used?  For example, I would like
to use the sun coding standard as the base for my
coding standard and I want to change some of the settings.
I notice that the turbine config just redefines all of the
sun settings as well as the ones they wanted to change.
I think it would be a neat feature to support configuration
importing.  Then the turbine config could look like this:

http://www.puppycrawl.com/dtds/configuration_1_1.dtd";>








  


  


  


  




Modules defined in the 'importing' document override those defined in 
the
'imported' one.

-John K

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Ant Goal

2003-11-08 Thread John Keyes
Hi,

I use Maven to generate an Ant file so people do not need
to install Maven to build a source distribution (those
crazy people :-).  I recently added the 'maven.javadoc.links'
property to my project.properties.  The issue is that when
I generate the Ant file there is no  child element of
the  element.  I haven't looked at the implementation
of the Ant plugin but I presume it only examines the
project descriptor and not the associated properties file
also.  Is this the case?
Thanks,
-John K
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]