Re: JDK 1.5 is out, and it breaks Maven

2004-03-03 Thread Berin Loritsch
Jörg Schaible wrote:
Hi Berin,

Jörg Schaible wrote on Wednesday, March 03, 2004 9:08 AM:

Berin Loritsch wrote on Tuesday, March 02, 2004 10:52 PM:

Thanks to the new JDK 1.5 installer, the default location to install
both the runtime and the developer kit is within the %PROGRAM_FILES%
directory.  That means a space is in the path to the "java" command
no matter how you slice it. 

The current "maven" script for Cygwin compatibility does not properly
handle this arrangement--because it never had to until now.  The
proper way to solve the issue is to add surrounding quotes to the
$JAVACMD that starts up maven. Enclosed is a script that works.
Berin,

can you raise an issue for the cli component:
http://jira.codehaus.org/secure/BrowseProject.jspa?id=> 10030


just saw that there is already an issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-1179
can you attach the file there?


Thank you.  I created a new entry, and then I saw this message, so I
attached the fix in both places.  I also created a new entry for the
maven-java-plugin module to fix the compilation defaults issue.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: JDK 1.5 is out, and it breaks Maven

2004-03-03 Thread Jörg Schaible
Hi Berin,

Jörg Schaible wrote on Wednesday, March 03, 2004 9:08 AM:
> Berin Loritsch wrote on Tuesday, March 02, 2004 10:52 PM:
>> Thanks to the new JDK 1.5 installer, the default location to install
>> both the runtime and the developer kit is within the %PROGRAM_FILES%
>> directory.  That means a space is in the path to the "java" command
>> no matter how you slice it. 
>> 
>> The current "maven" script for Cygwin compatibility does not properly
>> handle this arrangement--because it never had to until now.  The
>> proper way to solve the issue is to add surrounding quotes to the
>> $JAVACMD that starts up maven. Enclosed is a script that works.
> 
> Berin,
> 
> can you raise an issue for the cli component:
> http://jira.codehaus.org/secure/BrowseProject.jspa?id=> 10030

just saw that there is already an issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-1179

can you attach the file there?

Regards,
Jörg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: JDK 1.5 is out, and it breaks Maven

2004-03-03 Thread Jörg Schaible
Berin Loritsch wrote on Tuesday, March 02, 2004 10:52 PM:
> Thanks to the new JDK 1.5 installer, the default location to
> install both the runtime and the developer kit is within the
> %PROGRAM_FILES% directory.  That means a space is in the path
> to the "java" command no matter how you slice it.
> 
> The current "maven" script for Cygwin compatibility does not
> properly handle this arrangement--because it never had to
> until now.  The proper way to solve the issue is to add
> surrounding quotes to the $JAVACMD that starts up maven.
> Enclosed is a script that works.

Berin,

can you raise an issue for the cli component:
http://jira.codehaus.org/secure/BrowseProject.jspa?id=10030

Regards,
Jörg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: JDK 1.5 is out, and it breaks Maven

2004-03-02 Thread Berin Loritsch
Berin Loritsch wrote:

As a temperary workaround, how do we override the "-source" property in
Maven?
Ok, I found the answer to my own question:

maven.compile.source
maven.compile.target
Thanks.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


JDK 1.5 is out, and it breaks Maven

2004-03-02 Thread Berin Loritsch
Thanks to the new JDK 1.5 installer, the default location to install both the
runtime and the developer kit is within the %PROGRAM_FILES% directory.  That
means a space is in the path to the "java" command no matter how you slice it.
The current "maven" script for Cygwin compatibility does not properly handle
this arrangement--because it never had to until now.  The proper way to solve
the issue is to add surrounding quotes to the $JAVACMD that starts up maven.
Enclosed is a script that works.
Also a problem is that the defaults on the "javac" compiler are different, and
the fact that we set the "-target" option without specifying the "-source"
option means that all compilation will fail with the following message:
javac: source release 1.4 requires target release 1.4

The default "-source" option is "1.4" for JDK 1.5, which means you need a
"-target" of "1.4".  Actually, unless you intend to have Java 1.1 compatible
binaries, the "-target" option should never be set.
As a temperary workaround, how do we override the "-source" property in
Maven?
#!/bin/sh

#   Copyright (c) 2001-2002 The Apache Software Foundation.  All rights
#   reserved.

FOREHEAD_VERSION=1.0-beta-5

if [ -z "$MAVEN_OPTS" ] ; then
  MAVEN_OPTS="-Xmx256m"
fi

if [ -f "$HOME/.mavenrc" ] ; then
  . $HOME/.mavenrc
fi

# OS specific support.  $var _must_ be set to either true or false.
cygwin=false;
darwin=false;
case "`uname`" in
  CYGWIN*) cygwin=true ;;
  Darwin*) darwin=true ;;
esac

if [ -z "$MAVEN_HOME" ] ; then
  # try to find MAVEN
  if [ -d /opt/maven ] ; then
MAVEN_HOME=/opt/maven
  fi

  if [ -d ${HOME}/maven ] ; then
MAVEN_HOME=${HOME}/maven
  fi

  ## resolve links - $0 may be a link to maven's home
  PRG=$0
  progname=`basename $0`
  saveddir=`pwd`

  # need this for relative symlinks
  cd `dirname $PRG`

  while [ -h "$PRG" ] ; do
ls=`ls -ld "$PRG"`
link=`expr "$ls" : '.*-> \(.*\)$'`
if expr "$link" : '.*/.*' > /dev/null; then
  PRG="$link"
else
  PRG="`dirname $PRG`/$link"
fi
  done

  MAVEN_HOME=`dirname "$PRG"`/..

  # make it fully qualified
  MAVEN_HOME=`cd "$MAVEN_HOME" && pwd`

  cd $saveddir
fi

# For Cygwin, ensure paths are in UNIX format before anything is touched
if $cygwin ; then
  [ -n "$MAVEN_HOME" ] &&
MAVEN_HOME="`cygpath --unix "$MAVEN_HOME"`"
  [ -n "$MAVEN_HOME_LOCAL" ] &&
MAVEN_HOME_LOCAL="`cygpath --unix "$MAVEN_HOME_LOCAL"`"
  [ -n "$JAVA_HOME" ] &&
JAVA_HOME="`cygpath --unix "$JAVA_HOME"`"
  [ -n "$CLASSPATH" ] &&
CLASSPATH="`cygpath --path --unix "$CLASSPATH"`"
fi

if [ -z "$JAVACMD" ] ; then
  if [ -n "$JAVA_HOME"  ] ; then
if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
  # IBM's JDK on AIX uses strange locations for the executables
  JAVACMD=$JAVA_HOME/jre/sh/java
else
  JAVACMD=$JAVA_HOME/bin/java
fi
  else
JAVACMD=java
  fi
fi

if [ ! -x "$JAVACMD" ] ; then
  echo "Error: JAVA_HOME is not defined correctly."
  echo "  We cannot execute $JAVACMD"
  exit
fi

if [ -z "$JAVA_HOME" ] ; then
  echo "Warning: JAVA_HOME environment variable is not set."
  echo "  If build fails because sun.* classes could not be found"
  echo "  you will need to set the JAVA_HOME environment variable"
  echo "  to the installation directory of java."
fi

MAVEN_ENDORSED==${JAVA_HOME}/lib/endorsed:${MAVEN_HOME}/lib/endorsed

# For Cygwin, switch paths to Windows format before running java
if $cygwin; then
  [ -n "$MAVEN_HOME" ] &&
MAVEN_HOME="`cygpath --path --windows "$MAVEN_HOME"`"
  [ -n "$MAVEN_HOME_LOCAL" ] &&
MAVEN_HOME_LOCAL="`cygpath --path --windows "$MAVEN_HOME_LOCAL"`"
  [ -n "$JAVA_HOME" ] &&
JAVA_HOME="`cygpath --path --windows "$JAVA_HOME"`"
  [ -n "$MAVEN_ENDORSED" ] &&
MAVEN_ENDORSED="`cygpath --path --windows "$MAVEN_ENDORSED"`"
fi

# For Darwin, use classes.jar for TOOLS_JAR
TOOLS_JAR="${JAVA_HOME}/lib/tools.jar"
if $darwin; then
  
TOOLS_JAR="/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Classes/classes.jar"
fi

MAIN_CLASS=com.werken.forehead.Forehead
if [ -n "$MAVEN_HOME_LOCAL" ]; then
  "$JAVACMD" \
$MAVEN_OPTS \
-Djavax.xml.parsers.SAXParserFactory=org.apache.xerces.jaxp.SAXParserFactoryImpl \

-Djavax.xml.parsers.DocumentBuilderFactory=org.apache.xerces.jaxp.DocumentBuilderFactoryImpl
 \
"-Djava.endorsed.dirs=${MAVEN_ENDORSED}" \
-classpath "${MAVEN_HOME}/lib/forehead-${FOREHEAD_VERSION}.jar" \
"-Dforehead.conf.file=${MAVEN_HOME}/bin/forehead.conf"  \
"-Dtools.jar=$TOOLS_JAR" \
"-Dmaven.home=${MAVEN_HOME}" \
"-Dmaven.home.local=${MAVEN_HOME_LOCAL}" \
$MAIN_CLASS $@
fi
if [ ! -n "$MAVEN_HOME_LOCAL" ]; then
  "$JAVACMD" \
$MAVEN_OPTS \
-Djavax.xml.parsers.SAXParserFactory=org.apache.xerces.jaxp.SAXParserFactoryImpl \

-Djavax.xml.parsers.DocumentBuilderFactory=org.apache.xerces.jaxp.DocumentBuilderFactoryImpl
 \
"-Djava.endorsed.dirs=${MAVEN_ENDORSED}" \
-classpath "${MAVEN_HOME}/lib/forehead-${FOREHEAD_VERSION}.jar" \
"-Dforehead.conf.file=$