Re: NPE using eclipse:install-plugins
2008/9/16 Barrie Treloar [EMAIL PROTECTED] On Tue, Sep 16, 2008 at 5:45 PM, Arnaud HERITIER [EMAIL PROTECTED] wrote: I don't think we are using a mocking framework like easy mock but you can propose I had a look in InstallPluginsMojoTest and there seems to be some org.easymock.MockControl used there :-/. To be simplest you can create an integration test. You just have to create a maven project which reproduces the issue. I've been tinkering in the plugin lately, especially the test side of things, so I thought I would have a look. InstallPluginsMojoTest was explicity excluded from the tests. The code in there needed an overhaul to find a suitable jar and to test it runs, so I've done that. Now I can look at creating a unit test for this patch as well - probably by using the jar that fails. Hi Barrie, With the jar that fails, the thing is I think it's proprietary(xdb.jar from the Oracle XDK).Though It's publicly downloadable (retrievable from oracle.com with a free account). So I guess it would be better to create a simple dumb jar with one or two classes, without any META-INF directory. Then this jar will be included in the project without any problem. I really think it's better. And obviously, I'll be happy to manually test the new version once the modification is applied. What do you think? Cheers. -- Baptiste Batmat MATHUS - http://batmat.net Save a tree, Eat a beaver!
Re: NPE using eclipse:install-plugins
Then this jar will be included in the project without any problem. I really think it's better. And obviously, I'll be happy to manually test the new version once the modification is applied. Fixed, with unit test as well. I just created a zip file with no manifest and renamed to jar. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: NPE using eclipse:install-plugins
perfect thx On Wed, Sep 17, 2008 at 1:07 AM, Barrie Treloar [EMAIL PROTECTED] wrote: Then this jar will be included in the project without any problem. I really think it's better. And obviously, I'll be happy to manually test the new version once the modification is applied. Fixed, with unit test as well. I just created a zip file with no manifest and renamed to jar. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- .. Arnaud HERITIER .. OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com .. ASF - aheritier AT apache DOT org www.apache.org | maven.apache.org ...
Re: NPE using eclipse:install-plugins
On Wed, Sep 17, 2008 at 9:08 AM, Arnaud HERITIER [EMAIL PROTECTED] wrote: perfect thx I'd feel happier if you could check it works in your envionment. I've build and tested on my windows xp box and on minotaur, but since I'm just tinkering around the edges I'm not confident I haven't stuffed something up. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: NPE using eclipse:install-plugins
units tests and integration tests passed on my laptop (mac os x) I'll do more checks on existing projects at work (for my personal devs I'm more often using m2eclipse) cheers arnaud On Wed, Sep 17, 2008 at 4:18 AM, Barrie Treloar [EMAIL PROTECTED] wrote: On Wed, Sep 17, 2008 at 9:08 AM, Arnaud HERITIER [EMAIL PROTECTED] wrote: perfect thx I'd feel happier if you could check it works in your envionment. I've build and tested on my windows xp box and on minotaur, but since I'm just tinkering around the edges I'm not confident I haven't stuffed something up. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- .. Arnaud HERITIER .. OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com .. ASF - aheritier AT apache DOT org www.apache.org | maven.apache.org ...
Re: NPE using eclipse:install-plugins
On Wed, Sep 17, 2008 at 2:08 PM, Arnaud HERITIER [EMAIL PROTECTED] wrote: units tests and integration tests passed on my laptop (mac os x) I'll do more checks on existing projects at work (for my personal devs I'm more often using m2eclipse) That's probably enough. Appreciate the check. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
