Release Plugin 2.1 : invalid label perforce scm provider 1.4

2010-10-11 Thread Thiebaud, Christophe
Hi all,

I just tested the brand new Release Plugin 2.1 and I found that the label 
created by the perforce scm provider has an empty file set.

Looking at the generated perforce label, I can see that the perforce view 
specification is wrongly all lowercase.

I then found that the ReleaseUtil.java getCommonBaseDir function produces a 
lowercased result when running under Windows (which is the case for me).

I guess that this is common base dir is then used then by the scm provider to 
create the wrong perforce label.

It looks it is rather a Release Plugin issue than a scm perforce provider issue.

My question is : why does getCommonBaseDir lowercase the common base dir ?

Christophe



Re: Release Plugin 2.1 : invalid label perforce scm provider 1.4

2010-10-11 Thread Brett Porter
This was to avoid case-comparison issues where c:\something looked different to 
C:\something (MRELEASE-536). It seems like it shouldn't be persisting that 
change then.

Can you file a new issue?

On 12/10/2010, at 9:11 AM, Thiebaud, Christophe wrote:

 Hi all,
 
 I just tested the brand new Release Plugin 2.1 and I found that the label 
 created by the perforce scm provider has an empty file set.
 
 Looking at the generated perforce label, I can see that the perforce view 
 specification is wrongly all lowercase.
 
 I then found that the ReleaseUtil.java getCommonBaseDir function produces a 
 lowercased result when running under Windows (which is the case for me).
 
 I guess that this is common base dir is then used then by the scm provider to 
 create the wrong perforce label.
 
 It looks it is rather a Release Plugin issue than a scm perforce provider 
 issue.
 
 My question is : why does getCommonBaseDir lowercase the common base dir ?
 
 Christophe
 

--
Brett Porter
br...@apache.org
http://brettporter.wordpress.com/





-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org