Re: maven-checkstyle-plugin does not include test resources
Hi! For reference: i opened a discussion http://maven.40175.n5.nabble.com/Fix-for-MCHECKSTYLE-295-td5837127.html on the developer list, and added a patch to the ticket https://issues.apache.org/jira/browse/MCHECKSTYLE-295.
Re: maven-checkstyle-plugin does not include test resources
Hi Karl, i would love to fix this issue, i think this should be easy. Who should i contact for information? I read the site, but did not found that, maybe i looked in the wrong place. Thanks, Csaba
Re: maven-checkstyle-plugin does not include test resources
Hi, On 6/7/15 3:38 PM, Csaba Kozák wrote: Hi Karl, i would love to fix this issue, i think this should be easy. on which issue do you referencing to ? Who should i contact for information? I read the site, but did not found that, maybe i looked in the wrong place. Best is to reference to a jira issue and if you like please attach a patch to the issue...and please add appropriate integration/unit tests to it... Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
Re: maven-checkstyle-plugin does not include test resources
Hi Karl! Thanks for the quick answer. This is the ticket: https://issues.apache.org/jira/browse/MCHECKSTYLE-295 OK, i will do by best, however i did not use JIRA ever for development, and svn only a long time ago, so maybe i will ask some questions.
Re: maven-checkstyle-plugin does not include test resources
Hi, On 6/7/15 4:15 PM, Csaba Kozák wrote: Hi Karl! Thanks for the quick answer. This is the ticket: https://issues.apache.org/jira/browse/MCHECKSTYLE-295 OK, i will do by best, however i did not use JIRA ever for development, and svn only a long time ago, so maybe i will ask some questions. Don't hesitate to ask questions... but they are releated to the development so we should change to the development list Many thanks for helping here... Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
Re: maven-checkstyle-plugin does not include test resources
Hi Karl, I know, i was just confirming that the issue is valid. Since i examined the wrong version of the code for writing the report, it could have been wrong, too. Sorry for spamming. :) Regards, Csaba
Re: maven-checkstyle-plugin does not include test resources
Hi, On 5/26/15 7:49 PM, Csaba Kozák wrote: Hi Karl, Yeah, you are right. I was checking out the wrong revision from svn. :( I checked the latest HEAD codebase, and my bug report is still valid i think. I was only referencing to the information about the jira link not on the issue you have found... Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
Re: maven-checkstyle-plugin does not include test resources
Hi Karl, Yeah, you are right. I was checking out the wrong revision from svn. :( I checked the latest HEAD codebase, and my bug report is still valid i think. Regards, Csaba
Re: maven-checkstyle-plugin does not include test resources
Hi, On 5/25/15 11:30 AM, Csaba Kozák wrote: Thanks! I created this https://issues.apache.org/jira/browse/MCHECKSTYLE-295 ticket. I guess the maven checkstyle plugin POM should be updated to refer to the new location of the JIRA. The pom contains already the new JIRA location...but in the meantime no new release has been done to update the official plugin site... Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
maven-checkstyle-plugin does not include test resources
The documentation says it includes these resources by default, but apparently it never does. After examining the code, it seems CheckstyleViolationCheckMojo.execute() forgets to call request.setTestResources(), hence that is always null and skipped from audit. I wanted to file a report on JIRA, but it seems codehaus is shutting down and i cannot add new issues anymore. :S -- View this message in context: http://maven.40175.n5.nabble.com/maven-checkstyle-plugin-does-not-include-test-resources-tp5835797.html Sent from the Maven - Users mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
Re: maven-checkstyle-plugin does not include test resources
On Monday, 25 May 2015 at 09:46, WonderCsabo wrote: The documentation says it includes these resources by default, but apparently it never does. After examining the code, it seems CheckstyleViolationCheckMojo.execute() forgets to call request.setTestResources(), hence that is always null and skipped from audit. I wanted to file a report on JIRA, but it seems codehaus is shutting down and i cannot add new issues anymore. :S FYI, you can log new issues at https://issues.apache.org/jira/browse/MCHECKSTYLE See also https://maven.apache.org/issue-tracking.html and https://maven.apache.org/plugins/index.html for updated links to the new JIRA projects -- View this message in context: http://maven.40175.n5.nabble.com/maven-checkstyle-plugin-does-not-include-test-resources-tp5835797.html Sent from the Maven - Users mailing list archive at Nabble.com (http://Nabble.com). - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org (mailto:users-unsubscr...@maven.apache.org) For additional commands, e-mail: users-h...@maven.apache.org (mailto:users-h...@maven.apache.org)
Re: maven-checkstyle-plugin does not include test resources
Thanks! I created this https://issues.apache.org/jira/browse/MCHECKSTYLE-295 ticket. I guess the maven checkstyle plugin POM should be updated to refer to the new location of the JIRA.