Re: release:perform not removing release.properties

2012-05-21 Thread Mark Hobson
On 21 May 2012 21:33, Jesse Farinacci  wrote:
> Thanks for the fix, but a new release seems excessive. The bug doesn't
> cause any sort of breakage, it just leaves some work files around.. I
> haven't tested it, but I think these work files won't even interfere
> with another invocation of the release.

It doesn't break the release but it's an unnecessary inconvenience for
the user.  I'll look into a 2.3.1 release with this fix tomorrow.

Mark

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



Re: release:perform not removing release.properties

2012-05-21 Thread Jesse Farinacci
Greetings,

On Mon, May 21, 2012 at 4:08 PM, Mark Hobson  wrote:
> Thanks for the quick fix Robert.  Any chance of a 2.3.1 release as
> this is quite a visible regression?

Thanks for the fix, but a new release seems excessive. The bug doesn't
cause any sort of breakage, it just leaves some work files around.. I
haven't tested it, but I think these work files won't even interfere
with another invocation of the release.

-Jesse

-- 
There are 10 types of people in this world, those
that can read binary and those that can not.

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



Re: release:perform not removing release.properties

2012-05-21 Thread Mark Hobson
Thanks for the quick fix Robert.  Any chance of a 2.3.1 release as
this is quite a visible regression?

Mark

On 21 May 2012 19:31, Robert Scholte  wrote:
> Fixed, will be part of the next release.
>
> Robert
>
> Op Mon, 21 May 2012 16:01:19 +0200 schreef Mark Hobson
> :
>
>
>> Hi Jesse,
>>
>> Thanks for the feedback.  I've raised an issue:
>>
>> http://jira.codehaus.org/browse/MRELEASE-758
>>
>> Cheers,
>>
>> Mark
>>
>> On 21 May 2012 13:18, Jesse Farinacci  wrote:
>>>
>>> Greetings,
>>>
>>> On Mon, May 21, 2012 at 8:15 AM, Mark Hobson 
>>> wrote:

 On upgrading maven-release-plugin from 2.2.2 to 2.3 I noticed that
 release:perform no longer removes release.properties nor
 pom.xml.releaseBackup.
>>>
>>>
>>> I confirm that this is happening to my release builds, also. I don't
>>> recall this happening before, and I don't think it is deliberate.
>>>
>>> -Jesse
>>>
>>> --
>>> There are 10 types of people in this world, those
>>> that can read binary and those that can not.
>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: users-h...@maven.apache.org
>>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
>> For additional commands, e-mail: users-h...@maven.apache.org
>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
> For additional commands, e-mail: users-h...@maven.apache.org
>

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



Re: release:perform not removing release.properties

2012-05-21 Thread Robert Scholte

Fixed, will be part of the next release.

Robert

Op Mon, 21 May 2012 16:01:19 +0200 schreef Mark Hobson  
:



Hi Jesse,

Thanks for the feedback.  I've raised an issue:

http://jira.codehaus.org/browse/MRELEASE-758

Cheers,

Mark

On 21 May 2012 13:18, Jesse Farinacci  wrote:

Greetings,

On Mon, May 21, 2012 at 8:15 AM, Mark Hobson   
wrote:

On upgrading maven-release-plugin from 2.2.2 to 2.3 I noticed that
release:perform no longer removes release.properties nor
pom.xml.releaseBackup.


I confirm that this is happening to my release builds, also. I don't
recall this happening before, and I don't think it is deliberate.

-Jesse

--
There are 10 types of people in this world, those
that can read binary and those that can not.

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



Re: release:perform not removing release.properties

2012-05-21 Thread Mark Hobson
Hi Jesse,

Thanks for the feedback.  I've raised an issue:

http://jira.codehaus.org/browse/MRELEASE-758

Cheers,

Mark

On 21 May 2012 13:18, Jesse Farinacci  wrote:
> Greetings,
>
> On Mon, May 21, 2012 at 8:15 AM, Mark Hobson  wrote:
>> On upgrading maven-release-plugin from 2.2.2 to 2.3 I noticed that
>> release:perform no longer removes release.properties nor
>> pom.xml.releaseBackup.
>
> I confirm that this is happening to my release builds, also. I don't
> recall this happening before, and I don't think it is deliberate.
>
> -Jesse
>
> --
> There are 10 types of people in this world, those
> that can read binary and those that can not.
>
> -
> To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
> For additional commands, e-mail: users-h...@maven.apache.org
>

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



Re: release:perform not removing release.properties

2012-05-21 Thread Jesse Farinacci
Greetings,

On Mon, May 21, 2012 at 8:15 AM, Mark Hobson  wrote:
> On upgrading maven-release-plugin from 2.2.2 to 2.3 I noticed that
> release:perform no longer removes release.properties nor
> pom.xml.releaseBackup.

I confirm that this is happening to my release builds, also. I don't
recall this happening before, and I don't think it is deliberate.

-Jesse

-- 
There are 10 types of people in this world, those
that can read binary and those that can not.

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org



release:perform not removing release.properties

2012-05-21 Thread Mark Hobson
Hi there,

On upgrading maven-release-plugin from 2.2.2 to 2.3 I noticed that
release:perform no longer removes release.properties nor
pom.xml.releaseBackup.  Is this intended behaviour?  I couldn't see
anything regarding this in the release notes and the documentation
still states that they should be removed.

I'll raise an issue if it's a regression.

Cheers,

Mark

-
To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
For additional commands, e-mail: users-h...@maven.apache.org