AW: AW: [Users] problems with vzctl init logging patch
Attached is the new patch. - Dietmar vzctl.diff Description: vzctl.diff ___ Users mailing list Users@openvz.org https://openvz.org/mailman/listinfo/users
AW: [Users] problems with vzctl init logging patch
Just a guess: its the logging proxess itself, because that process still runs on the host - I need to do a exec instead? - Dietmar -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Dietmar Maurer Gesendet: Mittwoch, 12. März 2008 10:37 An: users@openvz.org Betreff: [Users] problems with vzctl init logging patch hi all, my init logging patch works so far, but unfortunately it breaks checkpointing: --- vzctl chkpnt 101 Setting up checkpoint... suspend... dump... Can not dump container: Invalid argument Error: d_path err=-22 Checkpointing failed --- Maybe some of the developers can give me a hint whats wrong? lsof shows (16531 id the logging process) lt-vzctl 16531 root cwd DIR 0,22 4096 1226401 /var/lib/vz/root/101 lt-vzctl 16531 root rtd DIR 0,22 4096 1226401 /var/lib/vz/root/101 lt-vzctl 16531 root txt REG8,198155 2047179 /home/dietmar/pve/vzctl/vzctl-3.0.22/src/.libs/lt-vzctl lt-vzctl 16531 root mem REG0,0 0 [heap] (stat: No such file or directory) lt-vzctl 16531 root mem REG8,197928 1896840 /lib/ld-2.3.6.so lt-vzctl 16531 root mem REG8,1 488939 2031943 /home/dietmar/pve/vzctl/vzctl-3.0.22/src/lib/.libs/libvzctl-0.0.2.so lt-vzctl 16531 root mem REG8,110392 1896846 /lib/libdl-2.3.6.so lt-vzctl 16531 root mem REG8,110520 1896843 /lib/libutil-2.3.6.so lt-vzctl 16531 root mem REG8,1 1282008 1896845 /lib/libc-2.3.6.so lt-vzctl 16531 root0u CHR1,3 1423308 /var/lib/vz/root/101/dev/null lt-vzctl 16531 root1w REG 0,22 1941 1232142 /var/lib/vz/root/101/var/log/init.log lt-vzctl 16531 root2r FIFO 0,22 1232141 /var/lib/vz/root/101/var/log/init.fifo ___ Users mailing list Users@openvz.org https://openvz.org/mailman/listinfo/users
Re: AW: [Users] problems with vzctl init logging patch
This looks good. Can you (1) make it optional, i.e. retain the old behavior by default and provide a way to turn init logging on (command-line switch, or VE config parameter) (2) make init-logger so it would not depend on perl being available inside the container; i guess it can be rewritten in shell as /bin/sh should be there (3) add the comment to init-logger saying that this file was copied from the host system to this container and so any changes made to it inside a container will be lost during the next container start (4) document it all (5) add init-logger to the vzctl.spec file Dietmar Maurer wrote: Ok, exec solves the problem. Attached is the new patch. ___ Users mailing list Users@openvz.org https://openvz.org/mailman/listinfo/users
Re: AW: AW: [Users] problems with vzctl init logging patch
Dietmar Maurer wrote: This looks good. Can you (1) make it optional, i.e. retain the old behavior by default and provide a way to turn init logging on (command-line switch, or VE config parameter) Ok (2) make init-logger so it would not depend on perl being available inside the container; i guess it can be rewritten in shell as /bin/sh should be there Will try. But cant we depend on perl? Perl should be available on most platforms. I can even add a test if perl is available, and do not start the logger if there is no perl? Adding a check makes sense. But first -- why do you need perl at all? Is there something that can't be done in shell? (3) add the comment to init-logger saying that this file was copied from the host system to this container and so any changes made to it inside a container will be lost during the next container start (4) document it all (5) add init-logger to the vzctl.spec file Ok, will send a new patch when ready. - Dietmar ___ Users mailing list Users@openvz.org https://openvz.org/mailman/listinfo/users ___ Users mailing list Users@openvz.org https://openvz.org/mailman/listinfo/users
AW: AW: AW: [Users] problems with vzctl init logging patch
Adding a check makes sense. But first -- why do you need perl at all? Is there something that can't be done in shell? I guess you are right - will rewrite it. - Dietmar ___ Users mailing list Users@openvz.org https://openvz.org/mailman/listinfo/users
