Re: [VOTE] Release Qpid Broker-J 9.0.0 (RC2)
+1 * verified signatures and checksum files * extracted source bundle using 'tar -xvf' or 'mc' on Ubuntu 22.04 and using 7-zip (Windows 10) * executed mvn apache-rat:check * executed the build and tests with -DskipITs parameter on JDK 11/17 * started Qpid Broker-J, created queues/exchanges/ports/... via REST API * sent and received messages using Qpid JMS Client Tomas On 2022/11/14 11:51:14 Tomas Vavricka wrote: > Hi all, > > I built release artefacts for Qpid Broker-J version 9.0.0 RC2. > Please, give them a test out and vote accordingly. > > The source and binary archives can be found at: > https://dist.apache.org/repos/dist/dev/qpid/broker-j/9.0.0-rc2/ > > The maven artifacts are also staged at: > https://repository.apache.org/content/repositories/orgapacheqpid-1251/ > > The new version brings a number of improvements and bug fixes. > You can find the full list of JIRAs included in the release here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12348607 > > Regards, > Tomas > > P.S. For testing of maven broker staging repo artefacts, please add > into to your project pom the staging repo as below: > > > > staging > > https://repository.apache.org/content/repositories/orgapacheqpid-1251/ > > > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Qpid Broker-J 9.0.0 (RC2)
+1 I checked out the following: * Checked licence headers in the source archive (mvn apache-rat:check) * Built successfully from source (mvn clean install) under JDK 11 / JDK 17 * Ran successfully unit tests / integration tests using default profile under JDK 11 / JDK 17 (mvn verify -DskipTests=false -DskipITs=false) * Started broker and created a queue via web management console (JDK 11) On Mon, 14 Nov 2022 at 19:16, Robbie Gemmell wrote: > > +1 > > I checked things out as follows: > - Checked over diff to RC1. > - Verified the signature and checksum files [1]. > - Checked for LICENCE and NOTICE files present in the archives. > - Ran "mvn apache-rat:check" to check headers in the source archive. > - Ran the build + tests with "mvn clean verify -DskipITs=false" on JDK 17. > - Started broker from the binary archive and created a queue using the > web management console on JDK 17. > - Ran Qpid JMS 2.1.0 HelloWorld example against the broker on JDK 17. > - Verified the JDK 11 (and 17) CI run passed. > > [1] Verified against https://people.apache.org/keys/committer/vavrtom.asc and > updated the main KEYS file with it at https://downloads.apache.org/qpid/KEYS > / https://dist.apache.org/repos/dist/release/qpid/KEYS > > Robbie > > On Mon, 14 Nov 2022 at 11:51, Tomas Vavricka wrote: > > > > Hi all, > > > > I built release artefacts for Qpid Broker-J version 9.0.0 RC2. > > Please, give them a test out and vote accordingly. > > > > The source and binary archives can be found at: > > https://dist.apache.org/repos/dist/dev/qpid/broker-j/9.0.0-rc2/ > > > > The maven artifacts are also staged at: > > https://repository.apache.org/content/repositories/orgapacheqpid-1251/ > > > > The new version brings a number of improvements and bug fixes. > > You can find the full list of JIRAs included in the release here: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12348607 > > > > Regards, > > Tomas > > > > P.S. For testing of maven broker staging repo artefacts, please add > > into to your project pom the staging repo as below: > > > > > > > > staging > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1251/ > > > > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Qpid Broker-J 9.0.0 (RC2)
+1 I checked things out as follows: - Checked over diff to RC1. - Verified the signature and checksum files [1]. - Checked for LICENCE and NOTICE files present in the archives. - Ran "mvn apache-rat:check" to check headers in the source archive. - Ran the build + tests with "mvn clean verify -DskipITs=false" on JDK 17. - Started broker from the binary archive and created a queue using the web management console on JDK 17. - Ran Qpid JMS 2.1.0 HelloWorld example against the broker on JDK 17. - Verified the JDK 11 (and 17) CI run passed. [1] Verified against https://people.apache.org/keys/committer/vavrtom.asc and updated the main KEYS file with it at https://downloads.apache.org/qpid/KEYS / https://dist.apache.org/repos/dist/release/qpid/KEYS Robbie On Mon, 14 Nov 2022 at 11:51, Tomas Vavricka wrote: > > Hi all, > > I built release artefacts for Qpid Broker-J version 9.0.0 RC2. > Please, give them a test out and vote accordingly. > > The source and binary archives can be found at: > https://dist.apache.org/repos/dist/dev/qpid/broker-j/9.0.0-rc2/ > > The maven artifacts are also staged at: > https://repository.apache.org/content/repositories/orgapacheqpid-1251/ > > The new version brings a number of improvements and bug fixes. > You can find the full list of JIRAs included in the release here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12348607 > > Regards, > Tomas > > P.S. For testing of maven broker staging repo artefacts, please add > into to your project pom the staging repo as below: > > > > staging > > https://repository.apache.org/content/repositories/orgapacheqpid-1251/ > > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
[VOTE] Release Qpid Broker-J 9.0.0 (RC2)
Hi all, I built release artefacts for Qpid Broker-J version 9.0.0 RC2. Please, give them a test out and vote accordingly. The source and binary archives can be found at: https://dist.apache.org/repos/dist/dev/qpid/broker-j/9.0.0-rc2/ The maven artifacts are also staged at: https://repository.apache.org/content/repositories/orgapacheqpid-1251/ The new version brings a number of improvements and bug fixes. You can find the full list of JIRAs included in the release here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12348607 Regards, Tomas P.S. For testing of maven broker staging repo artefacts, please add into to your project pom the staging repo as below: staging https://repository.apache.org/content/repositories/orgapacheqpid-1251/
Re: [VOTE] Release Qpid Broker-J 9.0.0
For a start, I created new Jenkins job for Java 17 with -DskipITs=false parameter https://ci-builds.apache.org/job/Qpid/job/Qpid-Broker-J-Test-JDK17/ and added -DskipITs=false parameter to existing Java 11 Jenkins job https://ci-builds.apache.org/job/Qpid/job/Qpid-Broker-J-Test-JDK11/. I tried to add a Jenkins post build action 'Set GitHub commit status', but the post build action seems to require some changes to the github repository settings that I do not have permissions to set. On 2022/11/11 16:09:42 Robbie Gemmell wrote: > Np. Though it does suggest some update/rework of the CI jobs is in > order, since the test issues should have been caught earlier. That in > addition to perhaps preparing for removal of the Travis based jobs > when Infra cease paying for Travis at the end of December. > > On Fri, 11 Nov 2022 at 15:54, Tomas Vavricka wrote: > > > > Hi Robbie, > > > > thank you very much for testing and comments. > > > > The points mentioned should be fixed in main branch. > > > > I will try to prepare RC2 next week (if no more issues). > > > > Regards, > > Tomas > > > > On 2022/11/11 13:25:27 Robbie Gemmell wrote: > > > One further issue noticed now the earlier test issue was resolved on > > > main and the build got further this time: > > > > > > Another test failing on Java 17, probably related to > > > https://issues.apache.org/jira/browse/QPID-8586 as it seems the same > > > type of failure and area. > > > > > > mvn clean verify -DskipITs=false > > > > > > [INFO] Running org.apache.qpid.systest.disttest.endtoend.EndToEndTest > > > [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time > > > elapsed: 7.784 s <<< FAILURE! - in > > > org.apache.qpid.systest.disttest.endtoend.EndToEndTest > > > [ERROR] > > > testHillClimbing(org.apache.qpid.systest.disttest.endtoend.EndToEndTest) > > > Time elapsed: 0.073 s <<< ERROR! > > > java.lang.NullPointerException: Cannot invoke > > > "javax.script.ScriptEngine.eval(java.io.Reader)" because "engine" is > > > null > > > at > > > org.apache.qpid.systest.disttest.endtoend.EndToEndTest.runController(EndToEndTest.java:288) > > > at > > > org.apache.qpid.systest.disttest.endtoend.EndToEndTest.testHillClimbing(EndToEndTest.java:226) > > > > > > > > > > > > On Wed, 9 Nov 2022 at 13:03, Robbie Gemmell > > > wrote: > > > > > > > > I know the vote was already cancelled, but I had started testing and > > > > so continued. Given that, my vote would have been -1 due some niggles > > > > needing fixed. > > > > > > > > Quick list, with expansions later: > > > > - Some licence file updates needed for the binary distribution. > > > > - Possible extraneous tests jar file in the binary distribution. > > > > - The binary distribution doesnt start on Java 17 due to a removed GC > > > > option, same option causes a warning on Java 11. > > > > - The E2E Conversion tests fail for me. > > > > - I would delete the 9.0.x branch and use main. > > > > > > > > > > > > ## Licence file issues and potentially stray jar in distribution: > > > > - ASM / ASM-Tree was added to the binary distro and should be > > > > mentioned in LICENCE given it isnt ASLv2; prodding this is part of > > > > what dependencies reference file is for, LICENCE update should be made > > > > at same time as adding the deps. > > > > - A couple of logback -db jars added, names should be noted in LICENCE > > > > with the others (assuming using the same licence). > > > > - There is a possibly extraneous logback tests jar added to the > > > > distribution, the dep should either be removed wherever it is coming > > > > in (if not actually needed), or also covered in LICENCE. > > > > > > > > > > > > ## The broker distribution cant start on Java 17 out the box due to > > > > the default options set from JAVA_GC: > > > > This seems unreasonable at this stage, especially for a new major this > > > > long after Java 17 came out, and would be particularly odd given the > > > > overall changes look to include JDK17 compatibility fixes. > > > > > > > > Info: QPID_JAVA_GC not set. Defaulting to JAVA_GC > > > > -XX:+UseConcMarkSweepGC -XX:+HeapDumpOnOutOfMemoryError > > > > Info: QPID_JAVA_MEM not set. Defaulting to JAVA_MEM -Xmx512m > > > > -XX:MaxDirectMemorySize=1536m > > > > Unrecognized VM option 'UseConcMarkSweepGC' > > > > Error: Could not create the Java Virtual Machine. > > > > Error: A fatal exception has occurred. Program will exit. > > > > > > > > The same option also causes a warning when starting on Java 11 since > > > > it was deprecated in Java 9. > > > > > > > > > > > > ## E2E Conversion tests fail: > > > > > > > > Perhaps something to do with the updates of the tests maven-based > > > > dependencies, and compatibility with other deps and/or the maven > > > > version running the build. Failed for me on Java 17 and 11, using > > > > Maven 3.8.6 and 3.8.5. > > > > > > > > Quick path to the failure without installing the dependent modules is: > > > > mvn clean verify -DskipTests
