Re: Heads-up: Splitting proton-c into multiple libraries [Was: Proton's road ahead]

[Andrew Stitcher]

Just to note that I have now merged this change into master, having
received no strong objections.

I did receive a comment that perhaps the new directory layout for some
of the legacy code isn't the best it could be, and I agree with this.
Specifically - that the "handlers" directory should really be a part of
the "reactor" directory as handlers are reactor API specific, also
since "io" is actually shared between the reactor and messenger APIs
maybe it should be at the top level.

In the interests of progressing I think we can make any further changes
here separately from this change.

Andrew


-
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org

Re: Heads-up: Splitting proton-c into multiple libraries [Was: Proton's road ahead]

[Andrew Stitcher]

We could certainly copy the URL parser functionality into the C++
binding but as Ken notes it is used in the reactor so we'd have to
leave it there too (although we can make it private).

As for the parser for the pn_data_t I think that can be completely
removed as I'm not aware of any use of it all.

Andrew


On Fri, 2016-11-11 at 15:25 -0500, Ken Giusti wrote:
> IIRC C reactor also uses the url parser.
> 
> 
> - Original Message -
> > 
> > From: "Justin Ross" <justin.r...@gmail.com>
> > To: users@qpid.apache.org
> > Sent: Friday, November 11, 2016 3:02:40 PM
> > Subject: Re: Heads-up: Splitting proton-c into multiple libraries
> > [Was: Proton's road ahead]
> > 
> > On Fri, Nov 11, 2016 at 8:46 AM, Andrew Stitcher <astitcher@redhat.
> > com>
> > wrote:
> > > 
> > > 
> > > Extra (potential) library: All source in directory
> > > - extra
> > > 
> > 
> > Could we avoid having this extra library if we copied the URL
> > parser to the
> > C++ binding?  You noted elsewhere that the only other thing in
> > here, the
> > data parser, isn't currently used.
> > 
> 

-
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org

Re: Heads-up: Splitting proton-c into multiple libraries [Was: Proton's road ahead]

[Justin Ross]

On Fri, Nov 11, 2016 at 8:46 AM, Andrew Stitcher 
wrote:
>
> Extra (potential) library: All source in directory
> - extra
>

Could we avoid having this extra library if we copied the URL parser to the
C++ binding?  You noted elsewhere that the only other thing in here, the
data parser, isn't currently used.