PerMsgStatus Util warnings

2015-05-14 Thread Alex Regan

Hi,

I have v3.4.1 with amavisd v2.9.1 on fedora20 and receiving the 
following warnings:


May 13 23:32:31 mail01 amavis[17306]: (17306-10) _WARN: plugin: eval 
failed: Undefined subroutine 
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain called at 
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/Util.pm line 1236.


May 13 23:35:43 mail01 amavis[17386]: (17386-12) _WARN: Use of 
uninitialized value in concatenation (.) or string at 
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/PerMsgStatus.pm line 3082.


I thought I remembered this issue being discussed some time ago, but 
couldn't find any recent references to it. It looks like it happens just 
in the course of processing messages with no other information around 
these lines. I also don't know when it first started. Thought someone 
might have some ideas?


Thanks,
Alex


Re: PerMsgStatus Util warnings

2015-05-14 Thread Mark Martinec

Alex Regan wrote:


I have v3.4.1 with amavisd v2.9.1 on fedora20 and receiving the
following warnings:

May 13 23:32:31 mail01 amavis[17306]: (17306-10) _WARN: plugin: eval
failed: Undefined subroutine
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain called at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/Util.pm line 1236.

May 13 23:35:43 mail01 amavis[17386]: (17386-12) _WARN: Use of
uninitialized value in concatenation (.) or string at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/PerMsgStatus.pm line
3082.

I thought I remembered this issue being discussed some time ago, but
couldn't find any recent references to it. It looks like it happens
just in the course of processing messages with no other information
around these lines. I also don't know when it first started. Thought
someone might have some ideas?


Are you using some third-party SpamAssasin plugin that relies on the
deprecated subroutine Mail::SpamAssassin::Util::uri_to_domain ?

Please try the patch below:

===
--- Mail/SpamAssassin/Util.pm~  2015-04-28 21:56:49.0 +0200
+++ Mail/SpamAssassin/Util.pm   2015-05-14 16:26:23.198104251 +0200
@@ -49,4 +49,5 @@

 use Mail::SpamAssassin::Logger;
+use Mail::SpamAssassin::Util::RegistrarBoundaries;  # deprecated

 BEGIN {
===


Mark


Re: Turning off queries to SORBS

2015-05-14 Thread Bill Cole
On 13 May 2015, at 20:24, Chris wrote:

 So I guess then that the bottom line is that eventually the queries are
 getting through to SORBS but I'll still be seeing some errors and just
 don't worry about it. Does that sound about right?

Yes.


Re: PerMsgStatus Util warnings

2015-05-14 Thread Mark Martinec

Alex Regan wrote:


Please open a bug report (one should do, even though these are two

independent issues).


Bug filed, thanks so much.

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7195



Great, thanks. Please also try the posted patch and see if that
resolves the first type of a warning (the 'Undefined subroutine').

  Mark


Re: PerMsgStatus Util warnings

2015-05-14 Thread Alex Regan

Hi,

On 05/14/2015 10:58 AM, Mark Martinec wrote:

I have v3.4.1 with amavisd v2.9.1 on fedora20 and receiving the
following warnings:

May 13 23:32:31 mail01 amavis[17306]: (17306-10) _WARN: plugin: eval
failed: Undefined subroutine
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain called at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/Util.pm line 1236.

May 13 23:35:43 mail01 amavis[17386]: (17386-12) _WARN: Use of
uninitialized value in concatenation (.) or string at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/PerMsgStatus.pm line
3082.


The second warning is independent from the first, I'm seeing these too.

It's because the RegistryBoundaries::uri_to_domain returns undef
when it sees %hh encoding in an URL, and the caller then tries to
concatenate it with 'dummy@', which produces this warning.
Seems harmless but annoying, should be fixed.

Please open a bug report (one should do, even though these are two
independent issues).


Bug filed, thanks so much.

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7195

Alex




   Mark


Re: PerMsgStatus Util warnings

2015-05-14 Thread Mark Martinec

I have v3.4.1 with amavisd v2.9.1 on fedora20 and receiving the
following warnings:

May 13 23:32:31 mail01 amavis[17306]: (17306-10) _WARN: plugin: eval
failed: Undefined subroutine
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain called at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/Util.pm line 1236.

May 13 23:35:43 mail01 amavis[17386]: (17386-12) _WARN: Use of
uninitialized value in concatenation (.) or string at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/PerMsgStatus.pm line
3082.


The second warning is independent from the first, I'm seeing these too.

It's because the RegistryBoundaries::uri_to_domain returns undef
when it sees %hh encoding in an URL, and the caller then tries to
concatenate it with 'dummy@', which produces this warning.
Seems harmless but annoying, should be fixed.

Please open a bug report (one should do, even though these are two
independent issues).

  Mark


RE: PerMsgStatus Util warnings

2015-05-14 Thread Jim Barber
 From: Mark Martinec [mailto:mark.martinec...@ijs.si] 
 
 Are you using some third-party SpamAssasin plugin that relies on the
 deprecated subroutine Mail::SpamAssassin::Util::uri_to_domain ?
 

I'm getting the same error:

May 15 12:34:41 smtp-syd mimedefang-multiplexor[30108]: t4F2YYjZ003229: Slave 6 
stderr: plugin: eval failed: Undefined subroutine 
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain called at 
/usr/share/perl5/Mail/SpamAssassin/Util.pm line 1236.

I'm using The SpamAssassin Debian package (which is version 3.4.1-1).

I do have a third party plugin that is calling uri_to_domain.
It is located at the following URL:

https://github.com/smfreegard/DecodeShortURLs

And is linked to from the SpamAssassin Custom Plugins wiki page:

https://wiki.apache.org/spamassassin/CustomPlugins

Here is the offending line:

jimb@smtp-syd:~$ grep uri_to_domain 
/etc/spamassassin/DecodeShortURLs.pm 
my ($dom, $host) = Mail::SpamAssassin::Util::uri_to_domain($_);

I'm mentioning this because the bug that was raised for this has the following 
comment:

KAM: Please let us know if you are using a 3rd party plugin because 
we'd like to make sure the authors noticed the change in 3.4.1.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7195

Regards,
Jim.