Syntax error at svnpubsub/daemonize.py:59

[sebb]

The code reads:

58:except (ChildTerminatedAbnormally, ChildForkFailed,
59:DaemonTerminatedAbnormally, DaemonForkFailed), e:

The ',' is invalid syntax; it should be 'as'.

There is also an invalid comment at line 20:

19: # This software lives at:
20: #http://gstein.googlecode.com/svn/trunk/python/daemonize.py

svnpubsub/svnwcsub.py crashes if pidfile option is not supplied

[sebb]

As the subject says, the code crashes as below unless --pidfile is provided

  File "./svnwcsub.py", line 559, in 
main(sys.argv[1:])
  File "./svnwcsub.py", line 548, in main
d = Daemon('/dev/null', os.path.abspath(options.pidfile),
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
line 367, in abspath
if not isabs(path):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
line 54, in isabs
return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'

Re: Syntax error at svnpubsub/daemonize.py:59

[Daniel Shahaf]

sebb wrote on Tue, 11 May 2021 16:22 +00:00:
> The code reads:
> 
> 58:except (ChildTerminatedAbnormally, ChildForkFailed,
> 59:DaemonTerminatedAbnormally, DaemonForkFailed), e:
> 
> The ',' is invalid syntax; it should be 'as'.

+1 to commit.  Feel free to also nominate it for backport to 1.14.x with
my +1, if you need it backported.

> There is also an invalid comment at line 20:
> 
> 19: # This software lives at:
> 20: #http://gstein.googlecode.com/svn/trunk/python/daemonize.py

I don't know a forwarding address for this, sorry.

Cheers,

Daniel

Re: svnpubsub/svnwcsub.py crashes if pidfile option is not supplied

[Daniel Shahaf]

sebb wrote on Tue, 11 May 2021 16:25 +00:00:
> As the subject says, the code crashes as below unless --pidfile is provided
> 
>   File "./svnwcsub.py", line 559, in 
> main(sys.argv[1:])
>   File "./svnwcsub.py", line 548, in main
> d = Daemon('/dev/null', os.path.abspath(options.pidfile),
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
>  line 367, in abspath
> if not isabs(path):
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
>  line 54, in isabs
> return s.startswith('/')
> AttributeError: 'NoneType' object has no attribute 'startswith'

Any chance of a patch?  Feel free to just make --pidfile required, if
making it properly optional is a larger diff than you have tuits for.

Re: svnpubsub/svnwcsub.py crashes if pidfile option is not supplied

[sebb]

On Tue, 11 May 2021 at 19:33, Daniel Shahaf  wrote:
>
> sebb wrote on Tue, 11 May 2021 16:25 +00:00:
> > As the subject says, the code crashes as below unless --pidfile is provided
> >
> >   File "./svnwcsub.py", line 559, in 
> > main(sys.argv[1:])
> >   File "./svnwcsub.py", line 548, in main
> > d = Daemon('/dev/null', os.path.abspath(options.pidfile),
> >   File 
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> >  line 367, in abspath
> > if not isabs(path):
> >   File 
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> >  line 54, in isabs
> > return s.startswith('/')
> > AttributeError: 'NoneType' object has no attribute 'startswith'
>
> Any chance of a patch?  Feel free to just make --pidfile required, if
> making it properly optional is a larger diff than you have tuits for.


svnwcsub.patch
Description: Binary data

Re: Syntax error at svnpubsub/daemonize.py:59

[Ryan Schmidt]

On May 11, 2021, at 12:45, Daniel Shahaf wrote:

>> There is also an invalid comment at line 20:
>> 
>> 19: # This software lives at:
>> 20: #http://gstein.googlecode.com/svn/trunk/python/daemonize.py
> 
> I don't know a forwarding address for this, sorry.

I followed the redirects on archive.org and found its new home at:

https://gstein.svn.beanstalkapp.com/oss/trunk/python/daemonize.py