Re: svnpubsub/svnwcsub.py crashes if pidfile option is not supplied
sebb wrote on Tue, May 11, 2021 at 22:41:38 +0100:
> On Tue, 11 May 2021 at 19:33, Daniel Shahaf wrote:
> >
> > sebb wrote on Tue, 11 May 2021 16:25 +00:00:
> > > As the subject says, the code crashes as below unless --pidfile is
> > > provided
> > >
> > > File "./svnwcsub.py", line 559, in
> > > main(sys.argv[1:])
> > > File "./svnwcsub.py", line 548, in main
> > > d = Daemon('/dev/null', os.path.abspath(options.pidfile),
> > > File
> > > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> > > line 367, in abspath
> > > if not isabs(path):
> > > File
> > > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> > > line 54, in isabs
> > > return s.startswith('/')
> > > AttributeError: 'NoneType' object has no attribute 'startswith'
> >
> > Any chance of a patch? Feel free to just make --pidfile required, if
> > making it properly optional is a larger diff than you have tuits for.
Update the usage message, use «svn diff -x-p», root the diff at the
branch root, address it to dev@, include a proposed log message (that
follows our log message syntax and linguistic conventions and is free of
spelling errors); see https://subversion.apache.org/patches for details.
Re: svnpubsub/svnwcsub.py crashes if pidfile option is not supplied
On Tue, 11 May 2021 at 19:33, Daniel Shahaf wrote:
>
> sebb wrote on Tue, 11 May 2021 16:25 +00:00:
> > As the subject says, the code crashes as below unless --pidfile is provided
> >
> > File "./svnwcsub.py", line 559, in
> > main(sys.argv[1:])
> > File "./svnwcsub.py", line 548, in main
> > d = Daemon('/dev/null', os.path.abspath(options.pidfile),
> > File
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> > line 367, in abspath
> > if not isabs(path):
> > File
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> > line 54, in isabs
> > return s.startswith('/')
> > AttributeError: 'NoneType' object has no attribute 'startswith'
>
> Any chance of a patch? Feel free to just make --pidfile required, if
> making it properly optional is a larger diff than you have tuits for.
svnwcsub.patch
Description: Binary data
Re: svnpubsub/svnwcsub.py crashes if pidfile option is not supplied
sebb wrote on Tue, 11 May 2021 16:25 +00:00:
> As the subject says, the code crashes as below unless --pidfile is provided
>
> File "./svnwcsub.py", line 559, in
> main(sys.argv[1:])
> File "./svnwcsub.py", line 548, in main
> d = Daemon('/dev/null', os.path.abspath(options.pidfile),
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> line 367, in abspath
> if not isabs(path):
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
> line 54, in isabs
> return s.startswith('/')
> AttributeError: 'NoneType' object has no attribute 'startswith'
Any chance of a patch? Feel free to just make --pidfile required, if
making it properly optional is a larger diff than you have tuits for.
svnpubsub/svnwcsub.py crashes if pidfile option is not supplied
As the subject says, the code crashes as below unless --pidfile is provided
File "./svnwcsub.py", line 559, in
main(sys.argv[1:])
File "./svnwcsub.py", line 548, in main
d = Daemon('/dev/null', os.path.abspath(options.pidfile),
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
line 367, in abspath
if not isabs(path):
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py",
line 54, in isabs
return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'
