Re: [T5.4-alpha-2] Ajax alerts not rendered after a call to dismissAll()

2013-01-31 Thread Steve Eynon
 Can you please open an issue and attach the patch there?

https://issues.apache.org/jira/browse/TAP5-2062

-
To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
For additional commands, e-mail: users-h...@tapestry.apache.org



[T5.4-alpha-2] Ajax alerts not rendered after a call to dismissAll()

2013-01-30 Thread Steve Eynon
When first rendered via a call to setupUI the alerts HTML looks like:

div data-container-type=alerts
  div class=well
div data-container-type=inner
  ... alerts ...
/div
  /div
/div

After a call to dismissAll() the HTML looks like:

div data-container-type=alerts
/div

With the inner container nowhere to be found. So when an attempt is
next made to show an alert after an ajax call:

(t5/core/alert.coffee)

alert = (data) -
  container = findInnerContainer()
  return unless container
  ...

Eeek! No container! So alert() just exits.

Should I raise a JIRA?

While someone is on the alert.coffee code, could you add a warn
class to the severityToClass object... pretty please!

Steve.

-
To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
For additional commands, e-mail: users-h...@tapestry.apache.org



Re: [T5.4-alpha-2] Ajax alerts not rendered after a call to dismissAll()

2013-01-30 Thread Kalle Korhonen
The mailing list doesn't allow attachments. Can you please open an issue
and attach the patch there?

Kalle

On Wed, Jan 30, 2013 at 6:01 AM, Steve Eynon steve.ey...@alienfactory.co.uk
 wrote:

 So... my last email was a little, um, wrong!

 The error is actually to do with dismissOne() removing the inner
 container - but wotever, it boils down to a typo on Line 77 (ish) of
 alert.coffee:

 container.on click button.close, -

 should actually be:

 container.on click, button.close, -

 Patch file for alert.coffee attached.

 Steve.
 --
 Steve Eynon
 ---
 If at first you don't succeed,
so much for skydiving!



 -
 To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
 For additional commands, e-mail: users-h...@tapestry.apache.org