Re: CompressionAnalyzerImpl exception
All set, thanks guys. https://issues.apache.org/jira/browse/TAP5-2430 On Mon, Dec 15, 2014 at 5:24 PM, Kalle Korhonen kalle.o.korho...@gmail.com wrote: On Mon, Dec 15, 2014 at 12:35 PM, Thiago H de Paula Figueiredo thiag...@gmail.com wrote: On Mon, 15 Dec 2014 12:05:52 -0200, George Christman gchrist...@cardaddy.com wrote: Howard, you were correct. the MIME type was null. CompressionAnalyzerImpl was failing on line 32 do to contentType being null. As you stated, this NPE is a failure and should probably be checked and thrown with a proper message. I ended up having to override the service in order to resolve the issue. https://github.com/apache/tapestry-5/blob/90766995f59048cb7f7d4cf042a21a 9d728583db/tapestry-core/src/main/java/org/apache/ tapestry5/internal/services/assets/CompressionAnalyzerImpl.java That's a bug and I'll fix it. JIRA please? :) While the root cause for the contentType being null is somewhere else, CompressionAnalyzerImpl should probably just return false on null contentType rather than throw an exception. Kalle -- Thiago H. de Paula Figueiredo Tapestry, Java and Hibernate consultant and developer http://machina.com.br - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org -- George Christman CEO www.CarDaddy.com P.O. Box 735 Johnstown, New York
Re: CompressionAnalyzerImpl exception
Howard, you were correct. the MIME type was null. CompressionAnalyzerImpl was failing on line 32 do to contentType being null. As you stated, this NPE is a failure and should probably be checked and thrown with a proper message. I ended up having to override the service in order to resolve the issue. https://github.com/apache/tapestry-5/blob/90766995f59048cb7f7d4cf042a21a9d728583db/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CompressionAnalyzerImpl.java On Tue, Dec 9, 2014 at 2:30 PM, Howard Lewis Ship hls...@gmail.com wrote: Well, right off the bat, any NPE like this (with no additional message to explain it) is a failure. Was there anything special about the page being rendered? It seems like the MIME type of the page is null, that's what might cause this NPE. On Tue, Dec 9, 2014 at 11:01 AM, George Christman gchrist...@cardaddy.com wrote: I just started using gzip etc and I'm not getting the following exception. Does anybody know what it means or how to fix it? Caused by: java.lang.NullPointerException at org.apache.tapestry5.internal. services.assets.CompressionAnalyzerImpl.isCompressable(CompressionAnalyzerImpl.java:32) at $CompressionAnalyzer_10e85f85a5.isCompressable(Unknown Source) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.openResponseOutputStream(BufferedGZipOutputStream.java:77) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.checkForCutover(BufferedGZipOutputStream.java:70) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.write(BufferedGZipOutputStream.java:118) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282) at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125) at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207) at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129) at java.io.BufferedWriter.close(BufferedWriter.java:265) at java.io.PrintWriter.close(PrintWriter.java:339) at org.apache.tapestry5.internal.services.PageResponseRendererImpl.renderPageResponse(PageResponseRendererImpl.java:85) at $PageResponseRenderer_10e85f8608.renderPageResponse(Unknown Source) at org.apache.tapestry5.internal.services.PageRenderRequestHandlerImpl.handle(PageRenderRequestHandlerImpl.java:72) at org.apache.tapestry5.modules.TapestryModule$34.handle(TapestryModule.java:1978) at $PageRenderRequestHandler_10e85f860a.handle(Unknown Source) at $PageRenderRequestHandler_10e85f8605.handle(Unknown Source) at org.apache.tapestry5.internal.services.ComponentRequestHandlerTerminator.handlePageRender(ComponentRequestHandlerTerminator.java:48) at org.apache.tapestry5.internal.services.DeferredResponseRenderer.handlePageRender(DeferredResponseRenderer.java:52) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.services.InitializeActivePageName.handlePageRender(InitializeActivePageName.java:47) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.ProductionModeUnknownComponentFilter.handlePageRender(ProductionModeUnknownComponentFilter.java:62) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.RequestOperationTracker$2.run(RequestOperationTracker.java:73) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:56) ... 69 more -- George Christman CEO www.CarDaddy.com P.O. Box 735 Johnstown, New York -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com @hlship -- George Christman CEO www.CarDaddy.com P.O. Box 735 Johnstown, New York
Re: CompressionAnalyzerImpl exception
On Mon, 15 Dec 2014 12:05:52 -0200, George Christman gchrist...@cardaddy.com wrote: Howard, you were correct. the MIME type was null. CompressionAnalyzerImpl was failing on line 32 do to contentType being null. As you stated, this NPE is a failure and should probably be checked and thrown with a proper message. I ended up having to override the service in order to resolve the issue. https://github.com/apache/tapestry-5/blob/90766995f59048cb7f7d4cf042a21a9d728583db/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CompressionAnalyzerImpl.java That's a bug and I'll fix it. JIRA please? :) -- Thiago H. de Paula Figueiredo Tapestry, Java and Hibernate consultant and developer http://machina.com.br - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: CompressionAnalyzerImpl exception
On Mon, Dec 15, 2014 at 12:35 PM, Thiago H de Paula Figueiredo thiag...@gmail.com wrote: On Mon, 15 Dec 2014 12:05:52 -0200, George Christman gchrist...@cardaddy.com wrote: Howard, you were correct. the MIME type was null. CompressionAnalyzerImpl was failing on line 32 do to contentType being null. As you stated, this NPE is a failure and should probably be checked and thrown with a proper message. I ended up having to override the service in order to resolve the issue. https://github.com/apache/tapestry-5/blob/90766995f59048cb7f7d4cf042a21a 9d728583db/tapestry-core/src/main/java/org/apache/ tapestry5/internal/services/assets/CompressionAnalyzerImpl.java That's a bug and I'll fix it. JIRA please? :) While the root cause for the contentType being null is somewhere else, CompressionAnalyzerImpl should probably just return false on null contentType rather than throw an exception. Kalle -- Thiago H. de Paula Figueiredo Tapestry, Java and Hibernate consultant and developer http://machina.com.br - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
CompressionAnalyzerImpl exception
I just started using gzip etc and I'm not getting the following exception. Does anybody know what it means or how to fix it? Caused by: java.lang.NullPointerException at org.apache.tapestry5.internal. services.assets.CompressionAnalyzerImpl.isCompressable(CompressionAnalyzerImpl.java:32) at $CompressionAnalyzer_10e85f85a5.isCompressable(Unknown Source) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.openResponseOutputStream(BufferedGZipOutputStream.java:77) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.checkForCutover(BufferedGZipOutputStream.java:70) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.write(BufferedGZipOutputStream.java:118) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282) at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125) at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207) at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129) at java.io.BufferedWriter.close(BufferedWriter.java:265) at java.io.PrintWriter.close(PrintWriter.java:339) at org.apache.tapestry5.internal.services.PageResponseRendererImpl.renderPageResponse(PageResponseRendererImpl.java:85) at $PageResponseRenderer_10e85f8608.renderPageResponse(Unknown Source) at org.apache.tapestry5.internal.services.PageRenderRequestHandlerImpl.handle(PageRenderRequestHandlerImpl.java:72) at org.apache.tapestry5.modules.TapestryModule$34.handle(TapestryModule.java:1978) at $PageRenderRequestHandler_10e85f860a.handle(Unknown Source) at $PageRenderRequestHandler_10e85f8605.handle(Unknown Source) at org.apache.tapestry5.internal.services.ComponentRequestHandlerTerminator.handlePageRender(ComponentRequestHandlerTerminator.java:48) at org.apache.tapestry5.internal.services.DeferredResponseRenderer.handlePageRender(DeferredResponseRenderer.java:52) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.services.InitializeActivePageName.handlePageRender(InitializeActivePageName.java:47) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.ProductionModeUnknownComponentFilter.handlePageRender(ProductionModeUnknownComponentFilter.java:62) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.RequestOperationTracker$2.run(RequestOperationTracker.java:73) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:56) ... 69 more -- George Christman CEO www.CarDaddy.com P.O. Box 735 Johnstown, New York
Re: CompressionAnalyzerImpl exception
Well, right off the bat, any NPE like this (with no additional message to explain it) is a failure. Was there anything special about the page being rendered? It seems like the MIME type of the page is null, that's what might cause this NPE. On Tue, Dec 9, 2014 at 11:01 AM, George Christman gchrist...@cardaddy.com wrote: I just started using gzip etc and I'm not getting the following exception. Does anybody know what it means or how to fix it? Caused by: java.lang.NullPointerException at org.apache.tapestry5.internal. services.assets.CompressionAnalyzerImpl.isCompressable(CompressionAnalyzerImpl.java:32) at $CompressionAnalyzer_10e85f85a5.isCompressable(Unknown Source) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.openResponseOutputStream(BufferedGZipOutputStream.java:77) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.checkForCutover(BufferedGZipOutputStream.java:70) at org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.write(BufferedGZipOutputStream.java:118) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282) at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125) at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207) at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129) at java.io.BufferedWriter.close(BufferedWriter.java:265) at java.io.PrintWriter.close(PrintWriter.java:339) at org.apache.tapestry5.internal.services.PageResponseRendererImpl.renderPageResponse(PageResponseRendererImpl.java:85) at $PageResponseRenderer_10e85f8608.renderPageResponse(Unknown Source) at org.apache.tapestry5.internal.services.PageRenderRequestHandlerImpl.handle(PageRenderRequestHandlerImpl.java:72) at org.apache.tapestry5.modules.TapestryModule$34.handle(TapestryModule.java:1978) at $PageRenderRequestHandler_10e85f860a.handle(Unknown Source) at $PageRenderRequestHandler_10e85f8605.handle(Unknown Source) at org.apache.tapestry5.internal.services.ComponentRequestHandlerTerminator.handlePageRender(ComponentRequestHandlerTerminator.java:48) at org.apache.tapestry5.internal.services.DeferredResponseRenderer.handlePageRender(DeferredResponseRenderer.java:52) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.services.InitializeActivePageName.handlePageRender(InitializeActivePageName.java:47) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.ProductionModeUnknownComponentFilter.handlePageRender(ProductionModeUnknownComponentFilter.java:62) at $ComponentRequestHandler_10e85f8606.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.RequestOperationTracker$2.run(RequestOperationTracker.java:73) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:56) ... 69 more -- George Christman CEO www.CarDaddy.com P.O. Box 735 Johnstown, New York -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com @hlship
Re: CompressionAnalyzerImpl exception
So tonight I was playing around on the site and I noticed I somehow was able to triggered this exception. If it didn't appear in the logs, it would have gone completely unnoticed. Now I will say I logged in using facebook which uses oauth and at some point during the login process, this exception was triggered. Here's the exception in it's entirety. George Christman mozilla/5.0 (macintosh; intel mac os x 10.10; rv:34.0) gecko/20100101 firefox/34.0 org.apache.tapestry5.ioc. internal.OperationException at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:184) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:62) at org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.run(PerThreadOperationTracker.java:60) at org.apache.tapestry5.ioc.internal.RegistryImpl.run(RegistryImpl.java:1252) at org.apache.tapestry5.internal.services.RequestOperationTracker.handlePageRender(RequestOperationTracker.java:66) at $ComponentRequestHandler_a4dc9da5d0e.handlePageRender(Unknown Source) at org.tynamo.security.SecurityComponentRequestFilter.handlePageRender(SecurityComponentRequestFilter.java:49) at $ComponentRequestFilter_a4dc9da5d0b.handlePageRender(Unknown Source) at $ComponentRequestHandler_a4dc9da5d0e.handlePageRender(Unknown Source) at $ComponentRequestHandler_a4dc9da5cd8.handlePageRender(Unknown Source) at org.apache.tapestry5.internal.services.PageRenderDispatcher.dispatch(PageRenderDispatcher.java:52) at $Dispatcher_a4dc9da5cd9.dispatch(Unknown Source) at $Dispatcher_a4dc9da5cd2.dispatch(Unknown Source) at org.apache.tapestry5.modules.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:304) at org.apache.tapestry5.internal.services.RequestErrorFilter.service(RequestErrorFilter.java:26) at $RequestHandler_a4dc9da5cd3.service(Unknown Source) at org.apache.tapestry5.modules.TapestryModule$3.service(TapestryModule.java:854) at $RequestHandler_a4dc9da5cd3.service(Unknown Source) at org.apache.tapestry5.modules.TapestryModule$2.service(TapestryModule.java:844) at $RequestHandler_a4dc9da5cd3.service(Unknown Source) at org.apache.tapestry5.internal.services.StaticFilesFilter.service(StaticFilesFilter.java:89) at $RequestHandler_a4dc9da5cd3.service(Unknown Source) at com.cardaddy.auto.services.CkeditorRequestFilter.service(CkeditorRequestFilter.java:69) at $RequestFilter_a4dc9da5cce.service(Unknown Source) at $RequestHandler_a4dc9da5cd3.service(Unknown Source) at com.cardaddy.auto.services.AppModule$1.service(AppModule.java:265) at $RequestFilter_a4dc9da5ccd.service(Unknown Source) at $RequestHandler_a4dc9da5cd3.service(Unknown Source) at $RequestHandler_a4dc9da5cb0.service(Unknown Source) at org.apache.tapestry5.modules.TapestryModule$HttpServletRequestHandlerTerminator.service(TapestryModule.java:255) at org.tynamo.security.services.impl.SecurityConfiguration$1.call(SecurityConfiguration.java:56) at org.tynamo.security.services.impl.SecurityConfiguration$1.call(SecurityConfiguration.java:54) at org.apache.shiro.subject.support.SubjectCallable.doCall(SubjectCallable.java:90) at org.apache.shiro.subject.support.SubjectCallable.call(SubjectCallable.java:83) at org.apache.shiro.subject.support.DelegatingSubject.execute(DelegatingSubject.java:383) at org.tynamo.security.services.impl.SecurityConfiguration.service(SecurityConfiguration.java:54) at $HttpServletRequestFilter_a4dc9da5caf.service(Unknown Source) at $HttpServletRequestHandler_a4dc9da5cb2.service(Unknown Source) at org.apache.tapestry5.upload.internal.services.MultipartServletRequestFilter.service(MultipartServletRequestFilter.java:45) at $HttpServletRequestHandler_a4dc9da5cb2.service(Unknown Source) at org.apache.tapestry5.internal.gzip.GZipFilter.service(GZipFilter.java:59) at $HttpServletRequestHandler_a4dc9da5cb2.service(Unknown Source) at com.cardaddy.auto.services.photo.impl.AjaxUploadServletRequestFilter.service(AjaxUploadServletRequestFilter.java:29) at $HttpServletRequestHandler_a4dc9da5cb2.service(Unknown Source) at org.apache.tapestry5.internal.services.IgnoredPathsFilter.service(IgnoredPathsFilter.java:62) at $HttpServletRequestFilter_a4dc9da5cab.service(Unknown Source) at $HttpServletRequestHandler_a4dc9da5cb2.service(Unknown Source) at org.apache.tapestry5.modules.TapestryModule$1.service(TapestryModule.java:804) at $HttpServletRequestHandler_a4dc9da5cb2.service(Unknown Source) at $HttpServletRequestHandler_a4dc9da5ca9.service(Unknown Source) at org.apache.tapestry5.TapestryFilter.doFilter(TapestryFilter.java:166) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:239) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:219) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) at
