RE: decorateClientInfrastructure not called anymore
Raised https://issues.apache.org/jira/browse/TAP5-1196 as a possible
improvement.
Regards,
Jim.
-Original Message-
From: Howard Lewis Ship [mailto:hls...@gmail.com]
Sent: 30 June 2010 21:05
To: Tapestry users
Subject: Re: decorateClientInfrastructure not called anymore
Yes, it's an issue. Probably, if there is no @Match annotation, then
the implicit service id (from the method name) should be required to
exist.
On Wed, Jun 30, 2010 at 4:53 AM, Jim O'Callaghan
wrote:
> Shouldn't decorator methods fail with a message that 'decorated xyz
service
> doesn't exist'? It would make it a lot easier to find things like this
...
>
> Regards,
> Jim.
>
> -Original Message-
> From: Christian Koller [mailto:christian.kol...@net-m.ch]
> Sent: 30 June 2010 12:38
> To: Tapestry users
> Subject: decorateClientInfrastructure not called anymore
>
> Hi all
>
> Maybe someone has the same problem. Here the solution:
>
> The name of the service has changed from PageTemplateLocator to
> ComponentTemplateLocator
> and this means also decorate method has a new name:
> decorateComponentTemplateLocator
>
> This method is called in 5.2.
>
> Furthermore ClientInfrastructure is deprecated now and this is possibly
the
> reason why the decoration method is not called anymore.
>
> br
> chris
>
> On 24.06.2010, at 14:22, Christian Koller wrote:
>
>> Hi
>>
>> 14:20:08.279 [main] INFO o.a.tapestry5.ioc.RegistryBuilder - Adding
> module definition for class
> net.netm.portals.tapestry.example.services.TapestryExampleModule
>> 14:20:08.821 [main] INFO n.n.p.t.e.s.TapestryExampleModule - adding
> coercion
>>
>> thats what I see in the stack on startup. No errors or something.
>>
>>
>> On 24.06.2010, at 14:06, Christophe Cordenier wrote:
>>
>>> Hi
>>>
>>> Are your services loaded ? Is your module class correctly loaded (see
> stack
>>> on startup)
>>>
>>> 2010/6/24 Christian Koller
>>>
>>>> Hi
>>>>
>>>> I tried to decorate ClientInfrastructure. With the old tapestry version
> it
>>>> was called, then i changed only the tapestry version to 5.2.0-SNAPSHOT
>>>> afterwards the method wasn't called anymore.
>>>>
>>>> Also i tried with the PageTemplateLocator
>>>> public PageTemplateLocator decoratePageTemplateLocator(final
>>>> PageTemplateLocator original) {
>>>> System.out.println("decoratePageTemplateLocator");
>>>> return null;
>>>> }
>>>>
>>>> The message "decoratePageTemplateLocator" was never printed out.
>>>>
>>>> br
>>>> chris
>>>>
>>>>
>>>>
>>>> On 24.06.2010, at 13:38, Christophe Cordenier wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> Which service are you trying to decorate ?
>>>>>
>>>>> 2010/6/24 Christian Koller
>>>>>
>>>>>> Hi kris
>>>>>>
>>>>>> Thank you for your response.
>>>>>> I'll try out Advisors now. Still decoration isn't working for me.
>>>>>> Has someone faced the same problem?
>>>>>>
>>>>>> thx
>>>>>> chris
>>>>>>
>>>>>>
>>>>>> On 24.06.2010, at 12:24, Kristian Marinkovic wrote:
>>>>>>
>>>>>>> Hi Christian,
>>>>>>>
>>>>>>> Advices have been introduced in 5.1 to replace decorators.
>>>>>>> please see:
>>>>>>> http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html
>>>>>>>
>>>>>>> the 5.2-SNAPSHOT documentation does not state that decorators are
>>>>>>> not supported anymore. the last time i was playing with 5.2 (some
> weeks
>>>>>>> ago)
>>>>>>> my decorators worked.
>>>>>>>
>>>>>>> g,
>>>>>>> kris
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Von: Christian Koller
>>>>>>> An: users@tapestry.apache.org
>>>>>>> Datum: 23.06.2010 16:38
>>>>>>> Betreff: decorateClientInfrastructure not called anymore
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Hello everyone
&g
Re: decorateClientInfrastructure not called anymore
Yes, it's an issue. Probably, if there is no @Match annotation, then
the implicit service id (from the method name) should be required to
exist.
On Wed, Jun 30, 2010 at 4:53 AM, Jim O'Callaghan wrote:
> Shouldn't decorator methods fail with a message that 'decorated xyz service
> doesn't exist'? It would make it a lot easier to find things like this ...
>
> Regards,
> Jim.
>
> -Original Message-
> From: Christian Koller [mailto:christian.kol...@net-m.ch]
> Sent: 30 June 2010 12:38
> To: Tapestry users
> Subject: decorateClientInfrastructure not called anymore
>
> Hi all
>
> Maybe someone has the same problem. Here the solution:
>
> The name of the service has changed from PageTemplateLocator to
> ComponentTemplateLocator
> and this means also decorate method has a new name:
> decorateComponentTemplateLocator
>
> This method is called in 5.2.
>
> Furthermore ClientInfrastructure is deprecated now and this is possibly the
> reason why the decoration method is not called anymore.
>
> br
> chris
>
> On 24.06.2010, at 14:22, Christian Koller wrote:
>
>> Hi
>>
>> 14:20:08.279 [main] INFO o.a.tapestry5.ioc.RegistryBuilder - Adding
> module definition for class
> net.netm.portals.tapestry.example.services.TapestryExampleModule
>> 14:20:08.821 [main] INFO n.n.p.t.e.s.TapestryExampleModule - adding
> coercion
>>
>> thats what I see in the stack on startup. No errors or something.
>>
>>
>> On 24.06.2010, at 14:06, Christophe Cordenier wrote:
>>
>>> Hi
>>>
>>> Are your services loaded ? Is your module class correctly loaded (see
> stack
>>> on startup)
>>>
>>> 2010/6/24 Christian Koller
>>>
Hi
I tried to decorate ClientInfrastructure. With the old tapestry version
> it
was called, then i changed only the tapestry version to 5.2.0-SNAPSHOT
afterwards the method wasn't called anymore.
Also i tried with the PageTemplateLocator
public PageTemplateLocator decoratePageTemplateLocator(final
PageTemplateLocator original) {
System.out.println("decoratePageTemplateLocator");
return null;
}
The message "decoratePageTemplateLocator" was never printed out.
br
chris
On 24.06.2010, at 13:38, Christophe Cordenier wrote:
> Hi
>
> Which service are you trying to decorate ?
>
> 2010/6/24 Christian Koller
>
>> Hi kris
>>
>> Thank you for your response.
>> I'll try out Advisors now. Still decoration isn't working for me.
>> Has someone faced the same problem?
>>
>> thx
>> chris
>>
>>
>> On 24.06.2010, at 12:24, Kristian Marinkovic wrote:
>>
>>> Hi Christian,
>>>
>>> Advices have been introduced in 5.1 to replace decorators.
>>> please see:
>>> http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html
>>>
>>> the 5.2-SNAPSHOT documentation does not state that decorators are
>>> not supported anymore. the last time i was playing with 5.2 (some
> weeks
>>> ago)
>>> my decorators worked.
>>>
>>> g,
>>> kris
>>>
>>>
>>>
>>> Von: Christian Koller
>>> An: users@tapestry.apache.org
>>> Datum: 23.06.2010 16:38
>>> Betreff: decorateClientInfrastructure not called anymore
>>>
>>>
>>>
>>> Hello everyone
>>>
>>> Since we updated the version of tapestry from 5.1.0.5 to
> 5.2.0-SNAPSHOT
>>> the decorate methods in the module class are not called anymore.
>>> Is there a new concept to decorate a service or is it a bug?
>>>
>>> Please let me know if you know something.
>>> Thanks
>>> chris
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
>> For additional commands, e-mail: users-h...@tapestry.apache.org
>>
>>
>
>
> --
> Regards,
> Christophe Cordenier.
>
> Developer of wooki @wookicentral.com
Christian Koller
Sofwareentwickler
net mobile Schweiz AG
Seestrasse 45
CH ñ 8702 Zollikon
Tel: + 41 (0) 44 918 99 99
Fax: + 41 (0) 44 918 99 98
Direkt: + 41 (0) 44 918 99 72
Mail: christian.kol...@net-m.ch
Web: www.net-m.ch
>>>
>>>
>>> --
>>> Regards,
>>> Christophe Cordenier.
>>>
>>> Developer of wooki @wookicentral.com
>>
>> Christian Koller
>> Sofwareentwickler
>>
>> net mobile Schweiz AG
>> Seestrasse 45
>> CH ñ 8702 Zollikon
>>
>> Tel: + 41 (0) 44 918 99 99
>> Fax: + 41 (0) 44 918 99 98
>> Direkt: + 41 (0) 44 918 99 72
>>
>> Mail: christian.kol...@net-m.ch
>> Web: www.net-m.ch
>>
>
> Christian Koller
> Sofwareentwickler
>
> net mobile Schweiz AG
> Seestrasse 45
> CH ñ 8702 Zollikon
>
> Tel: + 41 (0) 44 918 99 99
> Fax: + 41 (0) 44 918 99 98
> Direkt: + 41 (0) 44 918 99 72
>
> Mail: christian.kol...@net-m.ch
> Web: www.net-m.ch
>
>
>
> ---
RE: decorateClientInfrastructure not called anymore
Shouldn't decorator methods fail with a message that 'decorated xyz service
doesn't exist'? It would make it a lot easier to find things like this ...
Regards,
Jim.
-Original Message-
From: Christian Koller [mailto:christian.kol...@net-m.ch]
Sent: 30 June 2010 12:38
To: Tapestry users
Subject: decorateClientInfrastructure not called anymore
Hi all
Maybe someone has the same problem. Here the solution:
The name of the service has changed from PageTemplateLocator to
ComponentTemplateLocator
and this means also decorate method has a new name:
decorateComponentTemplateLocator
This method is called in 5.2.
Furthermore ClientInfrastructure is deprecated now and this is possibly the
reason why the decoration method is not called anymore.
br
chris
On 24.06.2010, at 14:22, Christian Koller wrote:
> Hi
>
> 14:20:08.279 [main] INFO o.a.tapestry5.ioc.RegistryBuilder - Adding
module definition for class
net.netm.portals.tapestry.example.services.TapestryExampleModule
> 14:20:08.821 [main] INFO n.n.p.t.e.s.TapestryExampleModule - adding
coercion
>
> thats what I see in the stack on startup. No errors or something.
>
>
> On 24.06.2010, at 14:06, Christophe Cordenier wrote:
>
>> Hi
>>
>> Are your services loaded ? Is your module class correctly loaded (see
stack
>> on startup)
>>
>> 2010/6/24 Christian Koller
>>
>>> Hi
>>>
>>> I tried to decorate ClientInfrastructure. With the old tapestry version
it
>>> was called, then i changed only the tapestry version to 5.2.0-SNAPSHOT
>>> afterwards the method wasn't called anymore.
>>>
>>> Also i tried with the PageTemplateLocator
>>> public PageTemplateLocator decoratePageTemplateLocator(final
>>> PageTemplateLocator original) {
>>> System.out.println("decoratePageTemplateLocator");
>>> return null;
>>> }
>>>
>>> The message "decoratePageTemplateLocator" was never printed out.
>>>
>>> br
>>> chris
>>>
>>>
>>>
>>> On 24.06.2010, at 13:38, Christophe Cordenier wrote:
>>>
Hi
Which service are you trying to decorate ?
2010/6/24 Christian Koller
> Hi kris
>
> Thank you for your response.
> I'll try out Advisors now. Still decoration isn't working for me.
> Has someone faced the same problem?
>
> thx
> chris
>
>
> On 24.06.2010, at 12:24, Kristian Marinkovic wrote:
>
>> Hi Christian,
>>
>> Advices have been introduced in 5.1 to replace decorators.
>> please see:
>> http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html
>>
>> the 5.2-SNAPSHOT documentation does not state that decorators are
>> not supported anymore. the last time i was playing with 5.2 (some
weeks
>> ago)
>> my decorators worked.
>>
>> g,
>> kris
>>
>>
>>
>> Von:Christian Koller
>> An: users@tapestry.apache.org
>> Datum: 23.06.2010 16:38
>> Betreff:decorateClientInfrastructure not called anymore
>>
>>
>>
>> Hello everyone
>>
>> Since we updated the version of tapestry from 5.1.0.5 to
5.2.0-SNAPSHOT
>> the decorate methods in the module class are not called anymore.
>> Is there a new concept to decorate a service or is it a bug?
>>
>> Please let me know if you know something.
>> Thanks
>> chris
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
> For additional commands, e-mail: users-h...@tapestry.apache.org
>
>
--
Regards,
Christophe Cordenier.
Developer of wooki @wookicentral.com
>>>
>>> Christian Koller
>>> Sofwareentwickler
>>>
>>> net mobile Schweiz AG
>>> Seestrasse 45
>>> CH ñ 8702 Zollikon
>>>
>>> Tel: + 41 (0) 44 918 99 99
>>> Fax: + 41 (0) 44 918 99 98
>>> Direkt: + 41 (0) 44 918 99 72
>>>
>>> Mail: christian.kol...@net-m.ch
>>> Web: www.net-m.ch
>>>
>>>
>>
>>
>> --
>> Regards,
>> Christophe Cordenier.
>>
>> Developer of wooki @wookicentral.com
>
> Christian Koller
> Sofwareentwickler
>
> net mobile Schweiz AG
> Seestrasse 45
> CH ñ 8702 Zollikon
>
> Tel: + 41 (0) 44 918 99 99
> Fax: + 41 (0) 44 918 99 98
> Direkt: + 41 (0) 44 918 99 72
>
> Mail: christian.kol...@net-m.ch
> Web: www.net-m.ch
>
Christian Koller
Sofwareentwickler
net mobile Schweiz AG
Seestrasse 45
CH ñ 8702 Zollikon
Tel: + 41 (0) 44 918 99 99
Fax: + 41 (0) 44 918 99 98
Direkt: + 41 (0) 44 918 99 72
Mail: christian.kol...@net-m.ch
Web: www.net-m.ch
-
To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
For additional commands, e-mail: users-h...@tapestry.apache.org
Re: decorateClientInfrastructure not called anymore
Actually, decorators are used when you know, and compile time, what interface the service implements and you want to provide a specific object, implementing that interface, as the interceptor (the wrapper around the core service implementation). Advice is used when you want to dynamically analyze the service interface, whatever it is, adding ComponentMethodAdvice to individual methods. Making specific changes to a known interface is easier using decoration, such as extending a known existing service to add new features. On the other hand, wide-ranging concerns (such as logging or transaction management or security) can be handled best using advice. Unfortunately, they don't mix, due to the evolution of the underlying APIs (decoration was implemented first, advice came a couple of years later). The end result is that all decoration executes before any advice, with the core service implementation being at the end of the chain. On Thu, Jun 24, 2010 at 3:24 AM, Kristian Marinkovic wrote: > Hi Christian, > > Advices have been introduced in 5.1 to replace decorators. > please see: > http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html > > the 5.2-SNAPSHOT documentation does not state that decorators are > not supported anymore. the last time i was playing with 5.2 (some weeks > ago) > my decorators worked. > > g, > kris > > > > Von: Christian Koller > An: users@tapestry.apache.org > Datum: 23.06.2010 16:38 > Betreff: decorateClientInfrastructure not called anymore > > > > Hello everyone > > Since we updated the version of tapestry from 5.1.0.5 to 5.2.0-SNAPSHOT > the decorate methods in the module class are not called anymore. > Is there a new concept to decorate a service or is it a bug? > > Please let me know if you know something. > Thanks > chris > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: decorateClientInfrastructure not called anymore
Hi
Are your services loaded ? Is your module class correctly loaded (see stack
on startup)
2010/6/24 Christian Koller
> Hi
>
> I tried to decorate ClientInfrastructure. With the old tapestry version it
> was called, then i changed only the tapestry version to 5.2.0-SNAPSHOT
> afterwards the method wasn't called anymore.
>
> Also i tried with the PageTemplateLocator
> public PageTemplateLocator decoratePageTemplateLocator(final
> PageTemplateLocator original) {
>System.out.println("decoratePageTemplateLocator");
>return null;
> }
>
> The message "decoratePageTemplateLocator" was never printed out.
>
> br
> chris
>
>
>
> On 24.06.2010, at 13:38, Christophe Cordenier wrote:
>
> > Hi
> >
> > Which service are you trying to decorate ?
> >
> > 2010/6/24 Christian Koller
> >
> >> Hi kris
> >>
> >> Thank you for your response.
> >> I'll try out Advisors now. Still decoration isn't working for me.
> >> Has someone faced the same problem?
> >>
> >> thx
> >> chris
> >>
> >>
> >> On 24.06.2010, at 12:24, Kristian Marinkovic wrote:
> >>
> >>> Hi Christian,
> >>>
> >>> Advices have been introduced in 5.1 to replace decorators.
> >>> please see:
> >>> http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html
> >>>
> >>> the 5.2-SNAPSHOT documentation does not state that decorators are
> >>> not supported anymore. the last time i was playing with 5.2 (some weeks
> >>> ago)
> >>> my decorators worked.
> >>>
> >>> g,
> >>> kris
> >>>
> >>>
> >>>
> >>> Von:Christian Koller
> >>> An: users@tapestry.apache.org
> >>> Datum: 23.06.2010 16:38
> >>> Betreff:decorateClientInfrastructure not called anymore
> >>>
> >>>
> >>>
> >>> Hello everyone
> >>>
> >>> Since we updated the version of tapestry from 5.1.0.5 to 5.2.0-SNAPSHOT
> >>> the decorate methods in the module class are not called anymore.
> >>> Is there a new concept to decorate a service or is it a bug?
> >>>
> >>> Please let me know if you know something.
> >>> Thanks
> >>> chris
> >>
> >> -
> >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
> >> For additional commands, e-mail: users-h...@tapestry.apache.org
> >>
> >>
> >
> >
> > --
> > Regards,
> > Christophe Cordenier.
> >
> > Developer of wooki @wookicentral.com
>
> Christian Koller
> Sofwareentwickler
>
> net mobile Schweiz AG
> Seestrasse 45
> CH ñ 8702 Zollikon
>
> Tel: + 41 (0) 44 918 99 99
> Fax: + 41 (0) 44 918 99 98
> Direkt: + 41 (0) 44 918 99 72
>
> Mail: christian.kol...@net-m.ch
> Web: www.net-m.ch
>
>
--
Regards,
Christophe Cordenier.
Developer of wooki @wookicentral.com
Re: decorateClientInfrastructure not called anymore
oups i should read the title :) 2010/6/24 Christophe Cordenier > Hi > > Which service are you trying to decorate ? > > 2010/6/24 Christian Koller > > Hi kris >> >> Thank you for your response. >> I'll try out Advisors now. Still decoration isn't working for me. >> Has someone faced the same problem? >> >> thx >> chris >> >> >> On 24.06.2010, at 12:24, Kristian Marinkovic wrote: >> >> > Hi Christian, >> > >> > Advices have been introduced in 5.1 to replace decorators. >> > please see: >> > http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html >> > >> > the 5.2-SNAPSHOT documentation does not state that decorators are >> > not supported anymore. the last time i was playing with 5.2 (some weeks >> > ago) >> > my decorators worked. >> > >> > g, >> > kris >> > >> > >> > >> > Von:Christian Koller >> > An: users@tapestry.apache.org >> > Datum: 23.06.2010 16:38 >> > Betreff:decorateClientInfrastructure not called anymore >> > >> > >> > >> > Hello everyone >> > >> > Since we updated the version of tapestry from 5.1.0.5 to 5.2.0-SNAPSHOT >> > the decorate methods in the module class are not called anymore. >> > Is there a new concept to decorate a service or is it a bug? >> > >> > Please let me know if you know something. >> > Thanks >> > chris >> >> - >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: users-h...@tapestry.apache.org >> >> > > > -- > Regards, > Christophe Cordenier. > > Developer of wooki @wookicentral.com > -- Regards, Christophe Cordenier. Developer of wooki @wookicentral.com
Re: decorateClientInfrastructure not called anymore
Hi Which service are you trying to decorate ? 2010/6/24 Christian Koller > Hi kris > > Thank you for your response. > I'll try out Advisors now. Still decoration isn't working for me. > Has someone faced the same problem? > > thx > chris > > > On 24.06.2010, at 12:24, Kristian Marinkovic wrote: > > > Hi Christian, > > > > Advices have been introduced in 5.1 to replace decorators. > > please see: > > http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html > > > > the 5.2-SNAPSHOT documentation does not state that decorators are > > not supported anymore. the last time i was playing with 5.2 (some weeks > > ago) > > my decorators worked. > > > > g, > > kris > > > > > > > > Von:Christian Koller > > An: users@tapestry.apache.org > > Datum: 23.06.2010 16:38 > > Betreff:decorateClientInfrastructure not called anymore > > > > > > > > Hello everyone > > > > Since we updated the version of tapestry from 5.1.0.5 to 5.2.0-SNAPSHOT > > the decorate methods in the module class are not called anymore. > > Is there a new concept to decorate a service or is it a bug? > > > > Please let me know if you know something. > > Thanks > > chris > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > > -- Regards, Christophe Cordenier. Developer of wooki @wookicentral.com
RE: decorateClientInfrastructure not called anymore
Hi Christian, Advices have been introduced in 5.1 to replace decorators. please see: http://tapestry.apache.org/tapestry5.1/tapestry-ioc/advice.html the 5.2-SNAPSHOT documentation does not state that decorators are not supported anymore. the last time i was playing with 5.2 (some weeks ago) my decorators worked. g, kris Von:Christian Koller An: users@tapestry.apache.org Datum: 23.06.2010 16:38 Betreff:decorateClientInfrastructure not called anymore Hello everyone Since we updated the version of tapestry from 5.1.0.5 to 5.2.0-SNAPSHOT the decorate methods in the module class are not called anymore. Is there a new concept to decorate a service or is it a bug? Please let me know if you know something. Thanks chris
