Re: thread deadlock issue in WebappClassLoader (Tomcat 6.0.26)

2010-05-24 Thread Rainer Jung

On 24.05.2010 14:08, PJ Fanning wrote:

Hi,

We've been seeing the occasional deadlock in WebappClassLoader and
upgraded to Tomcat 6.0.26 because of
https://issues.apache.org/bugzilla/show_bug.cgi?id=48694.

The fix in 48694 does not seem to have gotten rid of the deadlock
altogether.


Could you please try the patch contained in 
http://svn.apache.org/viewvc?view=revision&revision=941868, which was 
applied *after* 6.0.26?


Regards,

Rainer

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



RE: thread deadlock issue in WebappClassLoader (Tomcat 6.0.26)

2010-05-24 Thread PJ Fanning
Thanks Rainer for the quick response. That code change looks like it
will get rid of the deadlock issue. Do you have any idea if it affects
performance in a marked way? Synchronizing on the class loader object
instance should lead to a lot more contention. Still better than getting
deadlocks.


-Original Message-
From: Rainer Jung [mailto:rainer.j...@kippdata.de] 
Sent: 24 May 2010 13:21
To: Tomcat Users List
Subject: Re: thread deadlock issue in WebappClassLoader (Tomcat 6.0.26)

On 24.05.2010 14:08, PJ Fanning wrote:
> Hi,
>
> We've been seeing the occasional deadlock in WebappClassLoader and
> upgraded to Tomcat 6.0.26 because of
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48694.
>
> The fix in 48694 does not seem to have gotten rid of the deadlock
> altogether.

Could you please try the patch contained in 
http://svn.apache.org/viewvc?view=revision&revision=941868, which was 
applied *after* 6.0.26?

Regards,

Rainer

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: thread deadlock issue in WebappClassLoader (Tomcat 6.0.26)

2010-05-24 Thread Mark Thomas

On 24/05/2010 13:47, PJ Fanning wrote:

Thanks Rainer for the quick response. That code change looks like it
will get rid of the deadlock issue. Do you have any idea if it affects
performance in a marked way? Synchronizing on the class loader object
instance should lead to a lot more contention. Still better than getting
deadlocks.


Not that I could see in some quick tests. Keep in mind that the JDK 
class loaders all synchronize that method.


Mark



-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org