Re: [wicketstuff-push] How to disconnect cleanly?
just tested on a quickstart,works well .. thanks for the fix ! On Fri, Oct 21, 2011 at 6:23 PM, Sebastian wrote: > hi, > > we fixed it in trunk now. please give it a try. > > regards, > > seb > > On 12.10.2011 11:18, vineet semwal wrote: >> >> thank you martin ! >> >> herald ,i have opened a issue for you >> https://github.com/wicketstuff/core/issues/66 >> thank you ! >> >> On Wed, Oct 12, 2011 at 2:19 PM, Martin Grigorov >> wrote: >>> >>> On Wed, Oct 12, 2011 at 11:13 AM, vineet semwal >>> wrote: there is no need for the api change,its a bug and i think wicket-stuff push developers will make that change there in uninstallNode(component,node) ,they might be busy .. >>> >>> they should be notified >>> add an issue in GitHub On Wed, Oct 12, 2011 at 12:50 PM, Harald Wellmann wrote: > > I'm currently doing timer.stop() in my application code before calling > uninstallNode(), but that requires copying code from the private > method TimerPushService._findPushBehavior(). So it seems the API could > do with a couple of extensions for this case... > > Best regards, > Harald > > 2011/10/11 vineet semwal: >> >> i think its better to do timerpushbehavior.stop() instead of >> component.remove(behavior) >> inside uninstallNode(component,node) but it might require other >> changes too .. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- thank you, regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> >>> >>> -- >>> Martin Grigorov >>> jWeekend >>> Training, Consulting, Development >>> http://jWeekend.com >>> >>> - >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> >> >> >> > > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- thank you, regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: [wicketstuff-push] How to disconnect cleanly?
hi, we fixed it in trunk now. please give it a try. regards, seb On 12.10.2011 11:18, vineet semwal wrote: thank you martin ! herald ,i have opened a issue for you https://github.com/wicketstuff/core/issues/66 thank you ! On Wed, Oct 12, 2011 at 2:19 PM, Martin Grigorov wrote: On Wed, Oct 12, 2011 at 11:13 AM, vineet semwal wrote: there is no need for the api change,its a bug and i think wicket-stuff push developers will make that change there in uninstallNode(component,node) ,they might be busy .. they should be notified add an issue in GitHub On Wed, Oct 12, 2011 at 12:50 PM, Harald Wellmann wrote: I'm currently doing timer.stop() in my application code before calling uninstallNode(), but that requires copying code from the private method TimerPushService._findPushBehavior(). So it seems the API could do with a couple of extensions for this case... Best regards, Harald 2011/10/11 vineet semwal: i think its better to do timerpushbehavior.stop() instead of component.remove(behavior) inside uninstallNode(component,node) but it might require other changes too .. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- thank you, regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: [wicketstuff-push] How to disconnect cleanly?
thank you martin ! herald ,i have opened a issue for you https://github.com/wicketstuff/core/issues/66 thank you ! On Wed, Oct 12, 2011 at 2:19 PM, Martin Grigorov wrote: > On Wed, Oct 12, 2011 at 11:13 AM, vineet semwal > wrote: >> there is no need for the api change,its a bug and i think wicket-stuff >> push developers will make that change there in >> uninstallNode(component,node) ,they might be busy .. > they should be notified > add an issue in GitHub >> >> On Wed, Oct 12, 2011 at 12:50 PM, Harald Wellmann >> wrote: >>> I'm currently doing timer.stop() in my application code before calling >>> uninstallNode(), but that requires copying code from the private >>> method TimerPushService._findPushBehavior(). So it seems the API could >>> do with a couple of extensions for this case... >>> >>> Best regards, >>> Harald >>> >>> 2011/10/11 vineet semwal : i think its better to do timerpushbehavior.stop() instead of component.remove(behavior) inside uninstallNode(component,node) but it might require other changes too .. >>> >>> - >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> >> >> >> >> -- >> thank you, >> >> regards, >> Vineet Semwal >> >> - >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> > > > > -- > Martin Grigorov > jWeekend > Training, Consulting, Development > http://jWeekend.com > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- thank you, regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: [wicketstuff-push] How to disconnect cleanly?
On Wed, Oct 12, 2011 at 11:13 AM, vineet semwal wrote: > there is no need for the api change,its a bug and i think wicket-stuff > push developers will make that change there in > uninstallNode(component,node) ,they might be busy .. they should be notified add an issue in GitHub > > On Wed, Oct 12, 2011 at 12:50 PM, Harald Wellmann > wrote: >> I'm currently doing timer.stop() in my application code before calling >> uninstallNode(), but that requires copying code from the private >> method TimerPushService._findPushBehavior(). So it seems the API could >> do with a couple of extensions for this case... >> >> Best regards, >> Harald >> >> 2011/10/11 vineet semwal : >>> i think its better to do timerpushbehavior.stop() instead of >>> component.remove(behavior) >>> inside uninstallNode(component,node) but it might require other changes too >>> .. >> >> - >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> > > > > -- > thank you, > > regards, > Vineet Semwal > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: [wicketstuff-push] How to disconnect cleanly?
there is no need for the api change,its a bug and i think wicket-stuff push developers will make that change there in uninstallNode(component,node) ,they might be busy .. On Wed, Oct 12, 2011 at 12:50 PM, Harald Wellmann wrote: > I'm currently doing timer.stop() in my application code before calling > uninstallNode(), but that requires copying code from the private > method TimerPushService._findPushBehavior(). So it seems the API could > do with a couple of extensions for this case... > > Best regards, > Harald > > 2011/10/11 vineet semwal : >> i think its better to do timerpushbehavior.stop() instead of >> component.remove(behavior) >> inside uninstallNode(component,node) but it might require other changes too >> .. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- thank you, regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: [wicketstuff-push] How to disconnect cleanly?
I'm currently doing timer.stop() in my application code before calling uninstallNode(), but that requires copying code from the private method TimerPushService._findPushBehavior(). So it seems the API could do with a couple of extensions for this case... Best regards, Harald 2011/10/11 vineet semwal : > i think its better to do timerpushbehavior.stop() instead of > component.remove(behavior) > inside uninstallNode(component,node) but it might require other changes too .. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: [wicketstuff-push] How to disconnect cleanly?
i think its better to do timerpushbehavior.stop() instead of component.remove(behavior) inside uninstallNode(component,node) but it might require other changes too .. On Tue, Oct 11, 2011 at 9:25 PM, Harald Wellmann wrote: > I'm experimenting with wicketstuff-push-timer, and I wonder if there's > a way to cleanly uninstall a node. > > Use case: The server pushes a number of progress events during a long > running action. When the action is finished, no more events will be > sent, so there is no point for the browser to continue polling the > server. > > I've tried pushService.uninstallNode(), but I always end up with an > exception of the following kind: > > Caused by: java.lang.IllegalStateException: Behavior must be added to > component before its id can be generated. Behavior: > org.wicketstuff.push.timer.TimerPushBehavior@3522971b, Component: > org.apache.wicket.Behaviors@6d96e397 > at org.apache.wicket.Behaviors.getBehaviorId(Behaviors.java:252) > ~[wicket-core-1.5.1.jar:1.5.1] > at org.apache.wicket.Component.getBehaviorId(Component.java:4413) > ~[wicket-core-1.5.1.jar:1.5.1] > at org.apache.wicket.Component.urlFor(Component.java:3290) > ~[wicket-core-1.5.1.jar:1.5.1] > at > org.apache.wicket.behavior.AbstractAjaxBehavior.getCallbackUrl(AbstractAjaxBehavior.java:89) > ~[wicket-core-1.5.1.jar:1.5.1] > at > org.apache.wicket.ajax.AbstractAjaxTimerBehavior.getCallbackScript(AbstractAjaxTimerBehavior.java:125) > ~[wicket-core-1.5.1.jar:1.5.1] > at > org.apache.wicket.ajax.AbstractAjaxTimerBehavior.getJsTimeoutCall(AbstractAjaxTimerBehavior.java:118) > ~[wicket-core-1.5.1.jar:1.5.1] > > It seems that uninstallNode() only removes the behaviour but does not > stop the timer. > > Any hints welcome... > > Best regards, > > Harald > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- thank you, regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
[wicketstuff-push] How to disconnect cleanly?
I'm experimenting with wicketstuff-push-timer, and I wonder if there's a way to cleanly uninstall a node. Use case: The server pushes a number of progress events during a long running action. When the action is finished, no more events will be sent, so there is no point for the browser to continue polling the server. I've tried pushService.uninstallNode(), but I always end up with an exception of the following kind: Caused by: java.lang.IllegalStateException: Behavior must be added to component before its id can be generated. Behavior: org.wicketstuff.push.timer.TimerPushBehavior@3522971b, Component: org.apache.wicket.Behaviors@6d96e397 at org.apache.wicket.Behaviors.getBehaviorId(Behaviors.java:252) ~[wicket-core-1.5.1.jar:1.5.1] at org.apache.wicket.Component.getBehaviorId(Component.java:4413) ~[wicket-core-1.5.1.jar:1.5.1] at org.apache.wicket.Component.urlFor(Component.java:3290) ~[wicket-core-1.5.1.jar:1.5.1] at org.apache.wicket.behavior.AbstractAjaxBehavior.getCallbackUrl(AbstractAjaxBehavior.java:89) ~[wicket-core-1.5.1.jar:1.5.1] at org.apache.wicket.ajax.AbstractAjaxTimerBehavior.getCallbackScript(AbstractAjaxTimerBehavior.java:125) ~[wicket-core-1.5.1.jar:1.5.1] at org.apache.wicket.ajax.AbstractAjaxTimerBehavior.getJsTimeoutCall(AbstractAjaxTimerBehavior.java:118) ~[wicket-core-1.5.1.jar:1.5.1] It seems that uninstallNode() only removes the behaviour but does not stop the timer. Any hints welcome... Best regards, Harald - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org